Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/neat-runs-serialize.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/core": minor
"workflow": minor
---

Use custom class serialization for `Run` across runtime and workflow VM contexts, and add e2e coverage for `Run` instance boundary roundtrips
39 changes: 39 additions & 0 deletions packages/core/e2e/e2e.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1528,6 +1528,45 @@ describe('e2e', () => {
}
);

test(
'runClassSerializationWorkflow - Run instances serialize across workflow/step boundaries',
{ timeout: 120_000 },
async () => {
const inputValue = 21;
const run = await start(await e2e('runClassSerializationWorkflow'), [
inputValue,
]);
const returnValue = await run.returnValue;

expect(returnValue).toHaveProperty('isRunInWorkflow', true);
expect(returnValue).toHaveProperty('childRunId');
expect(returnValue).toHaveProperty('runIdFromStep');
expect(returnValue).toHaveProperty('childResult');

expect(typeof returnValue.childRunId).toBe('string');
expect(returnValue.childRunId.startsWith('wrun_')).toBe(true);
expect(returnValue.runIdFromStep).toBe(returnValue.childRunId);
expect(returnValue.childResult).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});

const { json: parentRunData } = await cliInspectJson(
`runs ${run.runId} --withData`
);
expect(parentRunData.status).toBe('completed');

const { json: childRunData } = await cliInspectJson(
`runs ${returnValue.childRunId} --withData`
);
expect(childRunData.status).toBe('completed');
expect(childRunData.output).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});
}
);

// Skipped for Vercel since VQS doesn't support direct HTTP calls
test.skipIf(!isLocalDeployment())(
'health check endpoint (HTTP) - workflow and step endpoints respond to __health query parameter',
Expand Down
4 changes: 4 additions & 0 deletions packages/core/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,10 @@
"types": "./dist/runtime.d.ts",
"default": "./dist/runtime.js"
},
"./runtime/run": {
Comment thread
VaguelySerious marked this conversation as resolved.
"types": "./dist/runtime/run.d.ts",
Comment thread
TooTallNate marked this conversation as resolved.
"default": "./dist/runtime/run.js"
},
"./runtime/start": {
"types": "./dist/runtime/start.d.ts",
"default": "./dist/runtime/start.js"
Expand Down
75 changes: 50 additions & 25 deletions packages/core/src/runtime/run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {
WorkflowRunNotCompletedError,
WorkflowRunNotFoundError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import {
SPEC_VERSION_CURRENT,
type WorkflowRunStatus,
Expand DownExpand Up@@ -69,6 +70,17 @@ export interface WorkflowReadableStreamOptions {
* A handler class for a workflow run.
*/
export class Run<TResult> {
static [WORKFLOW_SERIALIZE](instance: Run<unknown>) {
return { runId: instance.runId, resilientStart: instance.#resilientStart };
}

static [WORKFLOW_DESERIALIZE](data: {
runId: string;
resilientStart?: boolean;
}) {
return new Run(data.runId, { resilientStart: data.resilientStart });
}

/**
* The ID of the workflow run.
*/
Expand All@@ -78,14 +90,18 @@ export class Run<TResult> {
* The world object.
* @internal
*/
private worldPromise: Promise<World>;
#worldPromise: Promise<World> | undefined;
get #lazyWorldPromise() {
if (!this.#worldPromise) this.#worldPromise = getWorld();
return this.#worldPromise;
}

/**
* Cached encryption key resolution. Resolved once on first use and
* reused for returnValue, getReadable(), etc.
* @internal
*/
private encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;
#encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;

/**
* When true, run_created failed and the run may not exist yet (the
Expand All@@ -94,12 +110,11 @@ export class Run<TResult> {
* that normal runs fail fast on 404.
* @internal
*/
private resilientStart = false;
#resilientStart = false;

constructor(runId: string, opts?: { resilientStart?: boolean }) {
this.runId = runId;
this.worldPromise = getWorld();
this.resilientStart = opts?.resilientStart ?? false;
this.#resilientStart = opts?.resilientStart ?? false;
}

/**
Expand All@@ -108,16 +123,16 @@ export class Run<TResult> {
* to be resolved once.
* @internal
*/
private getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.encryptionKeyPromise) {
this.encryptionKeyPromise = (async () => {
const world = await this.worldPromise;
#getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.#encryptionKeyPromise) {
this.#encryptionKeyPromise = (async () => {
const world = await this.#lazyWorldPromise;
const run = await world.runs.get(this.runId);
const rawKey = await world.getEncryptionKeyForRun?.(run);
return rawKey ? await importKey(rawKey) : undefined;
})();
}
return this.encryptionKeyPromise;
return this.#encryptionKeyPromise;
}

/**
Expand All@@ -128,14 +143,16 @@ export class Run<TResult> {
* @returns A {@link StopSleepResult} object containing the number of sleep calls that were interrupted.
*/
async wakeUp(options?: StopSleepOptions): Promise<StopSleepResult> {
return wakeUpRun(await this.worldPromise, this.runId, options);
'use step';
return wakeUpRun(await this.#lazyWorldPromise, this.runId, options);
}

/**
* Cancels the workflow run.
*/
async cancel(): Promise<void> {
const world = await this.worldPromise;
'use step';
const world = await this.#lazyWorldPromise;
await world.events.create(this.runId, {
eventType: 'run_cancelled',
specVersion: SPEC_VERSION_CURRENT,
Expand All@@ -146,7 +163,8 @@ export class Run<TResult> {
* Whether the workflow run exists.
*/
get exists(): Promise<boolean> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs
.get(this.runId, { resolveData: 'none' })
.then(() => true)
Expand All@@ -163,7 +181,8 @@ export class Run<TResult> {
* The status of the workflow run.
*/
get status(): Promise<WorkflowRunStatus> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.status)
);
}
Expand All@@ -173,14 +192,16 @@ export class Run<TResult> {
* Polls the workflow return value until it is completed.
*/
get returnValue(): Promise<TResult> {
return this.pollReturnValue();
'use step';
return this.#pollReturnValue();
}

/**
* The name of the workflow.
*/
get workflowName(): Promise<string> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.workflowName)
);
}
Expand All@@ -189,7 +210,8 @@ export class Run<TResult> {
* The timestamp when the workflow run was created.
*/
get createdAt(): Promise<Date> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.createdAt)
);
}
Expand All@@ -199,7 +221,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not started yet.
*/
get startedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.startedAt)
);
}
Expand All@@ -209,7 +232,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not completed yet.
*/
get completedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.completedAt)
);
}
Expand All@@ -236,11 +260,12 @@ export class Run<TResult> {
getReadable<R = any>(
options: WorkflowReadableStreamOptions = {}
): WorkflowReadableStream<R> {
'use step';
Comment thread
TooTallNate marked this conversation as resolved.
const { ops = [], global = globalThis, startIndex, namespace } = options;
const name = getWorkflowRunStreamId(this.runId, namespace);
// Pass the key as a promise — it will be resolved lazily inside
// the first async transform() call of the deserialize stream.
const encryptionKey = this.getEncryptionKey();
const encryptionKey = this.#getEncryptionKey();
const stream = getExternalRevivers(
global,
ops,
Expand All@@ -251,7 +276,7 @@ export class Run<TResult> {
startIndex,
}) as ReadableStream<R>;

const worldPromise = this.worldPromise;
const worldPromise = this.#lazyWorldPromise;
const runId = this.runId;
return Object.assign(stream, {
getTailIndex: async (): Promise<number> => {
Expand All@@ -267,24 +292,24 @@ export class Run<TResult> {
* @internal
* @returns The workflow return value.
*/
private async pollReturnValue(): Promise<TResult> {
const world = await this.worldPromise;
async #pollReturnValue(): Promise<TResult> {
const world = await this.#lazyWorldPromise;

// When resilientStart is true, run_created failed and the run may
// not exist yet. Retry on WorkflowRunNotFoundError up to 3 times
// (1s + 3s + 6s = 10s total) to give the queue time to deliver
// and the runtime to create the run via run_started.
// When resilientStart is false, 404 is a real error — fail fast.
let notFoundRetries = 0;
const NOT_FOUND_MAX_RETRIES = this.resilientStart ? 3 : 0;
const NOT_FOUND_MAX_RETRIES = this.#resilientStart ? 3 : 0;
const NOT_FOUND_DELAYS = [1_000, 3_000, 6_000];

while (true) {
try {
const run = await world.runs.get(this.runId);

if (run.status === 'completed') {
const encryptionKey = await this.getEncryptionKey();
const encryptionKey = await this.#getEncryptionKey();
return await hydrateWorkflowReturnValue(
run.output,
this.runId,
Expand Down
53 changes: 51 additions & 2 deletions packages/core/src/runtime/runs.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
import {
EntityConflictError,
WorkflowWorldError,
WorkflowRunNotFoundError,
WorkflowWorldError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import type { Event, World } from '@workflow/world';
import { afterEach, describe, expect, it, vi } from 'vitest';

// Mock version module to avoid missing generated file
vi.mock('../version.js', () => ({ version: '0.0.0-test' }));

import { wakeUpRun } from './runs.js';
import { registerSerializationClass } from '../class-serialization.js';
import {
dehydrateStepReturnValue,
hydrateStepReturnValue,
} from '../serialization.js';
import { Run } from './run.js';
import { wakeUpRun } from './runs.js';
import { setWorld } from './world.js';

function createMockWorld(
Expand DownExpand Up@@ -225,3 +231,46 @@ describe('Run.wakeUp', () => {
expect(world.queue).not.toHaveBeenCalled();
});
});

describe('Run custom serialization', () => {
// In production builds, the SWC plugin auto-registers the class via an
// inline IIFE. In tests (no SWC), we register manually.
registerSerializationClass('Run', Run);

afterEach(() => {
setWorld(undefined as unknown as World);
});

it('should expose WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE methods', () => {
const run = new Run('wrun_serialize');
const serialized = Run[WORKFLOW_SERIALIZE](run);
const deserialized = Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});

expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
Comment on lines +246 to +256

CopilotAIApr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new serialization unit test only asserts resilientStart: false. Since resilientStart is now part of the serialized payload (and affects returnValue retry behavior), add a case that serializes/deserializes a Run created with resilientStart: true and asserts it roundtrips as true to prevent regressions.

Suggested change
constserialized=Run[WORKFLOW_SERIALIZE](run);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
constserialized=Run[WORKFLOW_SERIALIZE](run);
constresilientRun=newRun('wrun_serialize_resilient',{
resilientStart: true,
});
constresilientSerialized=Run[WORKFLOW_SERIALIZE](resilientRun);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
constresilientDeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize_resilient',
resilientStart: true,
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(resilientSerialized).toEqual({
runId: 'wrun_serialize_resilient',
resilientStart: true,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
expect(deserialized.resilientStart).toBe(false);
expect(resilientDeserialized).toBeInstanceOf(Run);
expect(resilientDeserialized.runId).toBe('wrun_deserialize_resilient');
expect(resilientDeserialized.resilientStart).toBe(true);

Copilot uses AI. Check for mistakes.
});

it('should roundtrip through step serialization boundary', async () => {
const run = new Run('wrun_roundtrip');
const dehydrated = await dehydrateStepReturnValue(
run,
'wrun_parent',
undefined
);

const hydrated = await hydrateStepReturnValue(
dehydrated,
'wrun_parent',
undefined
);

expect(hydrated).toBeInstanceOf(Run);
expect((hydrated as Run<unknown>).runId).toBe('wrun_roundtrip');
});
});
7 changes: 2 additions & 5 deletions packages/workflow/src/api-workflow.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,14 @@ export type {
WorkflowRun,
} from '@workflow/core/runtime';

export { Run } from '@workflow/core/runtime/run';

Comment thread
TooTallNate marked this conversation as resolved.
const workflowStub = (item: string) => {
throw new Error(
`The workflow environment doesn't allow this runtime usage of ${item}. Move this call to a step function ("use step") or call it outside the workflow context.`
);
};

export class Run {
constructor() {
workflowStub('Run');
}
}
export const getRun = () => workflowStub('getRun');
export const getHookByToken = () => workflowStub('getHookByToken');
export const resumeHook = () => workflowStub('resumeHook');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix: serialize Run across runtime and workflow VM by TooTallNate · Pull Request #1616 · vercel/workflow · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/neat-runs-serialize.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/core": minor
"workflow": minor
---

Use custom class serialization for `Run` across runtime and workflow VM contexts, and add e2e coverage for `Run` instance boundary roundtrips
39 changes: 39 additions & 0 deletions packages/core/e2e/e2e.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1528,6 +1528,45 @@ describe('e2e', () => {
}
);

test(
'runClassSerializationWorkflow - Run instances serialize across workflow/step boundaries',
{ timeout: 120_000 },
async () => {
const inputValue = 21;
const run = await start(await e2e('runClassSerializationWorkflow'), [
inputValue,
]);
const returnValue = await run.returnValue;

expect(returnValue).toHaveProperty('isRunInWorkflow', true);
expect(returnValue).toHaveProperty('childRunId');
expect(returnValue).toHaveProperty('runIdFromStep');
expect(returnValue).toHaveProperty('childResult');

expect(typeof returnValue.childRunId).toBe('string');
expect(returnValue.childRunId.startsWith('wrun_')).toBe(true);
expect(returnValue.runIdFromStep).toBe(returnValue.childRunId);
expect(returnValue.childResult).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});

const { json: parentRunData } = await cliInspectJson(
`runs ${run.runId} --withData`
);
expect(parentRunData.status).toBe('completed');

const { json: childRunData } = await cliInspectJson(
`runs ${returnValue.childRunId} --withData`
);
expect(childRunData.status).toBe('completed');
expect(childRunData.output).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});
}
);

// Skipped for Vercel since VQS doesn't support direct HTTP calls
test.skipIf(!isLocalDeployment())(
'health check endpoint (HTTP) - workflow and step endpoints respond to __health query parameter',
Expand Down
4 changes: 4 additions & 0 deletions packages/core/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,10 @@
"types": "./dist/runtime.d.ts",
"default": "./dist/runtime.js"
},
"./runtime/run": {
Comment thread
VaguelySerious marked this conversation as resolved.
"types": "./dist/runtime/run.d.ts",
Comment thread
TooTallNate marked this conversation as resolved.
"default": "./dist/runtime/run.js"
},
"./runtime/start": {
"types": "./dist/runtime/start.d.ts",
"default": "./dist/runtime/start.js"
Expand Down
75 changes: 50 additions & 25 deletions packages/core/src/runtime/run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {
WorkflowRunNotCompletedError,
WorkflowRunNotFoundError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import {
SPEC_VERSION_CURRENT,
type WorkflowRunStatus,
Expand DownExpand Up@@ -69,6 +70,17 @@ export interface WorkflowReadableStreamOptions {
* A handler class for a workflow run.
*/
export class Run<TResult> {
static [WORKFLOW_SERIALIZE](instance: Run<unknown>) {
return { runId: instance.runId, resilientStart: instance.#resilientStart };
}

static [WORKFLOW_DESERIALIZE](data: {
runId: string;
resilientStart?: boolean;
}) {
return new Run(data.runId, { resilientStart: data.resilientStart });
}

/**
* The ID of the workflow run.
*/
Expand All@@ -78,14 +90,18 @@ export class Run<TResult> {
* The world object.
* @internal
*/
private worldPromise: Promise<World>;
#worldPromise: Promise<World> | undefined;
get #lazyWorldPromise() {
if (!this.#worldPromise) this.#worldPromise = getWorld();
return this.#worldPromise;
}

/**
* Cached encryption key resolution. Resolved once on first use and
* reused for returnValue, getReadable(), etc.
* @internal
*/
private encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;
#encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;

/**
* When true, run_created failed and the run may not exist yet (the
Expand All@@ -94,12 +110,11 @@ export class Run<TResult> {
* that normal runs fail fast on 404.
* @internal
*/
private resilientStart = false;
#resilientStart = false;

constructor(runId: string, opts?: { resilientStart?: boolean }) {
this.runId = runId;
this.worldPromise = getWorld();
this.resilientStart = opts?.resilientStart ?? false;
this.#resilientStart = opts?.resilientStart ?? false;
}

/**
Expand All@@ -108,16 +123,16 @@ export class Run<TResult> {
* to be resolved once.
* @internal
*/
private getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.encryptionKeyPromise) {
this.encryptionKeyPromise = (async () => {
const world = await this.worldPromise;
#getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.#encryptionKeyPromise) {
this.#encryptionKeyPromise = (async () => {
const world = await this.#lazyWorldPromise;
const run = await world.runs.get(this.runId);
const rawKey = await world.getEncryptionKeyForRun?.(run);
return rawKey ? await importKey(rawKey) : undefined;
})();
}
return this.encryptionKeyPromise;
return this.#encryptionKeyPromise;
}

/**
Expand All@@ -128,14 +143,16 @@ export class Run<TResult> {
* @returns A {@link StopSleepResult} object containing the number of sleep calls that were interrupted.
*/
async wakeUp(options?: StopSleepOptions): Promise<StopSleepResult> {
return wakeUpRun(await this.worldPromise, this.runId, options);
'use step';
return wakeUpRun(await this.#lazyWorldPromise, this.runId, options);
}

/**
* Cancels the workflow run.
*/
async cancel(): Promise<void> {
const world = await this.worldPromise;
'use step';
const world = await this.#lazyWorldPromise;
await world.events.create(this.runId, {
eventType: 'run_cancelled',
specVersion: SPEC_VERSION_CURRENT,
Expand All@@ -146,7 +163,8 @@ export class Run<TResult> {
* Whether the workflow run exists.
*/
get exists(): Promise<boolean> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs
.get(this.runId, { resolveData: 'none' })
.then(() => true)
Expand All@@ -163,7 +181,8 @@ export class Run<TResult> {
* The status of the workflow run.
*/
get status(): Promise<WorkflowRunStatus> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.status)
);
}
Expand All@@ -173,14 +192,16 @@ export class Run<TResult> {
* Polls the workflow return value until it is completed.
*/
get returnValue(): Promise<TResult> {
return this.pollReturnValue();
'use step';
return this.#pollReturnValue();
}

/**
* The name of the workflow.
*/
get workflowName(): Promise<string> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.workflowName)
);
}
Expand All@@ -189,7 +210,8 @@ export class Run<TResult> {
* The timestamp when the workflow run was created.
*/
get createdAt(): Promise<Date> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.createdAt)
);
}
Expand All@@ -199,7 +221,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not started yet.
*/
get startedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.startedAt)
);
}
Expand All@@ -209,7 +232,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not completed yet.
*/
get completedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.completedAt)
);
}
Expand All@@ -236,11 +260,12 @@ export class Run<TResult> {
getReadable<R = any>(
options: WorkflowReadableStreamOptions = {}
): WorkflowReadableStream<R> {
'use step';
Comment thread
TooTallNate marked this conversation as resolved.
const { ops = [], global = globalThis, startIndex, namespace } = options;
const name = getWorkflowRunStreamId(this.runId, namespace);
// Pass the key as a promise — it will be resolved lazily inside
// the first async transform() call of the deserialize stream.
const encryptionKey = this.getEncryptionKey();
const encryptionKey = this.#getEncryptionKey();
const stream = getExternalRevivers(
global,
ops,
Expand All@@ -251,7 +276,7 @@ export class Run<TResult> {
startIndex,
}) as ReadableStream<R>;

const worldPromise = this.worldPromise;
const worldPromise = this.#lazyWorldPromise;
const runId = this.runId;
return Object.assign(stream, {
getTailIndex: async (): Promise<number> => {
Expand All@@ -267,24 +292,24 @@ export class Run<TResult> {
* @internal
* @returns The workflow return value.
*/
private async pollReturnValue(): Promise<TResult> {
const world = await this.worldPromise;
async #pollReturnValue(): Promise<TResult> {
const world = await this.#lazyWorldPromise;

// When resilientStart is true, run_created failed and the run may
// not exist yet. Retry on WorkflowRunNotFoundError up to 3 times
// (1s + 3s + 6s = 10s total) to give the queue time to deliver
// and the runtime to create the run via run_started.
// When resilientStart is false, 404 is a real error — fail fast.
let notFoundRetries = 0;
const NOT_FOUND_MAX_RETRIES = this.resilientStart ? 3 : 0;
const NOT_FOUND_MAX_RETRIES = this.#resilientStart ? 3 : 0;
const NOT_FOUND_DELAYS = [1_000, 3_000, 6_000];

while (true) {
try {
const run = await world.runs.get(this.runId);

if (run.status === 'completed') {
const encryptionKey = await this.getEncryptionKey();
const encryptionKey = await this.#getEncryptionKey();
return await hydrateWorkflowReturnValue(
run.output,
this.runId,
Expand Down
53 changes: 51 additions & 2 deletions packages/core/src/runtime/runs.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
import {
EntityConflictError,
WorkflowWorldError,
WorkflowRunNotFoundError,
WorkflowWorldError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import type { Event, World } from '@workflow/world';
import { afterEach, describe, expect, it, vi } from 'vitest';

// Mock version module to avoid missing generated file
vi.mock('../version.js', () => ({ version: '0.0.0-test' }));

import { wakeUpRun } from './runs.js';
import { registerSerializationClass } from '../class-serialization.js';
import {
dehydrateStepReturnValue,
hydrateStepReturnValue,
} from '../serialization.js';
import { Run } from './run.js';
import { wakeUpRun } from './runs.js';
import { setWorld } from './world.js';

function createMockWorld(
Expand DownExpand Up@@ -225,3 +231,46 @@ describe('Run.wakeUp', () => {
expect(world.queue).not.toHaveBeenCalled();
});
});

describe('Run custom serialization', () => {
// In production builds, the SWC plugin auto-registers the class via an
// inline IIFE. In tests (no SWC), we register manually.
registerSerializationClass('Run', Run);

afterEach(() => {
setWorld(undefined as unknown as World);
});

it('should expose WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE methods', () => {
const run = new Run('wrun_serialize');
const serialized = Run[WORKFLOW_SERIALIZE](run);
const deserialized = Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});

expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
Comment on lines +246 to +256

CopilotAIApr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new serialization unit test only asserts resilientStart: false. Since resilientStart is now part of the serialized payload (and affects returnValue retry behavior), add a case that serializes/deserializes a Run created with resilientStart: true and asserts it roundtrips as true to prevent regressions.

Suggested change
constserialized=Run[WORKFLOW_SERIALIZE](run);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
constserialized=Run[WORKFLOW_SERIALIZE](run);
constresilientRun=newRun('wrun_serialize_resilient',{
resilientStart: true,
});
constresilientSerialized=Run[WORKFLOW_SERIALIZE](resilientRun);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
constresilientDeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize_resilient',
resilientStart: true,
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(resilientSerialized).toEqual({
runId: 'wrun_serialize_resilient',
resilientStart: true,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
expect(deserialized.resilientStart).toBe(false);
expect(resilientDeserialized).toBeInstanceOf(Run);
expect(resilientDeserialized.runId).toBe('wrun_deserialize_resilient');
expect(resilientDeserialized.resilientStart).toBe(true);

Copilot uses AI. Check for mistakes.
});

it('should roundtrip through step serialization boundary', async () => {
const run = new Run('wrun_roundtrip');
const dehydrated = await dehydrateStepReturnValue(
run,
'wrun_parent',
undefined
);

const hydrated = await hydrateStepReturnValue(
dehydrated,
'wrun_parent',
undefined
);

expect(hydrated).toBeInstanceOf(Run);
expect((hydrated as Run<unknown>).runId).toBe('wrun_roundtrip');
});
});
7 changes: 2 additions & 5 deletions packages/workflow/src/api-workflow.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,14 @@ export type {
WorkflowRun,
} from '@workflow/core/runtime';

export { Run } from '@workflow/core/runtime/run';

Comment thread
TooTallNate marked this conversation as resolved.
const workflowStub = (item: string) => {
throw new Error(
`The workflow environment doesn't allow this runtime usage of ${item}. Move this call to a step function ("use step") or call it outside the workflow context.`
);
};

export class Run {
constructor() {
workflowStub('Run');
}
}
export const getRun = () => workflowStub('getRun');
export const getHookByToken = () => workflowStub('getHookByToken');
export const resumeHook = () => workflowStub('resumeHook');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: serialize Run across runtime and workflow VM by TooTallNate · Pull Request #1616 · vercel/workflow · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/neat-runs-serialize.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/core": minor
"workflow": minor
---

Use custom class serialization for `Run` across runtime and workflow VM contexts, and add e2e coverage for `Run` instance boundary roundtrips
39 changes: 39 additions & 0 deletions packages/core/e2e/e2e.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1528,6 +1528,45 @@ describe('e2e', () => {
}
);

test(
'runClassSerializationWorkflow - Run instances serialize across workflow/step boundaries',
{ timeout: 120_000 },
async () => {
const inputValue = 21;
const run = await start(await e2e('runClassSerializationWorkflow'), [
inputValue,
]);
const returnValue = await run.returnValue;

expect(returnValue).toHaveProperty('isRunInWorkflow', true);
expect(returnValue).toHaveProperty('childRunId');
expect(returnValue).toHaveProperty('runIdFromStep');
expect(returnValue).toHaveProperty('childResult');

expect(typeof returnValue.childRunId).toBe('string');
expect(returnValue.childRunId.startsWith('wrun_')).toBe(true);
expect(returnValue.runIdFromStep).toBe(returnValue.childRunId);
expect(returnValue.childResult).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});

const { json: parentRunData } = await cliInspectJson(
`runs ${run.runId} --withData`
);
expect(parentRunData.status).toBe('completed');

const { json: childRunData } = await cliInspectJson(
`runs ${returnValue.childRunId} --withData`
);
expect(childRunData.status).toBe('completed');
expect(childRunData.output).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});
}
);

// Skipped for Vercel since VQS doesn't support direct HTTP calls
test.skipIf(!isLocalDeployment())(
'health check endpoint (HTTP) - workflow and step endpoints respond to __health query parameter',
Expand Down
4 changes: 4 additions & 0 deletions packages/core/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,10 @@
"types": "./dist/runtime.d.ts",
"default": "./dist/runtime.js"
},
"./runtime/run": {
Comment thread
VaguelySerious marked this conversation as resolved.
"types": "./dist/runtime/run.d.ts",
Comment thread
TooTallNate marked this conversation as resolved.
"default": "./dist/runtime/run.js"
},
"./runtime/start": {
"types": "./dist/runtime/start.d.ts",
"default": "./dist/runtime/start.js"
Expand Down
75 changes: 50 additions & 25 deletions packages/core/src/runtime/run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {
WorkflowRunNotCompletedError,
WorkflowRunNotFoundError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import {
SPEC_VERSION_CURRENT,
type WorkflowRunStatus,
Expand DownExpand Up@@ -69,6 +70,17 @@ export interface WorkflowReadableStreamOptions {
* A handler class for a workflow run.
*/
export class Run<TResult> {
static [WORKFLOW_SERIALIZE](instance: Run<unknown>) {
return { runId: instance.runId, resilientStart: instance.#resilientStart };
}

static [WORKFLOW_DESERIALIZE](data: {
runId: string;
resilientStart?: boolean;
}) {
return new Run(data.runId, { resilientStart: data.resilientStart });
}

/**
* The ID of the workflow run.
*/
Expand All@@ -78,14 +90,18 @@ export class Run<TResult> {
* The world object.
* @internal
*/
private worldPromise: Promise<World>;
#worldPromise: Promise<World> | undefined;
get #lazyWorldPromise() {
if (!this.#worldPromise) this.#worldPromise = getWorld();
return this.#worldPromise;
}

/**
* Cached encryption key resolution. Resolved once on first use and
* reused for returnValue, getReadable(), etc.
* @internal
*/
private encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;
#encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;

/**
* When true, run_created failed and the run may not exist yet (the
Expand All@@ -94,12 +110,11 @@ export class Run<TResult> {
* that normal runs fail fast on 404.
* @internal
*/
private resilientStart = false;
#resilientStart = false;

constructor(runId: string, opts?: { resilientStart?: boolean }) {
this.runId = runId;
this.worldPromise = getWorld();
this.resilientStart = opts?.resilientStart ?? false;
this.#resilientStart = opts?.resilientStart ?? false;
}

/**
Expand All@@ -108,16 +123,16 @@ export class Run<TResult> {
* to be resolved once.
* @internal
*/
private getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.encryptionKeyPromise) {
this.encryptionKeyPromise = (async () => {
const world = await this.worldPromise;
#getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.#encryptionKeyPromise) {
this.#encryptionKeyPromise = (async () => {
const world = await this.#lazyWorldPromise;
const run = await world.runs.get(this.runId);
const rawKey = await world.getEncryptionKeyForRun?.(run);
return rawKey ? await importKey(rawKey) : undefined;
})();
}
return this.encryptionKeyPromise;
return this.#encryptionKeyPromise;
}

/**
Expand All@@ -128,14 +143,16 @@ export class Run<TResult> {
* @returns A {@link StopSleepResult} object containing the number of sleep calls that were interrupted.
*/
async wakeUp(options?: StopSleepOptions): Promise<StopSleepResult> {
return wakeUpRun(await this.worldPromise, this.runId, options);
'use step';
return wakeUpRun(await this.#lazyWorldPromise, this.runId, options);
}

/**
* Cancels the workflow run.
*/
async cancel(): Promise<void> {
const world = await this.worldPromise;
'use step';
const world = await this.#lazyWorldPromise;
await world.events.create(this.runId, {
eventType: 'run_cancelled',
specVersion: SPEC_VERSION_CURRENT,
Expand All@@ -146,7 +163,8 @@ export class Run<TResult> {
* Whether the workflow run exists.
*/
get exists(): Promise<boolean> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs
.get(this.runId, { resolveData: 'none' })
.then(() => true)
Expand All@@ -163,7 +181,8 @@ export class Run<TResult> {
* The status of the workflow run.
*/
get status(): Promise<WorkflowRunStatus> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.status)
);
}
Expand All@@ -173,14 +192,16 @@ export class Run<TResult> {
* Polls the workflow return value until it is completed.
*/
get returnValue(): Promise<TResult> {
return this.pollReturnValue();
'use step';
return this.#pollReturnValue();
}

/**
* The name of the workflow.
*/
get workflowName(): Promise<string> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.workflowName)
);
}
Expand All@@ -189,7 +210,8 @@ export class Run<TResult> {
* The timestamp when the workflow run was created.
*/
get createdAt(): Promise<Date> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.createdAt)
);
}
Expand All@@ -199,7 +221,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not started yet.
*/
get startedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.startedAt)
);
}
Expand All@@ -209,7 +232,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not completed yet.
*/
get completedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.completedAt)
);
}
Expand All@@ -236,11 +260,12 @@ export class Run<TResult> {
getReadable<R = any>(
options: WorkflowReadableStreamOptions = {}
): WorkflowReadableStream<R> {
'use step';
Comment thread
TooTallNate marked this conversation as resolved.
const { ops = [], global = globalThis, startIndex, namespace } = options;
const name = getWorkflowRunStreamId(this.runId, namespace);
// Pass the key as a promise — it will be resolved lazily inside
// the first async transform() call of the deserialize stream.
const encryptionKey = this.getEncryptionKey();
const encryptionKey = this.#getEncryptionKey();
const stream = getExternalRevivers(
global,
ops,
Expand All@@ -251,7 +276,7 @@ export class Run<TResult> {
startIndex,
}) as ReadableStream<R>;

const worldPromise = this.worldPromise;
const worldPromise = this.#lazyWorldPromise;
const runId = this.runId;
return Object.assign(stream, {
getTailIndex: async (): Promise<number> => {
Expand All@@ -267,24 +292,24 @@ export class Run<TResult> {
* @internal
* @returns The workflow return value.
*/
private async pollReturnValue(): Promise<TResult> {
const world = await this.worldPromise;
async #pollReturnValue(): Promise<TResult> {
const world = await this.#lazyWorldPromise;

// When resilientStart is true, run_created failed and the run may
// not exist yet. Retry on WorkflowRunNotFoundError up to 3 times
// (1s + 3s + 6s = 10s total) to give the queue time to deliver
// and the runtime to create the run via run_started.
// When resilientStart is false, 404 is a real error — fail fast.
let notFoundRetries = 0;
const NOT_FOUND_MAX_RETRIES = this.resilientStart ? 3 : 0;
const NOT_FOUND_MAX_RETRIES = this.#resilientStart ? 3 : 0;
const NOT_FOUND_DELAYS = [1_000, 3_000, 6_000];

while (true) {
try {
const run = await world.runs.get(this.runId);

if (run.status === 'completed') {
const encryptionKey = await this.getEncryptionKey();
const encryptionKey = await this.#getEncryptionKey();
return await hydrateWorkflowReturnValue(
run.output,
this.runId,
Expand Down
53 changes: 51 additions & 2 deletions packages/core/src/runtime/runs.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
import {
EntityConflictError,
WorkflowWorldError,
WorkflowRunNotFoundError,
WorkflowWorldError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import type { Event, World } from '@workflow/world';
import { afterEach, describe, expect, it, vi } from 'vitest';

// Mock version module to avoid missing generated file
vi.mock('../version.js', () => ({ version: '0.0.0-test' }));

import { wakeUpRun } from './runs.js';
import { registerSerializationClass } from '../class-serialization.js';
import {
dehydrateStepReturnValue,
hydrateStepReturnValue,
} from '../serialization.js';
import { Run } from './run.js';
import { wakeUpRun } from './runs.js';
import { setWorld } from './world.js';

function createMockWorld(
Expand DownExpand Up@@ -225,3 +231,46 @@ describe('Run.wakeUp', () => {
expect(world.queue).not.toHaveBeenCalled();
});
});

describe('Run custom serialization', () => {
// In production builds, the SWC plugin auto-registers the class via an
// inline IIFE. In tests (no SWC), we register manually.
registerSerializationClass('Run', Run);

afterEach(() => {
setWorld(undefined as unknown as World);
});

it('should expose WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE methods', () => {
const run = new Run('wrun_serialize');
const serialized = Run[WORKFLOW_SERIALIZE](run);
const deserialized = Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});

expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
Comment on lines +246 to +256

CopilotAIApr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new serialization unit test only asserts resilientStart: false. Since resilientStart is now part of the serialized payload (and affects returnValue retry behavior), add a case that serializes/deserializes a Run created with resilientStart: true and asserts it roundtrips as true to prevent regressions.

Suggested change
constserialized=Run[WORKFLOW_SERIALIZE](run);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
constserialized=Run[WORKFLOW_SERIALIZE](run);
constresilientRun=newRun('wrun_serialize_resilient',{
resilientStart: true,
});
constresilientSerialized=Run[WORKFLOW_SERIALIZE](resilientRun);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
constresilientDeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize_resilient',
resilientStart: true,
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(resilientSerialized).toEqual({
runId: 'wrun_serialize_resilient',
resilientStart: true,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
expect(deserialized.resilientStart).toBe(false);
expect(resilientDeserialized).toBeInstanceOf(Run);
expect(resilientDeserialized.runId).toBe('wrun_deserialize_resilient');
expect(resilientDeserialized.resilientStart).toBe(true);

Copilot uses AI. Check for mistakes.
});

it('should roundtrip through step serialization boundary', async () => {
const run = new Run('wrun_roundtrip');
const dehydrated = await dehydrateStepReturnValue(
run,
'wrun_parent',
undefined
);

const hydrated = await hydrateStepReturnValue(
dehydrated,
'wrun_parent',
undefined
);

expect(hydrated).toBeInstanceOf(Run);
expect((hydrated as Run<unknown>).runId).toBe('wrun_roundtrip');
});
});
7 changes: 2 additions & 5 deletions packages/workflow/src/api-workflow.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,14 @@ export type {
WorkflowRun,
} from '@workflow/core/runtime';

export { Run } from '@workflow/core/runtime/run';

Comment thread
TooTallNate marked this conversation as resolved.
const workflowStub = (item: string) => {
throw new Error(
`The workflow environment doesn't allow this runtime usage of ${item}. Move this call to a step function ("use step") or call it outside the workflow context.`
);
};

export class Run {
constructor() {
workflowStub('Run');
}
}
export const getRun = () => workflowStub('getRun');
export const getHookByToken = () => workflowStub('getHookByToken');
export const resumeHook = () => workflowStub('resumeHook');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: serialize Run across runtime and workflow VM by TooTallNate · Pull Request #1616 · vercel/workflow · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/neat-runs-serialize.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/core": minor
"workflow": minor
---

Use custom class serialization for `Run` across runtime and workflow VM contexts, and add e2e coverage for `Run` instance boundary roundtrips
39 changes: 39 additions & 0 deletions packages/core/e2e/e2e.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1528,6 +1528,45 @@ describe('e2e', () => {
}
);

test(
'runClassSerializationWorkflow - Run instances serialize across workflow/step boundaries',
{ timeout: 120_000 },
async () => {
const inputValue = 21;
const run = await start(await e2e('runClassSerializationWorkflow'), [
inputValue,
]);
const returnValue = await run.returnValue;

expect(returnValue).toHaveProperty('isRunInWorkflow', true);
expect(returnValue).toHaveProperty('childRunId');
expect(returnValue).toHaveProperty('runIdFromStep');
expect(returnValue).toHaveProperty('childResult');

expect(typeof returnValue.childRunId).toBe('string');
expect(returnValue.childRunId.startsWith('wrun_')).toBe(true);
expect(returnValue.runIdFromStep).toBe(returnValue.childRunId);
expect(returnValue.childResult).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});

const { json: parentRunData } = await cliInspectJson(
`runs ${run.runId} --withData`
);
expect(parentRunData.status).toBe('completed');

const { json: childRunData } = await cliInspectJson(
`runs ${returnValue.childRunId} --withData`
);
expect(childRunData.status).toBe('completed');
expect(childRunData.output).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});
}
);

// Skipped for Vercel since VQS doesn't support direct HTTP calls
test.skipIf(!isLocalDeployment())(
'health check endpoint (HTTP) - workflow and step endpoints respond to __health query parameter',
Expand Down
4 changes: 4 additions & 0 deletions packages/core/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,10 @@
"types": "./dist/runtime.d.ts",
"default": "./dist/runtime.js"
},
"./runtime/run": {
Comment thread
VaguelySerious marked this conversation as resolved.
"types": "./dist/runtime/run.d.ts",
Comment thread
TooTallNate marked this conversation as resolved.
"default": "./dist/runtime/run.js"
},
"./runtime/start": {
"types": "./dist/runtime/start.d.ts",
"default": "./dist/runtime/start.js"
Expand Down
75 changes: 50 additions & 25 deletions packages/core/src/runtime/run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {
WorkflowRunNotCompletedError,
WorkflowRunNotFoundError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import {
SPEC_VERSION_CURRENT,
type WorkflowRunStatus,
Expand DownExpand Up@@ -69,6 +70,17 @@ export interface WorkflowReadableStreamOptions {
* A handler class for a workflow run.
*/
export class Run<TResult> {
static [WORKFLOW_SERIALIZE](instance: Run<unknown>) {
return { runId: instance.runId, resilientStart: instance.#resilientStart };
}

static [WORKFLOW_DESERIALIZE](data: {
runId: string;
resilientStart?: boolean;
}) {
return new Run(data.runId, { resilientStart: data.resilientStart });
}

/**
* The ID of the workflow run.
*/
Expand All@@ -78,14 +90,18 @@ export class Run<TResult> {
* The world object.
* @internal
*/
private worldPromise: Promise<World>;
#worldPromise: Promise<World> | undefined;
get #lazyWorldPromise() {
if (!this.#worldPromise) this.#worldPromise = getWorld();
return this.#worldPromise;
}

/**
* Cached encryption key resolution. Resolved once on first use and
* reused for returnValue, getReadable(), etc.
* @internal
*/
private encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;
#encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;

/**
* When true, run_created failed and the run may not exist yet (the
Expand All@@ -94,12 +110,11 @@ export class Run<TResult> {
* that normal runs fail fast on 404.
* @internal
*/
private resilientStart = false;
#resilientStart = false;

constructor(runId: string, opts?: { resilientStart?: boolean }) {
this.runId = runId;
this.worldPromise = getWorld();
this.resilientStart = opts?.resilientStart ?? false;
this.#resilientStart = opts?.resilientStart ?? false;
}

/**
Expand All@@ -108,16 +123,16 @@ export class Run<TResult> {
* to be resolved once.
* @internal
*/
private getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.encryptionKeyPromise) {
this.encryptionKeyPromise = (async () => {
const world = await this.worldPromise;
#getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.#encryptionKeyPromise) {
this.#encryptionKeyPromise = (async () => {
const world = await this.#lazyWorldPromise;
const run = await world.runs.get(this.runId);
const rawKey = await world.getEncryptionKeyForRun?.(run);
return rawKey ? await importKey(rawKey) : undefined;
})();
}
return this.encryptionKeyPromise;
return this.#encryptionKeyPromise;
}

/**
Expand All@@ -128,14 +143,16 @@ export class Run<TResult> {
* @returns A {@link StopSleepResult} object containing the number of sleep calls that were interrupted.
*/
async wakeUp(options?: StopSleepOptions): Promise<StopSleepResult> {
return wakeUpRun(await this.worldPromise, this.runId, options);
'use step';
return wakeUpRun(await this.#lazyWorldPromise, this.runId, options);
}

/**
* Cancels the workflow run.
*/
async cancel(): Promise<void> {
const world = await this.worldPromise;
'use step';
const world = await this.#lazyWorldPromise;
await world.events.create(this.runId, {
eventType: 'run_cancelled',
specVersion: SPEC_VERSION_CURRENT,
Expand All@@ -146,7 +163,8 @@ export class Run<TResult> {
* Whether the workflow run exists.
*/
get exists(): Promise<boolean> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs
.get(this.runId, { resolveData: 'none' })
.then(() => true)
Expand All@@ -163,7 +181,8 @@ export class Run<TResult> {
* The status of the workflow run.
*/
get status(): Promise<WorkflowRunStatus> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.status)
);
}
Expand All@@ -173,14 +192,16 @@ export class Run<TResult> {
* Polls the workflow return value until it is completed.
*/
get returnValue(): Promise<TResult> {
return this.pollReturnValue();
'use step';
return this.#pollReturnValue();
}

/**
* The name of the workflow.
*/
get workflowName(): Promise<string> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.workflowName)
);
}
Expand All@@ -189,7 +210,8 @@ export class Run<TResult> {
* The timestamp when the workflow run was created.
*/
get createdAt(): Promise<Date> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.createdAt)
);
}
Expand All@@ -199,7 +221,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not started yet.
*/
get startedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.startedAt)
);
}
Expand All@@ -209,7 +232,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not completed yet.
*/
get completedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.completedAt)
);
}
Expand All@@ -236,11 +260,12 @@ export class Run<TResult> {
getReadable<R = any>(
options: WorkflowReadableStreamOptions = {}
): WorkflowReadableStream<R> {
'use step';
Comment thread
TooTallNate marked this conversation as resolved.
const { ops = [], global = globalThis, startIndex, namespace } = options;
const name = getWorkflowRunStreamId(this.runId, namespace);
// Pass the key as a promise — it will be resolved lazily inside
// the first async transform() call of the deserialize stream.
const encryptionKey = this.getEncryptionKey();
const encryptionKey = this.#getEncryptionKey();
const stream = getExternalRevivers(
global,
ops,
Expand All@@ -251,7 +276,7 @@ export class Run<TResult> {
startIndex,
}) as ReadableStream<R>;

const worldPromise = this.worldPromise;
const worldPromise = this.#lazyWorldPromise;
const runId = this.runId;
return Object.assign(stream, {
getTailIndex: async (): Promise<number> => {
Expand All@@ -267,24 +292,24 @@ export class Run<TResult> {
* @internal
* @returns The workflow return value.
*/
private async pollReturnValue(): Promise<TResult> {
const world = await this.worldPromise;
async #pollReturnValue(): Promise<TResult> {
const world = await this.#lazyWorldPromise;

// When resilientStart is true, run_created failed and the run may
// not exist yet. Retry on WorkflowRunNotFoundError up to 3 times
// (1s + 3s + 6s = 10s total) to give the queue time to deliver
// and the runtime to create the run via run_started.
// When resilientStart is false, 404 is a real error — fail fast.
let notFoundRetries = 0;
const NOT_FOUND_MAX_RETRIES = this.resilientStart ? 3 : 0;
const NOT_FOUND_MAX_RETRIES = this.#resilientStart ? 3 : 0;
const NOT_FOUND_DELAYS = [1_000, 3_000, 6_000];

while (true) {
try {
const run = await world.runs.get(this.runId);

if (run.status === 'completed') {
const encryptionKey = await this.getEncryptionKey();
const encryptionKey = await this.#getEncryptionKey();
return await hydrateWorkflowReturnValue(
run.output,
this.runId,
Expand Down
53 changes: 51 additions & 2 deletions packages/core/src/runtime/runs.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
import {
EntityConflictError,
WorkflowWorldError,
WorkflowRunNotFoundError,
WorkflowWorldError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import type { Event, World } from '@workflow/world';
import { afterEach, describe, expect, it, vi } from 'vitest';

// Mock version module to avoid missing generated file
vi.mock('../version.js', () => ({ version: '0.0.0-test' }));

import { wakeUpRun } from './runs.js';
import { registerSerializationClass } from '../class-serialization.js';
import {
dehydrateStepReturnValue,
hydrateStepReturnValue,
} from '../serialization.js';
import { Run } from './run.js';
import { wakeUpRun } from './runs.js';
import { setWorld } from './world.js';

function createMockWorld(
Expand DownExpand Up@@ -225,3 +231,46 @@ describe('Run.wakeUp', () => {
expect(world.queue).not.toHaveBeenCalled();
});
});

describe('Run custom serialization', () => {
// In production builds, the SWC plugin auto-registers the class via an
// inline IIFE. In tests (no SWC), we register manually.
registerSerializationClass('Run', Run);

afterEach(() => {
setWorld(undefined as unknown as World);
});

it('should expose WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE methods', () => {
const run = new Run('wrun_serialize');
const serialized = Run[WORKFLOW_SERIALIZE](run);
const deserialized = Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});

expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
Comment on lines +246 to +256

CopilotAIApr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new serialization unit test only asserts resilientStart: false. Since resilientStart is now part of the serialized payload (and affects returnValue retry behavior), add a case that serializes/deserializes a Run created with resilientStart: true and asserts it roundtrips as true to prevent regressions.

Suggested change
constserialized=Run[WORKFLOW_SERIALIZE](run);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
constserialized=Run[WORKFLOW_SERIALIZE](run);
constresilientRun=newRun('wrun_serialize_resilient',{
resilientStart: true,
});
constresilientSerialized=Run[WORKFLOW_SERIALIZE](resilientRun);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
constresilientDeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize_resilient',
resilientStart: true,
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(resilientSerialized).toEqual({
runId: 'wrun_serialize_resilient',
resilientStart: true,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
expect(deserialized.resilientStart).toBe(false);
expect(resilientDeserialized).toBeInstanceOf(Run);
expect(resilientDeserialized.runId).toBe('wrun_deserialize_resilient');
expect(resilientDeserialized.resilientStart).toBe(true);

Copilot uses AI. Check for mistakes.
});

it('should roundtrip through step serialization boundary', async () => {
const run = new Run('wrun_roundtrip');
const dehydrated = await dehydrateStepReturnValue(
run,
'wrun_parent',
undefined
);

const hydrated = await hydrateStepReturnValue(
dehydrated,
'wrun_parent',
undefined
);

expect(hydrated).toBeInstanceOf(Run);
expect((hydrated as Run<unknown>).runId).toBe('wrun_roundtrip');
});
});
7 changes: 2 additions & 5 deletions packages/workflow/src/api-workflow.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,14 @@ export type {
WorkflowRun,
} from '@workflow/core/runtime';

export { Run } from '@workflow/core/runtime/run';

Comment thread
TooTallNate marked this conversation as resolved.
const workflowStub = (item: string) => {
throw new Error(
`The workflow environment doesn't allow this runtime usage of ${item}. Move this call to a step function ("use step") or call it outside the workflow context.`
);
};

export class Run {
constructor() {
workflowStub('Run');
}
}
export const getRun = () => workflowStub('getRun');
export const getHookByToken = () => workflowStub('getHookByToken');
export const resumeHook = () => workflowStub('resumeHook');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix: serialize Run across runtime and workflow VM by TooTallNate · Pull Request #1616 · vercel/workflow · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/neat-runs-serialize.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/core": minor
"workflow": minor
---

Use custom class serialization for `Run` across runtime and workflow VM contexts, and add e2e coverage for `Run` instance boundary roundtrips
39 changes: 39 additions & 0 deletions packages/core/e2e/e2e.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1528,6 +1528,45 @@ describe('e2e', () => {
}
);

test(
'runClassSerializationWorkflow - Run instances serialize across workflow/step boundaries',
{ timeout: 120_000 },
async () => {
const inputValue = 21;
const run = await start(await e2e('runClassSerializationWorkflow'), [
inputValue,
]);
const returnValue = await run.returnValue;

expect(returnValue).toHaveProperty('isRunInWorkflow', true);
expect(returnValue).toHaveProperty('childRunId');
expect(returnValue).toHaveProperty('runIdFromStep');
expect(returnValue).toHaveProperty('childResult');

expect(typeof returnValue.childRunId).toBe('string');
expect(returnValue.childRunId.startsWith('wrun_')).toBe(true);
expect(returnValue.runIdFromStep).toBe(returnValue.childRunId);
expect(returnValue.childResult).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});

const { json: parentRunData } = await cliInspectJson(
`runs ${run.runId} --withData`
);
expect(parentRunData.status).toBe('completed');

const { json: childRunData } = await cliInspectJson(
`runs ${returnValue.childRunId} --withData`
);
expect(childRunData.status).toBe('completed');
expect(childRunData.output).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});
}
);

// Skipped for Vercel since VQS doesn't support direct HTTP calls
test.skipIf(!isLocalDeployment())(
'health check endpoint (HTTP) - workflow and step endpoints respond to __health query parameter',
Expand Down
4 changes: 4 additions & 0 deletions packages/core/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,10 @@
"types": "./dist/runtime.d.ts",
"default": "./dist/runtime.js"
},
"./runtime/run": {
Comment thread
VaguelySerious marked this conversation as resolved.
"types": "./dist/runtime/run.d.ts",
Comment thread
TooTallNate marked this conversation as resolved.
"default": "./dist/runtime/run.js"
},
"./runtime/start": {
"types": "./dist/runtime/start.d.ts",
"default": "./dist/runtime/start.js"
Expand Down
75 changes: 50 additions & 25 deletions packages/core/src/runtime/run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {
WorkflowRunNotCompletedError,
WorkflowRunNotFoundError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import {
SPEC_VERSION_CURRENT,
type WorkflowRunStatus,
Expand DownExpand Up@@ -69,6 +70,17 @@ export interface WorkflowReadableStreamOptions {
* A handler class for a workflow run.
*/
export class Run<TResult> {
static [WORKFLOW_SERIALIZE](instance: Run<unknown>) {
return { runId: instance.runId, resilientStart: instance.#resilientStart };
}

static [WORKFLOW_DESERIALIZE](data: {
runId: string;
resilientStart?: boolean;
}) {
return new Run(data.runId, { resilientStart: data.resilientStart });
}

/**
* The ID of the workflow run.
*/
Expand All@@ -78,14 +90,18 @@ export class Run<TResult> {
* The world object.
* @internal
*/
private worldPromise: Promise<World>;
#worldPromise: Promise<World> | undefined;
get #lazyWorldPromise() {
if (!this.#worldPromise) this.#worldPromise = getWorld();
return this.#worldPromise;
}

/**
* Cached encryption key resolution. Resolved once on first use and
* reused for returnValue, getReadable(), etc.
* @internal
*/
private encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;
#encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;

/**
* When true, run_created failed and the run may not exist yet (the
Expand All@@ -94,12 +110,11 @@ export class Run<TResult> {
* that normal runs fail fast on 404.
* @internal
*/
private resilientStart = false;
#resilientStart = false;

constructor(runId: string, opts?: { resilientStart?: boolean }) {
this.runId = runId;
this.worldPromise = getWorld();
this.resilientStart = opts?.resilientStart ?? false;
this.#resilientStart = opts?.resilientStart ?? false;
}

/**
Expand All@@ -108,16 +123,16 @@ export class Run<TResult> {
* to be resolved once.
* @internal
*/
private getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.encryptionKeyPromise) {
this.encryptionKeyPromise = (async () => {
const world = await this.worldPromise;
#getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.#encryptionKeyPromise) {
this.#encryptionKeyPromise = (async () => {
const world = await this.#lazyWorldPromise;
const run = await world.runs.get(this.runId);
const rawKey = await world.getEncryptionKeyForRun?.(run);
return rawKey ? await importKey(rawKey) : undefined;
})();
}
return this.encryptionKeyPromise;
return this.#encryptionKeyPromise;
}

/**
Expand All@@ -128,14 +143,16 @@ export class Run<TResult> {
* @returns A {@link StopSleepResult} object containing the number of sleep calls that were interrupted.
*/
async wakeUp(options?: StopSleepOptions): Promise<StopSleepResult> {
return wakeUpRun(await this.worldPromise, this.runId, options);
'use step';
return wakeUpRun(await this.#lazyWorldPromise, this.runId, options);
}

/**
* Cancels the workflow run.
*/
async cancel(): Promise<void> {
const world = await this.worldPromise;
'use step';
const world = await this.#lazyWorldPromise;
await world.events.create(this.runId, {
eventType: 'run_cancelled',
specVersion: SPEC_VERSION_CURRENT,
Expand All@@ -146,7 +163,8 @@ export class Run<TResult> {
* Whether the workflow run exists.
*/
get exists(): Promise<boolean> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs
.get(this.runId, { resolveData: 'none' })
.then(() => true)
Expand All@@ -163,7 +181,8 @@ export class Run<TResult> {
* The status of the workflow run.
*/
get status(): Promise<WorkflowRunStatus> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.status)
);
}
Expand All@@ -173,14 +192,16 @@ export class Run<TResult> {
* Polls the workflow return value until it is completed.
*/
get returnValue(): Promise<TResult> {
return this.pollReturnValue();
'use step';
return this.#pollReturnValue();
}

/**
* The name of the workflow.
*/
get workflowName(): Promise<string> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.workflowName)
);
}
Expand All@@ -189,7 +210,8 @@ export class Run<TResult> {
* The timestamp when the workflow run was created.
*/
get createdAt(): Promise<Date> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.createdAt)
);
}
Expand All@@ -199,7 +221,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not started yet.
*/
get startedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.startedAt)
);
}
Expand All@@ -209,7 +232,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not completed yet.
*/
get completedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.completedAt)
);
}
Expand All@@ -236,11 +260,12 @@ export class Run<TResult> {
getReadable<R = any>(
options: WorkflowReadableStreamOptions = {}
): WorkflowReadableStream<R> {
'use step';
Comment thread
TooTallNate marked this conversation as resolved.
const { ops = [], global = globalThis, startIndex, namespace } = options;
const name = getWorkflowRunStreamId(this.runId, namespace);
// Pass the key as a promise — it will be resolved lazily inside
// the first async transform() call of the deserialize stream.
const encryptionKey = this.getEncryptionKey();
const encryptionKey = this.#getEncryptionKey();
const stream = getExternalRevivers(
global,
ops,
Expand All@@ -251,7 +276,7 @@ export class Run<TResult> {
startIndex,
}) as ReadableStream<R>;

const worldPromise = this.worldPromise;
const worldPromise = this.#lazyWorldPromise;
const runId = this.runId;
return Object.assign(stream, {
getTailIndex: async (): Promise<number> => {
Expand All@@ -267,24 +292,24 @@ export class Run<TResult> {
* @internal
* @returns The workflow return value.
*/
private async pollReturnValue(): Promise<TResult> {
const world = await this.worldPromise;
async #pollReturnValue(): Promise<TResult> {
const world = await this.#lazyWorldPromise;

// When resilientStart is true, run_created failed and the run may
// not exist yet. Retry on WorkflowRunNotFoundError up to 3 times
// (1s + 3s + 6s = 10s total) to give the queue time to deliver
// and the runtime to create the run via run_started.
// When resilientStart is false, 404 is a real error — fail fast.
let notFoundRetries = 0;
const NOT_FOUND_MAX_RETRIES = this.resilientStart ? 3 : 0;
const NOT_FOUND_MAX_RETRIES = this.#resilientStart ? 3 : 0;
const NOT_FOUND_DELAYS = [1_000, 3_000, 6_000];

while (true) {
try {
const run = await world.runs.get(this.runId);

if (run.status === 'completed') {
const encryptionKey = await this.getEncryptionKey();
const encryptionKey = await this.#getEncryptionKey();
return await hydrateWorkflowReturnValue(
run.output,
this.runId,
Expand Down
53 changes: 51 additions & 2 deletions packages/core/src/runtime/runs.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
import {
EntityConflictError,
WorkflowWorldError,
WorkflowRunNotFoundError,
WorkflowWorldError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import type { Event, World } from '@workflow/world';
import { afterEach, describe, expect, it, vi } from 'vitest';

// Mock version module to avoid missing generated file
vi.mock('../version.js', () => ({ version: '0.0.0-test' }));

import { wakeUpRun } from './runs.js';
import { registerSerializationClass } from '../class-serialization.js';
import {
dehydrateStepReturnValue,
hydrateStepReturnValue,
} from '../serialization.js';
import { Run } from './run.js';
import { wakeUpRun } from './runs.js';
import { setWorld } from './world.js';

function createMockWorld(
Expand DownExpand Up@@ -225,3 +231,46 @@ describe('Run.wakeUp', () => {
expect(world.queue).not.toHaveBeenCalled();
});
});

describe('Run custom serialization', () => {
// In production builds, the SWC plugin auto-registers the class via an
// inline IIFE. In tests (no SWC), we register manually.
registerSerializationClass('Run', Run);

afterEach(() => {
setWorld(undefined as unknown as World);
});

it('should expose WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE methods', () => {
const run = new Run('wrun_serialize');
const serialized = Run[WORKFLOW_SERIALIZE](run);
const deserialized = Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});

expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
Comment on lines +246 to +256

CopilotAIApr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new serialization unit test only asserts resilientStart: false. Since resilientStart is now part of the serialized payload (and affects returnValue retry behavior), add a case that serializes/deserializes a Run created with resilientStart: true and asserts it roundtrips as true to prevent regressions.

Suggested change
constserialized=Run[WORKFLOW_SERIALIZE](run);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
constserialized=Run[WORKFLOW_SERIALIZE](run);
constresilientRun=newRun('wrun_serialize_resilient',{
resilientStart: true,
});
constresilientSerialized=Run[WORKFLOW_SERIALIZE](resilientRun);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
constresilientDeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize_resilient',
resilientStart: true,
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(resilientSerialized).toEqual({
runId: 'wrun_serialize_resilient',
resilientStart: true,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
expect(deserialized.resilientStart).toBe(false);
expect(resilientDeserialized).toBeInstanceOf(Run);
expect(resilientDeserialized.runId).toBe('wrun_deserialize_resilient');
expect(resilientDeserialized.resilientStart).toBe(true);

Copilot uses AI. Check for mistakes.
});

it('should roundtrip through step serialization boundary', async () => {
const run = new Run('wrun_roundtrip');
const dehydrated = await dehydrateStepReturnValue(
run,
'wrun_parent',
undefined
);

const hydrated = await hydrateStepReturnValue(
dehydrated,
'wrun_parent',
undefined
);

expect(hydrated).toBeInstanceOf(Run);
expect((hydrated as Run<unknown>).runId).toBe('wrun_roundtrip');
});
});
7 changes: 2 additions & 5 deletions packages/workflow/src/api-workflow.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,14 @@ export type {
WorkflowRun,
} from '@workflow/core/runtime';

export { Run } from '@workflow/core/runtime/run';

Comment thread
TooTallNate marked this conversation as resolved.
const workflowStub = (item: string) => {
throw new Error(
`The workflow environment doesn't allow this runtime usage of ${item}. Move this call to a step function ("use step") or call it outside the workflow context.`
);
};

export class Run {
constructor() {
workflowStub('Run');
}
}
export const getRun = () => workflowStub('getRun');
export const getHookByToken = () => workflowStub('getHookByToken');
export const resumeHook = () => workflowStub('resumeHook');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: serialize Run across runtime and workflow VM by TooTallNate · Pull Request #1616 · vercel/workflow · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/neat-runs-serialize.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/core": minor
"workflow": minor
---

Use custom class serialization for `Run` across runtime and workflow VM contexts, and add e2e coverage for `Run` instance boundary roundtrips
39 changes: 39 additions & 0 deletions packages/core/e2e/e2e.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1528,6 +1528,45 @@ describe('e2e', () => {
}
);

test(
'runClassSerializationWorkflow - Run instances serialize across workflow/step boundaries',
{ timeout: 120_000 },
async () => {
const inputValue = 21;
const run = await start(await e2e('runClassSerializationWorkflow'), [
inputValue,
]);
const returnValue = await run.returnValue;

expect(returnValue).toHaveProperty('isRunInWorkflow', true);
expect(returnValue).toHaveProperty('childRunId');
expect(returnValue).toHaveProperty('runIdFromStep');
expect(returnValue).toHaveProperty('childResult');

expect(typeof returnValue.childRunId).toBe('string');
expect(returnValue.childRunId.startsWith('wrun_')).toBe(true);
expect(returnValue.runIdFromStep).toBe(returnValue.childRunId);
expect(returnValue.childResult).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});

const { json: parentRunData } = await cliInspectJson(
`runs ${run.runId} --withData`
);
expect(parentRunData.status).toBe('completed');

const { json: childRunData } = await cliInspectJson(
`runs ${returnValue.childRunId} --withData`
);
expect(childRunData.status).toBe('completed');
expect(childRunData.output).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});
}
);

// Skipped for Vercel since VQS doesn't support direct HTTP calls
test.skipIf(!isLocalDeployment())(
'health check endpoint (HTTP) - workflow and step endpoints respond to __health query parameter',
Expand Down
4 changes: 4 additions & 0 deletions packages/core/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,10 @@
"types": "./dist/runtime.d.ts",
"default": "./dist/runtime.js"
},
"./runtime/run": {
Comment thread
VaguelySerious marked this conversation as resolved.
"types": "./dist/runtime/run.d.ts",
Comment thread
TooTallNate marked this conversation as resolved.
"default": "./dist/runtime/run.js"
},
"./runtime/start": {
"types": "./dist/runtime/start.d.ts",
"default": "./dist/runtime/start.js"
Expand Down
75 changes: 50 additions & 25 deletions packages/core/src/runtime/run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {
WorkflowRunNotCompletedError,
WorkflowRunNotFoundError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import {
SPEC_VERSION_CURRENT,
type WorkflowRunStatus,
Expand DownExpand Up@@ -69,6 +70,17 @@ export interface WorkflowReadableStreamOptions {
* A handler class for a workflow run.
*/
export class Run<TResult> {
static [WORKFLOW_SERIALIZE](instance: Run<unknown>) {
return { runId: instance.runId, resilientStart: instance.#resilientStart };
}

static [WORKFLOW_DESERIALIZE](data: {
runId: string;
resilientStart?: boolean;
}) {
return new Run(data.runId, { resilientStart: data.resilientStart });
}

/**
* The ID of the workflow run.
*/
Expand All@@ -78,14 +90,18 @@ export class Run<TResult> {
* The world object.
* @internal
*/
private worldPromise: Promise<World>;
#worldPromise: Promise<World> | undefined;
get #lazyWorldPromise() {
if (!this.#worldPromise) this.#worldPromise = getWorld();
return this.#worldPromise;
}

/**
* Cached encryption key resolution. Resolved once on first use and
* reused for returnValue, getReadable(), etc.
* @internal
*/
private encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;
#encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;

/**
* When true, run_created failed and the run may not exist yet (the
Expand All@@ -94,12 +110,11 @@ export class Run<TResult> {
* that normal runs fail fast on 404.
* @internal
*/
private resilientStart = false;
#resilientStart = false;

constructor(runId: string, opts?: { resilientStart?: boolean }) {
this.runId = runId;
this.worldPromise = getWorld();
this.resilientStart = opts?.resilientStart ?? false;
this.#resilientStart = opts?.resilientStart ?? false;
}

/**
Expand All@@ -108,16 +123,16 @@ export class Run<TResult> {
* to be resolved once.
* @internal
*/
private getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.encryptionKeyPromise) {
this.encryptionKeyPromise = (async () => {
const world = await this.worldPromise;
#getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.#encryptionKeyPromise) {
this.#encryptionKeyPromise = (async () => {
const world = await this.#lazyWorldPromise;
const run = await world.runs.get(this.runId);
const rawKey = await world.getEncryptionKeyForRun?.(run);
return rawKey ? await importKey(rawKey) : undefined;
})();
}
return this.encryptionKeyPromise;
return this.#encryptionKeyPromise;
}

/**
Expand All@@ -128,14 +143,16 @@ export class Run<TResult> {
* @returns A {@link StopSleepResult} object containing the number of sleep calls that were interrupted.
*/
async wakeUp(options?: StopSleepOptions): Promise<StopSleepResult> {
return wakeUpRun(await this.worldPromise, this.runId, options);
'use step';
return wakeUpRun(await this.#lazyWorldPromise, this.runId, options);
}

/**
* Cancels the workflow run.
*/
async cancel(): Promise<void> {
const world = await this.worldPromise;
'use step';
const world = await this.#lazyWorldPromise;
await world.events.create(this.runId, {
eventType: 'run_cancelled',
specVersion: SPEC_VERSION_CURRENT,
Expand All@@ -146,7 +163,8 @@ export class Run<TResult> {
* Whether the workflow run exists.
*/
get exists(): Promise<boolean> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs
.get(this.runId, { resolveData: 'none' })
.then(() => true)
Expand All@@ -163,7 +181,8 @@ export class Run<TResult> {
* The status of the workflow run.
*/
get status(): Promise<WorkflowRunStatus> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.status)
);
}
Expand All@@ -173,14 +192,16 @@ export class Run<TResult> {
* Polls the workflow return value until it is completed.
*/
get returnValue(): Promise<TResult> {
return this.pollReturnValue();
'use step';
return this.#pollReturnValue();
}

/**
* The name of the workflow.
*/
get workflowName(): Promise<string> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.workflowName)
);
}
Expand All@@ -189,7 +210,8 @@ export class Run<TResult> {
* The timestamp when the workflow run was created.
*/
get createdAt(): Promise<Date> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.createdAt)
);
}
Expand All@@ -199,7 +221,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not started yet.
*/
get startedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.startedAt)
);
}
Expand All@@ -209,7 +232,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not completed yet.
*/
get completedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.completedAt)
);
}
Expand All@@ -236,11 +260,12 @@ export class Run<TResult> {
getReadable<R = any>(
options: WorkflowReadableStreamOptions = {}
): WorkflowReadableStream<R> {
'use step';
Comment thread
TooTallNate marked this conversation as resolved.
const { ops = [], global = globalThis, startIndex, namespace } = options;
const name = getWorkflowRunStreamId(this.runId, namespace);
// Pass the key as a promise — it will be resolved lazily inside
// the first async transform() call of the deserialize stream.
const encryptionKey = this.getEncryptionKey();
const encryptionKey = this.#getEncryptionKey();
const stream = getExternalRevivers(
global,
ops,
Expand All@@ -251,7 +276,7 @@ export class Run<TResult> {
startIndex,
}) as ReadableStream<R>;

const worldPromise = this.worldPromise;
const worldPromise = this.#lazyWorldPromise;
const runId = this.runId;
return Object.assign(stream, {
getTailIndex: async (): Promise<number> => {
Expand All@@ -267,24 +292,24 @@ export class Run<TResult> {
* @internal
* @returns The workflow return value.
*/
private async pollReturnValue(): Promise<TResult> {
const world = await this.worldPromise;
async #pollReturnValue(): Promise<TResult> {
const world = await this.#lazyWorldPromise;

// When resilientStart is true, run_created failed and the run may
// not exist yet. Retry on WorkflowRunNotFoundError up to 3 times
// (1s + 3s + 6s = 10s total) to give the queue time to deliver
// and the runtime to create the run via run_started.
// When resilientStart is false, 404 is a real error — fail fast.
let notFoundRetries = 0;
const NOT_FOUND_MAX_RETRIES = this.resilientStart ? 3 : 0;
const NOT_FOUND_MAX_RETRIES = this.#resilientStart ? 3 : 0;
const NOT_FOUND_DELAYS = [1_000, 3_000, 6_000];

while (true) {
try {
const run = await world.runs.get(this.runId);

if (run.status === 'completed') {
const encryptionKey = await this.getEncryptionKey();
const encryptionKey = await this.#getEncryptionKey();
return await hydrateWorkflowReturnValue(
run.output,
this.runId,
Expand Down
53 changes: 51 additions & 2 deletions packages/core/src/runtime/runs.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
import {
EntityConflictError,
WorkflowWorldError,
WorkflowRunNotFoundError,
WorkflowWorldError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import type { Event, World } from '@workflow/world';
import { afterEach, describe, expect, it, vi } from 'vitest';

// Mock version module to avoid missing generated file
vi.mock('../version.js', () => ({ version: '0.0.0-test' }));

import { wakeUpRun } from './runs.js';
import { registerSerializationClass } from '../class-serialization.js';
import {
dehydrateStepReturnValue,
hydrateStepReturnValue,
} from '../serialization.js';
import { Run } from './run.js';
import { wakeUpRun } from './runs.js';
import { setWorld } from './world.js';

function createMockWorld(
Expand DownExpand Up@@ -225,3 +231,46 @@ describe('Run.wakeUp', () => {
expect(world.queue).not.toHaveBeenCalled();
});
});

describe('Run custom serialization', () => {
// In production builds, the SWC plugin auto-registers the class via an
// inline IIFE. In tests (no SWC), we register manually.
registerSerializationClass('Run', Run);

afterEach(() => {
setWorld(undefined as unknown as World);
});

it('should expose WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE methods', () => {
const run = new Run('wrun_serialize');
const serialized = Run[WORKFLOW_SERIALIZE](run);
const deserialized = Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});

expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
Comment on lines +246 to +256

CopilotAIApr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new serialization unit test only asserts resilientStart: false. Since resilientStart is now part of the serialized payload (and affects returnValue retry behavior), add a case that serializes/deserializes a Run created with resilientStart: true and asserts it roundtrips as true to prevent regressions.

Suggested change
constserialized=Run[WORKFLOW_SERIALIZE](run);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
constserialized=Run[WORKFLOW_SERIALIZE](run);
constresilientRun=newRun('wrun_serialize_resilient',{
resilientStart: true,
});
constresilientSerialized=Run[WORKFLOW_SERIALIZE](resilientRun);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
constresilientDeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize_resilient',
resilientStart: true,
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(resilientSerialized).toEqual({
runId: 'wrun_serialize_resilient',
resilientStart: true,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
expect(deserialized.resilientStart).toBe(false);
expect(resilientDeserialized).toBeInstanceOf(Run);
expect(resilientDeserialized.runId).toBe('wrun_deserialize_resilient');
expect(resilientDeserialized.resilientStart).toBe(true);

Copilot uses AI. Check for mistakes.
});

it('should roundtrip through step serialization boundary', async () => {
const run = new Run('wrun_roundtrip');
const dehydrated = await dehydrateStepReturnValue(
run,
'wrun_parent',
undefined
);

const hydrated = await hydrateStepReturnValue(
dehydrated,
'wrun_parent',
undefined
);

expect(hydrated).toBeInstanceOf(Run);
expect((hydrated as Run<unknown>).runId).toBe('wrun_roundtrip');
});
});
7 changes: 2 additions & 5 deletions packages/workflow/src/api-workflow.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,14 @@ export type {
WorkflowRun,
} from '@workflow/core/runtime';

export { Run } from '@workflow/core/runtime/run';

Comment thread
TooTallNate marked this conversation as resolved.
const workflowStub = (item: string) => {
throw new Error(
`The workflow environment doesn't allow this runtime usage of ${item}. Move this call to a step function ("use step") or call it outside the workflow context.`
);
};

export class Run {
constructor() {
workflowStub('Run');
}
}
export const getRun = () => workflowStub('getRun');
export const getHookByToken = () => workflowStub('getHookByToken');
export const resumeHook = () => workflowStub('resumeHook');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: serialize Run across runtime and workflow VM by TooTallNate · Pull Request #1616 · vercel/workflow · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/neat-runs-serialize.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/core": minor
"workflow": minor
---

Use custom class serialization for `Run` across runtime and workflow VM contexts, and add e2e coverage for `Run` instance boundary roundtrips
39 changes: 39 additions & 0 deletions packages/core/e2e/e2e.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1528,6 +1528,45 @@ describe('e2e', () => {
}
);

test(
'runClassSerializationWorkflow - Run instances serialize across workflow/step boundaries',
{ timeout: 120_000 },
async () => {
const inputValue = 21;
const run = await start(await e2e('runClassSerializationWorkflow'), [
inputValue,
]);
const returnValue = await run.returnValue;

expect(returnValue).toHaveProperty('isRunInWorkflow', true);
expect(returnValue).toHaveProperty('childRunId');
expect(returnValue).toHaveProperty('runIdFromStep');
expect(returnValue).toHaveProperty('childResult');

expect(typeof returnValue.childRunId).toBe('string');
expect(returnValue.childRunId.startsWith('wrun_')).toBe(true);
expect(returnValue.runIdFromStep).toBe(returnValue.childRunId);
expect(returnValue.childResult).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});

const { json: parentRunData } = await cliInspectJson(
`runs ${run.runId} --withData`
);
expect(parentRunData.status).toBe('completed');

const { json: childRunData } = await cliInspectJson(
`runs ${returnValue.childRunId} --withData`
);
expect(childRunData.status).toBe('completed');
expect(childRunData.output).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});
}
);

// Skipped for Vercel since VQS doesn't support direct HTTP calls
test.skipIf(!isLocalDeployment())(
'health check endpoint (HTTP) - workflow and step endpoints respond to __health query parameter',
Expand Down
4 changes: 4 additions & 0 deletions packages/core/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,10 @@
"types": "./dist/runtime.d.ts",
"default": "./dist/runtime.js"
},
"./runtime/run": {
Comment thread
VaguelySerious marked this conversation as resolved.
"types": "./dist/runtime/run.d.ts",
Comment thread
TooTallNate marked this conversation as resolved.
"default": "./dist/runtime/run.js"
},
"./runtime/start": {
"types": "./dist/runtime/start.d.ts",
"default": "./dist/runtime/start.js"
Expand Down
75 changes: 50 additions & 25 deletions packages/core/src/runtime/run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {
WorkflowRunNotCompletedError,
WorkflowRunNotFoundError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import {
SPEC_VERSION_CURRENT,
type WorkflowRunStatus,
Expand DownExpand Up@@ -69,6 +70,17 @@ export interface WorkflowReadableStreamOptions {
* A handler class for a workflow run.
*/
export class Run<TResult> {
static [WORKFLOW_SERIALIZE](instance: Run<unknown>) {
return { runId: instance.runId, resilientStart: instance.#resilientStart };
}

static [WORKFLOW_DESERIALIZE](data: {
runId: string;
resilientStart?: boolean;
}) {
return new Run(data.runId, { resilientStart: data.resilientStart });
}

/**
* The ID of the workflow run.
*/
Expand All@@ -78,14 +90,18 @@ export class Run<TResult> {
* The world object.
* @internal
*/
private worldPromise: Promise<World>;
#worldPromise: Promise<World> | undefined;
get #lazyWorldPromise() {
if (!this.#worldPromise) this.#worldPromise = getWorld();
return this.#worldPromise;
}

/**
* Cached encryption key resolution. Resolved once on first use and
* reused for returnValue, getReadable(), etc.
* @internal
*/
private encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;
#encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;

/**
* When true, run_created failed and the run may not exist yet (the
Expand All@@ -94,12 +110,11 @@ export class Run<TResult> {
* that normal runs fail fast on 404.
* @internal
*/
private resilientStart = false;
#resilientStart = false;

constructor(runId: string, opts?: { resilientStart?: boolean }) {
this.runId = runId;
this.worldPromise = getWorld();
this.resilientStart = opts?.resilientStart ?? false;
this.#resilientStart = opts?.resilientStart ?? false;
}

/**
Expand All@@ -108,16 +123,16 @@ export class Run<TResult> {
* to be resolved once.
* @internal
*/
private getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.encryptionKeyPromise) {
this.encryptionKeyPromise = (async () => {
const world = await this.worldPromise;
#getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.#encryptionKeyPromise) {
this.#encryptionKeyPromise = (async () => {
const world = await this.#lazyWorldPromise;
const run = await world.runs.get(this.runId);
const rawKey = await world.getEncryptionKeyForRun?.(run);
return rawKey ? await importKey(rawKey) : undefined;
})();
}
return this.encryptionKeyPromise;
return this.#encryptionKeyPromise;
}

/**
Expand All@@ -128,14 +143,16 @@ export class Run<TResult> {
* @returns A {@link StopSleepResult} object containing the number of sleep calls that were interrupted.
*/
async wakeUp(options?: StopSleepOptions): Promise<StopSleepResult> {
return wakeUpRun(await this.worldPromise, this.runId, options);
'use step';
return wakeUpRun(await this.#lazyWorldPromise, this.runId, options);
}

/**
* Cancels the workflow run.
*/
async cancel(): Promise<void> {
const world = await this.worldPromise;
'use step';
const world = await this.#lazyWorldPromise;
await world.events.create(this.runId, {
eventType: 'run_cancelled',
specVersion: SPEC_VERSION_CURRENT,
Expand All@@ -146,7 +163,8 @@ export class Run<TResult> {
* Whether the workflow run exists.
*/
get exists(): Promise<boolean> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs
.get(this.runId, { resolveData: 'none' })
.then(() => true)
Expand All@@ -163,7 +181,8 @@ export class Run<TResult> {
* The status of the workflow run.
*/
get status(): Promise<WorkflowRunStatus> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.status)
);
}
Expand All@@ -173,14 +192,16 @@ export class Run<TResult> {
* Polls the workflow return value until it is completed.
*/
get returnValue(): Promise<TResult> {
return this.pollReturnValue();
'use step';
return this.#pollReturnValue();
}

/**
* The name of the workflow.
*/
get workflowName(): Promise<string> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.workflowName)
);
}
Expand All@@ -189,7 +210,8 @@ export class Run<TResult> {
* The timestamp when the workflow run was created.
*/
get createdAt(): Promise<Date> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.createdAt)
);
}
Expand All@@ -199,7 +221,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not started yet.
*/
get startedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.startedAt)
);
}
Expand All@@ -209,7 +232,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not completed yet.
*/
get completedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.completedAt)
);
}
Expand All@@ -236,11 +260,12 @@ export class Run<TResult> {
getReadable<R = any>(
options: WorkflowReadableStreamOptions = {}
): WorkflowReadableStream<R> {
'use step';
Comment thread
TooTallNate marked this conversation as resolved.
const { ops = [], global = globalThis, startIndex, namespace } = options;
const name = getWorkflowRunStreamId(this.runId, namespace);
// Pass the key as a promise — it will be resolved lazily inside
// the first async transform() call of the deserialize stream.
const encryptionKey = this.getEncryptionKey();
const encryptionKey = this.#getEncryptionKey();
const stream = getExternalRevivers(
global,
ops,
Expand All@@ -251,7 +276,7 @@ export class Run<TResult> {
startIndex,
}) as ReadableStream<R>;

const worldPromise = this.worldPromise;
const worldPromise = this.#lazyWorldPromise;
const runId = this.runId;
return Object.assign(stream, {
getTailIndex: async (): Promise<number> => {
Expand All@@ -267,24 +292,24 @@ export class Run<TResult> {
* @internal
* @returns The workflow return value.
*/
private async pollReturnValue(): Promise<TResult> {
const world = await this.worldPromise;
async #pollReturnValue(): Promise<TResult> {
const world = await this.#lazyWorldPromise;

// When resilientStart is true, run_created failed and the run may
// not exist yet. Retry on WorkflowRunNotFoundError up to 3 times
// (1s + 3s + 6s = 10s total) to give the queue time to deliver
// and the runtime to create the run via run_started.
// When resilientStart is false, 404 is a real error — fail fast.
let notFoundRetries = 0;
const NOT_FOUND_MAX_RETRIES = this.resilientStart ? 3 : 0;
const NOT_FOUND_MAX_RETRIES = this.#resilientStart ? 3 : 0;
const NOT_FOUND_DELAYS = [1_000, 3_000, 6_000];

while (true) {
try {
const run = await world.runs.get(this.runId);

if (run.status === 'completed') {
const encryptionKey = await this.getEncryptionKey();
const encryptionKey = await this.#getEncryptionKey();
return await hydrateWorkflowReturnValue(
run.output,
this.runId,
Expand Down
53 changes: 51 additions & 2 deletions packages/core/src/runtime/runs.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
import {
EntityConflictError,
WorkflowWorldError,
WorkflowRunNotFoundError,
WorkflowWorldError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import type { Event, World } from '@workflow/world';
import { afterEach, describe, expect, it, vi } from 'vitest';

// Mock version module to avoid missing generated file
vi.mock('../version.js', () => ({ version: '0.0.0-test' }));

import { wakeUpRun } from './runs.js';
import { registerSerializationClass } from '../class-serialization.js';
import {
dehydrateStepReturnValue,
hydrateStepReturnValue,
} from '../serialization.js';
import { Run } from './run.js';
import { wakeUpRun } from './runs.js';
import { setWorld } from './world.js';

function createMockWorld(
Expand DownExpand Up@@ -225,3 +231,46 @@ describe('Run.wakeUp', () => {
expect(world.queue).not.toHaveBeenCalled();
});
});

describe('Run custom serialization', () => {
// In production builds, the SWC plugin auto-registers the class via an
// inline IIFE. In tests (no SWC), we register manually.
registerSerializationClass('Run', Run);

afterEach(() => {
setWorld(undefined as unknown as World);
});

it('should expose WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE methods', () => {
const run = new Run('wrun_serialize');
const serialized = Run[WORKFLOW_SERIALIZE](run);
const deserialized = Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});

expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
Comment on lines +246 to +256

CopilotAIApr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new serialization unit test only asserts resilientStart: false. Since resilientStart is now part of the serialized payload (and affects returnValue retry behavior), add a case that serializes/deserializes a Run created with resilientStart: true and asserts it roundtrips as true to prevent regressions.

Suggested change
constserialized=Run[WORKFLOW_SERIALIZE](run);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
constserialized=Run[WORKFLOW_SERIALIZE](run);
constresilientRun=newRun('wrun_serialize_resilient',{
resilientStart: true,
});
constresilientSerialized=Run[WORKFLOW_SERIALIZE](resilientRun);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
constresilientDeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize_resilient',
resilientStart: true,
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(resilientSerialized).toEqual({
runId: 'wrun_serialize_resilient',
resilientStart: true,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
expect(deserialized.resilientStart).toBe(false);
expect(resilientDeserialized).toBeInstanceOf(Run);
expect(resilientDeserialized.runId).toBe('wrun_deserialize_resilient');
expect(resilientDeserialized.resilientStart).toBe(true);

Copilot uses AI. Check for mistakes.
});

it('should roundtrip through step serialization boundary', async () => {
const run = new Run('wrun_roundtrip');
const dehydrated = await dehydrateStepReturnValue(
run,
'wrun_parent',
undefined
);

const hydrated = await hydrateStepReturnValue(
dehydrated,
'wrun_parent',
undefined
);

expect(hydrated).toBeInstanceOf(Run);
expect((hydrated as Run<unknown>).runId).toBe('wrun_roundtrip');
});
});
7 changes: 2 additions & 5 deletions packages/workflow/src/api-workflow.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,14 @@ export type {
WorkflowRun,
} from '@workflow/core/runtime';

export { Run } from '@workflow/core/runtime/run';

Comment thread
TooTallNate marked this conversation as resolved.
const workflowStub = (item: string) => {
throw new Error(
`The workflow environment doesn't allow this runtime usage of ${item}. Move this call to a step function ("use step") or call it outside the workflow context.`
);
};

export class Run {
constructor() {
workflowStub('Run');
}
}
export const getRun = () => workflowStub('getRun');
export const getHookByToken = () => workflowStub('getHookByToken');
export const resumeHook = () => workflowStub('resumeHook');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix: serialize Run across runtime and workflow VM by TooTallNate · Pull Request #1616 · vercel/workflow · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/neat-runs-serialize.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
---
"@workflow/core": minor
"workflow": minor
---

Use custom class serialization for `Run` across runtime and workflow VM contexts, and add e2e coverage for `Run` instance boundary roundtrips
39 changes: 39 additions & 0 deletions packages/core/e2e/e2e.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1528,6 +1528,45 @@ describe('e2e', () => {
}
);

test(
'runClassSerializationWorkflow - Run instances serialize across workflow/step boundaries',
{ timeout: 120_000 },
async () => {
const inputValue = 21;
const run = await start(await e2e('runClassSerializationWorkflow'), [
inputValue,
]);
const returnValue = await run.returnValue;

expect(returnValue).toHaveProperty('isRunInWorkflow', true);
expect(returnValue).toHaveProperty('childRunId');
expect(returnValue).toHaveProperty('runIdFromStep');
expect(returnValue).toHaveProperty('childResult');

expect(typeof returnValue.childRunId).toBe('string');
expect(returnValue.childRunId.startsWith('wrun_')).toBe(true);
expect(returnValue.runIdFromStep).toBe(returnValue.childRunId);
expect(returnValue.childResult).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});

const { json: parentRunData } = await cliInspectJson(
`runs ${run.runId} --withData`
);
expect(parentRunData.status).toBe('completed');

const { json: childRunData } = await cliInspectJson(
`runs ${returnValue.childRunId} --withData`
);
expect(childRunData.status).toBe('completed');
expect(childRunData.output).toEqual({
childResult: inputValue * 2,
originalValue: inputValue,
});
}
);

// Skipped for Vercel since VQS doesn't support direct HTTP calls
test.skipIf(!isLocalDeployment())(
'health check endpoint (HTTP) - workflow and step endpoints respond to __health query parameter',
Expand Down
4 changes: 4 additions & 0 deletions packages/core/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,10 @@
"types": "./dist/runtime.d.ts",
"default": "./dist/runtime.js"
},
"./runtime/run": {
Comment thread
VaguelySerious marked this conversation as resolved.
"types": "./dist/runtime/run.d.ts",
Comment thread
TooTallNate marked this conversation as resolved.
"default": "./dist/runtime/run.js"
},
"./runtime/start": {
"types": "./dist/runtime/start.d.ts",
"default": "./dist/runtime/start.js"
Expand Down
75 changes: 50 additions & 25 deletions packages/core/src/runtime/run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import {
WorkflowRunNotCompletedError,
WorkflowRunNotFoundError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import {
SPEC_VERSION_CURRENT,
type WorkflowRunStatus,
Expand DownExpand Up@@ -69,6 +70,17 @@ export interface WorkflowReadableStreamOptions {
* A handler class for a workflow run.
*/
export class Run<TResult> {
static [WORKFLOW_SERIALIZE](instance: Run<unknown>) {
return { runId: instance.runId, resilientStart: instance.#resilientStart };
}

static [WORKFLOW_DESERIALIZE](data: {
runId: string;
resilientStart?: boolean;
}) {
return new Run(data.runId, { resilientStart: data.resilientStart });
}

/**
* The ID of the workflow run.
*/
Expand All@@ -78,14 +90,18 @@ export class Run<TResult> {
* The world object.
* @internal
*/
private worldPromise: Promise<World>;
#worldPromise: Promise<World> | undefined;
get #lazyWorldPromise() {
if (!this.#worldPromise) this.#worldPromise = getWorld();
return this.#worldPromise;
}

/**
* Cached encryption key resolution. Resolved once on first use and
* reused for returnValue, getReadable(), etc.
* @internal
*/
private encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;
#encryptionKeyPromise: Promise<CryptoKey | undefined> | null = null;

/**
* When true, run_created failed and the run may not exist yet (the
Expand All@@ -94,12 +110,11 @@ export class Run<TResult> {
* that normal runs fail fast on 404.
* @internal
*/
private resilientStart = false;
#resilientStart = false;

constructor(runId: string, opts?: { resilientStart?: boolean }) {
this.runId = runId;
this.worldPromise = getWorld();
this.resilientStart = opts?.resilientStart ?? false;
this.#resilientStart = opts?.resilientStart ?? false;
}

/**
Expand All@@ -108,16 +123,16 @@ export class Run<TResult> {
* to be resolved once.
* @internal
*/
private getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.encryptionKeyPromise) {
this.encryptionKeyPromise = (async () => {
const world = await this.worldPromise;
#getEncryptionKey(): Promise<CryptoKey | undefined> {
if (!this.#encryptionKeyPromise) {
this.#encryptionKeyPromise = (async () => {
const world = await this.#lazyWorldPromise;
const run = await world.runs.get(this.runId);
const rawKey = await world.getEncryptionKeyForRun?.(run);
return rawKey ? await importKey(rawKey) : undefined;
})();
}
return this.encryptionKeyPromise;
return this.#encryptionKeyPromise;
}

/**
Expand All@@ -128,14 +143,16 @@ export class Run<TResult> {
* @returns A {@link StopSleepResult} object containing the number of sleep calls that were interrupted.
*/
async wakeUp(options?: StopSleepOptions): Promise<StopSleepResult> {
return wakeUpRun(await this.worldPromise, this.runId, options);
'use step';
return wakeUpRun(await this.#lazyWorldPromise, this.runId, options);
}

/**
* Cancels the workflow run.
*/
async cancel(): Promise<void> {
const world = await this.worldPromise;
'use step';
const world = await this.#lazyWorldPromise;
await world.events.create(this.runId, {
eventType: 'run_cancelled',
specVersion: SPEC_VERSION_CURRENT,
Expand All@@ -146,7 +163,8 @@ export class Run<TResult> {
* Whether the workflow run exists.
*/
get exists(): Promise<boolean> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs
.get(this.runId, { resolveData: 'none' })
.then(() => true)
Expand All@@ -163,7 +181,8 @@ export class Run<TResult> {
* The status of the workflow run.
*/
get status(): Promise<WorkflowRunStatus> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.status)
);
}
Expand All@@ -173,14 +192,16 @@ export class Run<TResult> {
* Polls the workflow return value until it is completed.
*/
get returnValue(): Promise<TResult> {
return this.pollReturnValue();
'use step';
return this.#pollReturnValue();
}

/**
* The name of the workflow.
*/
get workflowName(): Promise<string> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.workflowName)
);
}
Expand All@@ -189,7 +210,8 @@ export class Run<TResult> {
* The timestamp when the workflow run was created.
*/
get createdAt(): Promise<Date> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.createdAt)
);
}
Expand All@@ -199,7 +221,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not started yet.
*/
get startedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.startedAt)
);
}
Expand All@@ -209,7 +232,8 @@ export class Run<TResult> {
* Returns undefined if the workflow has not completed yet.
*/
get completedAt(): Promise<Date | undefined> {
return this.worldPromise.then((world) =>
'use step';
return this.#lazyWorldPromise.then((world) =>
world.runs.get(this.runId).then((run) => run.completedAt)
);
}
Expand All@@ -236,11 +260,12 @@ export class Run<TResult> {
getReadable<R = any>(
options: WorkflowReadableStreamOptions = {}
): WorkflowReadableStream<R> {
'use step';
Comment thread
TooTallNate marked this conversation as resolved.
const { ops = [], global = globalThis, startIndex, namespace } = options;
const name = getWorkflowRunStreamId(this.runId, namespace);
// Pass the key as a promise — it will be resolved lazily inside
// the first async transform() call of the deserialize stream.
const encryptionKey = this.getEncryptionKey();
const encryptionKey = this.#getEncryptionKey();
const stream = getExternalRevivers(
global,
ops,
Expand All@@ -251,7 +276,7 @@ export class Run<TResult> {
startIndex,
}) as ReadableStream<R>;

const worldPromise = this.worldPromise;
const worldPromise = this.#lazyWorldPromise;
const runId = this.runId;
return Object.assign(stream, {
getTailIndex: async (): Promise<number> => {
Expand All@@ -267,24 +292,24 @@ export class Run<TResult> {
* @internal
* @returns The workflow return value.
*/
private async pollReturnValue(): Promise<TResult> {
const world = await this.worldPromise;
async #pollReturnValue(): Promise<TResult> {
const world = await this.#lazyWorldPromise;

// When resilientStart is true, run_created failed and the run may
// not exist yet. Retry on WorkflowRunNotFoundError up to 3 times
// (1s + 3s + 6s = 10s total) to give the queue time to deliver
// and the runtime to create the run via run_started.
// When resilientStart is false, 404 is a real error — fail fast.
let notFoundRetries = 0;
const NOT_FOUND_MAX_RETRIES = this.resilientStart ? 3 : 0;
const NOT_FOUND_MAX_RETRIES = this.#resilientStart ? 3 : 0;
const NOT_FOUND_DELAYS = [1_000, 3_000, 6_000];

while (true) {
try {
const run = await world.runs.get(this.runId);

if (run.status === 'completed') {
const encryptionKey = await this.getEncryptionKey();
const encryptionKey = await this.#getEncryptionKey();
return await hydrateWorkflowReturnValue(
run.output,
this.runId,
Expand Down
53 changes: 51 additions & 2 deletions packages/core/src/runtime/runs.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
import {
EntityConflictError,
WorkflowWorldError,
WorkflowRunNotFoundError,
WorkflowWorldError,
} from '@workflow/errors';
import { WORKFLOW_DESERIALIZE, WORKFLOW_SERIALIZE } from '@workflow/serde';
import type { Event, World } from '@workflow/world';
import { afterEach, describe, expect, it, vi } from 'vitest';

// Mock version module to avoid missing generated file
vi.mock('../version.js', () => ({ version: '0.0.0-test' }));

import { wakeUpRun } from './runs.js';
import { registerSerializationClass } from '../class-serialization.js';
import {
dehydrateStepReturnValue,
hydrateStepReturnValue,
} from '../serialization.js';
import { Run } from './run.js';
import { wakeUpRun } from './runs.js';
import { setWorld } from './world.js';

function createMockWorld(
Expand DownExpand Up@@ -225,3 +231,46 @@ describe('Run.wakeUp', () => {
expect(world.queue).not.toHaveBeenCalled();
});
});

describe('Run custom serialization', () => {
// In production builds, the SWC plugin auto-registers the class via an
// inline IIFE. In tests (no SWC), we register manually.
registerSerializationClass('Run', Run);

afterEach(() => {
setWorld(undefined as unknown as World);
});

it('should expose WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE methods', () => {
const run = new Run('wrun_serialize');
const serialized = Run[WORKFLOW_SERIALIZE](run);
const deserialized = Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});

expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
Comment on lines +246 to +256

CopilotAIApr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new serialization unit test only asserts resilientStart: false. Since resilientStart is now part of the serialized payload (and affects returnValue retry behavior), add a case that serializes/deserializes a Run created with resilientStart: true and asserts it roundtrips as true to prevent regressions.

Suggested change
constserialized=Run[WORKFLOW_SERIALIZE](run);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
constserialized=Run[WORKFLOW_SERIALIZE](run);
constresilientRun=newRun('wrun_serialize_resilient',{
resilientStart: true,
});
constresilientSerialized=Run[WORKFLOW_SERIALIZE](resilientRun);
constdeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize',
});
constresilientDeserialized=Run[WORKFLOW_DESERIALIZE]({
runId: 'wrun_deserialize_resilient',
resilientStart: true,
});
expect(serialized).toEqual({
runId: 'wrun_serialize',
resilientStart: false,
});
expect(resilientSerialized).toEqual({
runId: 'wrun_serialize_resilient',
resilientStart: true,
});
expect(deserialized).toBeInstanceOf(Run);
expect(deserialized.runId).toBe('wrun_deserialize');
expect(deserialized.resilientStart).toBe(false);
expect(resilientDeserialized).toBeInstanceOf(Run);
expect(resilientDeserialized.runId).toBe('wrun_deserialize_resilient');
expect(resilientDeserialized.resilientStart).toBe(true);

Copilot uses AI. Check for mistakes.
});

it('should roundtrip through step serialization boundary', async () => {
const run = new Run('wrun_roundtrip');
const dehydrated = await dehydrateStepReturnValue(
run,
'wrun_parent',
undefined
);

const hydrated = await hydrateStepReturnValue(
dehydrated,
'wrun_parent',
undefined
);

expect(hydrated).toBeInstanceOf(Run);
expect((hydrated as Run<unknown>).runId).toBe('wrun_roundtrip');
});
});
7 changes: 2 additions & 5 deletions packages/workflow/src/api-workflow.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,14 @@ export type {
WorkflowRun,
} from '@workflow/core/runtime';

export { Run } from '@workflow/core/runtime/run';

Comment thread
TooTallNate marked this conversation as resolved.
const workflowStub = (item: string) => {
throw new Error(
`The workflow environment doesn't allow this runtime usage of ${item}. Move this call to a step function ("use step") or call it outside the workflow context.`
);
};

export class Run {
constructor() {
workflowStub('Run');
}
}
export const getRun = () => workflowStub('getRun');
export const getHookByToken = () => workflowStub('getHookByToken');
export const resumeHook = () => workflowStub('resumeHook');
Expand Down
Loading
Loading