test: enable step source-map assertions for vite local dev - #1862

Merged
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e
Apr 28, 2026
Merged

test: enable step source-map assertions for vite local dev#1862
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Vite local-dev e2e tests basic step error preserves message and stack trace and cross-file step error preserves message and function names in stack have been failing consistently since #1827 bumped workbench/vite from vite@^7.1.12 to vite@^7.3.2.
  • The newer vite preserves step bundle source maps in dev mode, so stack traces now point at original files (99_e2e.ts, helpers.ts). However, hasStepSourceMaps() in packages/core/e2e/utils.ts still hard-codes vite as having no step source maps in any local environment, so the assertion expect(stack).not.toContain('99_e2e.ts') fails.
  • Fix: drop the vite-specific block in hasStepSourceMaps() entirely. Vite local dev now falls through to the default return true, while vite local prod is still caught by the existing !DEV_TEST_CONFIG guard further down — so local-prod behavior is unchanged.

Why this took 6 days to surface

  1. The push for [workflow] Bump Vite #1827 had Local Dev tests skipped due to matrix selection at the time.
  2. The next push (Lock next@canary test version #1860) introduced a CI env-var bug that prevented Local Dev tests from running at all.
  3. ci: fix VERCEL_WORKFLOW_SERVER_* env var ternary on main #1859 (28dc089e) fixed the env-var bug, finally letting vite local dev run — and it surfaced this assertion failure.

Reference failing run: https://github.com/vercel/workflow/actions/runs/25067758534/job/73444472541

Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
CopilotAI review requested due to automatic review settings April 28, 2026 18:49
@vercel

vercelBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 072a4d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production9780671045
✅ 💻 Local Development10540861140
✅ 📦 Local Production10540861140
✅ 🐘 Local Postgres10540861140
✅ 🪟 Windows950095
✅ 📋 Other267018285
Total450203434845

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8807
✅ example8807
✅ express8807
✅ fastify8807
✅ hono8807
✅ nextjs-turbopack9302
✅ nextjs-webpack9302
✅ nitro8807
✅ nuxt8807
✅ sveltekit8807
✅ vite8807
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9500
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8906
✅ e2e-local-postgres-nest-stable8906
✅ e2e-local-prod-nest-stable8906

📋 View full workflow run

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.040s (-9.3% 🟢)1.005s (~)0.965s101.00x
💻 LocalNitro0.046s (+6.7% 🔺)1.005s (~)0.959s101.14x
🐘 PostgresNitro0.049s (-48.3% 🟢)1.011s (-3.1%)0.961s101.22x
💻 LocalNext.js (Turbopack)0.051s1.005s0.954s101.27x
🐘 PostgresExpress0.053s (-8.4% 🟢)1.012s (~)0.959s101.32x
🐘 PostgresNext.js (Turbopack)0.057s1.009s0.952s101.42x
workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.120s2.005s0.886s101.00x
💻 LocalExpress1.127s (~)2.005s (~)0.878s101.01x
🐘 PostgresNitro1.128s (-1.1%)2.008s (~)0.880s101.01x
💻 LocalNitro1.137s (+0.5%)2.006s (~)0.869s101.02x
🐘 PostgresExpress1.144s (~)2.010s (~)0.867s101.02x
🐘 PostgresNext.js (Turbopack)1.150s2.012s0.862s101.03x
workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro10.770s (-0.9%)11.023s (~)0.253s31.00x
🐘 PostgresExpress10.787s (-1.6%)11.025s (~)0.238s31.00x
💻 LocalNext.js (Turbopack)10.789s11.024s0.235s31.00x
🐘 PostgresNext.js (Turbopack)10.879s11.025s0.146s31.01x
💻 LocalExpress10.922s (~)11.023s (~)0.100s31.01x
💻 LocalNitro10.955s (~)11.024s (~)0.069s31.02x
workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express14.344s (-1.6%)15.034s (~)0.691s41.00x
🐘 PostgresNext.js (Turbopack)14.467s15.023s0.556s41.01x
💻 LocalNext.js (Turbopack)14.720s15.030s0.310s41.03x
🐘 PostgresNitro14.789s (+1.3%)15.529s (+3.3%)0.740s41.03x
💻 LocalExpress14.980s (~)15.029s (~)0.049s41.04x
💻 LocalNitro15.104s (~)16.033s (~)0.929s41.05x
workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express13.522s (-3.5%)14.029s (-3.9%)0.507s71.00x
🐘 PostgresNext.js (Turbopack)13.921s14.022s0.101s71.03x
🐘 PostgresNitro14.610s (+4.6%)15.355s (+7.3% 🔺)0.745s61.08x
💻 LocalNext.js (Turbopack)16.229s17.032s0.803s61.20x
💻 LocalExpress16.828s (+1.4%)17.198s (+1.0%)0.370s61.24x
💻 LocalNitro16.921s (+0.8%)17.032s (~)0.111s61.25x
Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.203s (-5.6% 🟢)2.010s (~)0.807s151.00x
🐘 PostgresNext.js (Turbopack)1.233s2.010s0.777s151.03x
🐘 PostgresExpress1.234s (-2.1%)2.011s (~)0.777s151.03x
💻 LocalNext.js (Turbopack)1.509s2.006s0.497s151.25x
💻 LocalExpress1.526s (+2.5%)2.006s (~)0.480s151.27x
💻 LocalNitro1.561s (-4.3%)2.006s (-3.3%)0.445s151.30x
Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.304s (-2.0%)3.026s (+0.6%)0.722s101.00x
🐘 PostgresExpress2.376s (+0.6%)3.011s (~)0.635s101.03x
🐘 PostgresNext.js (Turbopack)2.406s3.009s0.603s101.04x
💻 LocalNext.js (Turbopack)2.809s3.454s0.645s91.22x
💻 LocalNitro3.045s (-3.1%)3.453s (-11.1% 🟢)0.407s91.32x
💻 LocalExpress3.066s (+3.8%)3.885s (+12.5% 🔺)0.819s81.33x
Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.494s (~)4.014s (~)0.520s81.00x
🐘 PostgresNitro3.496s (~)4.026s (~)0.530s81.00x
🐘 PostgresNext.js (Turbopack)3.682s4.011s0.329s81.05x
💻 LocalNext.js (Turbopack)7.885s8.519s0.634s42.26x
💻 LocalExpress8.294s (-0.5%)9.022s (~)0.728s42.37x
💻 LocalNitro9.038s (+8.2% 🔺)9.522s (+5.6% 🔺)0.485s42.59x
Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.206s (-4.0%)2.007s (~)0.801s151.00x
🐘 PostgresNext.js (Turbopack)1.239s2.010s0.771s151.03x
🐘 PostgresExpress1.247s (-0.8%)2.010s (~)0.763s151.03x
💻 LocalNext.js (Turbopack)1.520s2.006s0.486s151.26x
💻 LocalNitro1.566s (-16.1% 🟢)2.006s (-14.3% 🟢)0.440s151.30x
💻 LocalExpress1.678s (-11.4% 🟢)2.222s (-6.0% 🟢)0.544s141.39x
Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.270s (-3.0%)3.007s (~)0.737s101.00x
🐘 PostgresExpress2.342s (~)3.009s (~)0.667s101.03x
🐘 PostgresNext.js (Turbopack)2.402s3.010s0.608s101.06x
💻 LocalNext.js (Turbopack)2.983s3.760s0.776s81.31x
💻 LocalNitro3.004s (-2.0%)3.760s (-3.3%)0.756s81.32x
💻 LocalExpress3.144s (~)4.010s (+6.6% 🔺)0.866s81.39x
Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.416s (-1.9%)4.008s (~)0.593s81.00x
🐘 PostgresExpress3.448s (-1.5%)4.011s (~)0.563s81.01x
🐘 PostgresNext.js (Turbopack)3.649s4.014s0.365s81.07x
💻 LocalNext.js (Turbopack)8.305s9.021s0.716s42.43x
💻 LocalExpress8.866s (+0.7%)9.273s (~)0.406s42.60x
💻 LocalNitro9.213s (+0.8%)9.772s (-2.5%)0.559s42.70x
workflow with 10 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.714s (-15.0% 🟢)1.007s (-1.6%)0.293s601.00x
🐘 PostgresNext.js (Turbopack)0.781s1.006s0.226s601.09x
💻 LocalNext.js (Turbopack)0.890s1.039s0.149s581.25x
🐘 PostgresNitro0.982s (+19.7% 🔺)1.346s (+33.7% 🔺)0.363s451.38x
💻 LocalNitro1.014s (+3.4%)1.720s (+57.2% 🔺)0.706s351.42x
💻 LocalExpress1.128s (+14.6% 🔺)1.570s (+45.9% 🔺)0.442s391.58x
workflow with 25 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.698s (-14.1% 🟢)2.009s (-11.0% 🟢)0.311s451.00x
🐘 PostgresNitro1.728s (-10.3% 🟢)2.100s (~)0.372s431.02x
🐘 PostgresNext.js (Turbopack)1.932s2.173s0.241s421.14x
💻 LocalNext.js (Turbopack)2.943s3.223s0.280s281.73x
💻 LocalExpress3.035s (+0.6%)3.586s (~)0.550s261.79x
💻 LocalNitro3.041s (~)3.843s (+2.3%)0.803s241.79x
workflow with 50 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.431s (-16.4% 🟢)4.108s (-10.8% 🟢)0.678s301.00x
🐘 PostgresExpress3.498s (-12.3% 🟢)4.012s (-8.2% 🟢)0.514s301.02x
🐘 PostgresNext.js (Turbopack)3.864s4.045s0.181s301.13x
💻 LocalNext.js (Turbopack)8.870s9.161s0.291s142.59x
💻 LocalNitro9.175s (-1.3%)9.787s (-2.3%)0.613s132.67x
💻 LocalExpress9.295s (+0.9%)9.941s (-0.8%)0.646s132.71x
workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.244s (-13.9% 🟢)1.007s (~)0.764s601.00x
🐘 PostgresNext.js (Turbopack)0.248s1.007s0.759s601.02x
🐘 PostgresExpress0.261s (-7.6% 🟢)1.008s (~)0.747s601.07x
💻 LocalExpress0.595s (+6.1% 🔺)1.005s (~)0.410s602.44x
💻 LocalNitro0.599s (-1.0%)1.005s (-1.6%)0.406s602.46x
💻 LocalNext.js (Turbopack)0.607s1.022s0.415s592.49x
workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.409s (-19.7% 🟢)1.007s (~)0.598s901.00x
🐘 PostgresNitro0.426s (-14.1% 🟢)1.009s (~)0.583s901.04x
🐘 PostgresNext.js (Turbopack)0.504s1.007s0.503s901.23x
💻 LocalNitro2.548s (~)3.009s (~)0.461s306.23x
💻 LocalNext.js (Turbopack)2.681s3.009s0.328s306.55x
💻 LocalExpress2.844s (+13.1% 🔺)3.472s (+15.4% 🔺)0.629s266.95x
workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.654s (-20.1% 🟢)1.016s (~)0.362s1191.00x
🐘 PostgresNitro0.657s (-16.8% 🟢)1.054s (+4.7%)0.397s1141.01x
🐘 PostgresNext.js (Turbopack)0.820s1.016s0.196s1191.25x
💻 LocalNitro11.257s (+0.6%)11.938s (+2.3%)0.681s1117.21x
💻 LocalNext.js (Turbopack)11.270s11.847s0.577s1117.23x
💻 LocalExpress12.606s (+12.7% 🔺)13.033s (+9.1% 🔺)0.426s1019.28x
Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.180s1.002s0.013s1.019s0.839s101.00x
🐘 PostgresNext.js (Turbopack)0.198s1.000s0.001s1.010s0.812s101.10x
💻 LocalExpress0.201s (+0.8%)1.005s (~)0.012s (-0.8%)1.018s (~)0.818s101.12x
💻 LocalNitro0.209s (-2.2%)1.004s (~)0.013s (+3.2%)1.019s (~)0.810s101.16x
🐘 PostgresExpress0.255s (+24.3% 🔺)1.000s (~)0.045s (+2712.5% 🔺)1.056s (+4.4%)0.801s101.42x
🐘 PostgresNitro0.330s (+60.9% 🔺)1.008s (+0.8%)0.124s (+8166.7% 🔺)1.159s (+14.6% 🔺)0.829s101.84x
stream pipeline with 5 transform steps (1MB)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.585s (-6.3% 🟢)1.040s (+3.3%)0.032s (+667.7% 🔺)1.083s (+5.9% 🔺)0.499s561.00x
🐘 PostgresExpress0.600s (-4.7%)1.008s (~)0.005s (+32.7% 🔺)1.025s (~)0.425s591.03x
🐘 PostgresNext.js (Turbopack)0.650s1.026s0.007s1.042s0.392s581.11x
💻 LocalNext.js (Turbopack)0.680s1.011s0.009s1.023s0.343s591.16x
💻 LocalExpress0.825s (+8.9% 🔺)1.013s (-1.5%)0.015s (+59.3% 🔺)1.030s (-0.9%)0.206s591.41x
💻 LocalNitro0.847s (+0.9%)1.012s (~)0.010s (+4.2%)1.116s (~)0.269s541.45x
10 parallel streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Next.js (Turbopack)0.965s1.250s0.000s1.264s0.299s481.00x
🐘 PostgresExpress1.015s (+5.6% 🔺)1.463s (+14.5% 🔺)0.000s (-43.9% 🟢)1.478s (+13.1% 🔺)0.463s411.05x
🐘 PostgresNitro1.144s (+18.1% 🔺)1.461s (+17.1% 🔺)0.000s (-41.5% 🟢)1.481s (+17.7% 🔺)0.336s411.19x
💻 LocalNitro1.252s (+2.4%)2.022s (~)0.000s (+266.7% 🔺)2.024s (~)0.772s301.30x
💻 LocalNext.js (Turbopack)1.309s2.020s0.000s2.023s0.714s301.36x
💻 LocalExpress1.374s (+12.2% 🔺)2.022s (~)0.001s (+60.0% 🔺)2.025s (~)0.651s301.42x
fan-out fan-in 10 streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.888s (+6.5% 🔺)2.312s (+6.2% 🔺)0.000s (NaN%)2.331s (+6.0% 🔺)0.443s261.00x
🐘 PostgresNext.js (Turbopack)1.890s2.146s0.000s2.153s0.264s281.00x
🐘 PostgresNitro1.917s (+7.0% 🔺)2.465s (+15.1% 🔺)0.000s (-100.0% 🟢)2.532s (+16.4% 🔺)0.615s251.02x
💻 LocalNext.js (Turbopack)3.662s4.032s0.001s4.038s0.376s151.94x
💻 LocalNitro3.709s (+9.5% 🔺)4.234s (+5.0% 🔺)0.000s (-25.0% 🟢)4.236s (+5.0%)0.528s151.96x
💻 LocalExpress4.304s (+24.1% 🔺)4.423s (+9.7% 🔺)0.000s (-42.3% 🟢)4.812s (+19.2% 🔺)0.507s132.28x

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)16/21
🐘 PostgresNitro11/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres18/21
Next.js (Turbopack)🐘 Postgres17/21
Nitro🐘 Postgres19/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the e2e “step error preserves stack trace” assertions for Vite local dev after the Vite upgrade started preserving step bundle source maps in dev mode.

Changes:

  • Update hasStepSourceMaps() to allow Vite local dev to assert original source filenames in stacks (while keeping local prod behavior unchanged).
  • Add an (empty) changeset note documenting the Vite local-dev e2e fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/core/e2e/utils.tsRefines step sourcemap support matrix so Vite local dev no longer disables stack source assertions.
.changeset/fix-vite-step-source-maps-e2e.mdDocuments the reason for the Vite local-dev e2e assertion change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/e2e/utils.ts Outdated
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
@TooTallNate
TooTallNate enabled auto-merge (squash) April 28, 2026 19:13
@TooTallNate
TooTallNate merged commit d6f7eb6 into mainApr 28, 2026
154 of 163 checks passed
@TooTallNate
TooTallNate deleted the fix/vite-step-source-maps-e2e branch April 28, 2026 19:26
ijjk pushed a commit that referenced this pull request Apr 28, 2026
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
TooTallNate added a commit that referenced this pull request May 4, 2026
…al dev (#1919)
* Bump vite (#1827)
* test: enable step source-map assertions for vite local dev (#1862)
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
---------
Co-authored-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test: enable step source-map assertions for vite local dev - #1862

Merged
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e
Apr 28, 2026
Merged

test: enable step source-map assertions for vite local dev#1862
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Vite local-dev e2e tests basic step error preserves message and stack trace and cross-file step error preserves message and function names in stack have been failing consistently since #1827 bumped workbench/vite from vite@^7.1.12 to vite@^7.3.2.
  • The newer vite preserves step bundle source maps in dev mode, so stack traces now point at original files (99_e2e.ts, helpers.ts). However, hasStepSourceMaps() in packages/core/e2e/utils.ts still hard-codes vite as having no step source maps in any local environment, so the assertion expect(stack).not.toContain('99_e2e.ts') fails.
  • Fix: drop the vite-specific block in hasStepSourceMaps() entirely. Vite local dev now falls through to the default return true, while vite local prod is still caught by the existing !DEV_TEST_CONFIG guard further down — so local-prod behavior is unchanged.

Why this took 6 days to surface

  1. The push for [workflow] Bump Vite #1827 had Local Dev tests skipped due to matrix selection at the time.
  2. The next push (Lock next@canary test version #1860) introduced a CI env-var bug that prevented Local Dev tests from running at all.
  3. ci: fix VERCEL_WORKFLOW_SERVER_* env var ternary on main #1859 (28dc089e) fixed the env-var bug, finally letting vite local dev run — and it surfaced this assertion failure.

Reference failing run: https://github.com/vercel/workflow/actions/runs/25067758534/job/73444472541

Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
CopilotAI review requested due to automatic review settings April 28, 2026 18:49
@vercel

vercelBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 072a4d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production9780671045
✅ 💻 Local Development10540861140
✅ 📦 Local Production10540861140
✅ 🐘 Local Postgres10540861140
✅ 🪟 Windows950095
✅ 📋 Other267018285
Total450203434845

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8807
✅ example8807
✅ express8807
✅ fastify8807
✅ hono8807
✅ nextjs-turbopack9302
✅ nextjs-webpack9302
✅ nitro8807
✅ nuxt8807
✅ sveltekit8807
✅ vite8807
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9500
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8906
✅ e2e-local-postgres-nest-stable8906
✅ e2e-local-prod-nest-stable8906

📋 View full workflow run

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.040s (-9.3% 🟢)1.005s (~)0.965s101.00x
💻 LocalNitro0.046s (+6.7% 🔺)1.005s (~)0.959s101.14x
🐘 PostgresNitro0.049s (-48.3% 🟢)1.011s (-3.1%)0.961s101.22x
💻 LocalNext.js (Turbopack)0.051s1.005s0.954s101.27x
🐘 PostgresExpress0.053s (-8.4% 🟢)1.012s (~)0.959s101.32x
🐘 PostgresNext.js (Turbopack)0.057s1.009s0.952s101.42x
workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.120s2.005s0.886s101.00x
💻 LocalExpress1.127s (~)2.005s (~)0.878s101.01x
🐘 PostgresNitro1.128s (-1.1%)2.008s (~)0.880s101.01x
💻 LocalNitro1.137s (+0.5%)2.006s (~)0.869s101.02x
🐘 PostgresExpress1.144s (~)2.010s (~)0.867s101.02x
🐘 PostgresNext.js (Turbopack)1.150s2.012s0.862s101.03x
workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro10.770s (-0.9%)11.023s (~)0.253s31.00x
🐘 PostgresExpress10.787s (-1.6%)11.025s (~)0.238s31.00x
💻 LocalNext.js (Turbopack)10.789s11.024s0.235s31.00x
🐘 PostgresNext.js (Turbopack)10.879s11.025s0.146s31.01x
💻 LocalExpress10.922s (~)11.023s (~)0.100s31.01x
💻 LocalNitro10.955s (~)11.024s (~)0.069s31.02x
workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express14.344s (-1.6%)15.034s (~)0.691s41.00x
🐘 PostgresNext.js (Turbopack)14.467s15.023s0.556s41.01x
💻 LocalNext.js (Turbopack)14.720s15.030s0.310s41.03x
🐘 PostgresNitro14.789s (+1.3%)15.529s (+3.3%)0.740s41.03x
💻 LocalExpress14.980s (~)15.029s (~)0.049s41.04x
💻 LocalNitro15.104s (~)16.033s (~)0.929s41.05x
workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express13.522s (-3.5%)14.029s (-3.9%)0.507s71.00x
🐘 PostgresNext.js (Turbopack)13.921s14.022s0.101s71.03x
🐘 PostgresNitro14.610s (+4.6%)15.355s (+7.3% 🔺)0.745s61.08x
💻 LocalNext.js (Turbopack)16.229s17.032s0.803s61.20x
💻 LocalExpress16.828s (+1.4%)17.198s (+1.0%)0.370s61.24x
💻 LocalNitro16.921s (+0.8%)17.032s (~)0.111s61.25x
Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.203s (-5.6% 🟢)2.010s (~)0.807s151.00x
🐘 PostgresNext.js (Turbopack)1.233s2.010s0.777s151.03x
🐘 PostgresExpress1.234s (-2.1%)2.011s (~)0.777s151.03x
💻 LocalNext.js (Turbopack)1.509s2.006s0.497s151.25x
💻 LocalExpress1.526s (+2.5%)2.006s (~)0.480s151.27x
💻 LocalNitro1.561s (-4.3%)2.006s (-3.3%)0.445s151.30x
Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.304s (-2.0%)3.026s (+0.6%)0.722s101.00x
🐘 PostgresExpress2.376s (+0.6%)3.011s (~)0.635s101.03x
🐘 PostgresNext.js (Turbopack)2.406s3.009s0.603s101.04x
💻 LocalNext.js (Turbopack)2.809s3.454s0.645s91.22x
💻 LocalNitro3.045s (-3.1%)3.453s (-11.1% 🟢)0.407s91.32x
💻 LocalExpress3.066s (+3.8%)3.885s (+12.5% 🔺)0.819s81.33x
Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.494s (~)4.014s (~)0.520s81.00x
🐘 PostgresNitro3.496s (~)4.026s (~)0.530s81.00x
🐘 PostgresNext.js (Turbopack)3.682s4.011s0.329s81.05x
💻 LocalNext.js (Turbopack)7.885s8.519s0.634s42.26x
💻 LocalExpress8.294s (-0.5%)9.022s (~)0.728s42.37x
💻 LocalNitro9.038s (+8.2% 🔺)9.522s (+5.6% 🔺)0.485s42.59x
Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.206s (-4.0%)2.007s (~)0.801s151.00x
🐘 PostgresNext.js (Turbopack)1.239s2.010s0.771s151.03x
🐘 PostgresExpress1.247s (-0.8%)2.010s (~)0.763s151.03x
💻 LocalNext.js (Turbopack)1.520s2.006s0.486s151.26x
💻 LocalNitro1.566s (-16.1% 🟢)2.006s (-14.3% 🟢)0.440s151.30x
💻 LocalExpress1.678s (-11.4% 🟢)2.222s (-6.0% 🟢)0.544s141.39x
Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.270s (-3.0%)3.007s (~)0.737s101.00x
🐘 PostgresExpress2.342s (~)3.009s (~)0.667s101.03x
🐘 PostgresNext.js (Turbopack)2.402s3.010s0.608s101.06x
💻 LocalNext.js (Turbopack)2.983s3.760s0.776s81.31x
💻 LocalNitro3.004s (-2.0%)3.760s (-3.3%)0.756s81.32x
💻 LocalExpress3.144s (~)4.010s (+6.6% 🔺)0.866s81.39x
Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.416s (-1.9%)4.008s (~)0.593s81.00x
🐘 PostgresExpress3.448s (-1.5%)4.011s (~)0.563s81.01x
🐘 PostgresNext.js (Turbopack)3.649s4.014s0.365s81.07x
💻 LocalNext.js (Turbopack)8.305s9.021s0.716s42.43x
💻 LocalExpress8.866s (+0.7%)9.273s (~)0.406s42.60x
💻 LocalNitro9.213s (+0.8%)9.772s (-2.5%)0.559s42.70x
workflow with 10 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.714s (-15.0% 🟢)1.007s (-1.6%)0.293s601.00x
🐘 PostgresNext.js (Turbopack)0.781s1.006s0.226s601.09x
💻 LocalNext.js (Turbopack)0.890s1.039s0.149s581.25x
🐘 PostgresNitro0.982s (+19.7% 🔺)1.346s (+33.7% 🔺)0.363s451.38x
💻 LocalNitro1.014s (+3.4%)1.720s (+57.2% 🔺)0.706s351.42x
💻 LocalExpress1.128s (+14.6% 🔺)1.570s (+45.9% 🔺)0.442s391.58x
workflow with 25 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.698s (-14.1% 🟢)2.009s (-11.0% 🟢)0.311s451.00x
🐘 PostgresNitro1.728s (-10.3% 🟢)2.100s (~)0.372s431.02x
🐘 PostgresNext.js (Turbopack)1.932s2.173s0.241s421.14x
💻 LocalNext.js (Turbopack)2.943s3.223s0.280s281.73x
💻 LocalExpress3.035s (+0.6%)3.586s (~)0.550s261.79x
💻 LocalNitro3.041s (~)3.843s (+2.3%)0.803s241.79x
workflow with 50 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.431s (-16.4% 🟢)4.108s (-10.8% 🟢)0.678s301.00x
🐘 PostgresExpress3.498s (-12.3% 🟢)4.012s (-8.2% 🟢)0.514s301.02x
🐘 PostgresNext.js (Turbopack)3.864s4.045s0.181s301.13x
💻 LocalNext.js (Turbopack)8.870s9.161s0.291s142.59x
💻 LocalNitro9.175s (-1.3%)9.787s (-2.3%)0.613s132.67x
💻 LocalExpress9.295s (+0.9%)9.941s (-0.8%)0.646s132.71x
workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.244s (-13.9% 🟢)1.007s (~)0.764s601.00x
🐘 PostgresNext.js (Turbopack)0.248s1.007s0.759s601.02x
🐘 PostgresExpress0.261s (-7.6% 🟢)1.008s (~)0.747s601.07x
💻 LocalExpress0.595s (+6.1% 🔺)1.005s (~)0.410s602.44x
💻 LocalNitro0.599s (-1.0%)1.005s (-1.6%)0.406s602.46x
💻 LocalNext.js (Turbopack)0.607s1.022s0.415s592.49x
workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.409s (-19.7% 🟢)1.007s (~)0.598s901.00x
🐘 PostgresNitro0.426s (-14.1% 🟢)1.009s (~)0.583s901.04x
🐘 PostgresNext.js (Turbopack)0.504s1.007s0.503s901.23x
💻 LocalNitro2.548s (~)3.009s (~)0.461s306.23x
💻 LocalNext.js (Turbopack)2.681s3.009s0.328s306.55x
💻 LocalExpress2.844s (+13.1% 🔺)3.472s (+15.4% 🔺)0.629s266.95x
workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.654s (-20.1% 🟢)1.016s (~)0.362s1191.00x
🐘 PostgresNitro0.657s (-16.8% 🟢)1.054s (+4.7%)0.397s1141.01x
🐘 PostgresNext.js (Turbopack)0.820s1.016s0.196s1191.25x
💻 LocalNitro11.257s (+0.6%)11.938s (+2.3%)0.681s1117.21x
💻 LocalNext.js (Turbopack)11.270s11.847s0.577s1117.23x
💻 LocalExpress12.606s (+12.7% 🔺)13.033s (+9.1% 🔺)0.426s1019.28x
Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.180s1.002s0.013s1.019s0.839s101.00x
🐘 PostgresNext.js (Turbopack)0.198s1.000s0.001s1.010s0.812s101.10x
💻 LocalExpress0.201s (+0.8%)1.005s (~)0.012s (-0.8%)1.018s (~)0.818s101.12x
💻 LocalNitro0.209s (-2.2%)1.004s (~)0.013s (+3.2%)1.019s (~)0.810s101.16x
🐘 PostgresExpress0.255s (+24.3% 🔺)1.000s (~)0.045s (+2712.5% 🔺)1.056s (+4.4%)0.801s101.42x
🐘 PostgresNitro0.330s (+60.9% 🔺)1.008s (+0.8%)0.124s (+8166.7% 🔺)1.159s (+14.6% 🔺)0.829s101.84x
stream pipeline with 5 transform steps (1MB)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.585s (-6.3% 🟢)1.040s (+3.3%)0.032s (+667.7% 🔺)1.083s (+5.9% 🔺)0.499s561.00x
🐘 PostgresExpress0.600s (-4.7%)1.008s (~)0.005s (+32.7% 🔺)1.025s (~)0.425s591.03x
🐘 PostgresNext.js (Turbopack)0.650s1.026s0.007s1.042s0.392s581.11x
💻 LocalNext.js (Turbopack)0.680s1.011s0.009s1.023s0.343s591.16x
💻 LocalExpress0.825s (+8.9% 🔺)1.013s (-1.5%)0.015s (+59.3% 🔺)1.030s (-0.9%)0.206s591.41x
💻 LocalNitro0.847s (+0.9%)1.012s (~)0.010s (+4.2%)1.116s (~)0.269s541.45x
10 parallel streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Next.js (Turbopack)0.965s1.250s0.000s1.264s0.299s481.00x
🐘 PostgresExpress1.015s (+5.6% 🔺)1.463s (+14.5% 🔺)0.000s (-43.9% 🟢)1.478s (+13.1% 🔺)0.463s411.05x
🐘 PostgresNitro1.144s (+18.1% 🔺)1.461s (+17.1% 🔺)0.000s (-41.5% 🟢)1.481s (+17.7% 🔺)0.336s411.19x
💻 LocalNitro1.252s (+2.4%)2.022s (~)0.000s (+266.7% 🔺)2.024s (~)0.772s301.30x
💻 LocalNext.js (Turbopack)1.309s2.020s0.000s2.023s0.714s301.36x
💻 LocalExpress1.374s (+12.2% 🔺)2.022s (~)0.001s (+60.0% 🔺)2.025s (~)0.651s301.42x
fan-out fan-in 10 streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.888s (+6.5% 🔺)2.312s (+6.2% 🔺)0.000s (NaN%)2.331s (+6.0% 🔺)0.443s261.00x
🐘 PostgresNext.js (Turbopack)1.890s2.146s0.000s2.153s0.264s281.00x
🐘 PostgresNitro1.917s (+7.0% 🔺)2.465s (+15.1% 🔺)0.000s (-100.0% 🟢)2.532s (+16.4% 🔺)0.615s251.02x
💻 LocalNext.js (Turbopack)3.662s4.032s0.001s4.038s0.376s151.94x
💻 LocalNitro3.709s (+9.5% 🔺)4.234s (+5.0% 🔺)0.000s (-25.0% 🟢)4.236s (+5.0%)0.528s151.96x
💻 LocalExpress4.304s (+24.1% 🔺)4.423s (+9.7% 🔺)0.000s (-42.3% 🟢)4.812s (+19.2% 🔺)0.507s132.28x

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)16/21
🐘 PostgresNitro11/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres18/21
Next.js (Turbopack)🐘 Postgres17/21
Nitro🐘 Postgres19/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the e2e “step error preserves stack trace” assertions for Vite local dev after the Vite upgrade started preserving step bundle source maps in dev mode.

Changes:

  • Update hasStepSourceMaps() to allow Vite local dev to assert original source filenames in stacks (while keeping local prod behavior unchanged).
  • Add an (empty) changeset note documenting the Vite local-dev e2e fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/core/e2e/utils.tsRefines step sourcemap support matrix so Vite local dev no longer disables stack source assertions.
.changeset/fix-vite-step-source-maps-e2e.mdDocuments the reason for the Vite local-dev e2e assertion change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/e2e/utils.ts Outdated
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
@TooTallNate
TooTallNate enabled auto-merge (squash) April 28, 2026 19:13
@TooTallNate
TooTallNate merged commit d6f7eb6 into mainApr 28, 2026
154 of 163 checks passed
@TooTallNate
TooTallNate deleted the fix/vite-step-source-maps-e2e branch April 28, 2026 19:26
ijjk pushed a commit that referenced this pull request Apr 28, 2026
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
TooTallNate added a commit that referenced this pull request May 4, 2026
…al dev (#1919)
* Bump vite (#1827)
* test: enable step source-map assertions for vite local dev (#1862)
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
---------
Co-authored-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test: enable step source-map assertions for vite local dev - #1862

Merged
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e
Apr 28, 2026
Merged

test: enable step source-map assertions for vite local dev#1862
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Vite local-dev e2e tests basic step error preserves message and stack trace and cross-file step error preserves message and function names in stack have been failing consistently since #1827 bumped workbench/vite from vite@^7.1.12 to vite@^7.3.2.
  • The newer vite preserves step bundle source maps in dev mode, so stack traces now point at original files (99_e2e.ts, helpers.ts). However, hasStepSourceMaps() in packages/core/e2e/utils.ts still hard-codes vite as having no step source maps in any local environment, so the assertion expect(stack).not.toContain('99_e2e.ts') fails.
  • Fix: drop the vite-specific block in hasStepSourceMaps() entirely. Vite local dev now falls through to the default return true, while vite local prod is still caught by the existing !DEV_TEST_CONFIG guard further down — so local-prod behavior is unchanged.

Why this took 6 days to surface

  1. The push for [workflow] Bump Vite #1827 had Local Dev tests skipped due to matrix selection at the time.
  2. The next push (Lock next@canary test version #1860) introduced a CI env-var bug that prevented Local Dev tests from running at all.
  3. ci: fix VERCEL_WORKFLOW_SERVER_* env var ternary on main #1859 (28dc089e) fixed the env-var bug, finally letting vite local dev run — and it surfaced this assertion failure.

Reference failing run: https://github.com/vercel/workflow/actions/runs/25067758534/job/73444472541

Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
CopilotAI review requested due to automatic review settings April 28, 2026 18:49
@vercel

vercelBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 072a4d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production9780671045
✅ 💻 Local Development10540861140
✅ 📦 Local Production10540861140
✅ 🐘 Local Postgres10540861140
✅ 🪟 Windows950095
✅ 📋 Other267018285
Total450203434845

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8807
✅ example8807
✅ express8807
✅ fastify8807
✅ hono8807
✅ nextjs-turbopack9302
✅ nextjs-webpack9302
✅ nitro8807
✅ nuxt8807
✅ sveltekit8807
✅ vite8807
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9500
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8906
✅ e2e-local-postgres-nest-stable8906
✅ e2e-local-prod-nest-stable8906

📋 View full workflow run

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.040s (-9.3% 🟢)1.005s (~)0.965s101.00x
💻 LocalNitro0.046s (+6.7% 🔺)1.005s (~)0.959s101.14x
🐘 PostgresNitro0.049s (-48.3% 🟢)1.011s (-3.1%)0.961s101.22x
💻 LocalNext.js (Turbopack)0.051s1.005s0.954s101.27x
🐘 PostgresExpress0.053s (-8.4% 🟢)1.012s (~)0.959s101.32x
🐘 PostgresNext.js (Turbopack)0.057s1.009s0.952s101.42x
workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.120s2.005s0.886s101.00x
💻 LocalExpress1.127s (~)2.005s (~)0.878s101.01x
🐘 PostgresNitro1.128s (-1.1%)2.008s (~)0.880s101.01x
💻 LocalNitro1.137s (+0.5%)2.006s (~)0.869s101.02x
🐘 PostgresExpress1.144s (~)2.010s (~)0.867s101.02x
🐘 PostgresNext.js (Turbopack)1.150s2.012s0.862s101.03x
workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro10.770s (-0.9%)11.023s (~)0.253s31.00x
🐘 PostgresExpress10.787s (-1.6%)11.025s (~)0.238s31.00x
💻 LocalNext.js (Turbopack)10.789s11.024s0.235s31.00x
🐘 PostgresNext.js (Turbopack)10.879s11.025s0.146s31.01x
💻 LocalExpress10.922s (~)11.023s (~)0.100s31.01x
💻 LocalNitro10.955s (~)11.024s (~)0.069s31.02x
workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express14.344s (-1.6%)15.034s (~)0.691s41.00x
🐘 PostgresNext.js (Turbopack)14.467s15.023s0.556s41.01x
💻 LocalNext.js (Turbopack)14.720s15.030s0.310s41.03x
🐘 PostgresNitro14.789s (+1.3%)15.529s (+3.3%)0.740s41.03x
💻 LocalExpress14.980s (~)15.029s (~)0.049s41.04x
💻 LocalNitro15.104s (~)16.033s (~)0.929s41.05x
workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express13.522s (-3.5%)14.029s (-3.9%)0.507s71.00x
🐘 PostgresNext.js (Turbopack)13.921s14.022s0.101s71.03x
🐘 PostgresNitro14.610s (+4.6%)15.355s (+7.3% 🔺)0.745s61.08x
💻 LocalNext.js (Turbopack)16.229s17.032s0.803s61.20x
💻 LocalExpress16.828s (+1.4%)17.198s (+1.0%)0.370s61.24x
💻 LocalNitro16.921s (+0.8%)17.032s (~)0.111s61.25x
Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.203s (-5.6% 🟢)2.010s (~)0.807s151.00x
🐘 PostgresNext.js (Turbopack)1.233s2.010s0.777s151.03x
🐘 PostgresExpress1.234s (-2.1%)2.011s (~)0.777s151.03x
💻 LocalNext.js (Turbopack)1.509s2.006s0.497s151.25x
💻 LocalExpress1.526s (+2.5%)2.006s (~)0.480s151.27x
💻 LocalNitro1.561s (-4.3%)2.006s (-3.3%)0.445s151.30x
Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.304s (-2.0%)3.026s (+0.6%)0.722s101.00x
🐘 PostgresExpress2.376s (+0.6%)3.011s (~)0.635s101.03x
🐘 PostgresNext.js (Turbopack)2.406s3.009s0.603s101.04x
💻 LocalNext.js (Turbopack)2.809s3.454s0.645s91.22x
💻 LocalNitro3.045s (-3.1%)3.453s (-11.1% 🟢)0.407s91.32x
💻 LocalExpress3.066s (+3.8%)3.885s (+12.5% 🔺)0.819s81.33x
Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.494s (~)4.014s (~)0.520s81.00x
🐘 PostgresNitro3.496s (~)4.026s (~)0.530s81.00x
🐘 PostgresNext.js (Turbopack)3.682s4.011s0.329s81.05x
💻 LocalNext.js (Turbopack)7.885s8.519s0.634s42.26x
💻 LocalExpress8.294s (-0.5%)9.022s (~)0.728s42.37x
💻 LocalNitro9.038s (+8.2% 🔺)9.522s (+5.6% 🔺)0.485s42.59x
Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.206s (-4.0%)2.007s (~)0.801s151.00x
🐘 PostgresNext.js (Turbopack)1.239s2.010s0.771s151.03x
🐘 PostgresExpress1.247s (-0.8%)2.010s (~)0.763s151.03x
💻 LocalNext.js (Turbopack)1.520s2.006s0.486s151.26x
💻 LocalNitro1.566s (-16.1% 🟢)2.006s (-14.3% 🟢)0.440s151.30x
💻 LocalExpress1.678s (-11.4% 🟢)2.222s (-6.0% 🟢)0.544s141.39x
Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.270s (-3.0%)3.007s (~)0.737s101.00x
🐘 PostgresExpress2.342s (~)3.009s (~)0.667s101.03x
🐘 PostgresNext.js (Turbopack)2.402s3.010s0.608s101.06x
💻 LocalNext.js (Turbopack)2.983s3.760s0.776s81.31x
💻 LocalNitro3.004s (-2.0%)3.760s (-3.3%)0.756s81.32x
💻 LocalExpress3.144s (~)4.010s (+6.6% 🔺)0.866s81.39x
Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.416s (-1.9%)4.008s (~)0.593s81.00x
🐘 PostgresExpress3.448s (-1.5%)4.011s (~)0.563s81.01x
🐘 PostgresNext.js (Turbopack)3.649s4.014s0.365s81.07x
💻 LocalNext.js (Turbopack)8.305s9.021s0.716s42.43x
💻 LocalExpress8.866s (+0.7%)9.273s (~)0.406s42.60x
💻 LocalNitro9.213s (+0.8%)9.772s (-2.5%)0.559s42.70x
workflow with 10 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.714s (-15.0% 🟢)1.007s (-1.6%)0.293s601.00x
🐘 PostgresNext.js (Turbopack)0.781s1.006s0.226s601.09x
💻 LocalNext.js (Turbopack)0.890s1.039s0.149s581.25x
🐘 PostgresNitro0.982s (+19.7% 🔺)1.346s (+33.7% 🔺)0.363s451.38x
💻 LocalNitro1.014s (+3.4%)1.720s (+57.2% 🔺)0.706s351.42x
💻 LocalExpress1.128s (+14.6% 🔺)1.570s (+45.9% 🔺)0.442s391.58x
workflow with 25 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.698s (-14.1% 🟢)2.009s (-11.0% 🟢)0.311s451.00x
🐘 PostgresNitro1.728s (-10.3% 🟢)2.100s (~)0.372s431.02x
🐘 PostgresNext.js (Turbopack)1.932s2.173s0.241s421.14x
💻 LocalNext.js (Turbopack)2.943s3.223s0.280s281.73x
💻 LocalExpress3.035s (+0.6%)3.586s (~)0.550s261.79x
💻 LocalNitro3.041s (~)3.843s (+2.3%)0.803s241.79x
workflow with 50 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.431s (-16.4% 🟢)4.108s (-10.8% 🟢)0.678s301.00x
🐘 PostgresExpress3.498s (-12.3% 🟢)4.012s (-8.2% 🟢)0.514s301.02x
🐘 PostgresNext.js (Turbopack)3.864s4.045s0.181s301.13x
💻 LocalNext.js (Turbopack)8.870s9.161s0.291s142.59x
💻 LocalNitro9.175s (-1.3%)9.787s (-2.3%)0.613s132.67x
💻 LocalExpress9.295s (+0.9%)9.941s (-0.8%)0.646s132.71x
workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.244s (-13.9% 🟢)1.007s (~)0.764s601.00x
🐘 PostgresNext.js (Turbopack)0.248s1.007s0.759s601.02x
🐘 PostgresExpress0.261s (-7.6% 🟢)1.008s (~)0.747s601.07x
💻 LocalExpress0.595s (+6.1% 🔺)1.005s (~)0.410s602.44x
💻 LocalNitro0.599s (-1.0%)1.005s (-1.6%)0.406s602.46x
💻 LocalNext.js (Turbopack)0.607s1.022s0.415s592.49x
workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.409s (-19.7% 🟢)1.007s (~)0.598s901.00x
🐘 PostgresNitro0.426s (-14.1% 🟢)1.009s (~)0.583s901.04x
🐘 PostgresNext.js (Turbopack)0.504s1.007s0.503s901.23x
💻 LocalNitro2.548s (~)3.009s (~)0.461s306.23x
💻 LocalNext.js (Turbopack)2.681s3.009s0.328s306.55x
💻 LocalExpress2.844s (+13.1% 🔺)3.472s (+15.4% 🔺)0.629s266.95x
workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.654s (-20.1% 🟢)1.016s (~)0.362s1191.00x
🐘 PostgresNitro0.657s (-16.8% 🟢)1.054s (+4.7%)0.397s1141.01x
🐘 PostgresNext.js (Turbopack)0.820s1.016s0.196s1191.25x
💻 LocalNitro11.257s (+0.6%)11.938s (+2.3%)0.681s1117.21x
💻 LocalNext.js (Turbopack)11.270s11.847s0.577s1117.23x
💻 LocalExpress12.606s (+12.7% 🔺)13.033s (+9.1% 🔺)0.426s1019.28x
Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.180s1.002s0.013s1.019s0.839s101.00x
🐘 PostgresNext.js (Turbopack)0.198s1.000s0.001s1.010s0.812s101.10x
💻 LocalExpress0.201s (+0.8%)1.005s (~)0.012s (-0.8%)1.018s (~)0.818s101.12x
💻 LocalNitro0.209s (-2.2%)1.004s (~)0.013s (+3.2%)1.019s (~)0.810s101.16x
🐘 PostgresExpress0.255s (+24.3% 🔺)1.000s (~)0.045s (+2712.5% 🔺)1.056s (+4.4%)0.801s101.42x
🐘 PostgresNitro0.330s (+60.9% 🔺)1.008s (+0.8%)0.124s (+8166.7% 🔺)1.159s (+14.6% 🔺)0.829s101.84x
stream pipeline with 5 transform steps (1MB)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.585s (-6.3% 🟢)1.040s (+3.3%)0.032s (+667.7% 🔺)1.083s (+5.9% 🔺)0.499s561.00x
🐘 PostgresExpress0.600s (-4.7%)1.008s (~)0.005s (+32.7% 🔺)1.025s (~)0.425s591.03x
🐘 PostgresNext.js (Turbopack)0.650s1.026s0.007s1.042s0.392s581.11x
💻 LocalNext.js (Turbopack)0.680s1.011s0.009s1.023s0.343s591.16x
💻 LocalExpress0.825s (+8.9% 🔺)1.013s (-1.5%)0.015s (+59.3% 🔺)1.030s (-0.9%)0.206s591.41x
💻 LocalNitro0.847s (+0.9%)1.012s (~)0.010s (+4.2%)1.116s (~)0.269s541.45x
10 parallel streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Next.js (Turbopack)0.965s1.250s0.000s1.264s0.299s481.00x
🐘 PostgresExpress1.015s (+5.6% 🔺)1.463s (+14.5% 🔺)0.000s (-43.9% 🟢)1.478s (+13.1% 🔺)0.463s411.05x
🐘 PostgresNitro1.144s (+18.1% 🔺)1.461s (+17.1% 🔺)0.000s (-41.5% 🟢)1.481s (+17.7% 🔺)0.336s411.19x
💻 LocalNitro1.252s (+2.4%)2.022s (~)0.000s (+266.7% 🔺)2.024s (~)0.772s301.30x
💻 LocalNext.js (Turbopack)1.309s2.020s0.000s2.023s0.714s301.36x
💻 LocalExpress1.374s (+12.2% 🔺)2.022s (~)0.001s (+60.0% 🔺)2.025s (~)0.651s301.42x
fan-out fan-in 10 streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.888s (+6.5% 🔺)2.312s (+6.2% 🔺)0.000s (NaN%)2.331s (+6.0% 🔺)0.443s261.00x
🐘 PostgresNext.js (Turbopack)1.890s2.146s0.000s2.153s0.264s281.00x
🐘 PostgresNitro1.917s (+7.0% 🔺)2.465s (+15.1% 🔺)0.000s (-100.0% 🟢)2.532s (+16.4% 🔺)0.615s251.02x
💻 LocalNext.js (Turbopack)3.662s4.032s0.001s4.038s0.376s151.94x
💻 LocalNitro3.709s (+9.5% 🔺)4.234s (+5.0% 🔺)0.000s (-25.0% 🟢)4.236s (+5.0%)0.528s151.96x
💻 LocalExpress4.304s (+24.1% 🔺)4.423s (+9.7% 🔺)0.000s (-42.3% 🟢)4.812s (+19.2% 🔺)0.507s132.28x

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)16/21
🐘 PostgresNitro11/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres18/21
Next.js (Turbopack)🐘 Postgres17/21
Nitro🐘 Postgres19/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the e2e “step error preserves stack trace” assertions for Vite local dev after the Vite upgrade started preserving step bundle source maps in dev mode.

Changes:

  • Update hasStepSourceMaps() to allow Vite local dev to assert original source filenames in stacks (while keeping local prod behavior unchanged).
  • Add an (empty) changeset note documenting the Vite local-dev e2e fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/core/e2e/utils.tsRefines step sourcemap support matrix so Vite local dev no longer disables stack source assertions.
.changeset/fix-vite-step-source-maps-e2e.mdDocuments the reason for the Vite local-dev e2e assertion change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/e2e/utils.ts Outdated
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
@TooTallNate
TooTallNate enabled auto-merge (squash) April 28, 2026 19:13
@TooTallNate
TooTallNate merged commit d6f7eb6 into mainApr 28, 2026
154 of 163 checks passed
@TooTallNate
TooTallNate deleted the fix/vite-step-source-maps-e2e branch April 28, 2026 19:26
ijjk pushed a commit that referenced this pull request Apr 28, 2026
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
TooTallNate added a commit that referenced this pull request May 4, 2026
…al dev (#1919)
* Bump vite (#1827)
* test: enable step source-map assertions for vite local dev (#1862)
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
---------
Co-authored-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test: enable step source-map assertions for vite local dev - #1862

Merged
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e
Apr 28, 2026
Merged

test: enable step source-map assertions for vite local dev#1862
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Vite local-dev e2e tests basic step error preserves message and stack trace and cross-file step error preserves message and function names in stack have been failing consistently since #1827 bumped workbench/vite from vite@^7.1.12 to vite@^7.3.2.
  • The newer vite preserves step bundle source maps in dev mode, so stack traces now point at original files (99_e2e.ts, helpers.ts). However, hasStepSourceMaps() in packages/core/e2e/utils.ts still hard-codes vite as having no step source maps in any local environment, so the assertion expect(stack).not.toContain('99_e2e.ts') fails.
  • Fix: drop the vite-specific block in hasStepSourceMaps() entirely. Vite local dev now falls through to the default return true, while vite local prod is still caught by the existing !DEV_TEST_CONFIG guard further down — so local-prod behavior is unchanged.

Why this took 6 days to surface

  1. The push for [workflow] Bump Vite #1827 had Local Dev tests skipped due to matrix selection at the time.
  2. The next push (Lock next@canary test version #1860) introduced a CI env-var bug that prevented Local Dev tests from running at all.
  3. ci: fix VERCEL_WORKFLOW_SERVER_* env var ternary on main #1859 (28dc089e) fixed the env-var bug, finally letting vite local dev run — and it surfaced this assertion failure.

Reference failing run: https://github.com/vercel/workflow/actions/runs/25067758534/job/73444472541

Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
CopilotAI review requested due to automatic review settings April 28, 2026 18:49
@vercel

vercelBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 072a4d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production9780671045
✅ 💻 Local Development10540861140
✅ 📦 Local Production10540861140
✅ 🐘 Local Postgres10540861140
✅ 🪟 Windows950095
✅ 📋 Other267018285
Total450203434845

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8807
✅ example8807
✅ express8807
✅ fastify8807
✅ hono8807
✅ nextjs-turbopack9302
✅ nextjs-webpack9302
✅ nitro8807
✅ nuxt8807
✅ sveltekit8807
✅ vite8807
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9500
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8906
✅ e2e-local-postgres-nest-stable8906
✅ e2e-local-prod-nest-stable8906

📋 View full workflow run

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.040s (-9.3% 🟢)1.005s (~)0.965s101.00x
💻 LocalNitro0.046s (+6.7% 🔺)1.005s (~)0.959s101.14x
🐘 PostgresNitro0.049s (-48.3% 🟢)1.011s (-3.1%)0.961s101.22x
💻 LocalNext.js (Turbopack)0.051s1.005s0.954s101.27x
🐘 PostgresExpress0.053s (-8.4% 🟢)1.012s (~)0.959s101.32x
🐘 PostgresNext.js (Turbopack)0.057s1.009s0.952s101.42x
workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.120s2.005s0.886s101.00x
💻 LocalExpress1.127s (~)2.005s (~)0.878s101.01x
🐘 PostgresNitro1.128s (-1.1%)2.008s (~)0.880s101.01x
💻 LocalNitro1.137s (+0.5%)2.006s (~)0.869s101.02x
🐘 PostgresExpress1.144s (~)2.010s (~)0.867s101.02x
🐘 PostgresNext.js (Turbopack)1.150s2.012s0.862s101.03x
workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro10.770s (-0.9%)11.023s (~)0.253s31.00x
🐘 PostgresExpress10.787s (-1.6%)11.025s (~)0.238s31.00x
💻 LocalNext.js (Turbopack)10.789s11.024s0.235s31.00x
🐘 PostgresNext.js (Turbopack)10.879s11.025s0.146s31.01x
💻 LocalExpress10.922s (~)11.023s (~)0.100s31.01x
💻 LocalNitro10.955s (~)11.024s (~)0.069s31.02x
workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express14.344s (-1.6%)15.034s (~)0.691s41.00x
🐘 PostgresNext.js (Turbopack)14.467s15.023s0.556s41.01x
💻 LocalNext.js (Turbopack)14.720s15.030s0.310s41.03x
🐘 PostgresNitro14.789s (+1.3%)15.529s (+3.3%)0.740s41.03x
💻 LocalExpress14.980s (~)15.029s (~)0.049s41.04x
💻 LocalNitro15.104s (~)16.033s (~)0.929s41.05x
workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express13.522s (-3.5%)14.029s (-3.9%)0.507s71.00x
🐘 PostgresNext.js (Turbopack)13.921s14.022s0.101s71.03x
🐘 PostgresNitro14.610s (+4.6%)15.355s (+7.3% 🔺)0.745s61.08x
💻 LocalNext.js (Turbopack)16.229s17.032s0.803s61.20x
💻 LocalExpress16.828s (+1.4%)17.198s (+1.0%)0.370s61.24x
💻 LocalNitro16.921s (+0.8%)17.032s (~)0.111s61.25x
Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.203s (-5.6% 🟢)2.010s (~)0.807s151.00x
🐘 PostgresNext.js (Turbopack)1.233s2.010s0.777s151.03x
🐘 PostgresExpress1.234s (-2.1%)2.011s (~)0.777s151.03x
💻 LocalNext.js (Turbopack)1.509s2.006s0.497s151.25x
💻 LocalExpress1.526s (+2.5%)2.006s (~)0.480s151.27x
💻 LocalNitro1.561s (-4.3%)2.006s (-3.3%)0.445s151.30x
Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.304s (-2.0%)3.026s (+0.6%)0.722s101.00x
🐘 PostgresExpress2.376s (+0.6%)3.011s (~)0.635s101.03x
🐘 PostgresNext.js (Turbopack)2.406s3.009s0.603s101.04x
💻 LocalNext.js (Turbopack)2.809s3.454s0.645s91.22x
💻 LocalNitro3.045s (-3.1%)3.453s (-11.1% 🟢)0.407s91.32x
💻 LocalExpress3.066s (+3.8%)3.885s (+12.5% 🔺)0.819s81.33x
Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.494s (~)4.014s (~)0.520s81.00x
🐘 PostgresNitro3.496s (~)4.026s (~)0.530s81.00x
🐘 PostgresNext.js (Turbopack)3.682s4.011s0.329s81.05x
💻 LocalNext.js (Turbopack)7.885s8.519s0.634s42.26x
💻 LocalExpress8.294s (-0.5%)9.022s (~)0.728s42.37x
💻 LocalNitro9.038s (+8.2% 🔺)9.522s (+5.6% 🔺)0.485s42.59x
Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.206s (-4.0%)2.007s (~)0.801s151.00x
🐘 PostgresNext.js (Turbopack)1.239s2.010s0.771s151.03x
🐘 PostgresExpress1.247s (-0.8%)2.010s (~)0.763s151.03x
💻 LocalNext.js (Turbopack)1.520s2.006s0.486s151.26x
💻 LocalNitro1.566s (-16.1% 🟢)2.006s (-14.3% 🟢)0.440s151.30x
💻 LocalExpress1.678s (-11.4% 🟢)2.222s (-6.0% 🟢)0.544s141.39x
Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.270s (-3.0%)3.007s (~)0.737s101.00x
🐘 PostgresExpress2.342s (~)3.009s (~)0.667s101.03x
🐘 PostgresNext.js (Turbopack)2.402s3.010s0.608s101.06x
💻 LocalNext.js (Turbopack)2.983s3.760s0.776s81.31x
💻 LocalNitro3.004s (-2.0%)3.760s (-3.3%)0.756s81.32x
💻 LocalExpress3.144s (~)4.010s (+6.6% 🔺)0.866s81.39x
Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.416s (-1.9%)4.008s (~)0.593s81.00x
🐘 PostgresExpress3.448s (-1.5%)4.011s (~)0.563s81.01x
🐘 PostgresNext.js (Turbopack)3.649s4.014s0.365s81.07x
💻 LocalNext.js (Turbopack)8.305s9.021s0.716s42.43x
💻 LocalExpress8.866s (+0.7%)9.273s (~)0.406s42.60x
💻 LocalNitro9.213s (+0.8%)9.772s (-2.5%)0.559s42.70x
workflow with 10 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.714s (-15.0% 🟢)1.007s (-1.6%)0.293s601.00x
🐘 PostgresNext.js (Turbopack)0.781s1.006s0.226s601.09x
💻 LocalNext.js (Turbopack)0.890s1.039s0.149s581.25x
🐘 PostgresNitro0.982s (+19.7% 🔺)1.346s (+33.7% 🔺)0.363s451.38x
💻 LocalNitro1.014s (+3.4%)1.720s (+57.2% 🔺)0.706s351.42x
💻 LocalExpress1.128s (+14.6% 🔺)1.570s (+45.9% 🔺)0.442s391.58x
workflow with 25 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.698s (-14.1% 🟢)2.009s (-11.0% 🟢)0.311s451.00x
🐘 PostgresNitro1.728s (-10.3% 🟢)2.100s (~)0.372s431.02x
🐘 PostgresNext.js (Turbopack)1.932s2.173s0.241s421.14x
💻 LocalNext.js (Turbopack)2.943s3.223s0.280s281.73x
💻 LocalExpress3.035s (+0.6%)3.586s (~)0.550s261.79x
💻 LocalNitro3.041s (~)3.843s (+2.3%)0.803s241.79x
workflow with 50 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.431s (-16.4% 🟢)4.108s (-10.8% 🟢)0.678s301.00x
🐘 PostgresExpress3.498s (-12.3% 🟢)4.012s (-8.2% 🟢)0.514s301.02x
🐘 PostgresNext.js (Turbopack)3.864s4.045s0.181s301.13x
💻 LocalNext.js (Turbopack)8.870s9.161s0.291s142.59x
💻 LocalNitro9.175s (-1.3%)9.787s (-2.3%)0.613s132.67x
💻 LocalExpress9.295s (+0.9%)9.941s (-0.8%)0.646s132.71x
workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.244s (-13.9% 🟢)1.007s (~)0.764s601.00x
🐘 PostgresNext.js (Turbopack)0.248s1.007s0.759s601.02x
🐘 PostgresExpress0.261s (-7.6% 🟢)1.008s (~)0.747s601.07x
💻 LocalExpress0.595s (+6.1% 🔺)1.005s (~)0.410s602.44x
💻 LocalNitro0.599s (-1.0%)1.005s (-1.6%)0.406s602.46x
💻 LocalNext.js (Turbopack)0.607s1.022s0.415s592.49x
workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.409s (-19.7% 🟢)1.007s (~)0.598s901.00x
🐘 PostgresNitro0.426s (-14.1% 🟢)1.009s (~)0.583s901.04x
🐘 PostgresNext.js (Turbopack)0.504s1.007s0.503s901.23x
💻 LocalNitro2.548s (~)3.009s (~)0.461s306.23x
💻 LocalNext.js (Turbopack)2.681s3.009s0.328s306.55x
💻 LocalExpress2.844s (+13.1% 🔺)3.472s (+15.4% 🔺)0.629s266.95x
workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.654s (-20.1% 🟢)1.016s (~)0.362s1191.00x
🐘 PostgresNitro0.657s (-16.8% 🟢)1.054s (+4.7%)0.397s1141.01x
🐘 PostgresNext.js (Turbopack)0.820s1.016s0.196s1191.25x
💻 LocalNitro11.257s (+0.6%)11.938s (+2.3%)0.681s1117.21x
💻 LocalNext.js (Turbopack)11.270s11.847s0.577s1117.23x
💻 LocalExpress12.606s (+12.7% 🔺)13.033s (+9.1% 🔺)0.426s1019.28x
Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.180s1.002s0.013s1.019s0.839s101.00x
🐘 PostgresNext.js (Turbopack)0.198s1.000s0.001s1.010s0.812s101.10x
💻 LocalExpress0.201s (+0.8%)1.005s (~)0.012s (-0.8%)1.018s (~)0.818s101.12x
💻 LocalNitro0.209s (-2.2%)1.004s (~)0.013s (+3.2%)1.019s (~)0.810s101.16x
🐘 PostgresExpress0.255s (+24.3% 🔺)1.000s (~)0.045s (+2712.5% 🔺)1.056s (+4.4%)0.801s101.42x
🐘 PostgresNitro0.330s (+60.9% 🔺)1.008s (+0.8%)0.124s (+8166.7% 🔺)1.159s (+14.6% 🔺)0.829s101.84x
stream pipeline with 5 transform steps (1MB)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.585s (-6.3% 🟢)1.040s (+3.3%)0.032s (+667.7% 🔺)1.083s (+5.9% 🔺)0.499s561.00x
🐘 PostgresExpress0.600s (-4.7%)1.008s (~)0.005s (+32.7% 🔺)1.025s (~)0.425s591.03x
🐘 PostgresNext.js (Turbopack)0.650s1.026s0.007s1.042s0.392s581.11x
💻 LocalNext.js (Turbopack)0.680s1.011s0.009s1.023s0.343s591.16x
💻 LocalExpress0.825s (+8.9% 🔺)1.013s (-1.5%)0.015s (+59.3% 🔺)1.030s (-0.9%)0.206s591.41x
💻 LocalNitro0.847s (+0.9%)1.012s (~)0.010s (+4.2%)1.116s (~)0.269s541.45x
10 parallel streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Next.js (Turbopack)0.965s1.250s0.000s1.264s0.299s481.00x
🐘 PostgresExpress1.015s (+5.6% 🔺)1.463s (+14.5% 🔺)0.000s (-43.9% 🟢)1.478s (+13.1% 🔺)0.463s411.05x
🐘 PostgresNitro1.144s (+18.1% 🔺)1.461s (+17.1% 🔺)0.000s (-41.5% 🟢)1.481s (+17.7% 🔺)0.336s411.19x
💻 LocalNitro1.252s (+2.4%)2.022s (~)0.000s (+266.7% 🔺)2.024s (~)0.772s301.30x
💻 LocalNext.js (Turbopack)1.309s2.020s0.000s2.023s0.714s301.36x
💻 LocalExpress1.374s (+12.2% 🔺)2.022s (~)0.001s (+60.0% 🔺)2.025s (~)0.651s301.42x
fan-out fan-in 10 streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.888s (+6.5% 🔺)2.312s (+6.2% 🔺)0.000s (NaN%)2.331s (+6.0% 🔺)0.443s261.00x
🐘 PostgresNext.js (Turbopack)1.890s2.146s0.000s2.153s0.264s281.00x
🐘 PostgresNitro1.917s (+7.0% 🔺)2.465s (+15.1% 🔺)0.000s (-100.0% 🟢)2.532s (+16.4% 🔺)0.615s251.02x
💻 LocalNext.js (Turbopack)3.662s4.032s0.001s4.038s0.376s151.94x
💻 LocalNitro3.709s (+9.5% 🔺)4.234s (+5.0% 🔺)0.000s (-25.0% 🟢)4.236s (+5.0%)0.528s151.96x
💻 LocalExpress4.304s (+24.1% 🔺)4.423s (+9.7% 🔺)0.000s (-42.3% 🟢)4.812s (+19.2% 🔺)0.507s132.28x

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)16/21
🐘 PostgresNitro11/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres18/21
Next.js (Turbopack)🐘 Postgres17/21
Nitro🐘 Postgres19/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the e2e “step error preserves stack trace” assertions for Vite local dev after the Vite upgrade started preserving step bundle source maps in dev mode.

Changes:

  • Update hasStepSourceMaps() to allow Vite local dev to assert original source filenames in stacks (while keeping local prod behavior unchanged).
  • Add an (empty) changeset note documenting the Vite local-dev e2e fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/core/e2e/utils.tsRefines step sourcemap support matrix so Vite local dev no longer disables stack source assertions.
.changeset/fix-vite-step-source-maps-e2e.mdDocuments the reason for the Vite local-dev e2e assertion change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/e2e/utils.ts Outdated
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
@TooTallNate
TooTallNate enabled auto-merge (squash) April 28, 2026 19:13
@TooTallNate
TooTallNate merged commit d6f7eb6 into mainApr 28, 2026
154 of 163 checks passed
@TooTallNate
TooTallNate deleted the fix/vite-step-source-maps-e2e branch April 28, 2026 19:26
ijjk pushed a commit that referenced this pull request Apr 28, 2026
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
TooTallNate added a commit that referenced this pull request May 4, 2026
…al dev (#1919)
* Bump vite (#1827)
* test: enable step source-map assertions for vite local dev (#1862)
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
---------
Co-authored-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test: enable step source-map assertions for vite local dev - #1862

Merged
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e
Apr 28, 2026
Merged

test: enable step source-map assertions for vite local dev#1862
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Vite local-dev e2e tests basic step error preserves message and stack trace and cross-file step error preserves message and function names in stack have been failing consistently since #1827 bumped workbench/vite from vite@^7.1.12 to vite@^7.3.2.
  • The newer vite preserves step bundle source maps in dev mode, so stack traces now point at original files (99_e2e.ts, helpers.ts). However, hasStepSourceMaps() in packages/core/e2e/utils.ts still hard-codes vite as having no step source maps in any local environment, so the assertion expect(stack).not.toContain('99_e2e.ts') fails.
  • Fix: drop the vite-specific block in hasStepSourceMaps() entirely. Vite local dev now falls through to the default return true, while vite local prod is still caught by the existing !DEV_TEST_CONFIG guard further down — so local-prod behavior is unchanged.

Why this took 6 days to surface

  1. The push for [workflow] Bump Vite #1827 had Local Dev tests skipped due to matrix selection at the time.
  2. The next push (Lock next@canary test version #1860) introduced a CI env-var bug that prevented Local Dev tests from running at all.
  3. ci: fix VERCEL_WORKFLOW_SERVER_* env var ternary on main #1859 (28dc089e) fixed the env-var bug, finally letting vite local dev run — and it surfaced this assertion failure.

Reference failing run: https://github.com/vercel/workflow/actions/runs/25067758534/job/73444472541

Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
CopilotAI review requested due to automatic review settings April 28, 2026 18:49
@vercel

vercelBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 072a4d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production9780671045
✅ 💻 Local Development10540861140
✅ 📦 Local Production10540861140
✅ 🐘 Local Postgres10540861140
✅ 🪟 Windows950095
✅ 📋 Other267018285
Total450203434845

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8807
✅ example8807
✅ express8807
✅ fastify8807
✅ hono8807
✅ nextjs-turbopack9302
✅ nextjs-webpack9302
✅ nitro8807
✅ nuxt8807
✅ sveltekit8807
✅ vite8807
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9500
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8906
✅ e2e-local-postgres-nest-stable8906
✅ e2e-local-prod-nest-stable8906

📋 View full workflow run

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.040s (-9.3% 🟢)1.005s (~)0.965s101.00x
💻 LocalNitro0.046s (+6.7% 🔺)1.005s (~)0.959s101.14x
🐘 PostgresNitro0.049s (-48.3% 🟢)1.011s (-3.1%)0.961s101.22x
💻 LocalNext.js (Turbopack)0.051s1.005s0.954s101.27x
🐘 PostgresExpress0.053s (-8.4% 🟢)1.012s (~)0.959s101.32x
🐘 PostgresNext.js (Turbopack)0.057s1.009s0.952s101.42x
workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.120s2.005s0.886s101.00x
💻 LocalExpress1.127s (~)2.005s (~)0.878s101.01x
🐘 PostgresNitro1.128s (-1.1%)2.008s (~)0.880s101.01x
💻 LocalNitro1.137s (+0.5%)2.006s (~)0.869s101.02x
🐘 PostgresExpress1.144s (~)2.010s (~)0.867s101.02x
🐘 PostgresNext.js (Turbopack)1.150s2.012s0.862s101.03x
workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro10.770s (-0.9%)11.023s (~)0.253s31.00x
🐘 PostgresExpress10.787s (-1.6%)11.025s (~)0.238s31.00x
💻 LocalNext.js (Turbopack)10.789s11.024s0.235s31.00x
🐘 PostgresNext.js (Turbopack)10.879s11.025s0.146s31.01x
💻 LocalExpress10.922s (~)11.023s (~)0.100s31.01x
💻 LocalNitro10.955s (~)11.024s (~)0.069s31.02x
workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express14.344s (-1.6%)15.034s (~)0.691s41.00x
🐘 PostgresNext.js (Turbopack)14.467s15.023s0.556s41.01x
💻 LocalNext.js (Turbopack)14.720s15.030s0.310s41.03x
🐘 PostgresNitro14.789s (+1.3%)15.529s (+3.3%)0.740s41.03x
💻 LocalExpress14.980s (~)15.029s (~)0.049s41.04x
💻 LocalNitro15.104s (~)16.033s (~)0.929s41.05x
workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express13.522s (-3.5%)14.029s (-3.9%)0.507s71.00x
🐘 PostgresNext.js (Turbopack)13.921s14.022s0.101s71.03x
🐘 PostgresNitro14.610s (+4.6%)15.355s (+7.3% 🔺)0.745s61.08x
💻 LocalNext.js (Turbopack)16.229s17.032s0.803s61.20x
💻 LocalExpress16.828s (+1.4%)17.198s (+1.0%)0.370s61.24x
💻 LocalNitro16.921s (+0.8%)17.032s (~)0.111s61.25x
Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.203s (-5.6% 🟢)2.010s (~)0.807s151.00x
🐘 PostgresNext.js (Turbopack)1.233s2.010s0.777s151.03x
🐘 PostgresExpress1.234s (-2.1%)2.011s (~)0.777s151.03x
💻 LocalNext.js (Turbopack)1.509s2.006s0.497s151.25x
💻 LocalExpress1.526s (+2.5%)2.006s (~)0.480s151.27x
💻 LocalNitro1.561s (-4.3%)2.006s (-3.3%)0.445s151.30x
Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.304s (-2.0%)3.026s (+0.6%)0.722s101.00x
🐘 PostgresExpress2.376s (+0.6%)3.011s (~)0.635s101.03x
🐘 PostgresNext.js (Turbopack)2.406s3.009s0.603s101.04x
💻 LocalNext.js (Turbopack)2.809s3.454s0.645s91.22x
💻 LocalNitro3.045s (-3.1%)3.453s (-11.1% 🟢)0.407s91.32x
💻 LocalExpress3.066s (+3.8%)3.885s (+12.5% 🔺)0.819s81.33x
Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.494s (~)4.014s (~)0.520s81.00x
🐘 PostgresNitro3.496s (~)4.026s (~)0.530s81.00x
🐘 PostgresNext.js (Turbopack)3.682s4.011s0.329s81.05x
💻 LocalNext.js (Turbopack)7.885s8.519s0.634s42.26x
💻 LocalExpress8.294s (-0.5%)9.022s (~)0.728s42.37x
💻 LocalNitro9.038s (+8.2% 🔺)9.522s (+5.6% 🔺)0.485s42.59x
Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.206s (-4.0%)2.007s (~)0.801s151.00x
🐘 PostgresNext.js (Turbopack)1.239s2.010s0.771s151.03x
🐘 PostgresExpress1.247s (-0.8%)2.010s (~)0.763s151.03x
💻 LocalNext.js (Turbopack)1.520s2.006s0.486s151.26x
💻 LocalNitro1.566s (-16.1% 🟢)2.006s (-14.3% 🟢)0.440s151.30x
💻 LocalExpress1.678s (-11.4% 🟢)2.222s (-6.0% 🟢)0.544s141.39x
Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.270s (-3.0%)3.007s (~)0.737s101.00x
🐘 PostgresExpress2.342s (~)3.009s (~)0.667s101.03x
🐘 PostgresNext.js (Turbopack)2.402s3.010s0.608s101.06x
💻 LocalNext.js (Turbopack)2.983s3.760s0.776s81.31x
💻 LocalNitro3.004s (-2.0%)3.760s (-3.3%)0.756s81.32x
💻 LocalExpress3.144s (~)4.010s (+6.6% 🔺)0.866s81.39x
Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.416s (-1.9%)4.008s (~)0.593s81.00x
🐘 PostgresExpress3.448s (-1.5%)4.011s (~)0.563s81.01x
🐘 PostgresNext.js (Turbopack)3.649s4.014s0.365s81.07x
💻 LocalNext.js (Turbopack)8.305s9.021s0.716s42.43x
💻 LocalExpress8.866s (+0.7%)9.273s (~)0.406s42.60x
💻 LocalNitro9.213s (+0.8%)9.772s (-2.5%)0.559s42.70x
workflow with 10 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.714s (-15.0% 🟢)1.007s (-1.6%)0.293s601.00x
🐘 PostgresNext.js (Turbopack)0.781s1.006s0.226s601.09x
💻 LocalNext.js (Turbopack)0.890s1.039s0.149s581.25x
🐘 PostgresNitro0.982s (+19.7% 🔺)1.346s (+33.7% 🔺)0.363s451.38x
💻 LocalNitro1.014s (+3.4%)1.720s (+57.2% 🔺)0.706s351.42x
💻 LocalExpress1.128s (+14.6% 🔺)1.570s (+45.9% 🔺)0.442s391.58x
workflow with 25 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.698s (-14.1% 🟢)2.009s (-11.0% 🟢)0.311s451.00x
🐘 PostgresNitro1.728s (-10.3% 🟢)2.100s (~)0.372s431.02x
🐘 PostgresNext.js (Turbopack)1.932s2.173s0.241s421.14x
💻 LocalNext.js (Turbopack)2.943s3.223s0.280s281.73x
💻 LocalExpress3.035s (+0.6%)3.586s (~)0.550s261.79x
💻 LocalNitro3.041s (~)3.843s (+2.3%)0.803s241.79x
workflow with 50 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.431s (-16.4% 🟢)4.108s (-10.8% 🟢)0.678s301.00x
🐘 PostgresExpress3.498s (-12.3% 🟢)4.012s (-8.2% 🟢)0.514s301.02x
🐘 PostgresNext.js (Turbopack)3.864s4.045s0.181s301.13x
💻 LocalNext.js (Turbopack)8.870s9.161s0.291s142.59x
💻 LocalNitro9.175s (-1.3%)9.787s (-2.3%)0.613s132.67x
💻 LocalExpress9.295s (+0.9%)9.941s (-0.8%)0.646s132.71x
workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.244s (-13.9% 🟢)1.007s (~)0.764s601.00x
🐘 PostgresNext.js (Turbopack)0.248s1.007s0.759s601.02x
🐘 PostgresExpress0.261s (-7.6% 🟢)1.008s (~)0.747s601.07x
💻 LocalExpress0.595s (+6.1% 🔺)1.005s (~)0.410s602.44x
💻 LocalNitro0.599s (-1.0%)1.005s (-1.6%)0.406s602.46x
💻 LocalNext.js (Turbopack)0.607s1.022s0.415s592.49x
workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.409s (-19.7% 🟢)1.007s (~)0.598s901.00x
🐘 PostgresNitro0.426s (-14.1% 🟢)1.009s (~)0.583s901.04x
🐘 PostgresNext.js (Turbopack)0.504s1.007s0.503s901.23x
💻 LocalNitro2.548s (~)3.009s (~)0.461s306.23x
💻 LocalNext.js (Turbopack)2.681s3.009s0.328s306.55x
💻 LocalExpress2.844s (+13.1% 🔺)3.472s (+15.4% 🔺)0.629s266.95x
workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.654s (-20.1% 🟢)1.016s (~)0.362s1191.00x
🐘 PostgresNitro0.657s (-16.8% 🟢)1.054s (+4.7%)0.397s1141.01x
🐘 PostgresNext.js (Turbopack)0.820s1.016s0.196s1191.25x
💻 LocalNitro11.257s (+0.6%)11.938s (+2.3%)0.681s1117.21x
💻 LocalNext.js (Turbopack)11.270s11.847s0.577s1117.23x
💻 LocalExpress12.606s (+12.7% 🔺)13.033s (+9.1% 🔺)0.426s1019.28x
Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.180s1.002s0.013s1.019s0.839s101.00x
🐘 PostgresNext.js (Turbopack)0.198s1.000s0.001s1.010s0.812s101.10x
💻 LocalExpress0.201s (+0.8%)1.005s (~)0.012s (-0.8%)1.018s (~)0.818s101.12x
💻 LocalNitro0.209s (-2.2%)1.004s (~)0.013s (+3.2%)1.019s (~)0.810s101.16x
🐘 PostgresExpress0.255s (+24.3% 🔺)1.000s (~)0.045s (+2712.5% 🔺)1.056s (+4.4%)0.801s101.42x
🐘 PostgresNitro0.330s (+60.9% 🔺)1.008s (+0.8%)0.124s (+8166.7% 🔺)1.159s (+14.6% 🔺)0.829s101.84x
stream pipeline with 5 transform steps (1MB)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.585s (-6.3% 🟢)1.040s (+3.3%)0.032s (+667.7% 🔺)1.083s (+5.9% 🔺)0.499s561.00x
🐘 PostgresExpress0.600s (-4.7%)1.008s (~)0.005s (+32.7% 🔺)1.025s (~)0.425s591.03x
🐘 PostgresNext.js (Turbopack)0.650s1.026s0.007s1.042s0.392s581.11x
💻 LocalNext.js (Turbopack)0.680s1.011s0.009s1.023s0.343s591.16x
💻 LocalExpress0.825s (+8.9% 🔺)1.013s (-1.5%)0.015s (+59.3% 🔺)1.030s (-0.9%)0.206s591.41x
💻 LocalNitro0.847s (+0.9%)1.012s (~)0.010s (+4.2%)1.116s (~)0.269s541.45x
10 parallel streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Next.js (Turbopack)0.965s1.250s0.000s1.264s0.299s481.00x
🐘 PostgresExpress1.015s (+5.6% 🔺)1.463s (+14.5% 🔺)0.000s (-43.9% 🟢)1.478s (+13.1% 🔺)0.463s411.05x
🐘 PostgresNitro1.144s (+18.1% 🔺)1.461s (+17.1% 🔺)0.000s (-41.5% 🟢)1.481s (+17.7% 🔺)0.336s411.19x
💻 LocalNitro1.252s (+2.4%)2.022s (~)0.000s (+266.7% 🔺)2.024s (~)0.772s301.30x
💻 LocalNext.js (Turbopack)1.309s2.020s0.000s2.023s0.714s301.36x
💻 LocalExpress1.374s (+12.2% 🔺)2.022s (~)0.001s (+60.0% 🔺)2.025s (~)0.651s301.42x
fan-out fan-in 10 streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.888s (+6.5% 🔺)2.312s (+6.2% 🔺)0.000s (NaN%)2.331s (+6.0% 🔺)0.443s261.00x
🐘 PostgresNext.js (Turbopack)1.890s2.146s0.000s2.153s0.264s281.00x
🐘 PostgresNitro1.917s (+7.0% 🔺)2.465s (+15.1% 🔺)0.000s (-100.0% 🟢)2.532s (+16.4% 🔺)0.615s251.02x
💻 LocalNext.js (Turbopack)3.662s4.032s0.001s4.038s0.376s151.94x
💻 LocalNitro3.709s (+9.5% 🔺)4.234s (+5.0% 🔺)0.000s (-25.0% 🟢)4.236s (+5.0%)0.528s151.96x
💻 LocalExpress4.304s (+24.1% 🔺)4.423s (+9.7% 🔺)0.000s (-42.3% 🟢)4.812s (+19.2% 🔺)0.507s132.28x

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)16/21
🐘 PostgresNitro11/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres18/21
Next.js (Turbopack)🐘 Postgres17/21
Nitro🐘 Postgres19/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the e2e “step error preserves stack trace” assertions for Vite local dev after the Vite upgrade started preserving step bundle source maps in dev mode.

Changes:

  • Update hasStepSourceMaps() to allow Vite local dev to assert original source filenames in stacks (while keeping local prod behavior unchanged).
  • Add an (empty) changeset note documenting the Vite local-dev e2e fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/core/e2e/utils.tsRefines step sourcemap support matrix so Vite local dev no longer disables stack source assertions.
.changeset/fix-vite-step-source-maps-e2e.mdDocuments the reason for the Vite local-dev e2e assertion change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/e2e/utils.ts Outdated
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
@TooTallNate
TooTallNate enabled auto-merge (squash) April 28, 2026 19:13
@TooTallNate
TooTallNate merged commit d6f7eb6 into mainApr 28, 2026
154 of 163 checks passed
@TooTallNate
TooTallNate deleted the fix/vite-step-source-maps-e2e branch April 28, 2026 19:26
ijjk pushed a commit that referenced this pull request Apr 28, 2026
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
TooTallNate added a commit that referenced this pull request May 4, 2026
…al dev (#1919)
* Bump vite (#1827)
* test: enable step source-map assertions for vite local dev (#1862)
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
---------
Co-authored-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test: enable step source-map assertions for vite local dev - #1862

Merged
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e
Apr 28, 2026
Merged

test: enable step source-map assertions for vite local dev#1862
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Vite local-dev e2e tests basic step error preserves message and stack trace and cross-file step error preserves message and function names in stack have been failing consistently since #1827 bumped workbench/vite from vite@^7.1.12 to vite@^7.3.2.
  • The newer vite preserves step bundle source maps in dev mode, so stack traces now point at original files (99_e2e.ts, helpers.ts). However, hasStepSourceMaps() in packages/core/e2e/utils.ts still hard-codes vite as having no step source maps in any local environment, so the assertion expect(stack).not.toContain('99_e2e.ts') fails.
  • Fix: drop the vite-specific block in hasStepSourceMaps() entirely. Vite local dev now falls through to the default return true, while vite local prod is still caught by the existing !DEV_TEST_CONFIG guard further down — so local-prod behavior is unchanged.

Why this took 6 days to surface

  1. The push for [workflow] Bump Vite #1827 had Local Dev tests skipped due to matrix selection at the time.
  2. The next push (Lock next@canary test version #1860) introduced a CI env-var bug that prevented Local Dev tests from running at all.
  3. ci: fix VERCEL_WORKFLOW_SERVER_* env var ternary on main #1859 (28dc089e) fixed the env-var bug, finally letting vite local dev run — and it surfaced this assertion failure.

Reference failing run: https://github.com/vercel/workflow/actions/runs/25067758534/job/73444472541

Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
CopilotAI review requested due to automatic review settings April 28, 2026 18:49
@vercel

vercelBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 072a4d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production9780671045
✅ 💻 Local Development10540861140
✅ 📦 Local Production10540861140
✅ 🐘 Local Postgres10540861140
✅ 🪟 Windows950095
✅ 📋 Other267018285
Total450203434845

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8807
✅ example8807
✅ express8807
✅ fastify8807
✅ hono8807
✅ nextjs-turbopack9302
✅ nextjs-webpack9302
✅ nitro8807
✅ nuxt8807
✅ sveltekit8807
✅ vite8807
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9500
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8906
✅ e2e-local-postgres-nest-stable8906
✅ e2e-local-prod-nest-stable8906

📋 View full workflow run

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.040s (-9.3% 🟢)1.005s (~)0.965s101.00x
💻 LocalNitro0.046s (+6.7% 🔺)1.005s (~)0.959s101.14x
🐘 PostgresNitro0.049s (-48.3% 🟢)1.011s (-3.1%)0.961s101.22x
💻 LocalNext.js (Turbopack)0.051s1.005s0.954s101.27x
🐘 PostgresExpress0.053s (-8.4% 🟢)1.012s (~)0.959s101.32x
🐘 PostgresNext.js (Turbopack)0.057s1.009s0.952s101.42x
workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.120s2.005s0.886s101.00x
💻 LocalExpress1.127s (~)2.005s (~)0.878s101.01x
🐘 PostgresNitro1.128s (-1.1%)2.008s (~)0.880s101.01x
💻 LocalNitro1.137s (+0.5%)2.006s (~)0.869s101.02x
🐘 PostgresExpress1.144s (~)2.010s (~)0.867s101.02x
🐘 PostgresNext.js (Turbopack)1.150s2.012s0.862s101.03x
workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro10.770s (-0.9%)11.023s (~)0.253s31.00x
🐘 PostgresExpress10.787s (-1.6%)11.025s (~)0.238s31.00x
💻 LocalNext.js (Turbopack)10.789s11.024s0.235s31.00x
🐘 PostgresNext.js (Turbopack)10.879s11.025s0.146s31.01x
💻 LocalExpress10.922s (~)11.023s (~)0.100s31.01x
💻 LocalNitro10.955s (~)11.024s (~)0.069s31.02x
workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express14.344s (-1.6%)15.034s (~)0.691s41.00x
🐘 PostgresNext.js (Turbopack)14.467s15.023s0.556s41.01x
💻 LocalNext.js (Turbopack)14.720s15.030s0.310s41.03x
🐘 PostgresNitro14.789s (+1.3%)15.529s (+3.3%)0.740s41.03x
💻 LocalExpress14.980s (~)15.029s (~)0.049s41.04x
💻 LocalNitro15.104s (~)16.033s (~)0.929s41.05x
workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express13.522s (-3.5%)14.029s (-3.9%)0.507s71.00x
🐘 PostgresNext.js (Turbopack)13.921s14.022s0.101s71.03x
🐘 PostgresNitro14.610s (+4.6%)15.355s (+7.3% 🔺)0.745s61.08x
💻 LocalNext.js (Turbopack)16.229s17.032s0.803s61.20x
💻 LocalExpress16.828s (+1.4%)17.198s (+1.0%)0.370s61.24x
💻 LocalNitro16.921s (+0.8%)17.032s (~)0.111s61.25x
Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.203s (-5.6% 🟢)2.010s (~)0.807s151.00x
🐘 PostgresNext.js (Turbopack)1.233s2.010s0.777s151.03x
🐘 PostgresExpress1.234s (-2.1%)2.011s (~)0.777s151.03x
💻 LocalNext.js (Turbopack)1.509s2.006s0.497s151.25x
💻 LocalExpress1.526s (+2.5%)2.006s (~)0.480s151.27x
💻 LocalNitro1.561s (-4.3%)2.006s (-3.3%)0.445s151.30x
Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.304s (-2.0%)3.026s (+0.6%)0.722s101.00x
🐘 PostgresExpress2.376s (+0.6%)3.011s (~)0.635s101.03x
🐘 PostgresNext.js (Turbopack)2.406s3.009s0.603s101.04x
💻 LocalNext.js (Turbopack)2.809s3.454s0.645s91.22x
💻 LocalNitro3.045s (-3.1%)3.453s (-11.1% 🟢)0.407s91.32x
💻 LocalExpress3.066s (+3.8%)3.885s (+12.5% 🔺)0.819s81.33x
Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.494s (~)4.014s (~)0.520s81.00x
🐘 PostgresNitro3.496s (~)4.026s (~)0.530s81.00x
🐘 PostgresNext.js (Turbopack)3.682s4.011s0.329s81.05x
💻 LocalNext.js (Turbopack)7.885s8.519s0.634s42.26x
💻 LocalExpress8.294s (-0.5%)9.022s (~)0.728s42.37x
💻 LocalNitro9.038s (+8.2% 🔺)9.522s (+5.6% 🔺)0.485s42.59x
Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.206s (-4.0%)2.007s (~)0.801s151.00x
🐘 PostgresNext.js (Turbopack)1.239s2.010s0.771s151.03x
🐘 PostgresExpress1.247s (-0.8%)2.010s (~)0.763s151.03x
💻 LocalNext.js (Turbopack)1.520s2.006s0.486s151.26x
💻 LocalNitro1.566s (-16.1% 🟢)2.006s (-14.3% 🟢)0.440s151.30x
💻 LocalExpress1.678s (-11.4% 🟢)2.222s (-6.0% 🟢)0.544s141.39x
Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.270s (-3.0%)3.007s (~)0.737s101.00x
🐘 PostgresExpress2.342s (~)3.009s (~)0.667s101.03x
🐘 PostgresNext.js (Turbopack)2.402s3.010s0.608s101.06x
💻 LocalNext.js (Turbopack)2.983s3.760s0.776s81.31x
💻 LocalNitro3.004s (-2.0%)3.760s (-3.3%)0.756s81.32x
💻 LocalExpress3.144s (~)4.010s (+6.6% 🔺)0.866s81.39x
Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.416s (-1.9%)4.008s (~)0.593s81.00x
🐘 PostgresExpress3.448s (-1.5%)4.011s (~)0.563s81.01x
🐘 PostgresNext.js (Turbopack)3.649s4.014s0.365s81.07x
💻 LocalNext.js (Turbopack)8.305s9.021s0.716s42.43x
💻 LocalExpress8.866s (+0.7%)9.273s (~)0.406s42.60x
💻 LocalNitro9.213s (+0.8%)9.772s (-2.5%)0.559s42.70x
workflow with 10 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.714s (-15.0% 🟢)1.007s (-1.6%)0.293s601.00x
🐘 PostgresNext.js (Turbopack)0.781s1.006s0.226s601.09x
💻 LocalNext.js (Turbopack)0.890s1.039s0.149s581.25x
🐘 PostgresNitro0.982s (+19.7% 🔺)1.346s (+33.7% 🔺)0.363s451.38x
💻 LocalNitro1.014s (+3.4%)1.720s (+57.2% 🔺)0.706s351.42x
💻 LocalExpress1.128s (+14.6% 🔺)1.570s (+45.9% 🔺)0.442s391.58x
workflow with 25 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.698s (-14.1% 🟢)2.009s (-11.0% 🟢)0.311s451.00x
🐘 PostgresNitro1.728s (-10.3% 🟢)2.100s (~)0.372s431.02x
🐘 PostgresNext.js (Turbopack)1.932s2.173s0.241s421.14x
💻 LocalNext.js (Turbopack)2.943s3.223s0.280s281.73x
💻 LocalExpress3.035s (+0.6%)3.586s (~)0.550s261.79x
💻 LocalNitro3.041s (~)3.843s (+2.3%)0.803s241.79x
workflow with 50 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.431s (-16.4% 🟢)4.108s (-10.8% 🟢)0.678s301.00x
🐘 PostgresExpress3.498s (-12.3% 🟢)4.012s (-8.2% 🟢)0.514s301.02x
🐘 PostgresNext.js (Turbopack)3.864s4.045s0.181s301.13x
💻 LocalNext.js (Turbopack)8.870s9.161s0.291s142.59x
💻 LocalNitro9.175s (-1.3%)9.787s (-2.3%)0.613s132.67x
💻 LocalExpress9.295s (+0.9%)9.941s (-0.8%)0.646s132.71x
workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.244s (-13.9% 🟢)1.007s (~)0.764s601.00x
🐘 PostgresNext.js (Turbopack)0.248s1.007s0.759s601.02x
🐘 PostgresExpress0.261s (-7.6% 🟢)1.008s (~)0.747s601.07x
💻 LocalExpress0.595s (+6.1% 🔺)1.005s (~)0.410s602.44x
💻 LocalNitro0.599s (-1.0%)1.005s (-1.6%)0.406s602.46x
💻 LocalNext.js (Turbopack)0.607s1.022s0.415s592.49x
workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.409s (-19.7% 🟢)1.007s (~)0.598s901.00x
🐘 PostgresNitro0.426s (-14.1% 🟢)1.009s (~)0.583s901.04x
🐘 PostgresNext.js (Turbopack)0.504s1.007s0.503s901.23x
💻 LocalNitro2.548s (~)3.009s (~)0.461s306.23x
💻 LocalNext.js (Turbopack)2.681s3.009s0.328s306.55x
💻 LocalExpress2.844s (+13.1% 🔺)3.472s (+15.4% 🔺)0.629s266.95x
workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.654s (-20.1% 🟢)1.016s (~)0.362s1191.00x
🐘 PostgresNitro0.657s (-16.8% 🟢)1.054s (+4.7%)0.397s1141.01x
🐘 PostgresNext.js (Turbopack)0.820s1.016s0.196s1191.25x
💻 LocalNitro11.257s (+0.6%)11.938s (+2.3%)0.681s1117.21x
💻 LocalNext.js (Turbopack)11.270s11.847s0.577s1117.23x
💻 LocalExpress12.606s (+12.7% 🔺)13.033s (+9.1% 🔺)0.426s1019.28x
Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.180s1.002s0.013s1.019s0.839s101.00x
🐘 PostgresNext.js (Turbopack)0.198s1.000s0.001s1.010s0.812s101.10x
💻 LocalExpress0.201s (+0.8%)1.005s (~)0.012s (-0.8%)1.018s (~)0.818s101.12x
💻 LocalNitro0.209s (-2.2%)1.004s (~)0.013s (+3.2%)1.019s (~)0.810s101.16x
🐘 PostgresExpress0.255s (+24.3% 🔺)1.000s (~)0.045s (+2712.5% 🔺)1.056s (+4.4%)0.801s101.42x
🐘 PostgresNitro0.330s (+60.9% 🔺)1.008s (+0.8%)0.124s (+8166.7% 🔺)1.159s (+14.6% 🔺)0.829s101.84x
stream pipeline with 5 transform steps (1MB)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.585s (-6.3% 🟢)1.040s (+3.3%)0.032s (+667.7% 🔺)1.083s (+5.9% 🔺)0.499s561.00x
🐘 PostgresExpress0.600s (-4.7%)1.008s (~)0.005s (+32.7% 🔺)1.025s (~)0.425s591.03x
🐘 PostgresNext.js (Turbopack)0.650s1.026s0.007s1.042s0.392s581.11x
💻 LocalNext.js (Turbopack)0.680s1.011s0.009s1.023s0.343s591.16x
💻 LocalExpress0.825s (+8.9% 🔺)1.013s (-1.5%)0.015s (+59.3% 🔺)1.030s (-0.9%)0.206s591.41x
💻 LocalNitro0.847s (+0.9%)1.012s (~)0.010s (+4.2%)1.116s (~)0.269s541.45x
10 parallel streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Next.js (Turbopack)0.965s1.250s0.000s1.264s0.299s481.00x
🐘 PostgresExpress1.015s (+5.6% 🔺)1.463s (+14.5% 🔺)0.000s (-43.9% 🟢)1.478s (+13.1% 🔺)0.463s411.05x
🐘 PostgresNitro1.144s (+18.1% 🔺)1.461s (+17.1% 🔺)0.000s (-41.5% 🟢)1.481s (+17.7% 🔺)0.336s411.19x
💻 LocalNitro1.252s (+2.4%)2.022s (~)0.000s (+266.7% 🔺)2.024s (~)0.772s301.30x
💻 LocalNext.js (Turbopack)1.309s2.020s0.000s2.023s0.714s301.36x
💻 LocalExpress1.374s (+12.2% 🔺)2.022s (~)0.001s (+60.0% 🔺)2.025s (~)0.651s301.42x
fan-out fan-in 10 streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.888s (+6.5% 🔺)2.312s (+6.2% 🔺)0.000s (NaN%)2.331s (+6.0% 🔺)0.443s261.00x
🐘 PostgresNext.js (Turbopack)1.890s2.146s0.000s2.153s0.264s281.00x
🐘 PostgresNitro1.917s (+7.0% 🔺)2.465s (+15.1% 🔺)0.000s (-100.0% 🟢)2.532s (+16.4% 🔺)0.615s251.02x
💻 LocalNext.js (Turbopack)3.662s4.032s0.001s4.038s0.376s151.94x
💻 LocalNitro3.709s (+9.5% 🔺)4.234s (+5.0% 🔺)0.000s (-25.0% 🟢)4.236s (+5.0%)0.528s151.96x
💻 LocalExpress4.304s (+24.1% 🔺)4.423s (+9.7% 🔺)0.000s (-42.3% 🟢)4.812s (+19.2% 🔺)0.507s132.28x

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)16/21
🐘 PostgresNitro11/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres18/21
Next.js (Turbopack)🐘 Postgres17/21
Nitro🐘 Postgres19/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the e2e “step error preserves stack trace” assertions for Vite local dev after the Vite upgrade started preserving step bundle source maps in dev mode.

Changes:

  • Update hasStepSourceMaps() to allow Vite local dev to assert original source filenames in stacks (while keeping local prod behavior unchanged).
  • Add an (empty) changeset note documenting the Vite local-dev e2e fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/core/e2e/utils.tsRefines step sourcemap support matrix so Vite local dev no longer disables stack source assertions.
.changeset/fix-vite-step-source-maps-e2e.mdDocuments the reason for the Vite local-dev e2e assertion change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/e2e/utils.ts Outdated
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
@TooTallNate
TooTallNate enabled auto-merge (squash) April 28, 2026 19:13
@TooTallNate
TooTallNate merged commit d6f7eb6 into mainApr 28, 2026
154 of 163 checks passed
@TooTallNate
TooTallNate deleted the fix/vite-step-source-maps-e2e branch April 28, 2026 19:26
ijjk pushed a commit that referenced this pull request Apr 28, 2026
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
TooTallNate added a commit that referenced this pull request May 4, 2026
…al dev (#1919)
* Bump vite (#1827)
* test: enable step source-map assertions for vite local dev (#1862)
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
---------
Co-authored-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test: enable step source-map assertions for vite local dev - #1862

Merged
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e
Apr 28, 2026
Merged

test: enable step source-map assertions for vite local dev#1862
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Vite local-dev e2e tests basic step error preserves message and stack trace and cross-file step error preserves message and function names in stack have been failing consistently since #1827 bumped workbench/vite from vite@^7.1.12 to vite@^7.3.2.
  • The newer vite preserves step bundle source maps in dev mode, so stack traces now point at original files (99_e2e.ts, helpers.ts). However, hasStepSourceMaps() in packages/core/e2e/utils.ts still hard-codes vite as having no step source maps in any local environment, so the assertion expect(stack).not.toContain('99_e2e.ts') fails.
  • Fix: drop the vite-specific block in hasStepSourceMaps() entirely. Vite local dev now falls through to the default return true, while vite local prod is still caught by the existing !DEV_TEST_CONFIG guard further down — so local-prod behavior is unchanged.

Why this took 6 days to surface

  1. The push for [workflow] Bump Vite #1827 had Local Dev tests skipped due to matrix selection at the time.
  2. The next push (Lock next@canary test version #1860) introduced a CI env-var bug that prevented Local Dev tests from running at all.
  3. ci: fix VERCEL_WORKFLOW_SERVER_* env var ternary on main #1859 (28dc089e) fixed the env-var bug, finally letting vite local dev run — and it surfaced this assertion failure.

Reference failing run: https://github.com/vercel/workflow/actions/runs/25067758534/job/73444472541

Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
CopilotAI review requested due to automatic review settings April 28, 2026 18:49
@vercel

vercelBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 072a4d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production9780671045
✅ 💻 Local Development10540861140
✅ 📦 Local Production10540861140
✅ 🐘 Local Postgres10540861140
✅ 🪟 Windows950095
✅ 📋 Other267018285
Total450203434845

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8807
✅ example8807
✅ express8807
✅ fastify8807
✅ hono8807
✅ nextjs-turbopack9302
✅ nextjs-webpack9302
✅ nitro8807
✅ nuxt8807
✅ sveltekit8807
✅ vite8807
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9500
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8906
✅ e2e-local-postgres-nest-stable8906
✅ e2e-local-prod-nest-stable8906

📋 View full workflow run

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.040s (-9.3% 🟢)1.005s (~)0.965s101.00x
💻 LocalNitro0.046s (+6.7% 🔺)1.005s (~)0.959s101.14x
🐘 PostgresNitro0.049s (-48.3% 🟢)1.011s (-3.1%)0.961s101.22x
💻 LocalNext.js (Turbopack)0.051s1.005s0.954s101.27x
🐘 PostgresExpress0.053s (-8.4% 🟢)1.012s (~)0.959s101.32x
🐘 PostgresNext.js (Turbopack)0.057s1.009s0.952s101.42x
workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.120s2.005s0.886s101.00x
💻 LocalExpress1.127s (~)2.005s (~)0.878s101.01x
🐘 PostgresNitro1.128s (-1.1%)2.008s (~)0.880s101.01x
💻 LocalNitro1.137s (+0.5%)2.006s (~)0.869s101.02x
🐘 PostgresExpress1.144s (~)2.010s (~)0.867s101.02x
🐘 PostgresNext.js (Turbopack)1.150s2.012s0.862s101.03x
workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro10.770s (-0.9%)11.023s (~)0.253s31.00x
🐘 PostgresExpress10.787s (-1.6%)11.025s (~)0.238s31.00x
💻 LocalNext.js (Turbopack)10.789s11.024s0.235s31.00x
🐘 PostgresNext.js (Turbopack)10.879s11.025s0.146s31.01x
💻 LocalExpress10.922s (~)11.023s (~)0.100s31.01x
💻 LocalNitro10.955s (~)11.024s (~)0.069s31.02x
workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express14.344s (-1.6%)15.034s (~)0.691s41.00x
🐘 PostgresNext.js (Turbopack)14.467s15.023s0.556s41.01x
💻 LocalNext.js (Turbopack)14.720s15.030s0.310s41.03x
🐘 PostgresNitro14.789s (+1.3%)15.529s (+3.3%)0.740s41.03x
💻 LocalExpress14.980s (~)15.029s (~)0.049s41.04x
💻 LocalNitro15.104s (~)16.033s (~)0.929s41.05x
workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express13.522s (-3.5%)14.029s (-3.9%)0.507s71.00x
🐘 PostgresNext.js (Turbopack)13.921s14.022s0.101s71.03x
🐘 PostgresNitro14.610s (+4.6%)15.355s (+7.3% 🔺)0.745s61.08x
💻 LocalNext.js (Turbopack)16.229s17.032s0.803s61.20x
💻 LocalExpress16.828s (+1.4%)17.198s (+1.0%)0.370s61.24x
💻 LocalNitro16.921s (+0.8%)17.032s (~)0.111s61.25x
Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.203s (-5.6% 🟢)2.010s (~)0.807s151.00x
🐘 PostgresNext.js (Turbopack)1.233s2.010s0.777s151.03x
🐘 PostgresExpress1.234s (-2.1%)2.011s (~)0.777s151.03x
💻 LocalNext.js (Turbopack)1.509s2.006s0.497s151.25x
💻 LocalExpress1.526s (+2.5%)2.006s (~)0.480s151.27x
💻 LocalNitro1.561s (-4.3%)2.006s (-3.3%)0.445s151.30x
Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.304s (-2.0%)3.026s (+0.6%)0.722s101.00x
🐘 PostgresExpress2.376s (+0.6%)3.011s (~)0.635s101.03x
🐘 PostgresNext.js (Turbopack)2.406s3.009s0.603s101.04x
💻 LocalNext.js (Turbopack)2.809s3.454s0.645s91.22x
💻 LocalNitro3.045s (-3.1%)3.453s (-11.1% 🟢)0.407s91.32x
💻 LocalExpress3.066s (+3.8%)3.885s (+12.5% 🔺)0.819s81.33x
Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.494s (~)4.014s (~)0.520s81.00x
🐘 PostgresNitro3.496s (~)4.026s (~)0.530s81.00x
🐘 PostgresNext.js (Turbopack)3.682s4.011s0.329s81.05x
💻 LocalNext.js (Turbopack)7.885s8.519s0.634s42.26x
💻 LocalExpress8.294s (-0.5%)9.022s (~)0.728s42.37x
💻 LocalNitro9.038s (+8.2% 🔺)9.522s (+5.6% 🔺)0.485s42.59x
Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.206s (-4.0%)2.007s (~)0.801s151.00x
🐘 PostgresNext.js (Turbopack)1.239s2.010s0.771s151.03x
🐘 PostgresExpress1.247s (-0.8%)2.010s (~)0.763s151.03x
💻 LocalNext.js (Turbopack)1.520s2.006s0.486s151.26x
💻 LocalNitro1.566s (-16.1% 🟢)2.006s (-14.3% 🟢)0.440s151.30x
💻 LocalExpress1.678s (-11.4% 🟢)2.222s (-6.0% 🟢)0.544s141.39x
Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.270s (-3.0%)3.007s (~)0.737s101.00x
🐘 PostgresExpress2.342s (~)3.009s (~)0.667s101.03x
🐘 PostgresNext.js (Turbopack)2.402s3.010s0.608s101.06x
💻 LocalNext.js (Turbopack)2.983s3.760s0.776s81.31x
💻 LocalNitro3.004s (-2.0%)3.760s (-3.3%)0.756s81.32x
💻 LocalExpress3.144s (~)4.010s (+6.6% 🔺)0.866s81.39x
Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.416s (-1.9%)4.008s (~)0.593s81.00x
🐘 PostgresExpress3.448s (-1.5%)4.011s (~)0.563s81.01x
🐘 PostgresNext.js (Turbopack)3.649s4.014s0.365s81.07x
💻 LocalNext.js (Turbopack)8.305s9.021s0.716s42.43x
💻 LocalExpress8.866s (+0.7%)9.273s (~)0.406s42.60x
💻 LocalNitro9.213s (+0.8%)9.772s (-2.5%)0.559s42.70x
workflow with 10 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.714s (-15.0% 🟢)1.007s (-1.6%)0.293s601.00x
🐘 PostgresNext.js (Turbopack)0.781s1.006s0.226s601.09x
💻 LocalNext.js (Turbopack)0.890s1.039s0.149s581.25x
🐘 PostgresNitro0.982s (+19.7% 🔺)1.346s (+33.7% 🔺)0.363s451.38x
💻 LocalNitro1.014s (+3.4%)1.720s (+57.2% 🔺)0.706s351.42x
💻 LocalExpress1.128s (+14.6% 🔺)1.570s (+45.9% 🔺)0.442s391.58x
workflow with 25 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.698s (-14.1% 🟢)2.009s (-11.0% 🟢)0.311s451.00x
🐘 PostgresNitro1.728s (-10.3% 🟢)2.100s (~)0.372s431.02x
🐘 PostgresNext.js (Turbopack)1.932s2.173s0.241s421.14x
💻 LocalNext.js (Turbopack)2.943s3.223s0.280s281.73x
💻 LocalExpress3.035s (+0.6%)3.586s (~)0.550s261.79x
💻 LocalNitro3.041s (~)3.843s (+2.3%)0.803s241.79x
workflow with 50 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.431s (-16.4% 🟢)4.108s (-10.8% 🟢)0.678s301.00x
🐘 PostgresExpress3.498s (-12.3% 🟢)4.012s (-8.2% 🟢)0.514s301.02x
🐘 PostgresNext.js (Turbopack)3.864s4.045s0.181s301.13x
💻 LocalNext.js (Turbopack)8.870s9.161s0.291s142.59x
💻 LocalNitro9.175s (-1.3%)9.787s (-2.3%)0.613s132.67x
💻 LocalExpress9.295s (+0.9%)9.941s (-0.8%)0.646s132.71x
workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.244s (-13.9% 🟢)1.007s (~)0.764s601.00x
🐘 PostgresNext.js (Turbopack)0.248s1.007s0.759s601.02x
🐘 PostgresExpress0.261s (-7.6% 🟢)1.008s (~)0.747s601.07x
💻 LocalExpress0.595s (+6.1% 🔺)1.005s (~)0.410s602.44x
💻 LocalNitro0.599s (-1.0%)1.005s (-1.6%)0.406s602.46x
💻 LocalNext.js (Turbopack)0.607s1.022s0.415s592.49x
workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.409s (-19.7% 🟢)1.007s (~)0.598s901.00x
🐘 PostgresNitro0.426s (-14.1% 🟢)1.009s (~)0.583s901.04x
🐘 PostgresNext.js (Turbopack)0.504s1.007s0.503s901.23x
💻 LocalNitro2.548s (~)3.009s (~)0.461s306.23x
💻 LocalNext.js (Turbopack)2.681s3.009s0.328s306.55x
💻 LocalExpress2.844s (+13.1% 🔺)3.472s (+15.4% 🔺)0.629s266.95x
workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.654s (-20.1% 🟢)1.016s (~)0.362s1191.00x
🐘 PostgresNitro0.657s (-16.8% 🟢)1.054s (+4.7%)0.397s1141.01x
🐘 PostgresNext.js (Turbopack)0.820s1.016s0.196s1191.25x
💻 LocalNitro11.257s (+0.6%)11.938s (+2.3%)0.681s1117.21x
💻 LocalNext.js (Turbopack)11.270s11.847s0.577s1117.23x
💻 LocalExpress12.606s (+12.7% 🔺)13.033s (+9.1% 🔺)0.426s1019.28x
Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.180s1.002s0.013s1.019s0.839s101.00x
🐘 PostgresNext.js (Turbopack)0.198s1.000s0.001s1.010s0.812s101.10x
💻 LocalExpress0.201s (+0.8%)1.005s (~)0.012s (-0.8%)1.018s (~)0.818s101.12x
💻 LocalNitro0.209s (-2.2%)1.004s (~)0.013s (+3.2%)1.019s (~)0.810s101.16x
🐘 PostgresExpress0.255s (+24.3% 🔺)1.000s (~)0.045s (+2712.5% 🔺)1.056s (+4.4%)0.801s101.42x
🐘 PostgresNitro0.330s (+60.9% 🔺)1.008s (+0.8%)0.124s (+8166.7% 🔺)1.159s (+14.6% 🔺)0.829s101.84x
stream pipeline with 5 transform steps (1MB)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.585s (-6.3% 🟢)1.040s (+3.3%)0.032s (+667.7% 🔺)1.083s (+5.9% 🔺)0.499s561.00x
🐘 PostgresExpress0.600s (-4.7%)1.008s (~)0.005s (+32.7% 🔺)1.025s (~)0.425s591.03x
🐘 PostgresNext.js (Turbopack)0.650s1.026s0.007s1.042s0.392s581.11x
💻 LocalNext.js (Turbopack)0.680s1.011s0.009s1.023s0.343s591.16x
💻 LocalExpress0.825s (+8.9% 🔺)1.013s (-1.5%)0.015s (+59.3% 🔺)1.030s (-0.9%)0.206s591.41x
💻 LocalNitro0.847s (+0.9%)1.012s (~)0.010s (+4.2%)1.116s (~)0.269s541.45x
10 parallel streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Next.js (Turbopack)0.965s1.250s0.000s1.264s0.299s481.00x
🐘 PostgresExpress1.015s (+5.6% 🔺)1.463s (+14.5% 🔺)0.000s (-43.9% 🟢)1.478s (+13.1% 🔺)0.463s411.05x
🐘 PostgresNitro1.144s (+18.1% 🔺)1.461s (+17.1% 🔺)0.000s (-41.5% 🟢)1.481s (+17.7% 🔺)0.336s411.19x
💻 LocalNitro1.252s (+2.4%)2.022s (~)0.000s (+266.7% 🔺)2.024s (~)0.772s301.30x
💻 LocalNext.js (Turbopack)1.309s2.020s0.000s2.023s0.714s301.36x
💻 LocalExpress1.374s (+12.2% 🔺)2.022s (~)0.001s (+60.0% 🔺)2.025s (~)0.651s301.42x
fan-out fan-in 10 streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.888s (+6.5% 🔺)2.312s (+6.2% 🔺)0.000s (NaN%)2.331s (+6.0% 🔺)0.443s261.00x
🐘 PostgresNext.js (Turbopack)1.890s2.146s0.000s2.153s0.264s281.00x
🐘 PostgresNitro1.917s (+7.0% 🔺)2.465s (+15.1% 🔺)0.000s (-100.0% 🟢)2.532s (+16.4% 🔺)0.615s251.02x
💻 LocalNext.js (Turbopack)3.662s4.032s0.001s4.038s0.376s151.94x
💻 LocalNitro3.709s (+9.5% 🔺)4.234s (+5.0% 🔺)0.000s (-25.0% 🟢)4.236s (+5.0%)0.528s151.96x
💻 LocalExpress4.304s (+24.1% 🔺)4.423s (+9.7% 🔺)0.000s (-42.3% 🟢)4.812s (+19.2% 🔺)0.507s132.28x

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)16/21
🐘 PostgresNitro11/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres18/21
Next.js (Turbopack)🐘 Postgres17/21
Nitro🐘 Postgres19/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the e2e “step error preserves stack trace” assertions for Vite local dev after the Vite upgrade started preserving step bundle source maps in dev mode.

Changes:

  • Update hasStepSourceMaps() to allow Vite local dev to assert original source filenames in stacks (while keeping local prod behavior unchanged).
  • Add an (empty) changeset note documenting the Vite local-dev e2e fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/core/e2e/utils.tsRefines step sourcemap support matrix so Vite local dev no longer disables stack source assertions.
.changeset/fix-vite-step-source-maps-e2e.mdDocuments the reason for the Vite local-dev e2e assertion change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/e2e/utils.ts Outdated
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
@TooTallNate
TooTallNate enabled auto-merge (squash) April 28, 2026 19:13
@TooTallNate
TooTallNate merged commit d6f7eb6 into mainApr 28, 2026
154 of 163 checks passed
@TooTallNate
TooTallNate deleted the fix/vite-step-source-maps-e2e branch April 28, 2026 19:26
ijjk pushed a commit that referenced this pull request Apr 28, 2026
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
TooTallNate added a commit that referenced this pull request May 4, 2026
…al dev (#1919)
* Bump vite (#1827)
* test: enable step source-map assertions for vite local dev (#1862)
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
---------
Co-authored-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test: enable step source-map assertions for vite local dev - #1862

Merged
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e
Apr 28, 2026
Merged

test: enable step source-map assertions for vite local dev#1862
TooTallNate merged 3 commits into
mainfrom
fix/vite-step-source-maps-e2e

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Vite local-dev e2e tests basic step error preserves message and stack trace and cross-file step error preserves message and function names in stack have been failing consistently since #1827 bumped workbench/vite from vite@^7.1.12 to vite@^7.3.2.
  • The newer vite preserves step bundle source maps in dev mode, so stack traces now point at original files (99_e2e.ts, helpers.ts). However, hasStepSourceMaps() in packages/core/e2e/utils.ts still hard-codes vite as having no step source maps in any local environment, so the assertion expect(stack).not.toContain('99_e2e.ts') fails.
  • Fix: drop the vite-specific block in hasStepSourceMaps() entirely. Vite local dev now falls through to the default return true, while vite local prod is still caught by the existing !DEV_TEST_CONFIG guard further down — so local-prod behavior is unchanged.

Why this took 6 days to surface

  1. The push for [workflow] Bump Vite #1827 had Local Dev tests skipped due to matrix selection at the time.
  2. The next push (Lock next@canary test version #1860) introduced a CI env-var bug that prevented Local Dev tests from running at all.
  3. ci: fix VERCEL_WORKFLOW_SERVER_* env var ternary on main #1859 (28dc089e) fixed the env-var bug, finally letting vite local dev run — and it surfaced this assertion failure.

Reference failing run: https://github.com/vercel/workflow/actions/runs/25067758534/job/73444472541

Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
CopilotAI review requested due to automatic review settings April 28, 2026 18:49
@vercel

vercelBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Apr 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 072a4d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production9780671045
✅ 💻 Local Development10540861140
✅ 📦 Local Production10540861140
✅ 🐘 Local Postgres10540861140
✅ 🪟 Windows950095
✅ 📋 Other267018285
Total450203434845

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8807
✅ example8807
✅ express8807
✅ fastify8807
✅ hono8807
✅ nextjs-turbopack9302
✅ nextjs-webpack9302
✅ nitro8807
✅ nuxt8807
✅ sveltekit8807
✅ vite8807
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8906
✅ express-stable8906
✅ fastify-stable8906
✅ hono-stable8906
✅ nextjs-turbopack-canary76019
✅ nextjs-turbopack-stable9500
✅ nextjs-webpack-canary76019
✅ nextjs-webpack-stable9500
✅ nitro-stable8906
✅ nuxt-stable8906
✅ sveltekit-stable8906
✅ vite-stable8906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9500
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8906
✅ e2e-local-postgres-nest-stable8906
✅ e2e-local-prod-nest-stable8906

📋 View full workflow run

@github-actions

github-actionsBot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.040s (-9.3% 🟢)1.005s (~)0.965s101.00x
💻 LocalNitro0.046s (+6.7% 🔺)1.005s (~)0.959s101.14x
🐘 PostgresNitro0.049s (-48.3% 🟢)1.011s (-3.1%)0.961s101.22x
💻 LocalNext.js (Turbopack)0.051s1.005s0.954s101.27x
🐘 PostgresExpress0.053s (-8.4% 🟢)1.012s (~)0.959s101.32x
🐘 PostgresNext.js (Turbopack)0.057s1.009s0.952s101.42x
workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.120s2.005s0.886s101.00x
💻 LocalExpress1.127s (~)2.005s (~)0.878s101.01x
🐘 PostgresNitro1.128s (-1.1%)2.008s (~)0.880s101.01x
💻 LocalNitro1.137s (+0.5%)2.006s (~)0.869s101.02x
🐘 PostgresExpress1.144s (~)2.010s (~)0.867s101.02x
🐘 PostgresNext.js (Turbopack)1.150s2.012s0.862s101.03x
workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro10.770s (-0.9%)11.023s (~)0.253s31.00x
🐘 PostgresExpress10.787s (-1.6%)11.025s (~)0.238s31.00x
💻 LocalNext.js (Turbopack)10.789s11.024s0.235s31.00x
🐘 PostgresNext.js (Turbopack)10.879s11.025s0.146s31.01x
💻 LocalExpress10.922s (~)11.023s (~)0.100s31.01x
💻 LocalNitro10.955s (~)11.024s (~)0.069s31.02x
workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express14.344s (-1.6%)15.034s (~)0.691s41.00x
🐘 PostgresNext.js (Turbopack)14.467s15.023s0.556s41.01x
💻 LocalNext.js (Turbopack)14.720s15.030s0.310s41.03x
🐘 PostgresNitro14.789s (+1.3%)15.529s (+3.3%)0.740s41.03x
💻 LocalExpress14.980s (~)15.029s (~)0.049s41.04x
💻 LocalNitro15.104s (~)16.033s (~)0.929s41.05x
workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express13.522s (-3.5%)14.029s (-3.9%)0.507s71.00x
🐘 PostgresNext.js (Turbopack)13.921s14.022s0.101s71.03x
🐘 PostgresNitro14.610s (+4.6%)15.355s (+7.3% 🔺)0.745s61.08x
💻 LocalNext.js (Turbopack)16.229s17.032s0.803s61.20x
💻 LocalExpress16.828s (+1.4%)17.198s (+1.0%)0.370s61.24x
💻 LocalNitro16.921s (+0.8%)17.032s (~)0.111s61.25x
Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.203s (-5.6% 🟢)2.010s (~)0.807s151.00x
🐘 PostgresNext.js (Turbopack)1.233s2.010s0.777s151.03x
🐘 PostgresExpress1.234s (-2.1%)2.011s (~)0.777s151.03x
💻 LocalNext.js (Turbopack)1.509s2.006s0.497s151.25x
💻 LocalExpress1.526s (+2.5%)2.006s (~)0.480s151.27x
💻 LocalNitro1.561s (-4.3%)2.006s (-3.3%)0.445s151.30x
Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.304s (-2.0%)3.026s (+0.6%)0.722s101.00x
🐘 PostgresExpress2.376s (+0.6%)3.011s (~)0.635s101.03x
🐘 PostgresNext.js (Turbopack)2.406s3.009s0.603s101.04x
💻 LocalNext.js (Turbopack)2.809s3.454s0.645s91.22x
💻 LocalNitro3.045s (-3.1%)3.453s (-11.1% 🟢)0.407s91.32x
💻 LocalExpress3.066s (+3.8%)3.885s (+12.5% 🔺)0.819s81.33x
Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.494s (~)4.014s (~)0.520s81.00x
🐘 PostgresNitro3.496s (~)4.026s (~)0.530s81.00x
🐘 PostgresNext.js (Turbopack)3.682s4.011s0.329s81.05x
💻 LocalNext.js (Turbopack)7.885s8.519s0.634s42.26x
💻 LocalExpress8.294s (-0.5%)9.022s (~)0.728s42.37x
💻 LocalNitro9.038s (+8.2% 🔺)9.522s (+5.6% 🔺)0.485s42.59x
Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.206s (-4.0%)2.007s (~)0.801s151.00x
🐘 PostgresNext.js (Turbopack)1.239s2.010s0.771s151.03x
🐘 PostgresExpress1.247s (-0.8%)2.010s (~)0.763s151.03x
💻 LocalNext.js (Turbopack)1.520s2.006s0.486s151.26x
💻 LocalNitro1.566s (-16.1% 🟢)2.006s (-14.3% 🟢)0.440s151.30x
💻 LocalExpress1.678s (-11.4% 🟢)2.222s (-6.0% 🟢)0.544s141.39x
Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro2.270s (-3.0%)3.007s (~)0.737s101.00x
🐘 PostgresExpress2.342s (~)3.009s (~)0.667s101.03x
🐘 PostgresNext.js (Turbopack)2.402s3.010s0.608s101.06x
💻 LocalNext.js (Turbopack)2.983s3.760s0.776s81.31x
💻 LocalNitro3.004s (-2.0%)3.760s (-3.3%)0.756s81.32x
💻 LocalExpress3.144s (~)4.010s (+6.6% 🔺)0.866s81.39x
Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.416s (-1.9%)4.008s (~)0.593s81.00x
🐘 PostgresExpress3.448s (-1.5%)4.011s (~)0.563s81.01x
🐘 PostgresNext.js (Turbopack)3.649s4.014s0.365s81.07x
💻 LocalNext.js (Turbopack)8.305s9.021s0.716s42.43x
💻 LocalExpress8.866s (+0.7%)9.273s (~)0.406s42.60x
💻 LocalNitro9.213s (+0.8%)9.772s (-2.5%)0.559s42.70x
workflow with 10 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.714s (-15.0% 🟢)1.007s (-1.6%)0.293s601.00x
🐘 PostgresNext.js (Turbopack)0.781s1.006s0.226s601.09x
💻 LocalNext.js (Turbopack)0.890s1.039s0.149s581.25x
🐘 PostgresNitro0.982s (+19.7% 🔺)1.346s (+33.7% 🔺)0.363s451.38x
💻 LocalNitro1.014s (+3.4%)1.720s (+57.2% 🔺)0.706s351.42x
💻 LocalExpress1.128s (+14.6% 🔺)1.570s (+45.9% 🔺)0.442s391.58x
workflow with 25 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.698s (-14.1% 🟢)2.009s (-11.0% 🟢)0.311s451.00x
🐘 PostgresNitro1.728s (-10.3% 🟢)2.100s (~)0.372s431.02x
🐘 PostgresNext.js (Turbopack)1.932s2.173s0.241s421.14x
💻 LocalNext.js (Turbopack)2.943s3.223s0.280s281.73x
💻 LocalExpress3.035s (+0.6%)3.586s (~)0.550s261.79x
💻 LocalNitro3.041s (~)3.843s (+2.3%)0.803s241.79x
workflow with 50 sequential data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.431s (-16.4% 🟢)4.108s (-10.8% 🟢)0.678s301.00x
🐘 PostgresExpress3.498s (-12.3% 🟢)4.012s (-8.2% 🟢)0.514s301.02x
🐘 PostgresNext.js (Turbopack)3.864s4.045s0.181s301.13x
💻 LocalNext.js (Turbopack)8.870s9.161s0.291s142.59x
💻 LocalNitro9.175s (-1.3%)9.787s (-2.3%)0.613s132.67x
💻 LocalExpress9.295s (+0.9%)9.941s (-0.8%)0.646s132.71x
workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.244s (-13.9% 🟢)1.007s (~)0.764s601.00x
🐘 PostgresNext.js (Turbopack)0.248s1.007s0.759s601.02x
🐘 PostgresExpress0.261s (-7.6% 🟢)1.008s (~)0.747s601.07x
💻 LocalExpress0.595s (+6.1% 🔺)1.005s (~)0.410s602.44x
💻 LocalNitro0.599s (-1.0%)1.005s (-1.6%)0.406s602.46x
💻 LocalNext.js (Turbopack)0.607s1.022s0.415s592.49x
workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.409s (-19.7% 🟢)1.007s (~)0.598s901.00x
🐘 PostgresNitro0.426s (-14.1% 🟢)1.009s (~)0.583s901.04x
🐘 PostgresNext.js (Turbopack)0.504s1.007s0.503s901.23x
💻 LocalNitro2.548s (~)3.009s (~)0.461s306.23x
💻 LocalNext.js (Turbopack)2.681s3.009s0.328s306.55x
💻 LocalExpress2.844s (+13.1% 🔺)3.472s (+15.4% 🔺)0.629s266.95x
workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express0.654s (-20.1% 🟢)1.016s (~)0.362s1191.00x
🐘 PostgresNitro0.657s (-16.8% 🟢)1.054s (+4.7%)0.397s1141.01x
🐘 PostgresNext.js (Turbopack)0.820s1.016s0.196s1191.25x
💻 LocalNitro11.257s (+0.6%)11.938s (+2.3%)0.681s1117.21x
💻 LocalNext.js (Turbopack)11.270s11.847s0.577s1117.23x
💻 LocalExpress12.606s (+12.7% 🔺)13.033s (+9.1% 🔺)0.426s1019.28x
Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.180s1.002s0.013s1.019s0.839s101.00x
🐘 PostgresNext.js (Turbopack)0.198s1.000s0.001s1.010s0.812s101.10x
💻 LocalExpress0.201s (+0.8%)1.005s (~)0.012s (-0.8%)1.018s (~)0.818s101.12x
💻 LocalNitro0.209s (-2.2%)1.004s (~)0.013s (+3.2%)1.019s (~)0.810s101.16x
🐘 PostgresExpress0.255s (+24.3% 🔺)1.000s (~)0.045s (+2712.5% 🔺)1.056s (+4.4%)0.801s101.42x
🐘 PostgresNitro0.330s (+60.9% 🔺)1.008s (+0.8%)0.124s (+8166.7% 🔺)1.159s (+14.6% 🔺)0.829s101.84x
stream pipeline with 5 transform steps (1MB)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro0.585s (-6.3% 🟢)1.040s (+3.3%)0.032s (+667.7% 🔺)1.083s (+5.9% 🔺)0.499s561.00x
🐘 PostgresExpress0.600s (-4.7%)1.008s (~)0.005s (+32.7% 🔺)1.025s (~)0.425s591.03x
🐘 PostgresNext.js (Turbopack)0.650s1.026s0.007s1.042s0.392s581.11x
💻 LocalNext.js (Turbopack)0.680s1.011s0.009s1.023s0.343s591.16x
💻 LocalExpress0.825s (+8.9% 🔺)1.013s (-1.5%)0.015s (+59.3% 🔺)1.030s (-0.9%)0.206s591.41x
💻 LocalNitro0.847s (+0.9%)1.012s (~)0.010s (+4.2%)1.116s (~)0.269s541.45x
10 parallel streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Next.js (Turbopack)0.965s1.250s0.000s1.264s0.299s481.00x
🐘 PostgresExpress1.015s (+5.6% 🔺)1.463s (+14.5% 🔺)0.000s (-43.9% 🟢)1.478s (+13.1% 🔺)0.463s411.05x
🐘 PostgresNitro1.144s (+18.1% 🔺)1.461s (+17.1% 🔺)0.000s (-41.5% 🟢)1.481s (+17.7% 🔺)0.336s411.19x
💻 LocalNitro1.252s (+2.4%)2.022s (~)0.000s (+266.7% 🔺)2.024s (~)0.772s301.30x
💻 LocalNext.js (Turbopack)1.309s2.020s0.000s2.023s0.714s301.36x
💻 LocalExpress1.374s (+12.2% 🔺)2.022s (~)0.001s (+60.0% 🔺)2.025s (~)0.651s301.42x
fan-out fan-in 10 streams (1MB each)

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express1.888s (+6.5% 🔺)2.312s (+6.2% 🔺)0.000s (NaN%)2.331s (+6.0% 🔺)0.443s261.00x
🐘 PostgresNext.js (Turbopack)1.890s2.146s0.000s2.153s0.264s281.00x
🐘 PostgresNitro1.917s (+7.0% 🔺)2.465s (+15.1% 🔺)0.000s (-100.0% 🟢)2.532s (+16.4% 🔺)0.615s251.02x
💻 LocalNext.js (Turbopack)3.662s4.032s0.001s4.038s0.376s151.94x
💻 LocalNitro3.709s (+9.5% 🔺)4.234s (+5.0% 🔺)0.000s (-25.0% 🟢)4.236s (+5.0%)0.528s151.96x
💻 LocalExpress4.304s (+24.1% 🔺)4.423s (+9.7% 🔺)0.000s (-42.3% 🟢)4.812s (+19.2% 🔺)0.507s132.28x

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)16/21
🐘 PostgresNitro11/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres18/21
Next.js (Turbopack)🐘 Postgres17/21
Nitro🐘 Postgres19/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the e2e “step error preserves stack trace” assertions for Vite local dev after the Vite upgrade started preserving step bundle source maps in dev mode.

Changes:

  • Update hasStepSourceMaps() to allow Vite local dev to assert original source filenames in stacks (while keeping local prod behavior unchanged).
  • Add an (empty) changeset note documenting the Vite local-dev e2e fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
packages/core/e2e/utils.tsRefines step sourcemap support matrix so Vite local dev no longer disables stack source assertions.
.changeset/fix-vite-step-source-maps-e2e.mdDocuments the reason for the Vite local-dev e2e assertion change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/e2e/utils.ts Outdated
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
@TooTallNate
TooTallNate enabled auto-merge (squash) April 28, 2026 19:13
@TooTallNate
TooTallNate merged commit d6f7eb6 into mainApr 28, 2026
154 of 163 checks passed
@TooTallNate
TooTallNate deleted the fix/vite-step-source-maps-e2e branch April 28, 2026 19:26
ijjk pushed a commit that referenced this pull request Apr 28, 2026
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
TooTallNate added a commit that referenced this pull request May 4, 2026
…al dev (#1919)
* Bump vite (#1827)
* test: enable step source-map assertions for vite local dev (#1862)
* test: enable step source-map assertions for vite local dev
Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in
dev mode, so stack traces now contain original file paths. Update
hasStepSourceMaps() so vite returns true in local dev and stays false
only in local prod, fixing the consistently failing 'basic step error'
and 'cross-file step error' e2e tests.
* chore: drop body from empty changeset
* address review: drop redundant vite local-prod guard
The default `!DEV_TEST_CONFIG` fall-through already returns false for
vite local prod, so the vite-specific guard is dead code. Just remove
the vite block entirely now that vite local dev matches the default
'has source maps' behavior.
---------
Co-authored-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3