Uh oh!
There was an error while loading. Please reload this page.
[backport] Bump vite + enable step source-map assertions for vite local dev - #1919
Merged
Merged
Conversation
* test: enable step source-map assertions for vite local dev Vite ^7.3.2 (bumped in #1827) preserves step bundle source maps in dev mode, so stack traces now contain original file paths. Update hasStepSourceMaps() so vite returns true in local dev and stays false only in local prod, fixing the consistently failing 'basic step error' and 'cross-file step error' e2e tests. * chore: drop body from empty changeset * address review: drop redundant vite local-prod guard The default `!DEV_TEST_CONFIG` fall-through already returns false for vite local prod, so the vite-specific guard is dead code. Just remove the vite block entirely now that vite local dev matches the default 'has source maps' behavior.
🦋 Changeset detectedLatest commit: 6a0e4e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests💻 Local Development (246 failed)express-stable (82 failed):
fastify-stable (82 failed):
hono-stable (82 failed):
🌍 Community Worlds (83 failed)mongodb (11 failed):
redis (7 failed):
turso (65 failed):
Details by Category✅ ▲ Vercel Production
❌ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the main-branch fix for failing stable E2E “vite local dev” tests by aligning the step source-map expectation logic with Vite’s current dev-mode behavior, alongside bumping Vite to the intended version across workbenches.
Changes:
- Bump
viteto^7.3.2in the Vite and SvelteKit workbenches and updatepnpm-lock.yamlaccordingly. - Update
hasStepSourceMaps()to no longer treatviteas a special case (so vite local-dev participates in step source-map assertions whenDEV_TEST_CONFIGis set). - Add an empty changeset entry (test-only/backport bookkeeping).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workbench/vite/package.json | Bumps Vite devDependency to ^7.3.2 (and minor devDependency reordering). |
| workbench/sveltekit/package.json | Bumps Vite devDependency to ^7.3.2 for SvelteKit workbench consistency. |
| pnpm-lock.yaml | Lockfile regeneration to reflect the Vite bump and dependency graph updates. |
| packages/core/e2e/utils.ts | Removes vite-specific “no step sourcemaps” carve-out so local-dev expectations match actual stacks. |
| .changeset/fix-vite-step-source-maps-e2e.md | Adds an empty changeset file for this backport/test-only change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
karthikscale3
approved these changes
May 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
E2E Local Dev Tests (vite - stable)job has been consistently failing on stable with two assertion failures:Example: https://github.com/vercel/workflow/actions/runs/25334881746/job/74277642761
The tests assert that vite local-dev stack traces should NOT contain user source paths (because
hasStepSourceMaps()returnsfalsefor vite). But the SDK's actual output DOES contain those paths — vite ^7.3.x preserves step bundle source maps in dev mode.Already fixed on
mainin #1827 + #1862. This PR cherry-picks both tostable.Cherry-picked commits
[workflow] Bump Vite #1827 —
Bump viteworkbench/vite/package.json:^7.1.12→^7.3.2workbench/sveltekit/package.json:^7.1.7→^7.3.2pnpm-lock.yaml: regenerated to resolve a conflict with stable's diverged lockfile (re-ranpnpm install --no-frozen-lockfileafter applying the package.json changes).test: enable step source-map assertions for vite local dev #1862 —
test: enable step source-map assertions for vite local devpackages/core/e2e/utils.ts: drop the vite-specific carve-out inhasStepSourceMaps(). Vite local-dev now falls through to the default behavior (returnstruewhenDEV_TEST_CONFIGis set).Verification
pnpm install --frozen-lockfile✅ passes after the cherry-pick.hasStepSourceMaps()fall-through for vite local-dev now matches what the SDK actually produces: source maps ARE preserved, so the test correctly assertsexpect(stack).toContain('99_e2e.ts').