Uh oh!
There was an error while loading. Please reload this page.
Report corrupted event logs distinctly - #2046
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5cda583 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a distinct “corrupted event log” failure classification across the SDK so that replay/invariant violations are surfaced as a dedicated runtime error type and persisted with a dedicated run_failed.eventData.errorCode.
Changes:
- Add
CorruptedEventLogError(slugged to the existingcorrupted-event-logdocs page) and a newRUN_ERROR_CODES.CORRUPTED_EVENT_LOGrun failure code. - Replace corrupted event-log replay guard throws in core workflow primitives (step/hook/sleep/abort-controller + unconsumed events) to throw
CorruptedEventLogError, and update error classification/description logic accordingly. - Update/extend unit tests and snapshots to assert the new error name and error code propagation.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/world/src/shared.ts | Expands comment to reflect additional run failure codes beyond USER_ERROR / RUNTIME_ERROR. |
| packages/errors/src/index.ts | Adds CorruptedEventLogError as a WorkflowRuntimeError subclass with CORRUPTED_EVENT_LOG docs slug. |
| packages/errors/src/error-codes.ts | Introduces RUN_ERROR_CODES.CORRUPTED_EVENT_LOG and refines RUNTIME_ERROR doc comment. |
| packages/errors/src/corrupted-event-log-error.test.ts | Adds coverage for name, inheritance, docs link framing, and .is() behavior. |
| packages/core/src/workflow/sleep.ts | Throws CorruptedEventLogError for wait replay mismatches/unexpected event types. |
| packages/core/src/workflow/sleep.test.ts | Updates expectations/messages for the new corrupted-log error type. |
| packages/core/src/workflow/hook.ts | Throws CorruptedEventLogError for hook token mismatches/unexpected event types. |
| packages/core/src/workflow/hook.test.ts | Updates expectations for the new corrupted-log error type. |
| packages/core/src/workflow/abort-controller.ts | Throws CorruptedEventLogError for abort-hook token mismatch guard. |
| packages/core/src/abort-controller.test.ts | Updates expectation to CorruptedEventLogError. |
| packages/core/src/step.ts | Throws CorruptedEventLogError for step replay mismatches/orphaned events/unexpected event types. |
| packages/core/src/step.test.ts | Updates expectations/messages for the new corrupted-log error type. |
| packages/core/src/workflow.ts | Uses CorruptedEventLogError for unconsumed event-log detection during replay. |
| packages/core/src/runtime.ts | Updates classification comment to reflect more-specific subclass codes. |
| packages/core/src/runtime.test.ts | Expects run_failed.eventData.errorCode to be CORRUPTED_EVENT_LOG for replay guards. |
| packages/core/src/log-format.test.ts | Updates snapshot inputs/outputs for the new error name and code. |
| packages/core/src/describe-error.ts | Adds distinct hinting + code restoration/classification for corrupted event logs. |
| packages/core/src/describe-error.test.ts | Adds coverage and snapshots for corrupted-log attribution and code restoration. |
| packages/core/src/classify-error.ts | Classifies CorruptedEventLogError as CORRUPTED_EVENT_LOG ahead of generic runtime checks. |
| packages/core/src/classify-error.test.ts | Adds classification coverage for CorruptedEventLogError. |
| .changeset/corrupted-event-log-code.md | Declares patch bumps for core/errors/world to ship the new error + code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pranaygp
enabled auto-merge (squash)
May 20, 2026 22:49
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
added a commit
that referenced
this pull request
May 20, 2026
Signed-off-by: Pranay Prakash <pranay.gp@gmail.com>
Contributor
Backport PR opened against |
pranaygp pushed a commit
that referenced
this pull request
May 20, 2026
This was referenced May 21, 2026
This was referenced May 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CorruptedEventLogErrorandCORRUPTED_EVENT_LOGas a distinct run failure codeWorkflowRuntimeErrorrun_failed.eventData.errorCodeTesting
pnpm --filter @workflow/errors testpnpm --filter @workflow/core buildpnpm --filter @workflow/core exec vitest run src/classify-error.test.ts src/describe-error.test.ts src/runtime.test.ts src/workflow/sleep.test.ts src/workflow/hook.test.ts src/step.test.ts src/abort-controller.test.ts src/log-format.test.tsgit diff --checkNote: local commands were run on Node v25.2.1, which is outside the repo engine range, but the focused build/tests passed.