Skip to content

[web-shared] Fix "Queued for" duration for retried steps#2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VaguelySerious merged 1 commit into from
May 22, 2026
Merged

[web-shared] Fix "Queued for" duration for retried steps #2087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/queued-for-uses-first-step-started.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@workflow/web-shared": patch
---

Fix the "Queued for" duration shown in the events list for retried steps. It now measures from `step_created` to the first `step_started` instead of the last, so the displayed value reflects actual queue time rather than queue time plus all retry waits.
42 changes: 29 additions & 13 deletions packages/web-shared/src/components/event-list-view.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ function buildNameMaps(
return { correlationNameMap, workflowName };
}

interface DurationInfo {
export interface DurationInfo {
/** Time from created → started (ms) */
queued?: number;
/** Time from started → completed/failed/cancelled (ms) */
Expand All@@ -154,19 +154,30 @@ interface DurationInfo {
* created ↔ started (queued) and started ↔ completed/failed/cancelled (ran).
* Also computes run-level durations under the key '__run__'.
*/
function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
export function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
// Process events in chronological order so the result doesn't depend on
// the caller's sort direction. Retried steps emit multiple `step_started`
// events for the same correlationId; the queued duration must be measured
// against the first one, not the last.
const chronological = [...events].sort(
(a, b) => new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime()
);

const createdTimes = new Map<string, number>();
const firstStartedTimes = new Map<string, number>();
const startedTimes = new Map<string, number>();
const durations = new Map<string, DurationInfo>();

for (const event of events) {
for (const event of chronological) {
const ts = new Date(event.createdAt).getTime();
const key = event.correlationId ?? '__run__';
const type: string = event.eventType;

// Track created times (first event for each correlation)
if (type === 'step_created' || type === 'run_created') {
createdTimes.set(key, ts);
if (!createdTimes.has(key)) {
createdTimes.set(key, ts);
}
}

// Track started times & compute queued duration
Expand All@@ -176,16 +187,21 @@ function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
type === 'workflow_started'
) {
startedTimes.set(key, ts);
// If no explicit created event was seen, use the started time as created
if (!createdTimes.has(key)) {
createdTimes.set(key, ts);
}
const createdAt = createdTimes.get(key);
const info = durations.get(key) ?? {};
if (createdAt !== undefined) {
info.queued = ts - createdAt;
// The queued duration is anchored on the first start event only —
// subsequent step_started events come from retries.
if (!firstStartedTimes.has(key)) {
firstStartedTimes.set(key, ts);
// If no explicit created event was seen, use the started time as created
if (!createdTimes.has(key)) {
createdTimes.set(key, ts);
}
const createdAt = createdTimes.get(key);
const info = durations.get(key) ?? {};
if (createdAt !== undefined) {
info.queued = ts - createdAt;
}
durations.set(key, info);
}
durations.set(key, info);
}

// Compute ran duration on terminal events
Expand Down
77 changes: 77 additions & 0 deletions packages/web-shared/test/event-list-duration.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
import type { Event } from '@workflow/world';
import { describe, expect, it } from 'vitest';
import { buildDurationMap } from '../src/components/event-list-view.js';

/**
* Regression tests for the "Queued for" duration shown in the Events tab.
*
* A retried step emits multiple `step_started` events for the same
* correlationId. The queued duration must be anchored on the FIRST
* `step_started` (time from `step_created` to first attempt), not the last,
* so the displayed value reflects how long the step waited before any work
* began.
*/

function ev(
eventType: string,
correlationId: string | null,
createdAt: string
): Event {
// Only the fields buildDurationMap reads are required; the rest of Event
// is opaque to it.
return {
eventType,
correlationId,
createdAt,
} as unknown as Event;
}

describe('buildDurationMap → queued duration', () => {
it('uses the first step_started, not the last, for steps with retries', () => {
const events: Event[] = [
ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
ev('step_retrying', 'step-1', '2026-01-01T00:00:03.000Z'),
ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
];

const map = buildDurationMap(events);
// 1s between step_created and the first step_started.
expect(map.get('step-1')?.queued).toBe(1000);
});

it('handles events in descending order (newest first)', () => {
const ascending: Event[] = [
ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
];
const descending = [...ascending].reverse();

expect(buildDurationMap(ascending).get('step-1')?.queued).toBe(1000);
expect(buildDurationMap(descending).get('step-1')?.queued).toBe(1000);
});

it('still works for a step with a single start (no retry)', () => {
const events: Event[] = [
ev('step_created', 'step-2', '2026-01-01T00:00:00.000Z'),
ev('step_started', 'step-2', '2026-01-01T00:00:00.500Z'),
ev('step_completed', 'step-2', '2026-01-01T00:00:02.000Z'),
];

expect(buildDurationMap(events).get('step-2')?.queued).toBe(500);
});

it('falls back to the started time when no created event is seen', () => {
const events: Event[] = [
ev('step_started', 'step-3', '2026-01-01T00:00:05.000Z'),
ev('step_completed', 'step-3', '2026-01-01T00:00:06.000Z'),
];

expect(buildDurationMap(events).get('step-3')?.queued).toBe(0);
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[web-shared] Fix "Queued for" duration for retried steps by VaguelySerious · Pull Request #2087 · vercel/workflow · GitHub
Skip to content
[web-shared] Fix "Queued for" duration for retried steps#2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

VaguelySerious
merged 1 commit into

from

May 22, 2026
 Merged


[web-shared] Fix "Queued for" duration for retried steps
#2087
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/queued-for-uses-first-step-started.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@workflow/web-shared": patch
---

Fix the "Queued for" duration shown in the events list for retried steps. It now measures from `step_created` to the first `step_started` instead of the last, so the displayed value reflects actual queue time rather than queue time plus all retry waits.

42 changes: 29 additions & 13 deletions
packages/web-shared/src/components/event-list-view.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ function buildNameMaps(
 return { correlationNameMap, workflowName };
}

interface DurationInfo {
export interface DurationInfo {
 /** Time from created → started (ms) */
 queued?: number;
 /** Time from started → completed/failed/cancelled (ms) */
Expand All@@ -154,19 +154,30 @@ interface DurationInfo {
 * created ↔ started (queued) and started ↔ completed/failed/cancelled (ran).
 * Also computes run-level durations under the key '__run__'.
 */
function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
export function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 // Process events in chronological order so the result doesn't depend on
 // the caller's sort direction. Retried steps emit multiple `step_started`
 // events for the same correlationId; the queued duration must be measured
 // against the first one, not the last.
 const chronological = [...events].sort(
 (a, b) => new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime()
 );

 const createdTimes = new Map<string, number>();
 const firstStartedTimes = new Map<string, number>();
 const startedTimes = new Map<string, number>();
 const durations = new Map<string, DurationInfo>();

 for (const event of events) {
 for (const event of chronological) {
 const ts = new Date(event.createdAt).getTime();
 const key = event.correlationId ?? '__run__';
 const type: string = event.eventType;

 // Track created times (first event for each correlation)
 if (type === 'step_created' || type === 'run_created') {
 createdTimes.set(key, ts);
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 }

 // Track started times & compute queued duration
Expand All@@ -176,16 +187,21 @@ function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 type === 'workflow_started'
 ) {
 startedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 // The queued duration is anchored on the first start event only —
 // subsequent step_started events come from retries.
 if (!firstStartedTimes.has(key)) {
 firstStartedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 }
 durations.set(key, info);
 }
 durations.set(key, info);
 }

 // Compute ran duration on terminal events
Expand Down

77 changes: 77 additions & 0 deletions
packages/web-shared/test/event-list-duration.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
import type { Event } from '@workflow/world';
import { describe, expect, it } from 'vitest';
import { buildDurationMap } from '../src/components/event-list-view.js';

/**
 * Regression tests for the "Queued for" duration shown in the Events tab.
 *
 * A retried step emits multiple `step_started` events for the same
 * correlationId. The queued duration must be anchored on the FIRST
 * `step_started` (time from `step_created` to first attempt), not the last,
 * so the displayed value reflects how long the step waited before any work
 * began.
 */

function ev(
 eventType: string,
 correlationId: string | null,
 createdAt: string
): Event {
 // Only the fields buildDurationMap reads are required; the rest of Event
 // is opaque to it.
 return {
 eventType,
 correlationId,
 createdAt,
 } as unknown as Event;
}

describe('buildDurationMap → queued duration', () => {
 it('uses the first step_started, not the last, for steps with retries', () => {
 const events: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_retrying', 'step-1', '2026-01-01T00:00:03.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];

 const map = buildDurationMap(events);
 // 1s between step_created and the first step_started.
 expect(map.get('step-1')?.queued).toBe(1000);
 });

 it('handles events in descending order (newest first)', () => {
 const ascending: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];
 const descending = [...ascending].reverse();

 expect(buildDurationMap(ascending).get('step-1')?.queued).toBe(1000);
 expect(buildDurationMap(descending).get('step-1')?.queued).toBe(1000);
 });

 it('still works for a step with a single start (no retry)', () => {
 const events: Event[] = [
 ev('step_created', 'step-2', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-2', '2026-01-01T00:00:00.500Z'),
 ev('step_completed', 'step-2', '2026-01-01T00:00:02.000Z'),
 ];

 expect(buildDurationMap(events).get('step-2')?.queued).toBe(500);
 });

 it('falls back to the started time when no created event is seen', () => {
 const events: Event[] = [
 ev('step_started', 'step-3', '2026-01-01T00:00:05.000Z'),
 ev('step_completed', 'step-3', '2026-01-01T00:00:06.000Z'),
 ];

 expect(buildDurationMap(events).get('step-3')?.queued).toBe(0);
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[web-shared] Fix "Queued for" duration for retried steps by VaguelySerious · Pull Request #2087 · vercel/workflow · GitHub
Skip to content
[web-shared] Fix "Queued for" duration for retried steps#2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

VaguelySerious
merged 1 commit into

from

May 22, 2026
 Merged


[web-shared] Fix "Queued for" duration for retried steps
#2087
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/queued-for-uses-first-step-started.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@workflow/web-shared": patch
---

Fix the "Queued for" duration shown in the events list for retried steps. It now measures from `step_created` to the first `step_started` instead of the last, so the displayed value reflects actual queue time rather than queue time plus all retry waits.

42 changes: 29 additions & 13 deletions
packages/web-shared/src/components/event-list-view.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ function buildNameMaps(
 return { correlationNameMap, workflowName };
}

interface DurationInfo {
export interface DurationInfo {
 /** Time from created → started (ms) */
 queued?: number;
 /** Time from started → completed/failed/cancelled (ms) */
Expand All@@ -154,19 +154,30 @@ interface DurationInfo {
 * created ↔ started (queued) and started ↔ completed/failed/cancelled (ran).
 * Also computes run-level durations under the key '__run__'.
 */
function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
export function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 // Process events in chronological order so the result doesn't depend on
 // the caller's sort direction. Retried steps emit multiple `step_started`
 // events for the same correlationId; the queued duration must be measured
 // against the first one, not the last.
 const chronological = [...events].sort(
 (a, b) => new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime()
 );

 const createdTimes = new Map<string, number>();
 const firstStartedTimes = new Map<string, number>();
 const startedTimes = new Map<string, number>();
 const durations = new Map<string, DurationInfo>();

 for (const event of events) {
 for (const event of chronological) {
 const ts = new Date(event.createdAt).getTime();
 const key = event.correlationId ?? '__run__';
 const type: string = event.eventType;

 // Track created times (first event for each correlation)
 if (type === 'step_created' || type === 'run_created') {
 createdTimes.set(key, ts);
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 }

 // Track started times & compute queued duration
Expand All@@ -176,16 +187,21 @@ function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 type === 'workflow_started'
 ) {
 startedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 // The queued duration is anchored on the first start event only —
 // subsequent step_started events come from retries.
 if (!firstStartedTimes.has(key)) {
 firstStartedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 }
 durations.set(key, info);
 }
 durations.set(key, info);
 }

 // Compute ran duration on terminal events
Expand Down

77 changes: 77 additions & 0 deletions
packages/web-shared/test/event-list-duration.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
import type { Event } from '@workflow/world';
import { describe, expect, it } from 'vitest';
import { buildDurationMap } from '../src/components/event-list-view.js';

/**
 * Regression tests for the "Queued for" duration shown in the Events tab.
 *
 * A retried step emits multiple `step_started` events for the same
 * correlationId. The queued duration must be anchored on the FIRST
 * `step_started` (time from `step_created` to first attempt), not the last,
 * so the displayed value reflects how long the step waited before any work
 * began.
 */

function ev(
 eventType: string,
 correlationId: string | null,
 createdAt: string
): Event {
 // Only the fields buildDurationMap reads are required; the rest of Event
 // is opaque to it.
 return {
 eventType,
 correlationId,
 createdAt,
 } as unknown as Event;
}

describe('buildDurationMap → queued duration', () => {
 it('uses the first step_started, not the last, for steps with retries', () => {
 const events: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_retrying', 'step-1', '2026-01-01T00:00:03.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];

 const map = buildDurationMap(events);
 // 1s between step_created and the first step_started.
 expect(map.get('step-1')?.queued).toBe(1000);
 });

 it('handles events in descending order (newest first)', () => {
 const ascending: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];
 const descending = [...ascending].reverse();

 expect(buildDurationMap(ascending).get('step-1')?.queued).toBe(1000);
 expect(buildDurationMap(descending).get('step-1')?.queued).toBe(1000);
 });

 it('still works for a step with a single start (no retry)', () => {
 const events: Event[] = [
 ev('step_created', 'step-2', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-2', '2026-01-01T00:00:00.500Z'),
 ev('step_completed', 'step-2', '2026-01-01T00:00:02.000Z'),
 ];

 expect(buildDurationMap(events).get('step-2')?.queued).toBe(500);
 });

 it('falls back to the started time when no created event is seen', () => {
 const events: Event[] = [
 ev('step_started', 'step-3', '2026-01-01T00:00:05.000Z'),
 ev('step_completed', 'step-3', '2026-01-01T00:00:06.000Z'),
 ];

 expect(buildDurationMap(events).get('step-3')?.queued).toBe(0);
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[web-shared] Fix "Queued for" duration for retried steps by VaguelySerious · Pull Request #2087 · vercel/workflow · GitHub
Skip to content
[web-shared] Fix "Queued for" duration for retried steps#2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

VaguelySerious
merged 1 commit into

from

May 22, 2026
 Merged


[web-shared] Fix "Queued for" duration for retried steps
#2087
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/queued-for-uses-first-step-started.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@workflow/web-shared": patch
---

Fix the "Queued for" duration shown in the events list for retried steps. It now measures from `step_created` to the first `step_started` instead of the last, so the displayed value reflects actual queue time rather than queue time plus all retry waits.

42 changes: 29 additions & 13 deletions
packages/web-shared/src/components/event-list-view.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ function buildNameMaps(
 return { correlationNameMap, workflowName };
}

interface DurationInfo {
export interface DurationInfo {
 /** Time from created → started (ms) */
 queued?: number;
 /** Time from started → completed/failed/cancelled (ms) */
Expand All@@ -154,19 +154,30 @@ interface DurationInfo {
 * created ↔ started (queued) and started ↔ completed/failed/cancelled (ran).
 * Also computes run-level durations under the key '__run__'.
 */
function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
export function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 // Process events in chronological order so the result doesn't depend on
 // the caller's sort direction. Retried steps emit multiple `step_started`
 // events for the same correlationId; the queued duration must be measured
 // against the first one, not the last.
 const chronological = [...events].sort(
 (a, b) => new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime()
 );

 const createdTimes = new Map<string, number>();
 const firstStartedTimes = new Map<string, number>();
 const startedTimes = new Map<string, number>();
 const durations = new Map<string, DurationInfo>();

 for (const event of events) {
 for (const event of chronological) {
 const ts = new Date(event.createdAt).getTime();
 const key = event.correlationId ?? '__run__';
 const type: string = event.eventType;

 // Track created times (first event for each correlation)
 if (type === 'step_created' || type === 'run_created') {
 createdTimes.set(key, ts);
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 }

 // Track started times & compute queued duration
Expand All@@ -176,16 +187,21 @@ function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 type === 'workflow_started'
 ) {
 startedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 // The queued duration is anchored on the first start event only —
 // subsequent step_started events come from retries.
 if (!firstStartedTimes.has(key)) {
 firstStartedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 }
 durations.set(key, info);
 }
 durations.set(key, info);
 }

 // Compute ran duration on terminal events
Expand Down

77 changes: 77 additions & 0 deletions
packages/web-shared/test/event-list-duration.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
import type { Event } from '@workflow/world';
import { describe, expect, it } from 'vitest';
import { buildDurationMap } from '../src/components/event-list-view.js';

/**
 * Regression tests for the "Queued for" duration shown in the Events tab.
 *
 * A retried step emits multiple `step_started` events for the same
 * correlationId. The queued duration must be anchored on the FIRST
 * `step_started` (time from `step_created` to first attempt), not the last,
 * so the displayed value reflects how long the step waited before any work
 * began.
 */

function ev(
 eventType: string,
 correlationId: string | null,
 createdAt: string
): Event {
 // Only the fields buildDurationMap reads are required; the rest of Event
 // is opaque to it.
 return {
 eventType,
 correlationId,
 createdAt,
 } as unknown as Event;
}

describe('buildDurationMap → queued duration', () => {
 it('uses the first step_started, not the last, for steps with retries', () => {
 const events: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_retrying', 'step-1', '2026-01-01T00:00:03.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];

 const map = buildDurationMap(events);
 // 1s between step_created and the first step_started.
 expect(map.get('step-1')?.queued).toBe(1000);
 });

 it('handles events in descending order (newest first)', () => {
 const ascending: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];
 const descending = [...ascending].reverse();

 expect(buildDurationMap(ascending).get('step-1')?.queued).toBe(1000);
 expect(buildDurationMap(descending).get('step-1')?.queued).toBe(1000);
 });

 it('still works for a step with a single start (no retry)', () => {
 const events: Event[] = [
 ev('step_created', 'step-2', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-2', '2026-01-01T00:00:00.500Z'),
 ev('step_completed', 'step-2', '2026-01-01T00:00:02.000Z'),
 ];

 expect(buildDurationMap(events).get('step-2')?.queued).toBe(500);
 });

 it('falls back to the started time when no created event is seen', () => {
 const events: Event[] = [
 ev('step_started', 'step-3', '2026-01-01T00:00:05.000Z'),
 ev('step_completed', 'step-3', '2026-01-01T00:00:06.000Z'),
 ];

 expect(buildDurationMap(events).get('step-3')?.queued).toBe(0);
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[web-shared] Fix "Queued for" duration for retried steps by VaguelySerious · Pull Request #2087 · vercel/workflow · GitHub
Skip to content
[web-shared] Fix "Queued for" duration for retried steps#2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

VaguelySerious
merged 1 commit into

from

May 22, 2026
 Merged


[web-shared] Fix "Queued for" duration for retried steps
#2087
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/queued-for-uses-first-step-started.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@workflow/web-shared": patch
---

Fix the "Queued for" duration shown in the events list for retried steps. It now measures from `step_created` to the first `step_started` instead of the last, so the displayed value reflects actual queue time rather than queue time plus all retry waits.

42 changes: 29 additions & 13 deletions
packages/web-shared/src/components/event-list-view.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ function buildNameMaps(
 return { correlationNameMap, workflowName };
}

interface DurationInfo {
export interface DurationInfo {
 /** Time from created → started (ms) */
 queued?: number;
 /** Time from started → completed/failed/cancelled (ms) */
Expand All@@ -154,19 +154,30 @@ interface DurationInfo {
 * created ↔ started (queued) and started ↔ completed/failed/cancelled (ran).
 * Also computes run-level durations under the key '__run__'.
 */
function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
export function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 // Process events in chronological order so the result doesn't depend on
 // the caller's sort direction. Retried steps emit multiple `step_started`
 // events for the same correlationId; the queued duration must be measured
 // against the first one, not the last.
 const chronological = [...events].sort(
 (a, b) => new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime()
 );

 const createdTimes = new Map<string, number>();
 const firstStartedTimes = new Map<string, number>();
 const startedTimes = new Map<string, number>();
 const durations = new Map<string, DurationInfo>();

 for (const event of events) {
 for (const event of chronological) {
 const ts = new Date(event.createdAt).getTime();
 const key = event.correlationId ?? '__run__';
 const type: string = event.eventType;

 // Track created times (first event for each correlation)
 if (type === 'step_created' || type === 'run_created') {
 createdTimes.set(key, ts);
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 }

 // Track started times & compute queued duration
Expand All@@ -176,16 +187,21 @@ function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 type === 'workflow_started'
 ) {
 startedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 // The queued duration is anchored on the first start event only —
 // subsequent step_started events come from retries.
 if (!firstStartedTimes.has(key)) {
 firstStartedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 }
 durations.set(key, info);
 }
 durations.set(key, info);
 }

 // Compute ran duration on terminal events
Expand Down

77 changes: 77 additions & 0 deletions
packages/web-shared/test/event-list-duration.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
import type { Event } from '@workflow/world';
import { describe, expect, it } from 'vitest';
import { buildDurationMap } from '../src/components/event-list-view.js';

/**
 * Regression tests for the "Queued for" duration shown in the Events tab.
 *
 * A retried step emits multiple `step_started` events for the same
 * correlationId. The queued duration must be anchored on the FIRST
 * `step_started` (time from `step_created` to first attempt), not the last,
 * so the displayed value reflects how long the step waited before any work
 * began.
 */

function ev(
 eventType: string,
 correlationId: string | null,
 createdAt: string
): Event {
 // Only the fields buildDurationMap reads are required; the rest of Event
 // is opaque to it.
 return {
 eventType,
 correlationId,
 createdAt,
 } as unknown as Event;
}

describe('buildDurationMap → queued duration', () => {
 it('uses the first step_started, not the last, for steps with retries', () => {
 const events: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_retrying', 'step-1', '2026-01-01T00:00:03.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];

 const map = buildDurationMap(events);
 // 1s between step_created and the first step_started.
 expect(map.get('step-1')?.queued).toBe(1000);
 });

 it('handles events in descending order (newest first)', () => {
 const ascending: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];
 const descending = [...ascending].reverse();

 expect(buildDurationMap(ascending).get('step-1')?.queued).toBe(1000);
 expect(buildDurationMap(descending).get('step-1')?.queued).toBe(1000);
 });

 it('still works for a step with a single start (no retry)', () => {
 const events: Event[] = [
 ev('step_created', 'step-2', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-2', '2026-01-01T00:00:00.500Z'),
 ev('step_completed', 'step-2', '2026-01-01T00:00:02.000Z'),
 ];

 expect(buildDurationMap(events).get('step-2')?.queued).toBe(500);
 });

 it('falls back to the started time when no created event is seen', () => {
 const events: Event[] = [
 ev('step_started', 'step-3', '2026-01-01T00:00:05.000Z'),
 ev('step_completed', 'step-3', '2026-01-01T00:00:06.000Z'),
 ];

 expect(buildDurationMap(events).get('step-3')?.queued).toBe(0);
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[web-shared] Fix "Queued for" duration for retried steps by VaguelySerious · Pull Request #2087 · vercel/workflow · GitHub
Skip to content
[web-shared] Fix "Queued for" duration for retried steps#2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

VaguelySerious
merged 1 commit into

from

May 22, 2026
 Merged


[web-shared] Fix "Queued for" duration for retried steps
#2087
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/queued-for-uses-first-step-started.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@workflow/web-shared": patch
---

Fix the "Queued for" duration shown in the events list for retried steps. It now measures from `step_created` to the first `step_started` instead of the last, so the displayed value reflects actual queue time rather than queue time plus all retry waits.

42 changes: 29 additions & 13 deletions
packages/web-shared/src/components/event-list-view.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ function buildNameMaps(
 return { correlationNameMap, workflowName };
}

interface DurationInfo {
export interface DurationInfo {
 /** Time from created → started (ms) */
 queued?: number;
 /** Time from started → completed/failed/cancelled (ms) */
Expand All@@ -154,19 +154,30 @@ interface DurationInfo {
 * created ↔ started (queued) and started ↔ completed/failed/cancelled (ran).
 * Also computes run-level durations under the key '__run__'.
 */
function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
export function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 // Process events in chronological order so the result doesn't depend on
 // the caller's sort direction. Retried steps emit multiple `step_started`
 // events for the same correlationId; the queued duration must be measured
 // against the first one, not the last.
 const chronological = [...events].sort(
 (a, b) => new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime()
 );

 const createdTimes = new Map<string, number>();
 const firstStartedTimes = new Map<string, number>();
 const startedTimes = new Map<string, number>();
 const durations = new Map<string, DurationInfo>();

 for (const event of events) {
 for (const event of chronological) {
 const ts = new Date(event.createdAt).getTime();
 const key = event.correlationId ?? '__run__';
 const type: string = event.eventType;

 // Track created times (first event for each correlation)
 if (type === 'step_created' || type === 'run_created') {
 createdTimes.set(key, ts);
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 }

 // Track started times & compute queued duration
Expand All@@ -176,16 +187,21 @@ function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 type === 'workflow_started'
 ) {
 startedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 // The queued duration is anchored on the first start event only —
 // subsequent step_started events come from retries.
 if (!firstStartedTimes.has(key)) {
 firstStartedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 }
 durations.set(key, info);
 }
 durations.set(key, info);
 }

 // Compute ran duration on terminal events
Expand Down

77 changes: 77 additions & 0 deletions
packages/web-shared/test/event-list-duration.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
import type { Event } from '@workflow/world';
import { describe, expect, it } from 'vitest';
import { buildDurationMap } from '../src/components/event-list-view.js';

/**
 * Regression tests for the "Queued for" duration shown in the Events tab.
 *
 * A retried step emits multiple `step_started` events for the same
 * correlationId. The queued duration must be anchored on the FIRST
 * `step_started` (time from `step_created` to first attempt), not the last,
 * so the displayed value reflects how long the step waited before any work
 * began.
 */

function ev(
 eventType: string,
 correlationId: string | null,
 createdAt: string
): Event {
 // Only the fields buildDurationMap reads are required; the rest of Event
 // is opaque to it.
 return {
 eventType,
 correlationId,
 createdAt,
 } as unknown as Event;
}

describe('buildDurationMap → queued duration', () => {
 it('uses the first step_started, not the last, for steps with retries', () => {
 const events: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_retrying', 'step-1', '2026-01-01T00:00:03.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];

 const map = buildDurationMap(events);
 // 1s between step_created and the first step_started.
 expect(map.get('step-1')?.queued).toBe(1000);
 });

 it('handles events in descending order (newest first)', () => {
 const ascending: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];
 const descending = [...ascending].reverse();

 expect(buildDurationMap(ascending).get('step-1')?.queued).toBe(1000);
 expect(buildDurationMap(descending).get('step-1')?.queued).toBe(1000);
 });

 it('still works for a step with a single start (no retry)', () => {
 const events: Event[] = [
 ev('step_created', 'step-2', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-2', '2026-01-01T00:00:00.500Z'),
 ev('step_completed', 'step-2', '2026-01-01T00:00:02.000Z'),
 ];

 expect(buildDurationMap(events).get('step-2')?.queued).toBe(500);
 });

 it('falls back to the started time when no created event is seen', () => {
 const events: Event[] = [
 ev('step_started', 'step-3', '2026-01-01T00:00:05.000Z'),
 ev('step_completed', 'step-3', '2026-01-01T00:00:06.000Z'),
 ];

 expect(buildDurationMap(events).get('step-3')?.queued).toBe(0);
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[web-shared] Fix "Queued for" duration for retried steps by VaguelySerious · Pull Request #2087 · vercel/workflow · GitHub
Skip to content
[web-shared] Fix "Queued for" duration for retried steps#2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

VaguelySerious
merged 1 commit into

from

May 22, 2026
 Merged


[web-shared] Fix "Queued for" duration for retried steps
#2087
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/queued-for-uses-first-step-started.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@workflow/web-shared": patch
---

Fix the "Queued for" duration shown in the events list for retried steps. It now measures from `step_created` to the first `step_started` instead of the last, so the displayed value reflects actual queue time rather than queue time plus all retry waits.

42 changes: 29 additions & 13 deletions
packages/web-shared/src/components/event-list-view.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ function buildNameMaps(
 return { correlationNameMap, workflowName };
}

interface DurationInfo {
export interface DurationInfo {
 /** Time from created → started (ms) */
 queued?: number;
 /** Time from started → completed/failed/cancelled (ms) */
Expand All@@ -154,19 +154,30 @@ interface DurationInfo {
 * created ↔ started (queued) and started ↔ completed/failed/cancelled (ran).
 * Also computes run-level durations under the key '__run__'.
 */
function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
export function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 // Process events in chronological order so the result doesn't depend on
 // the caller's sort direction. Retried steps emit multiple `step_started`
 // events for the same correlationId; the queued duration must be measured
 // against the first one, not the last.
 const chronological = [...events].sort(
 (a, b) => new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime()
 );

 const createdTimes = new Map<string, number>();
 const firstStartedTimes = new Map<string, number>();
 const startedTimes = new Map<string, number>();
 const durations = new Map<string, DurationInfo>();

 for (const event of events) {
 for (const event of chronological) {
 const ts = new Date(event.createdAt).getTime();
 const key = event.correlationId ?? '__run__';
 const type: string = event.eventType;

 // Track created times (first event for each correlation)
 if (type === 'step_created' || type === 'run_created') {
 createdTimes.set(key, ts);
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 }

 // Track started times & compute queued duration
Expand All@@ -176,16 +187,21 @@ function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 type === 'workflow_started'
 ) {
 startedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 // The queued duration is anchored on the first start event only —
 // subsequent step_started events come from retries.
 if (!firstStartedTimes.has(key)) {
 firstStartedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 }
 durations.set(key, info);
 }
 durations.set(key, info);
 }

 // Compute ran duration on terminal events
Expand Down

77 changes: 77 additions & 0 deletions
packages/web-shared/test/event-list-duration.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
import type { Event } from '@workflow/world';
import { describe, expect, it } from 'vitest';
import { buildDurationMap } from '../src/components/event-list-view.js';

/**
 * Regression tests for the "Queued for" duration shown in the Events tab.
 *
 * A retried step emits multiple `step_started` events for the same
 * correlationId. The queued duration must be anchored on the FIRST
 * `step_started` (time from `step_created` to first attempt), not the last,
 * so the displayed value reflects how long the step waited before any work
 * began.
 */

function ev(
 eventType: string,
 correlationId: string | null,
 createdAt: string
): Event {
 // Only the fields buildDurationMap reads are required; the rest of Event
 // is opaque to it.
 return {
 eventType,
 correlationId,
 createdAt,
 } as unknown as Event;
}

describe('buildDurationMap → queued duration', () => {
 it('uses the first step_started, not the last, for steps with retries', () => {
 const events: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_retrying', 'step-1', '2026-01-01T00:00:03.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];

 const map = buildDurationMap(events);
 // 1s between step_created and the first step_started.
 expect(map.get('step-1')?.queued).toBe(1000);
 });

 it('handles events in descending order (newest first)', () => {
 const ascending: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];
 const descending = [...ascending].reverse();

 expect(buildDurationMap(ascending).get('step-1')?.queued).toBe(1000);
 expect(buildDurationMap(descending).get('step-1')?.queued).toBe(1000);
 });

 it('still works for a step with a single start (no retry)', () => {
 const events: Event[] = [
 ev('step_created', 'step-2', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-2', '2026-01-01T00:00:00.500Z'),
 ev('step_completed', 'step-2', '2026-01-01T00:00:02.000Z'),
 ];

 expect(buildDurationMap(events).get('step-2')?.queued).toBe(500);
 });

 it('falls back to the started time when no created event is seen', () => {
 const events: Event[] = [
 ev('step_started', 'step-3', '2026-01-01T00:00:05.000Z'),
 ev('step_completed', 'step-3', '2026-01-01T00:00:06.000Z'),
 ];

 expect(buildDurationMap(events).get('step-3')?.queued).toBe(0);
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[web-shared] Fix "Queued for" duration for retried steps by VaguelySerious · Pull Request #2087 · vercel/workflow · GitHub
Skip to content
[web-shared] Fix "Queued for" duration for retried steps#2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

VaguelySerious
merged 1 commit into

from

May 22, 2026
 Merged


[web-shared] Fix "Queued for" duration for retried steps
#2087
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/queued-for-uses-first-step-started.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@workflow/web-shared": patch
---

Fix the "Queued for" duration shown in the events list for retried steps. It now measures from `step_created` to the first `step_started` instead of the last, so the displayed value reflects actual queue time rather than queue time plus all retry waits.

42 changes: 29 additions & 13 deletions
packages/web-shared/src/components/event-list-view.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ function buildNameMaps(
 return { correlationNameMap, workflowName };
}

interface DurationInfo {
export interface DurationInfo {
 /** Time from created → started (ms) */
 queued?: number;
 /** Time from started → completed/failed/cancelled (ms) */
Expand All@@ -154,19 +154,30 @@ interface DurationInfo {
 * created ↔ started (queued) and started ↔ completed/failed/cancelled (ran).
 * Also computes run-level durations under the key '__run__'.
 */
function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
export function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 // Process events in chronological order so the result doesn't depend on
 // the caller's sort direction. Retried steps emit multiple `step_started`
 // events for the same correlationId; the queued duration must be measured
 // against the first one, not the last.
 const chronological = [...events].sort(
 (a, b) => new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime()
 );

 const createdTimes = new Map<string, number>();
 const firstStartedTimes = new Map<string, number>();
 const startedTimes = new Map<string, number>();
 const durations = new Map<string, DurationInfo>();

 for (const event of events) {
 for (const event of chronological) {
 const ts = new Date(event.createdAt).getTime();
 const key = event.correlationId ?? '__run__';
 const type: string = event.eventType;

 // Track created times (first event for each correlation)
 if (type === 'step_created' || type === 'run_created') {
 createdTimes.set(key, ts);
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 }

 // Track started times & compute queued duration
Expand All@@ -176,16 +187,21 @@ function buildDurationMap(events: Event[]): Map<string, DurationInfo> {
 type === 'workflow_started'
 ) {
 startedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 // The queued duration is anchored on the first start event only —
 // subsequent step_started events come from retries.
 if (!firstStartedTimes.has(key)) {
 firstStartedTimes.set(key, ts);
 // If no explicit created event was seen, use the started time as created
 if (!createdTimes.has(key)) {
 createdTimes.set(key, ts);
 }
 const createdAt = createdTimes.get(key);
 const info = durations.get(key) ?? {};
 if (createdAt !== undefined) {
 info.queued = ts - createdAt;
 }
 durations.set(key, info);
 }
 durations.set(key, info);
 }

 // Compute ran duration on terminal events
Expand Down

77 changes: 77 additions & 0 deletions
packages/web-shared/test/event-list-duration.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
import type { Event } from '@workflow/world';
import { describe, expect, it } from 'vitest';
import { buildDurationMap } from '../src/components/event-list-view.js';

/**
 * Regression tests for the "Queued for" duration shown in the Events tab.
 *
 * A retried step emits multiple `step_started` events for the same
 * correlationId. The queued duration must be anchored on the FIRST
 * `step_started` (time from `step_created` to first attempt), not the last,
 * so the displayed value reflects how long the step waited before any work
 * began.
 */

function ev(
 eventType: string,
 correlationId: string | null,
 createdAt: string
): Event {
 // Only the fields buildDurationMap reads are required; the rest of Event
 // is opaque to it.
 return {
 eventType,
 correlationId,
 createdAt,
 } as unknown as Event;
}

describe('buildDurationMap → queued duration', () => {
 it('uses the first step_started, not the last, for steps with retries', () => {
 const events: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_retrying', 'step-1', '2026-01-01T00:00:03.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];

 const map = buildDurationMap(events);
 // 1s between step_created and the first step_started.
 expect(map.get('step-1')?.queued).toBe(1000);
 });

 it('handles events in descending order (newest first)', () => {
 const ascending: Event[] = [
 ev('step_created', 'step-1', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:01.000Z'),
 ev('step_failed', 'step-1', '2026-01-01T00:00:02.000Z'),
 ev('step_started', 'step-1', '2026-01-01T00:00:10.000Z'),
 ev('step_completed', 'step-1', '2026-01-01T00:00:11.000Z'),
 ];
 const descending = [...ascending].reverse();

 expect(buildDurationMap(ascending).get('step-1')?.queued).toBe(1000);
 expect(buildDurationMap(descending).get('step-1')?.queued).toBe(1000);
 });

 it('still works for a step with a single start (no retry)', () => {
 const events: Event[] = [
 ev('step_created', 'step-2', '2026-01-01T00:00:00.000Z'),
 ev('step_started', 'step-2', '2026-01-01T00:00:00.500Z'),
 ev('step_completed', 'step-2', '2026-01-01T00:00:02.000Z'),
 ];

 expect(buildDurationMap(events).get('step-2')?.queued).toBe(500);
 });

 it('falls back to the started time when no created event is seen', () => {
 const events: Event[] = [
 ev('step_started', 'step-3', '2026-01-01T00:00:05.000Z'),
 ev('step_completed', 'step-3', '2026-01-01T00:00:06.000Z'),
 ];

 expect(buildDurationMap(events).get('step-3')?.queued).toBe(0);
 });
});
Loading