Skip to content

[Docs] Cookbook update for child workflows pattern - #2100

Merged
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion
May 25, 2026
Merged

[Docs] Cookbook update for child workflows pattern#2100
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites the v4 and v5 Child Workflows cookbook to recommend hook-based completion (defineHook + withChildCompletionHook + startAndWait) instead of getRun().status polling loops
  • Updates Workflow Composition cross-links in v4/v5 to point at the hook resume pattern
  • Updates the workbench cookbook fixture to spawn a wrapped child that resumes the parent hook in finally

Why

Polling child status in a durable sleep loop works but is slower to wake, holds worker slots when combined with returnValue, and requires extra result-collection steps. The hook resume pattern lets each child signal completion directly and keeps the parent suspended with zero compute until the child finishes.

Test plan

  • pnpm --filter @workflow/docs-typecheck typecheck
  • pnpm exec vitest run test/cookbook-common.test.ts -t "child-workflows" in workbench/vitest (local plugin env issue unrelated to this diff)
  • Review updated cookbook pages at /cookbook/advanced/child-workflows for v4 and v5

Made with Cursor

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — all four asks addressed cleanly

Karthik's fix commit (1c0e18ff0 Fix child-workflows cookbook review feedback) addresses all four items from the previous review:

AskFix
1. Type error in resumeParentCompletion (Docs Code Samples CI)Tightened to discriminated union in both v4 and v5
2. Missing zod dep (Vitest Plugin Tests CI)Added "zod": "catalog:" to workbench/vitest/package.json + lockfile
3. Unused resumeHook importRemoved
4. No changesetAdded empty changeset .changeset/cookbook-child-workflows-hook-resume.md

What I verified locally

  • pnpm install --frozen-lockfile ✓ (lockfile updated cleanly)
  • pnpm turbo run build --filter '!./workbench/*'
  • pnpm --filter @workflow/docs-typecheck test:docs ✓ (911/911 tests pass — child-workflows v4 and v5 both clean)
  • cd workbench/vitest && pnpm test ✓ (34/34 tests pass, including should spawn a child workflow via start() and collect its result)

CI

  • 37 success, 0 failures, 73 in progress — both previously-failing checks now green:
    • Docs Code Samples: pass (was failing on lines 33 of both v4 and v5)
    • Vitest Plugin Tests: pass (was failing on zod resolution)

Branch hygiene

The ~10 merge commits from main are still there — they'll be squashed away on merge so it's not a blocker, but a rebase would clean up the working history.

Nice work on the pattern. The hook resume + withChildCompletionHook + startAndWait shape is clean, and the prose explanation of why hooks beat polling (zero compute, immediate wake, typed payloads, no worker-pool pressure) is well-grounded with the Eager Processing link.

Approving.

karthikscale3and others added 2 commits May 25, 2026 10:03
Remove redundant polling comparison copy, the getRun() alternative section, and v5-only start() tips to keep the cookbook focused on the hook pattern.
Co-authored-by: Cursor <cursoragent@cursor.com>
@karthikscale3
karthikscale3 merged commit c58cae6 into mainMay 25, 2026
229 of 252 checks passed
@karthikscale3
karthikscale3 deleted the karthik/child-workflows-hook-completion branch May 25, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for c58cae6 (AI decision).

All meaningful changes target docs cookbook pages (docs/content/docs/v4/cookbook/..., docs/content/docs/v5/cookbook/..., docs/lib/cookbook-tree.ts) and a workbench/vitest fixture (workbench/vitest/workflows/cookbook/child-workflows.ts) that do not exist on stable — verified via git ls-tree origin/stable. The only file present on stable is workbench/vitest/package.json, where the sole change is adding a zod dependency that solely supports the new fixture which isn't on stable, so the backport would be meaningless on its own.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

c58cae66122bed2c0dddfe7cf793def18c08b708

pranaygp added a commit that referenced this pull request Jun 11, 2026
…anch
- ai-sdk (#2099): tools inside the per-turn step are not individually
durable — remove the misleading "use step" directives and durability
claims, rewrite when-to-use, add the pitfall and corrected
streamText-vs-DurableAgent comparison
- child-workflows (#2100): replace spawn-and-poll (getRun().status loop)
with startAndWait() + withChildCompletionHook() hook resume
- durable-agent + agent-cancellation + human-in-the-loop (#2285):
DurableAgent is deprecated in v5 — add warn callout and notes pointing
at AI SDK v7's WorkflowAgent
- ai-sdk: add deployment-pinning versioning callout (#2010)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Docs] Cookbook update for child workflows pattern by karthikscale3 · Pull Request #2100 · vercel/workflow · GitHub
Skip to content

[Docs] Cookbook update for child workflows pattern - #2100

Merged
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion
May 25, 2026
Merged

[Docs] Cookbook update for child workflows pattern#2100
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites the v4 and v5 Child Workflows cookbook to recommend hook-based completion (defineHook + withChildCompletionHook + startAndWait) instead of getRun().status polling loops
  • Updates Workflow Composition cross-links in v4/v5 to point at the hook resume pattern
  • Updates the workbench cookbook fixture to spawn a wrapped child that resumes the parent hook in finally

Why

Polling child status in a durable sleep loop works but is slower to wake, holds worker slots when combined with returnValue, and requires extra result-collection steps. The hook resume pattern lets each child signal completion directly and keeps the parent suspended with zero compute until the child finishes.

Test plan

  • pnpm --filter @workflow/docs-typecheck typecheck
  • pnpm exec vitest run test/cookbook-common.test.ts -t "child-workflows" in workbench/vitest (local plugin env issue unrelated to this diff)
  • Review updated cookbook pages at /cookbook/advanced/child-workflows for v4 and v5

Made with Cursor

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — all four asks addressed cleanly

Karthik's fix commit (1c0e18ff0 Fix child-workflows cookbook review feedback) addresses all four items from the previous review:

AskFix
1. Type error in resumeParentCompletion (Docs Code Samples CI)Tightened to discriminated union in both v4 and v5
2. Missing zod dep (Vitest Plugin Tests CI)Added "zod": "catalog:" to workbench/vitest/package.json + lockfile
3. Unused resumeHook importRemoved
4. No changesetAdded empty changeset .changeset/cookbook-child-workflows-hook-resume.md

What I verified locally

  • pnpm install --frozen-lockfile ✓ (lockfile updated cleanly)
  • pnpm turbo run build --filter '!./workbench/*'
  • pnpm --filter @workflow/docs-typecheck test:docs ✓ (911/911 tests pass — child-workflows v4 and v5 both clean)
  • cd workbench/vitest && pnpm test ✓ (34/34 tests pass, including should spawn a child workflow via start() and collect its result)

CI

  • 37 success, 0 failures, 73 in progress — both previously-failing checks now green:
    • Docs Code Samples: pass (was failing on lines 33 of both v4 and v5)
    • Vitest Plugin Tests: pass (was failing on zod resolution)

Branch hygiene

The ~10 merge commits from main are still there — they'll be squashed away on merge so it's not a blocker, but a rebase would clean up the working history.

Nice work on the pattern. The hook resume + withChildCompletionHook + startAndWait shape is clean, and the prose explanation of why hooks beat polling (zero compute, immediate wake, typed payloads, no worker-pool pressure) is well-grounded with the Eager Processing link.

Approving.

karthikscale3and others added 2 commits May 25, 2026 10:03
Remove redundant polling comparison copy, the getRun() alternative section, and v5-only start() tips to keep the cookbook focused on the hook pattern.
Co-authored-by: Cursor <cursoragent@cursor.com>
@karthikscale3
karthikscale3 merged commit c58cae6 into mainMay 25, 2026
229 of 252 checks passed
@karthikscale3
karthikscale3 deleted the karthik/child-workflows-hook-completion branch May 25, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for c58cae6 (AI decision).

All meaningful changes target docs cookbook pages (docs/content/docs/v4/cookbook/..., docs/content/docs/v5/cookbook/..., docs/lib/cookbook-tree.ts) and a workbench/vitest fixture (workbench/vitest/workflows/cookbook/child-workflows.ts) that do not exist on stable — verified via git ls-tree origin/stable. The only file present on stable is workbench/vitest/package.json, where the sole change is adding a zod dependency that solely supports the new fixture which isn't on stable, so the backport would be meaningless on its own.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

c58cae66122bed2c0dddfe7cf793def18c08b708

pranaygp added a commit that referenced this pull request Jun 11, 2026
…anch
- ai-sdk (#2099): tools inside the per-turn step are not individually
durable — remove the misleading "use step" directives and durability
claims, rewrite when-to-use, add the pitfall and corrected
streamText-vs-DurableAgent comparison
- child-workflows (#2100): replace spawn-and-poll (getRun().status loop)
with startAndWait() + withChildCompletionHook() hook resume
- durable-agent + agent-cancellation + human-in-the-loop (#2285):
DurableAgent is deprecated in v5 — add warn callout and notes pointing
at AI SDK v7's WorkflowAgent
- ai-sdk: add deployment-pinning versioning callout (#2010)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Docs] Cookbook update for child workflows pattern by karthikscale3 · Pull Request #2100 · vercel/workflow · GitHub
Skip to content

[Docs] Cookbook update for child workflows pattern - #2100

Merged
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion
May 25, 2026
Merged

[Docs] Cookbook update for child workflows pattern#2100
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites the v4 and v5 Child Workflows cookbook to recommend hook-based completion (defineHook + withChildCompletionHook + startAndWait) instead of getRun().status polling loops
  • Updates Workflow Composition cross-links in v4/v5 to point at the hook resume pattern
  • Updates the workbench cookbook fixture to spawn a wrapped child that resumes the parent hook in finally

Why

Polling child status in a durable sleep loop works but is slower to wake, holds worker slots when combined with returnValue, and requires extra result-collection steps. The hook resume pattern lets each child signal completion directly and keeps the parent suspended with zero compute until the child finishes.

Test plan

  • pnpm --filter @workflow/docs-typecheck typecheck
  • pnpm exec vitest run test/cookbook-common.test.ts -t "child-workflows" in workbench/vitest (local plugin env issue unrelated to this diff)
  • Review updated cookbook pages at /cookbook/advanced/child-workflows for v4 and v5

Made with Cursor

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — all four asks addressed cleanly

Karthik's fix commit (1c0e18ff0 Fix child-workflows cookbook review feedback) addresses all four items from the previous review:

AskFix
1. Type error in resumeParentCompletion (Docs Code Samples CI)Tightened to discriminated union in both v4 and v5
2. Missing zod dep (Vitest Plugin Tests CI)Added "zod": "catalog:" to workbench/vitest/package.json + lockfile
3. Unused resumeHook importRemoved
4. No changesetAdded empty changeset .changeset/cookbook-child-workflows-hook-resume.md

What I verified locally

  • pnpm install --frozen-lockfile ✓ (lockfile updated cleanly)
  • pnpm turbo run build --filter '!./workbench/*'
  • pnpm --filter @workflow/docs-typecheck test:docs ✓ (911/911 tests pass — child-workflows v4 and v5 both clean)
  • cd workbench/vitest && pnpm test ✓ (34/34 tests pass, including should spawn a child workflow via start() and collect its result)

CI

  • 37 success, 0 failures, 73 in progress — both previously-failing checks now green:
    • Docs Code Samples: pass (was failing on lines 33 of both v4 and v5)
    • Vitest Plugin Tests: pass (was failing on zod resolution)

Branch hygiene

The ~10 merge commits from main are still there — they'll be squashed away on merge so it's not a blocker, but a rebase would clean up the working history.

Nice work on the pattern. The hook resume + withChildCompletionHook + startAndWait shape is clean, and the prose explanation of why hooks beat polling (zero compute, immediate wake, typed payloads, no worker-pool pressure) is well-grounded with the Eager Processing link.

Approving.

karthikscale3and others added 2 commits May 25, 2026 10:03
Remove redundant polling comparison copy, the getRun() alternative section, and v5-only start() tips to keep the cookbook focused on the hook pattern.
Co-authored-by: Cursor <cursoragent@cursor.com>
@karthikscale3
karthikscale3 merged commit c58cae6 into mainMay 25, 2026
229 of 252 checks passed
@karthikscale3
karthikscale3 deleted the karthik/child-workflows-hook-completion branch May 25, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for c58cae6 (AI decision).

All meaningful changes target docs cookbook pages (docs/content/docs/v4/cookbook/..., docs/content/docs/v5/cookbook/..., docs/lib/cookbook-tree.ts) and a workbench/vitest fixture (workbench/vitest/workflows/cookbook/child-workflows.ts) that do not exist on stable — verified via git ls-tree origin/stable. The only file present on stable is workbench/vitest/package.json, where the sole change is adding a zod dependency that solely supports the new fixture which isn't on stable, so the backport would be meaningless on its own.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

c58cae66122bed2c0dddfe7cf793def18c08b708

pranaygp added a commit that referenced this pull request Jun 11, 2026
…anch
- ai-sdk (#2099): tools inside the per-turn step are not individually
durable — remove the misleading "use step" directives and durability
claims, rewrite when-to-use, add the pitfall and corrected
streamText-vs-DurableAgent comparison
- child-workflows (#2100): replace spawn-and-poll (getRun().status loop)
with startAndWait() + withChildCompletionHook() hook resume
- durable-agent + agent-cancellation + human-in-the-loop (#2285):
DurableAgent is deprecated in v5 — add warn callout and notes pointing
at AI SDK v7's WorkflowAgent
- ai-sdk: add deployment-pinning versioning callout (#2010)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Docs] Cookbook update for child workflows pattern by karthikscale3 · Pull Request #2100 · vercel/workflow · GitHub
Skip to content

[Docs] Cookbook update for child workflows pattern - #2100

Merged
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion
May 25, 2026
Merged

[Docs] Cookbook update for child workflows pattern#2100
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites the v4 and v5 Child Workflows cookbook to recommend hook-based completion (defineHook + withChildCompletionHook + startAndWait) instead of getRun().status polling loops
  • Updates Workflow Composition cross-links in v4/v5 to point at the hook resume pattern
  • Updates the workbench cookbook fixture to spawn a wrapped child that resumes the parent hook in finally

Why

Polling child status in a durable sleep loop works but is slower to wake, holds worker slots when combined with returnValue, and requires extra result-collection steps. The hook resume pattern lets each child signal completion directly and keeps the parent suspended with zero compute until the child finishes.

Test plan

  • pnpm --filter @workflow/docs-typecheck typecheck
  • pnpm exec vitest run test/cookbook-common.test.ts -t "child-workflows" in workbench/vitest (local plugin env issue unrelated to this diff)
  • Review updated cookbook pages at /cookbook/advanced/child-workflows for v4 and v5

Made with Cursor

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — all four asks addressed cleanly

Karthik's fix commit (1c0e18ff0 Fix child-workflows cookbook review feedback) addresses all four items from the previous review:

AskFix
1. Type error in resumeParentCompletion (Docs Code Samples CI)Tightened to discriminated union in both v4 and v5
2. Missing zod dep (Vitest Plugin Tests CI)Added "zod": "catalog:" to workbench/vitest/package.json + lockfile
3. Unused resumeHook importRemoved
4. No changesetAdded empty changeset .changeset/cookbook-child-workflows-hook-resume.md

What I verified locally

  • pnpm install --frozen-lockfile ✓ (lockfile updated cleanly)
  • pnpm turbo run build --filter '!./workbench/*'
  • pnpm --filter @workflow/docs-typecheck test:docs ✓ (911/911 tests pass — child-workflows v4 and v5 both clean)
  • cd workbench/vitest && pnpm test ✓ (34/34 tests pass, including should spawn a child workflow via start() and collect its result)

CI

  • 37 success, 0 failures, 73 in progress — both previously-failing checks now green:
    • Docs Code Samples: pass (was failing on lines 33 of both v4 and v5)
    • Vitest Plugin Tests: pass (was failing on zod resolution)

Branch hygiene

The ~10 merge commits from main are still there — they'll be squashed away on merge so it's not a blocker, but a rebase would clean up the working history.

Nice work on the pattern. The hook resume + withChildCompletionHook + startAndWait shape is clean, and the prose explanation of why hooks beat polling (zero compute, immediate wake, typed payloads, no worker-pool pressure) is well-grounded with the Eager Processing link.

Approving.

karthikscale3and others added 2 commits May 25, 2026 10:03
Remove redundant polling comparison copy, the getRun() alternative section, and v5-only start() tips to keep the cookbook focused on the hook pattern.
Co-authored-by: Cursor <cursoragent@cursor.com>
@karthikscale3
karthikscale3 merged commit c58cae6 into mainMay 25, 2026
229 of 252 checks passed
@karthikscale3
karthikscale3 deleted the karthik/child-workflows-hook-completion branch May 25, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for c58cae6 (AI decision).

All meaningful changes target docs cookbook pages (docs/content/docs/v4/cookbook/..., docs/content/docs/v5/cookbook/..., docs/lib/cookbook-tree.ts) and a workbench/vitest fixture (workbench/vitest/workflows/cookbook/child-workflows.ts) that do not exist on stable — verified via git ls-tree origin/stable. The only file present on stable is workbench/vitest/package.json, where the sole change is adding a zod dependency that solely supports the new fixture which isn't on stable, so the backport would be meaningless on its own.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

c58cae66122bed2c0dddfe7cf793def18c08b708

pranaygp added a commit that referenced this pull request Jun 11, 2026
…anch
- ai-sdk (#2099): tools inside the per-turn step are not individually
durable — remove the misleading "use step" directives and durability
claims, rewrite when-to-use, add the pitfall and corrected
streamText-vs-DurableAgent comparison
- child-workflows (#2100): replace spawn-and-poll (getRun().status loop)
with startAndWait() + withChildCompletionHook() hook resume
- durable-agent + agent-cancellation + human-in-the-loop (#2285):
DurableAgent is deprecated in v5 — add warn callout and notes pointing
at AI SDK v7's WorkflowAgent
- ai-sdk: add deployment-pinning versioning callout (#2010)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [Docs] Cookbook update for child workflows pattern by karthikscale3 · Pull Request #2100 · vercel/workflow · GitHub
Skip to content

[Docs] Cookbook update for child workflows pattern - #2100

Merged
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion
May 25, 2026
Merged

[Docs] Cookbook update for child workflows pattern#2100
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites the v4 and v5 Child Workflows cookbook to recommend hook-based completion (defineHook + withChildCompletionHook + startAndWait) instead of getRun().status polling loops
  • Updates Workflow Composition cross-links in v4/v5 to point at the hook resume pattern
  • Updates the workbench cookbook fixture to spawn a wrapped child that resumes the parent hook in finally

Why

Polling child status in a durable sleep loop works but is slower to wake, holds worker slots when combined with returnValue, and requires extra result-collection steps. The hook resume pattern lets each child signal completion directly and keeps the parent suspended with zero compute until the child finishes.

Test plan

  • pnpm --filter @workflow/docs-typecheck typecheck
  • pnpm exec vitest run test/cookbook-common.test.ts -t "child-workflows" in workbench/vitest (local plugin env issue unrelated to this diff)
  • Review updated cookbook pages at /cookbook/advanced/child-workflows for v4 and v5

Made with Cursor

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — all four asks addressed cleanly

Karthik's fix commit (1c0e18ff0 Fix child-workflows cookbook review feedback) addresses all four items from the previous review:

AskFix
1. Type error in resumeParentCompletion (Docs Code Samples CI)Tightened to discriminated union in both v4 and v5
2. Missing zod dep (Vitest Plugin Tests CI)Added "zod": "catalog:" to workbench/vitest/package.json + lockfile
3. Unused resumeHook importRemoved
4. No changesetAdded empty changeset .changeset/cookbook-child-workflows-hook-resume.md

What I verified locally

  • pnpm install --frozen-lockfile ✓ (lockfile updated cleanly)
  • pnpm turbo run build --filter '!./workbench/*'
  • pnpm --filter @workflow/docs-typecheck test:docs ✓ (911/911 tests pass — child-workflows v4 and v5 both clean)
  • cd workbench/vitest && pnpm test ✓ (34/34 tests pass, including should spawn a child workflow via start() and collect its result)

CI

  • 37 success, 0 failures, 73 in progress — both previously-failing checks now green:
    • Docs Code Samples: pass (was failing on lines 33 of both v4 and v5)
    • Vitest Plugin Tests: pass (was failing on zod resolution)

Branch hygiene

The ~10 merge commits from main are still there — they'll be squashed away on merge so it's not a blocker, but a rebase would clean up the working history.

Nice work on the pattern. The hook resume + withChildCompletionHook + startAndWait shape is clean, and the prose explanation of why hooks beat polling (zero compute, immediate wake, typed payloads, no worker-pool pressure) is well-grounded with the Eager Processing link.

Approving.

karthikscale3and others added 2 commits May 25, 2026 10:03
Remove redundant polling comparison copy, the getRun() alternative section, and v5-only start() tips to keep the cookbook focused on the hook pattern.
Co-authored-by: Cursor <cursoragent@cursor.com>
@karthikscale3
karthikscale3 merged commit c58cae6 into mainMay 25, 2026
229 of 252 checks passed
@karthikscale3
karthikscale3 deleted the karthik/child-workflows-hook-completion branch May 25, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for c58cae6 (AI decision).

All meaningful changes target docs cookbook pages (docs/content/docs/v4/cookbook/..., docs/content/docs/v5/cookbook/..., docs/lib/cookbook-tree.ts) and a workbench/vitest fixture (workbench/vitest/workflows/cookbook/child-workflows.ts) that do not exist on stable — verified via git ls-tree origin/stable. The only file present on stable is workbench/vitest/package.json, where the sole change is adding a zod dependency that solely supports the new fixture which isn't on stable, so the backport would be meaningless on its own.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

c58cae66122bed2c0dddfe7cf793def18c08b708

pranaygp added a commit that referenced this pull request Jun 11, 2026
…anch
- ai-sdk (#2099): tools inside the per-turn step are not individually
durable — remove the misleading "use step" directives and durability
claims, rewrite when-to-use, add the pitfall and corrected
streamText-vs-DurableAgent comparison
- child-workflows (#2100): replace spawn-and-poll (getRun().status loop)
with startAndWait() + withChildCompletionHook() hook resume
- durable-agent + agent-cancellation + human-in-the-loop (#2285):
DurableAgent is deprecated in v5 — add warn callout and notes pointing
at AI SDK v7's WorkflowAgent
- ai-sdk: add deployment-pinning versioning callout (#2010)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Docs] Cookbook update for child workflows pattern by karthikscale3 · Pull Request #2100 · vercel/workflow · GitHub
Skip to content

[Docs] Cookbook update for child workflows pattern - #2100

Merged
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion
May 25, 2026
Merged

[Docs] Cookbook update for child workflows pattern#2100
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites the v4 and v5 Child Workflows cookbook to recommend hook-based completion (defineHook + withChildCompletionHook + startAndWait) instead of getRun().status polling loops
  • Updates Workflow Composition cross-links in v4/v5 to point at the hook resume pattern
  • Updates the workbench cookbook fixture to spawn a wrapped child that resumes the parent hook in finally

Why

Polling child status in a durable sleep loop works but is slower to wake, holds worker slots when combined with returnValue, and requires extra result-collection steps. The hook resume pattern lets each child signal completion directly and keeps the parent suspended with zero compute until the child finishes.

Test plan

  • pnpm --filter @workflow/docs-typecheck typecheck
  • pnpm exec vitest run test/cookbook-common.test.ts -t "child-workflows" in workbench/vitest (local plugin env issue unrelated to this diff)
  • Review updated cookbook pages at /cookbook/advanced/child-workflows for v4 and v5

Made with Cursor

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — all four asks addressed cleanly

Karthik's fix commit (1c0e18ff0 Fix child-workflows cookbook review feedback) addresses all four items from the previous review:

AskFix
1. Type error in resumeParentCompletion (Docs Code Samples CI)Tightened to discriminated union in both v4 and v5
2. Missing zod dep (Vitest Plugin Tests CI)Added "zod": "catalog:" to workbench/vitest/package.json + lockfile
3. Unused resumeHook importRemoved
4. No changesetAdded empty changeset .changeset/cookbook-child-workflows-hook-resume.md

What I verified locally

  • pnpm install --frozen-lockfile ✓ (lockfile updated cleanly)
  • pnpm turbo run build --filter '!./workbench/*'
  • pnpm --filter @workflow/docs-typecheck test:docs ✓ (911/911 tests pass — child-workflows v4 and v5 both clean)
  • cd workbench/vitest && pnpm test ✓ (34/34 tests pass, including should spawn a child workflow via start() and collect its result)

CI

  • 37 success, 0 failures, 73 in progress — both previously-failing checks now green:
    • Docs Code Samples: pass (was failing on lines 33 of both v4 and v5)
    • Vitest Plugin Tests: pass (was failing on zod resolution)

Branch hygiene

The ~10 merge commits from main are still there — they'll be squashed away on merge so it's not a blocker, but a rebase would clean up the working history.

Nice work on the pattern. The hook resume + withChildCompletionHook + startAndWait shape is clean, and the prose explanation of why hooks beat polling (zero compute, immediate wake, typed payloads, no worker-pool pressure) is well-grounded with the Eager Processing link.

Approving.

karthikscale3and others added 2 commits May 25, 2026 10:03
Remove redundant polling comparison copy, the getRun() alternative section, and v5-only start() tips to keep the cookbook focused on the hook pattern.
Co-authored-by: Cursor <cursoragent@cursor.com>
@karthikscale3
karthikscale3 merged commit c58cae6 into mainMay 25, 2026
229 of 252 checks passed
@karthikscale3
karthikscale3 deleted the karthik/child-workflows-hook-completion branch May 25, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for c58cae6 (AI decision).

All meaningful changes target docs cookbook pages (docs/content/docs/v4/cookbook/..., docs/content/docs/v5/cookbook/..., docs/lib/cookbook-tree.ts) and a workbench/vitest fixture (workbench/vitest/workflows/cookbook/child-workflows.ts) that do not exist on stable — verified via git ls-tree origin/stable. The only file present on stable is workbench/vitest/package.json, where the sole change is adding a zod dependency that solely supports the new fixture which isn't on stable, so the backport would be meaningless on its own.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

c58cae66122bed2c0dddfe7cf793def18c08b708

pranaygp added a commit that referenced this pull request Jun 11, 2026
…anch
- ai-sdk (#2099): tools inside the per-turn step are not individually
durable — remove the misleading "use step" directives and durability
claims, rewrite when-to-use, add the pitfall and corrected
streamText-vs-DurableAgent comparison
- child-workflows (#2100): replace spawn-and-poll (getRun().status loop)
with startAndWait() + withChildCompletionHook() hook resume
- durable-agent + agent-cancellation + human-in-the-loop (#2285):
DurableAgent is deprecated in v5 — add warn callout and notes pointing
at AI SDK v7's WorkflowAgent
- ai-sdk: add deployment-pinning versioning callout (#2010)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Docs] Cookbook update for child workflows pattern by karthikscale3 · Pull Request #2100 · vercel/workflow · GitHub
Skip to content

[Docs] Cookbook update for child workflows pattern - #2100

Merged
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion
May 25, 2026
Merged

[Docs] Cookbook update for child workflows pattern#2100
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites the v4 and v5 Child Workflows cookbook to recommend hook-based completion (defineHook + withChildCompletionHook + startAndWait) instead of getRun().status polling loops
  • Updates Workflow Composition cross-links in v4/v5 to point at the hook resume pattern
  • Updates the workbench cookbook fixture to spawn a wrapped child that resumes the parent hook in finally

Why

Polling child status in a durable sleep loop works but is slower to wake, holds worker slots when combined with returnValue, and requires extra result-collection steps. The hook resume pattern lets each child signal completion directly and keeps the parent suspended with zero compute until the child finishes.

Test plan

  • pnpm --filter @workflow/docs-typecheck typecheck
  • pnpm exec vitest run test/cookbook-common.test.ts -t "child-workflows" in workbench/vitest (local plugin env issue unrelated to this diff)
  • Review updated cookbook pages at /cookbook/advanced/child-workflows for v4 and v5

Made with Cursor

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — all four asks addressed cleanly

Karthik's fix commit (1c0e18ff0 Fix child-workflows cookbook review feedback) addresses all four items from the previous review:

AskFix
1. Type error in resumeParentCompletion (Docs Code Samples CI)Tightened to discriminated union in both v4 and v5
2. Missing zod dep (Vitest Plugin Tests CI)Added "zod": "catalog:" to workbench/vitest/package.json + lockfile
3. Unused resumeHook importRemoved
4. No changesetAdded empty changeset .changeset/cookbook-child-workflows-hook-resume.md

What I verified locally

  • pnpm install --frozen-lockfile ✓ (lockfile updated cleanly)
  • pnpm turbo run build --filter '!./workbench/*'
  • pnpm --filter @workflow/docs-typecheck test:docs ✓ (911/911 tests pass — child-workflows v4 and v5 both clean)
  • cd workbench/vitest && pnpm test ✓ (34/34 tests pass, including should spawn a child workflow via start() and collect its result)

CI

  • 37 success, 0 failures, 73 in progress — both previously-failing checks now green:
    • Docs Code Samples: pass (was failing on lines 33 of both v4 and v5)
    • Vitest Plugin Tests: pass (was failing on zod resolution)

Branch hygiene

The ~10 merge commits from main are still there — they'll be squashed away on merge so it's not a blocker, but a rebase would clean up the working history.

Nice work on the pattern. The hook resume + withChildCompletionHook + startAndWait shape is clean, and the prose explanation of why hooks beat polling (zero compute, immediate wake, typed payloads, no worker-pool pressure) is well-grounded with the Eager Processing link.

Approving.

karthikscale3and others added 2 commits May 25, 2026 10:03
Remove redundant polling comparison copy, the getRun() alternative section, and v5-only start() tips to keep the cookbook focused on the hook pattern.
Co-authored-by: Cursor <cursoragent@cursor.com>
@karthikscale3
karthikscale3 merged commit c58cae6 into mainMay 25, 2026
229 of 252 checks passed
@karthikscale3
karthikscale3 deleted the karthik/child-workflows-hook-completion branch May 25, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for c58cae6 (AI decision).

All meaningful changes target docs cookbook pages (docs/content/docs/v4/cookbook/..., docs/content/docs/v5/cookbook/..., docs/lib/cookbook-tree.ts) and a workbench/vitest fixture (workbench/vitest/workflows/cookbook/child-workflows.ts) that do not exist on stable — verified via git ls-tree origin/stable. The only file present on stable is workbench/vitest/package.json, where the sole change is adding a zod dependency that solely supports the new fixture which isn't on stable, so the backport would be meaningless on its own.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

c58cae66122bed2c0dddfe7cf793def18c08b708

pranaygp added a commit that referenced this pull request Jun 11, 2026
…anch
- ai-sdk (#2099): tools inside the per-turn step are not individually
durable — remove the misleading "use step" directives and durability
claims, rewrite when-to-use, add the pitfall and corrected
streamText-vs-DurableAgent comparison
- child-workflows (#2100): replace spawn-and-poll (getRun().status loop)
with startAndWait() + withChildCompletionHook() hook resume
- durable-agent + agent-cancellation + human-in-the-loop (#2285):
DurableAgent is deprecated in v5 — add warn callout and notes pointing
at AI SDK v7's WorkflowAgent
- ai-sdk: add deployment-pinning versioning callout (#2010)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [Docs] Cookbook update for child workflows pattern by karthikscale3 · Pull Request #2100 · vercel/workflow · GitHub
Skip to content

[Docs] Cookbook update for child workflows pattern - #2100

Merged
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion
May 25, 2026
Merged

[Docs] Cookbook update for child workflows pattern#2100
karthikscale3 merged 108 commits into
mainfrom
karthik/child-workflows-hook-completion

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites the v4 and v5 Child Workflows cookbook to recommend hook-based completion (defineHook + withChildCompletionHook + startAndWait) instead of getRun().status polling loops
  • Updates Workflow Composition cross-links in v4/v5 to point at the hook resume pattern
  • Updates the workbench cookbook fixture to spawn a wrapped child that resumes the parent hook in finally

Why

Polling child status in a durable sleep loop works but is slower to wake, holds worker slots when combined with returnValue, and requires extra result-collection steps. The hook resume pattern lets each child signal completion directly and keeps the parent suspended with zero compute until the child finishes.

Test plan

  • pnpm --filter @workflow/docs-typecheck typecheck
  • pnpm exec vitest run test/cookbook-common.test.ts -t "child-workflows" in workbench/vitest (local plugin env issue unrelated to this diff)
  • Review updated cookbook pages at /cookbook/advanced/child-workflows for v4 and v5

Made with Cursor

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — all four asks addressed cleanly

Karthik's fix commit (1c0e18ff0 Fix child-workflows cookbook review feedback) addresses all four items from the previous review:

AskFix
1. Type error in resumeParentCompletion (Docs Code Samples CI)Tightened to discriminated union in both v4 and v5
2. Missing zod dep (Vitest Plugin Tests CI)Added "zod": "catalog:" to workbench/vitest/package.json + lockfile
3. Unused resumeHook importRemoved
4. No changesetAdded empty changeset .changeset/cookbook-child-workflows-hook-resume.md

What I verified locally

  • pnpm install --frozen-lockfile ✓ (lockfile updated cleanly)
  • pnpm turbo run build --filter '!./workbench/*'
  • pnpm --filter @workflow/docs-typecheck test:docs ✓ (911/911 tests pass — child-workflows v4 and v5 both clean)
  • cd workbench/vitest && pnpm test ✓ (34/34 tests pass, including should spawn a child workflow via start() and collect its result)

CI

  • 37 success, 0 failures, 73 in progress — both previously-failing checks now green:
    • Docs Code Samples: pass (was failing on lines 33 of both v4 and v5)
    • Vitest Plugin Tests: pass (was failing on zod resolution)

Branch hygiene

The ~10 merge commits from main are still there — they'll be squashed away on merge so it's not a blocker, but a rebase would clean up the working history.

Nice work on the pattern. The hook resume + withChildCompletionHook + startAndWait shape is clean, and the prose explanation of why hooks beat polling (zero compute, immediate wake, typed payloads, no worker-pool pressure) is well-grounded with the Eager Processing link.

Approving.

karthikscale3and others added 2 commits May 25, 2026 10:03
Remove redundant polling comparison copy, the getRun() alternative section, and v5-only start() tips to keep the cookbook focused on the hook pattern.
Co-authored-by: Cursor <cursoragent@cursor.com>
@karthikscale3
karthikscale3 merged commit c58cae6 into mainMay 25, 2026
229 of 252 checks passed
@karthikscale3
karthikscale3 deleted the karthik/child-workflows-hook-completion branch May 25, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for c58cae6 (AI decision).

All meaningful changes target docs cookbook pages (docs/content/docs/v4/cookbook/..., docs/content/docs/v5/cookbook/..., docs/lib/cookbook-tree.ts) and a workbench/vitest fixture (workbench/vitest/workflows/cookbook/child-workflows.ts) that do not exist on stable — verified via git ls-tree origin/stable. The only file present on stable is workbench/vitest/package.json, where the sole change is adding a zod dependency that solely supports the new fixture which isn't on stable, so the backport would be meaningless on its own.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

c58cae66122bed2c0dddfe7cf793def18c08b708

pranaygp added a commit that referenced this pull request Jun 11, 2026
…anch
- ai-sdk (#2099): tools inside the per-turn step are not individually
durable — remove the misleading "use step" directives and durability
claims, rewrite when-to-use, add the pitfall and corrected
streamText-vs-DurableAgent comparison
- child-workflows (#2100): replace spawn-and-poll (getRun().status loop)
with startAndWait() + withChildCompletionHook() hook resume
- durable-agent + agent-cancellation + human-in-the-loop (#2285):
DurableAgent is deprecated in v5 — add warn callout and notes pointing
at AI SDK v7's WorkflowAgent
- ai-sdk: add deployment-pinning versioning callout (#2010)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@TooTallNate