Uh oh!
There was an error while loading. Please reload this page.
Prevent local tests from hanging - #2338
Conversation
🦋 Changeset detectedLatest commit: 7e1db60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@xujustinj is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
96bfcc2 to
83a2a77CompareThis commit allows manually running pnpm test: - use vitest run to stop world-vercel and world-testing when complete - disable Nuxt telemetry to prevent interactive telemetry prompt Signed-off-by: Justin Xu <xu.justin.j@gmail.com>
pranaygp
left a comment
There was a problem hiding this comment.
Reviewed and verified locally on this branch: world-vercel (131 tests) and world-testing (10 tests, via pnpm test --filter @workflow/world-testing so turbo builds deps first) both pass and exit cleanly, and the @workflow/nuxt build works with the env var set. The vitest run change matches what every other package in the repo already does (world-testing correctly omits the src filter since its tests live in test/), and there's no CI impact — vitest auto-disables watch mode and Nuxt skips the consent prompt when CI is set, which is why these hangs never showed up in CI. One non-blocking suggestion inline.
| "build": "NUXT_TELEMETRY_DISABLED=1 nuxt-module-build prepare && NUXT_TELEMETRY_DISABLED=1 nuxt-module-build build", | ||
| "dev": "NUXT_TELEMETRY_DISABLED=1 nuxt-module-build build --stub && NUXT_TELEMETRY_DISABLED=1 nuxt-module-build prepare", |
There was a problem hiding this comment.
Two related notes on the env-var approach (non-blocking):
Inline
VAR=1 cmdsyntax doesn't work on Windows — pnpm runs scripts through cmd.exe by default (this repo doesn't enable pnpm's shell emulator), soNUXT_TELEMETRY_DISABLED=1would be treated as a command and the build would fail. Other scripts in this repo usecross-envfor exactly this (seepackages/core'stestscript).An alternative that solves both problems at once: add a repo-root
.nuxtrcwithtelemetry.enabled=false.@nuxt/kitloads.nuxtrcfrom the workspace root (c12'sglobalRcoption resolves it viafindWorkspaceDir, keyed offpnpm-workspace.yaml), so it's cross-platform, keeps these scripts untouched, and would also coverworkbench/nuxt'snuxt build/nuxt dev— which hit the same first-run consent prompt in a fresh environment and aren't addressed by this PR.
There was a problem hiding this comment.
Addressed in 7e1db60: reverted the inline env vars and added a workspace-root .nuxtrc with telemetry.enabled=false instead. Verified that both packages/nuxt (nuxt-module-build) and workbench/nuxt resolve it from the workspace root (tested with HOME pointed at an empty dir so no user-level ~/.nuxtrc could mask it), and the @workflow/nuxt build completes cleanly. Also dropped @workflow/nuxt from the changeset since that package is no longer modified.
The inline NUXT_TELEMETRY_DISABLED=1 in package.json scripts doesn't work on Windows (pnpm runs scripts through cmd.exe). A workspace-root .nuxtrc is cross-platform, and @nuxt/kit resolves it from the pnpm workspace root, so it also covers workbench/nuxt's build/dev, which hit the same first-run consent prompt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
* Prevent local tests from hanging This commit allows manually running pnpm test: - use vitest run to stop world-vercel and world-testing when complete - disable Nuxt telemetry to prevent interactive telemetry prompt Signed-off-by: Justin Xu <xu.justin.j@gmail.com> * Disable Nuxt telemetry via workspace .nuxtrc instead of inline env vars The inline NUXT_TELEMETRY_DISABLED=1 in package.json scripts doesn't work on Windows (pnpm runs scripts through cmd.exe). A workspace-root .nuxtrc is cross-platform, and @nuxt/kit resolves it from the pnpm workspace root, so it also covers workbench/nuxt's build/dev, which hit the same first-run consent prompt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Signed-off-by: Justin Xu <xu.justin.j@gmail.com> Co-authored-by: Pranay Prakash <pranay.gp@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Justin Xu <xu.justin.j@gmail.com>
Backport PR opened against |
…hook-ready * origin-https/main: (119 commits) fix: settle aborted parallel steps before completing abortParallelWorkflow (#2244) Add native v4 workflow attribute events (#2226) Version Packages (beta) (#2326) [ci] Fix flaky windows unit tests (#2359) Capture Vercel runtime logs when e2e Vercel Prod lanes fail (#2356) Fix e2e failure reporting under vitest 4 and preserve fetch error causes (#2355) [core] Fix process crash from rejected waitUntil promises (#2336) [core] Remove duplicate `waitUntil` for suspension handler async operations (#2345) Prevent local tests from hanging (#2338) feat(core): add optional namespace for queue topic prefix (#2305) [web-shared] Show precise durations in the new trace viewer (#2335) Validate unique workflow step IDs at build time (#2018) Move run attributes into their own detail card (#2327) [core] Forward-port stream reconnect to getReadable level (#2318) [docs] Add "Step executed multiple times" error page (#2310) Fix flickering on the detail panel when navigating the trace viewer (#2325) Version Packages (beta) (#2254) Patch vulnerable package dependencies (#2301) Deprecate DurableAgent and update it with WorkflowAgent in v5 docs (#2285) [codex] Fix partial world-local exclusive writes (#2296) ... # Conflicts: # packages/core/src/runtime.ts # packages/core/src/runtime/suspension-handler.ts
…docs-run-idempotency * origin-https/main: (115 commits) [core] V2: unify wait+step queue dispatch in suspension processing (#1925) fix(world-local,world-postgres): make duplicate hook_created idempotent (#2295) docs(observability): remove MVP implementation detail bullet (#2367) fix: settle aborted parallel steps before completing abortParallelWorkflow (#2244) Add native v4 workflow attribute events (#2226) Version Packages (beta) (#2326) [ci] Fix flaky windows unit tests (#2359) Capture Vercel runtime logs when e2e Vercel Prod lanes fail (#2356) Fix e2e failure reporting under vitest 4 and preserve fetch error causes (#2355) [core] Fix process crash from rejected waitUntil promises (#2336) [core] Remove duplicate `waitUntil` for suspension handler async operations (#2345) Prevent local tests from hanging (#2338) feat(core): add optional namespace for queue topic prefix (#2305) [web-shared] Show precise durations in the new trace viewer (#2335) Validate unique workflow step IDs at build time (#2018) Move run attributes into their own detail card (#2327) [core] Forward-port stream reconnect to getReadable level (#2318) [docs] Add "Step executed multiple times" error page (#2310) Fix flickering on the detail panel when navigating the trace viewer (#2325) Version Packages (beta) (#2254) ... # Conflicts: # docs/content/docs/v4/cookbook/advanced/child-workflows.mdx # docs/content/docs/v5/cookbook/advanced/child-workflows.mdx # docs/content/docs/v5/cookbook/agent-patterns/durable-agent.mdx
* origin/main: [core] V2: unify wait+step queue dispatch in suspension processing (#1925) fix(world-local,world-postgres): make duplicate hook_created idempotent (#2295) docs(observability): remove MVP implementation detail bullet (#2367) fix: settle aborted parallel steps before completing abortParallelWorkflow (#2244) Add native v4 workflow attribute events (#2226) Version Packages (beta) (#2326) [ci] Fix flaky windows unit tests (#2359) Capture Vercel runtime logs when e2e Vercel Prod lanes fail (#2356) Fix e2e failure reporting under vitest 4 and preserve fetch error causes (#2355) [core] Fix process crash from rejected waitUntil promises (#2336) [core] Remove duplicate `waitUntil` for suspension handler async operations (#2345) Prevent local tests from hanging (#2338) feat(core): add optional namespace for queue topic prefix (#2305) [web-shared] Show precise durations in the new trace viewer (#2335) Validate unique workflow step IDs at build time (#2018) Move run attributes into their own detail card (#2327) [core] Forward-port stream reconnect to getReadable level (#2318) [docs] Add "Step executed multiple times" error page (#2310) Fix flickering on the detail panel when navigating the trace viewer (#2325)
Summary
This commit fixes the ability to manually run
pnpm test:vitest runto stopworld-vercelandworld-testingwhen completeBackground
On a fresh clone of this repo on my own machine, I ran setup with
pnpm i. Then I ranpnpm test, and the tests hung on three workers:nuxtworld-testingworld-vercelThe
world-verceltest passed but hung on the following:Likewise for
world-testing.Meanwhile
nuxthung because of an interactive prompt asking for telemetry:I encountered this because I have never configured Nuxt on my machine, and this will occur to anyone else in the same situation. You can reproduce this by deleting the
telemetry.enabledline in~/.nuxtrc.For various reasons I don't understand these hangs do not occur in CI.
Changes
vitest runinstead ofvitest(watch mode) so thatworld-testingandworld-vercelboth stop when tests passNUXT_TELEMETRY_DISABLED=1to prevent telemetry during the build for testing (I'm less sure about this one, maybe it's undesirable)After these tests
pnpm testruns to completion as expected.