Uh oh!
There was an error while loading. Please reload this page.
Propagate trace context to vercel-workflow.com in workbench instrumentation - #2601
Merged
Conversation
…tation @vercel/otel only propagates W3C trace context to Vercel deployment URLs by default, so outgoing requests to the workflow-server (vercel-workflow.com) got a client span with no `traceparent` header — breaking the APM trace link to workflow-server's spans. Add `instrumentationConfig.fetch.propagateContextUrls` for the workflow-server domain in every workbench that uses @vercel/otel: example, nextjs-turbopack, nextjs-webpack, and sveltekit. The Next.js and SvelteKit apps already declared @vercel/otel but weren't registering it at all; they now do. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)sveltekit (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
…e.com) The workflow-server queue path (@vercel/queue) sends to regional vercel-queue.com subdomains (e.g. iad1.vercel-queue.com) when not using the queues proxy, which were missing a `traceparent` header for the same reason as vercel-workflow.com. Add `/vercel-queue\.com/` to propagateContextUrls in all four workbench instrumentation configs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actionsBot
added a commit
that referenced
this pull request
Jun 23, 2026
…tation (#2601) * Propagate trace context to vercel-workflow.com in workbench instrumentation @vercel/otel only propagates W3C trace context to Vercel deployment URLs by default, so outgoing requests to the workflow-server (vercel-workflow.com) got a client span with no `traceparent` header — breaking the APM trace link to workflow-server's spans. Add `instrumentationConfig.fetch.propagateContextUrls` for the workflow-server domain in every workbench that uses @vercel/otel: example, nextjs-turbopack, nextjs-webpack, and sveltekit. The Next.js and SvelteKit apps already declared @vercel/otel but weren't registering it at all; they now do. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Also propagate trace context to the Vercel Queue Service (vercel-queue.com) The workflow-server queue path (@vercel/queue) sends to regional vercel-queue.com subdomains (e.g. iad1.vercel-queue.com) when not using the queues proxy, which were missing a `traceparent` header for the same reason as vercel-workflow.com. Add `/vercel-queue\.com/` to propagateContextUrls in all four workbench instrumentation configs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Pranay Prakash <pranay.gp@gmail.com>
Contributor
Backport PR opened against |
pranaygp added a commit
that referenced
this pull request
Jun 26, 2026
* origin/main: (46 commits) [web] Fix HTTP/2 in bundled server build so observability reads work (#2632) [core] Fix turbo-mode step-body writes racing run_started (#2629) fix(world-postgres): rename setup command (#2644) chore: ignore workflow swc caches (#2640) fix(ai): ignore intentional stream aborts (#2635) fix(nitro): reload steps during Vite HMR (#2572) [world] Make @workflow/world own its Zod dependency (#2622) feat(web-shared): extend cn with custom tailwind-merge class groups (#2619) [world-vercel] Enable HTTP/2 for the events API and stream writes (#2573) Remove shadow from off-screen marker indicator button (#2614) Fix discovery of dotted JS workflow imports (#2594) Version Packages (beta) (#2597) Thread occurredAt into web-shared entities (#2608) Propagate trace context to vercel-workflow.com in workbench instrumentation (#2601) Reduce workflow build log noise (#2565) Version Packages (beta) (#2596) Use text-gray-900 for trace shortcut helper text (#2595) Trace /flow route initialization (#2592) Version Packages (beta) (#2591) feat(web): add trace step shortcut helper (#2582) ... # Conflicts: # workbench/nextjs-turbopack/instrumentation.ts # workbench/nextjs-webpack/instrumentation.ts
pranaygp pushed a commit
that referenced
this pull request
Jun 29, 2026
…tation (#2601) (#2602) * Propagate trace context to vercel-workflow.com in workbench instrumentation @vercel/otel only propagates W3C trace context to Vercel deployment URLs by default, so outgoing requests to the workflow-server (vercel-workflow.com) got a client span with no `traceparent` header — breaking the APM trace link to workflow-server's spans. Add `instrumentationConfig.fetch.propagateContextUrls` for the workflow-server domain in every workbench that uses @vercel/otel: example, nextjs-turbopack, nextjs-webpack, and sveltekit. The Next.js and SvelteKit apps already declared @vercel/otel but weren't registering it at all; they now do. * Also propagate trace context to the Vercel Queue Service (vercel-queue.com) The workflow-server queue path (@vercel/queue) sends to regional vercel-queue.com subdomains (e.g. iad1.vercel-queue.com) when not using the queues proxy, which were missing a `traceparent` header for the same reason as vercel-workflow.com. Add `/vercel-queue\.com/` to propagateContextUrls in all four workbench instrumentation configs. --------- Signed-off-by: Pranay Prakash <pranay.gp@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Peter Wielander <mittgfu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vercel/otelpropagates W3C trace context only to Vercel deployment URLs by default (confirmed in both the package'sFetchInstrumentationConfigtype docs and its compiledshouldPropagatematcher). As a result, every outgoing request from a workbench app to the workflow-server backends got a client span but notraceparentheader, so their spans never joined the workbench's invocation trace in APM. Two backends are affected:https://vercel-workflow.com*.vercel-queue.comsubdomains (e.g.iad1.vercel-queue.com), used by@vercel/queuewhen not routing through the queues proxyThis adds
instrumentationConfig.fetch.propagateContextUrls: [/vercel-workflow\.com/, /vercel-queue\.com/]to every workbench that uses@vercel/otel:exampleinstrumentation.tsregisterOTelnextjs-turbopackinstrumentation.tsexport function register()(nosrc/)nextjs-webpackinstrumentation.tsexport function register()sveltekitsrc/hooks.server.tsregisterOTel, before the existinginithooknextjs-turbopack,nextjs-webpack, andsveltekitalready declared@vercel/otelas a dependency but weren't registering it anywhere — they now do, in addition to the propagation fix.Why regex matchers
The matcher does
url.toString().startsWith(matcher)for strings against the full URL, so a bare'vercel-workflow.com'would not matchhttps://vercel-workflow.com/.... Regexes match the host wherever it appears, and/vercel-queue\.com/covers every regional subdomain. Default propagation still covers deployment/branch/VERCEL_URLhosts (including the/queues-proxypath on the deployment's own host), so only the two backend domains are added.This complements the manual
injectTraceContextIntoHeadersin@workflow/world-vercel(which covers world-vercel's custom-dispatcher paths that auto-instrumentation can't reliably hook); this PR covers the standardfetchpaths that@vercel/oteldoes hook.Notes
.changeset/config.json'signorelist.🤖 Generated with Claude Code