build: declare typescript (catalog:) in every package that runs tsc - #2898

Merged
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep
Jul 13, 2026
Merged

build: declare typescript (catalog:) in every package that runs tsc#2898
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Problem

Twenty packages invoke tsc in their build/typecheck scripts without declaring a typescript dependency — they resolve whatever tsc pnpm happens to leave reachable (usually the hoisted root copy).

After the TypeScript 6 upgrade (#2700), the shared base.json uses the TS6-only "types": ["*"] wildcard. Worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned typescript@5.9.3 bins that pnpm never refreshes for an undeclared dependency) fail with:

error TS2688: Cannot find type definition file for '*'.

Hit locally in @workflow/astro, @workflow/world-postgres, and @workflow/nuxt — invisible in CI because fresh installs never have the stale shims.

Fix

Add "typescript": "catalog:" to the devDependencies of every package whose scripts run tsc (the convention @workflow/nest already follows). pnpm then owns each package's tsc bin shim and refreshes it on catalog upgrades, making this staleness class structurally impossible — and pinning every package to the workspace catalog version (^6.0.3) hermetically.

Packages without tsc in their scripts are left unchanged (nuxt, swc-plugin, tsconfig, plus those already declaring it).

Validation

  • All package-local pnpm exec tsc --version → 6.0.3
  • Full pnpm build: 27/27 tasks green
  • Diff is surgical: one devDependencies line per package (+ lockfile)

Twenty packages invoke tsc in their build/typecheck scripts without
declaring a typescript dependency, resolving whatever tsc pnpm happens
to leave reachable. That broke locally after the TypeScript 6 upgrade
(#2700): base.json now uses the TS6-only 'types': ['*'] wildcard, and
worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned
typescript@5.9.3 bins that pnpm never refreshes for an undeclared
dependency) fail with TS2688 'Cannot find type definition file for *'.
Declaring 'typescript': 'catalog:' (the convention nest already
follows) makes pnpm own each package's tsc bin, so version upgrades
refresh the shims and this staleness class cannot recur. Packages
without tsc in their scripts are left unchanged.
Full pnpm build: 27/27 tasks green.
CopilotAI review requested due to automatic review settings July 13, 2026 17:04
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 13, 2026 17:04
@changeset-bot

changeset-botBot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 85cd8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 85cd8d7 · Mon, 13 Jul 2026 18:05:34 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1276 (+5.4%)1631 🔴1694 🔴2456 🔴30
TTFShook + stream1605 (+6.5%)2020 🔴2056 🔴2322 🔴30
STSO1020 steps (1-20)244 (-10%)263 🔴332 🔴349 🔴19
STSO1020 steps (101-120)401 (-0.7%)448 🔴492 🔴500 🔴19
STSO1020 steps (1001-1020)850 (-6.2%)871 🔴964 🔴1088 🔴19
WOstream1276 (+5.4%)16311694245630
WOhook + stream1605 (+6.5%)20202056232230
SLstream4355 (-6.7%)5156 🔴5534 🔴5757 🔴30
SLhook + stream4837 (-4.5%)5391 🔴5514 🔴5593 🔴30
📜 Previous results (1)

1af2605

Mon, 13 Jul 2026 17:27:04 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1258 (+8.9%)1691 🔴1737 🔴2185 🔴30
TTFShook + stream1669 (+16%)2165 🔴2286 🔴2475 🔴30
STSO1020 steps (1-20)294 (-3.2%)331 🔴465 🔴509 🔴19
STSO1020 steps (101-120)482 (+12%)521 🔴599 🔴825 🔴19
STSO1020 steps (1001-1020)1117 (+31%)1198 🔴1427 🔴1493 🔴19
WOstream1258 (+8.9%)16911737218530
WOhook + stream1669 (+16%)21652286247530
SLstream4477 (-3.0%)5687 🔴5798 🔴5845 🔴30
SLhook + stream4922 (-4.0%)5610 🔴5779 🔴5885 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateTooTallNate changed the title build: declare typescript (catalog:) in every package that runs tscbuild: declare typescript (catalog:) in every package that runs tscJul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit per-package TypeScript toolchain ownership by declaring typescript: "catalog:" in packages that run tsc, preventing stale node_modules/.bin/tsc shims from causing TS6 config incompatibility errors in existing worktrees.

Changes:

  • Add typescript: "catalog:" to devDependencies for multiple packages that invoke tsc in build/typecheck scripts.
  • Update pnpm-lock.yaml to reflect the added per-package TypeScript dependencies.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile updated for newly declared per-package typescript dependencies (currently includes additional resolution churn to verify).
packages/world/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-vercel/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-testing/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-postgres/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-local/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/workflow/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vitest/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vite/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/utils/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/sveltekit/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/serde/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/rollup/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/nitro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/next/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/errors/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/core/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/cli/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/builders/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/astro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/ai/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/world/package.json
Comment threadpnpm-lock.yaml
- packages/world listed zod in both dependencies and devDependencies
(pre-existing on main, surfaced by the devDependencies sort) — keep
the runtime dependency only.
- Regenerate pnpm-lock.yaml from a pristine main baseline with
--lockfile-only (a clean-main run produces zero diff, so main has no
drift). Remaining non-typescript changes are mechanical consequences
of the change itself: typescript is an (optional) peer of several
tooling dependencies, so declaring it in 20 importers creates new
peer-resolution snapshot variants and prunes the now-orphaned old
ones; plus one radix-ui 1.6.1->1.6.2 refresh in docs caused by its
floating 'latest' specifier.
- Validated: pnpm install --frozen-lockfile succeeds; full build 27/27.
@TooTallNate
TooTallNate enabled auto-merge (squash) July 13, 2026 17:52
@TooTallNate
TooTallNate merged commit b01ed54 into mainJul 13, 2026
236 of 240 checks passed
@TooTallNate
TooTallNate deleted the fix/declare-typescript-dep branch July 13, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Backport to stable failed for b01ed54 due to a workflow error (backport job run).

This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details.

Once the underlying issue is fixed, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b01ed548d798f96eea9580dd82e2e3f4671105b6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TooTallNate@VaguelySerious@karthikscale3@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

build: declare typescript (catalog:) in every package that runs tsc - #2898

Merged
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep
Jul 13, 2026
Merged

build: declare typescript (catalog:) in every package that runs tsc#2898
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Problem

Twenty packages invoke tsc in their build/typecheck scripts without declaring a typescript dependency — they resolve whatever tsc pnpm happens to leave reachable (usually the hoisted root copy).

After the TypeScript 6 upgrade (#2700), the shared base.json uses the TS6-only "types": ["*"] wildcard. Worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned typescript@5.9.3 bins that pnpm never refreshes for an undeclared dependency) fail with:

error TS2688: Cannot find type definition file for '*'.

Hit locally in @workflow/astro, @workflow/world-postgres, and @workflow/nuxt — invisible in CI because fresh installs never have the stale shims.

Fix

Add "typescript": "catalog:" to the devDependencies of every package whose scripts run tsc (the convention @workflow/nest already follows). pnpm then owns each package's tsc bin shim and refreshes it on catalog upgrades, making this staleness class structurally impossible — and pinning every package to the workspace catalog version (^6.0.3) hermetically.

Packages without tsc in their scripts are left unchanged (nuxt, swc-plugin, tsconfig, plus those already declaring it).

Validation

  • All package-local pnpm exec tsc --version → 6.0.3
  • Full pnpm build: 27/27 tasks green
  • Diff is surgical: one devDependencies line per package (+ lockfile)

Twenty packages invoke tsc in their build/typecheck scripts without
declaring a typescript dependency, resolving whatever tsc pnpm happens
to leave reachable. That broke locally after the TypeScript 6 upgrade
(#2700): base.json now uses the TS6-only 'types': ['*'] wildcard, and
worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned
typescript@5.9.3 bins that pnpm never refreshes for an undeclared
dependency) fail with TS2688 'Cannot find type definition file for *'.
Declaring 'typescript': 'catalog:' (the convention nest already
follows) makes pnpm own each package's tsc bin, so version upgrades
refresh the shims and this staleness class cannot recur. Packages
without tsc in their scripts are left unchanged.
Full pnpm build: 27/27 tasks green.
CopilotAI review requested due to automatic review settings July 13, 2026 17:04
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 13, 2026 17:04
@changeset-bot

changeset-botBot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 85cd8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 85cd8d7 · Mon, 13 Jul 2026 18:05:34 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1276 (+5.4%)1631 🔴1694 🔴2456 🔴30
TTFShook + stream1605 (+6.5%)2020 🔴2056 🔴2322 🔴30
STSO1020 steps (1-20)244 (-10%)263 🔴332 🔴349 🔴19
STSO1020 steps (101-120)401 (-0.7%)448 🔴492 🔴500 🔴19
STSO1020 steps (1001-1020)850 (-6.2%)871 🔴964 🔴1088 🔴19
WOstream1276 (+5.4%)16311694245630
WOhook + stream1605 (+6.5%)20202056232230
SLstream4355 (-6.7%)5156 🔴5534 🔴5757 🔴30
SLhook + stream4837 (-4.5%)5391 🔴5514 🔴5593 🔴30
📜 Previous results (1)

1af2605

Mon, 13 Jul 2026 17:27:04 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1258 (+8.9%)1691 🔴1737 🔴2185 🔴30
TTFShook + stream1669 (+16%)2165 🔴2286 🔴2475 🔴30
STSO1020 steps (1-20)294 (-3.2%)331 🔴465 🔴509 🔴19
STSO1020 steps (101-120)482 (+12%)521 🔴599 🔴825 🔴19
STSO1020 steps (1001-1020)1117 (+31%)1198 🔴1427 🔴1493 🔴19
WOstream1258 (+8.9%)16911737218530
WOhook + stream1669 (+16%)21652286247530
SLstream4477 (-3.0%)5687 🔴5798 🔴5845 🔴30
SLhook + stream4922 (-4.0%)5610 🔴5779 🔴5885 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateTooTallNate changed the title build: declare typescript (catalog:) in every package that runs tscbuild: declare typescript (catalog:) in every package that runs tscJul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit per-package TypeScript toolchain ownership by declaring typescript: "catalog:" in packages that run tsc, preventing stale node_modules/.bin/tsc shims from causing TS6 config incompatibility errors in existing worktrees.

Changes:

  • Add typescript: "catalog:" to devDependencies for multiple packages that invoke tsc in build/typecheck scripts.
  • Update pnpm-lock.yaml to reflect the added per-package TypeScript dependencies.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile updated for newly declared per-package typescript dependencies (currently includes additional resolution churn to verify).
packages/world/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-vercel/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-testing/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-postgres/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-local/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/workflow/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vitest/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vite/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/utils/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/sveltekit/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/serde/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/rollup/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/nitro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/next/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/errors/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/core/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/cli/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/builders/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/astro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/ai/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/world/package.json
Comment threadpnpm-lock.yaml
- packages/world listed zod in both dependencies and devDependencies
(pre-existing on main, surfaced by the devDependencies sort) — keep
the runtime dependency only.
- Regenerate pnpm-lock.yaml from a pristine main baseline with
--lockfile-only (a clean-main run produces zero diff, so main has no
drift). Remaining non-typescript changes are mechanical consequences
of the change itself: typescript is an (optional) peer of several
tooling dependencies, so declaring it in 20 importers creates new
peer-resolution snapshot variants and prunes the now-orphaned old
ones; plus one radix-ui 1.6.1->1.6.2 refresh in docs caused by its
floating 'latest' specifier.
- Validated: pnpm install --frozen-lockfile succeeds; full build 27/27.
@TooTallNate
TooTallNate enabled auto-merge (squash) July 13, 2026 17:52
@TooTallNate
TooTallNate merged commit b01ed54 into mainJul 13, 2026
236 of 240 checks passed
@TooTallNate
TooTallNate deleted the fix/declare-typescript-dep branch July 13, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Backport to stable failed for b01ed54 due to a workflow error (backport job run).

This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details.

Once the underlying issue is fixed, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b01ed548d798f96eea9580dd82e2e3f4671105b6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TooTallNate@VaguelySerious@karthikscale3@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

build: declare typescript (catalog:) in every package that runs tsc - #2898

Merged
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep
Jul 13, 2026
Merged

build: declare typescript (catalog:) in every package that runs tsc#2898
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Problem

Twenty packages invoke tsc in their build/typecheck scripts without declaring a typescript dependency — they resolve whatever tsc pnpm happens to leave reachable (usually the hoisted root copy).

After the TypeScript 6 upgrade (#2700), the shared base.json uses the TS6-only "types": ["*"] wildcard. Worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned typescript@5.9.3 bins that pnpm never refreshes for an undeclared dependency) fail with:

error TS2688: Cannot find type definition file for '*'.

Hit locally in @workflow/astro, @workflow/world-postgres, and @workflow/nuxt — invisible in CI because fresh installs never have the stale shims.

Fix

Add "typescript": "catalog:" to the devDependencies of every package whose scripts run tsc (the convention @workflow/nest already follows). pnpm then owns each package's tsc bin shim and refreshes it on catalog upgrades, making this staleness class structurally impossible — and pinning every package to the workspace catalog version (^6.0.3) hermetically.

Packages without tsc in their scripts are left unchanged (nuxt, swc-plugin, tsconfig, plus those already declaring it).

Validation

  • All package-local pnpm exec tsc --version → 6.0.3
  • Full pnpm build: 27/27 tasks green
  • Diff is surgical: one devDependencies line per package (+ lockfile)

Twenty packages invoke tsc in their build/typecheck scripts without
declaring a typescript dependency, resolving whatever tsc pnpm happens
to leave reachable. That broke locally after the TypeScript 6 upgrade
(#2700): base.json now uses the TS6-only 'types': ['*'] wildcard, and
worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned
typescript@5.9.3 bins that pnpm never refreshes for an undeclared
dependency) fail with TS2688 'Cannot find type definition file for *'.
Declaring 'typescript': 'catalog:' (the convention nest already
follows) makes pnpm own each package's tsc bin, so version upgrades
refresh the shims and this staleness class cannot recur. Packages
without tsc in their scripts are left unchanged.
Full pnpm build: 27/27 tasks green.
CopilotAI review requested due to automatic review settings July 13, 2026 17:04
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 13, 2026 17:04
@changeset-bot

changeset-botBot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 85cd8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 85cd8d7 · Mon, 13 Jul 2026 18:05:34 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1276 (+5.4%)1631 🔴1694 🔴2456 🔴30
TTFShook + stream1605 (+6.5%)2020 🔴2056 🔴2322 🔴30
STSO1020 steps (1-20)244 (-10%)263 🔴332 🔴349 🔴19
STSO1020 steps (101-120)401 (-0.7%)448 🔴492 🔴500 🔴19
STSO1020 steps (1001-1020)850 (-6.2%)871 🔴964 🔴1088 🔴19
WOstream1276 (+5.4%)16311694245630
WOhook + stream1605 (+6.5%)20202056232230
SLstream4355 (-6.7%)5156 🔴5534 🔴5757 🔴30
SLhook + stream4837 (-4.5%)5391 🔴5514 🔴5593 🔴30
📜 Previous results (1)

1af2605

Mon, 13 Jul 2026 17:27:04 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1258 (+8.9%)1691 🔴1737 🔴2185 🔴30
TTFShook + stream1669 (+16%)2165 🔴2286 🔴2475 🔴30
STSO1020 steps (1-20)294 (-3.2%)331 🔴465 🔴509 🔴19
STSO1020 steps (101-120)482 (+12%)521 🔴599 🔴825 🔴19
STSO1020 steps (1001-1020)1117 (+31%)1198 🔴1427 🔴1493 🔴19
WOstream1258 (+8.9%)16911737218530
WOhook + stream1669 (+16%)21652286247530
SLstream4477 (-3.0%)5687 🔴5798 🔴5845 🔴30
SLhook + stream4922 (-4.0%)5610 🔴5779 🔴5885 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateTooTallNate changed the title build: declare typescript (catalog:) in every package that runs tscbuild: declare typescript (catalog:) in every package that runs tscJul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit per-package TypeScript toolchain ownership by declaring typescript: "catalog:" in packages that run tsc, preventing stale node_modules/.bin/tsc shims from causing TS6 config incompatibility errors in existing worktrees.

Changes:

  • Add typescript: "catalog:" to devDependencies for multiple packages that invoke tsc in build/typecheck scripts.
  • Update pnpm-lock.yaml to reflect the added per-package TypeScript dependencies.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile updated for newly declared per-package typescript dependencies (currently includes additional resolution churn to verify).
packages/world/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-vercel/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-testing/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-postgres/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-local/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/workflow/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vitest/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vite/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/utils/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/sveltekit/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/serde/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/rollup/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/nitro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/next/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/errors/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/core/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/cli/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/builders/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/astro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/ai/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/world/package.json
Comment threadpnpm-lock.yaml
- packages/world listed zod in both dependencies and devDependencies
(pre-existing on main, surfaced by the devDependencies sort) — keep
the runtime dependency only.
- Regenerate pnpm-lock.yaml from a pristine main baseline with
--lockfile-only (a clean-main run produces zero diff, so main has no
drift). Remaining non-typescript changes are mechanical consequences
of the change itself: typescript is an (optional) peer of several
tooling dependencies, so declaring it in 20 importers creates new
peer-resolution snapshot variants and prunes the now-orphaned old
ones; plus one radix-ui 1.6.1->1.6.2 refresh in docs caused by its
floating 'latest' specifier.
- Validated: pnpm install --frozen-lockfile succeeds; full build 27/27.
@TooTallNate
TooTallNate enabled auto-merge (squash) July 13, 2026 17:52
@TooTallNate
TooTallNate merged commit b01ed54 into mainJul 13, 2026
236 of 240 checks passed
@TooTallNate
TooTallNate deleted the fix/declare-typescript-dep branch July 13, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Backport to stable failed for b01ed54 due to a workflow error (backport job run).

This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details.

Once the underlying issue is fixed, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b01ed548d798f96eea9580dd82e2e3f4671105b6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TooTallNate@VaguelySerious@karthikscale3@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

build: declare typescript (catalog:) in every package that runs tsc - #2898

Merged
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep
Jul 13, 2026
Merged

build: declare typescript (catalog:) in every package that runs tsc#2898
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Problem

Twenty packages invoke tsc in their build/typecheck scripts without declaring a typescript dependency — they resolve whatever tsc pnpm happens to leave reachable (usually the hoisted root copy).

After the TypeScript 6 upgrade (#2700), the shared base.json uses the TS6-only "types": ["*"] wildcard. Worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned typescript@5.9.3 bins that pnpm never refreshes for an undeclared dependency) fail with:

error TS2688: Cannot find type definition file for '*'.

Hit locally in @workflow/astro, @workflow/world-postgres, and @workflow/nuxt — invisible in CI because fresh installs never have the stale shims.

Fix

Add "typescript": "catalog:" to the devDependencies of every package whose scripts run tsc (the convention @workflow/nest already follows). pnpm then owns each package's tsc bin shim and refreshes it on catalog upgrades, making this staleness class structurally impossible — and pinning every package to the workspace catalog version (^6.0.3) hermetically.

Packages without tsc in their scripts are left unchanged (nuxt, swc-plugin, tsconfig, plus those already declaring it).

Validation

  • All package-local pnpm exec tsc --version → 6.0.3
  • Full pnpm build: 27/27 tasks green
  • Diff is surgical: one devDependencies line per package (+ lockfile)

Twenty packages invoke tsc in their build/typecheck scripts without
declaring a typescript dependency, resolving whatever tsc pnpm happens
to leave reachable. That broke locally after the TypeScript 6 upgrade
(#2700): base.json now uses the TS6-only 'types': ['*'] wildcard, and
worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned
typescript@5.9.3 bins that pnpm never refreshes for an undeclared
dependency) fail with TS2688 'Cannot find type definition file for *'.
Declaring 'typescript': 'catalog:' (the convention nest already
follows) makes pnpm own each package's tsc bin, so version upgrades
refresh the shims and this staleness class cannot recur. Packages
without tsc in their scripts are left unchanged.
Full pnpm build: 27/27 tasks green.
CopilotAI review requested due to automatic review settings July 13, 2026 17:04
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 13, 2026 17:04
@changeset-bot

changeset-botBot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 85cd8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 85cd8d7 · Mon, 13 Jul 2026 18:05:34 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1276 (+5.4%)1631 🔴1694 🔴2456 🔴30
TTFShook + stream1605 (+6.5%)2020 🔴2056 🔴2322 🔴30
STSO1020 steps (1-20)244 (-10%)263 🔴332 🔴349 🔴19
STSO1020 steps (101-120)401 (-0.7%)448 🔴492 🔴500 🔴19
STSO1020 steps (1001-1020)850 (-6.2%)871 🔴964 🔴1088 🔴19
WOstream1276 (+5.4%)16311694245630
WOhook + stream1605 (+6.5%)20202056232230
SLstream4355 (-6.7%)5156 🔴5534 🔴5757 🔴30
SLhook + stream4837 (-4.5%)5391 🔴5514 🔴5593 🔴30
📜 Previous results (1)

1af2605

Mon, 13 Jul 2026 17:27:04 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1258 (+8.9%)1691 🔴1737 🔴2185 🔴30
TTFShook + stream1669 (+16%)2165 🔴2286 🔴2475 🔴30
STSO1020 steps (1-20)294 (-3.2%)331 🔴465 🔴509 🔴19
STSO1020 steps (101-120)482 (+12%)521 🔴599 🔴825 🔴19
STSO1020 steps (1001-1020)1117 (+31%)1198 🔴1427 🔴1493 🔴19
WOstream1258 (+8.9%)16911737218530
WOhook + stream1669 (+16%)21652286247530
SLstream4477 (-3.0%)5687 🔴5798 🔴5845 🔴30
SLhook + stream4922 (-4.0%)5610 🔴5779 🔴5885 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateTooTallNate changed the title build: declare typescript (catalog:) in every package that runs tscbuild: declare typescript (catalog:) in every package that runs tscJul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit per-package TypeScript toolchain ownership by declaring typescript: "catalog:" in packages that run tsc, preventing stale node_modules/.bin/tsc shims from causing TS6 config incompatibility errors in existing worktrees.

Changes:

  • Add typescript: "catalog:" to devDependencies for multiple packages that invoke tsc in build/typecheck scripts.
  • Update pnpm-lock.yaml to reflect the added per-package TypeScript dependencies.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile updated for newly declared per-package typescript dependencies (currently includes additional resolution churn to verify).
packages/world/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-vercel/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-testing/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-postgres/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-local/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/workflow/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vitest/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vite/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/utils/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/sveltekit/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/serde/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/rollup/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/nitro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/next/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/errors/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/core/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/cli/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/builders/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/astro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/ai/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/world/package.json
Comment threadpnpm-lock.yaml
- packages/world listed zod in both dependencies and devDependencies
(pre-existing on main, surfaced by the devDependencies sort) — keep
the runtime dependency only.
- Regenerate pnpm-lock.yaml from a pristine main baseline with
--lockfile-only (a clean-main run produces zero diff, so main has no
drift). Remaining non-typescript changes are mechanical consequences
of the change itself: typescript is an (optional) peer of several
tooling dependencies, so declaring it in 20 importers creates new
peer-resolution snapshot variants and prunes the now-orphaned old
ones; plus one radix-ui 1.6.1->1.6.2 refresh in docs caused by its
floating 'latest' specifier.
- Validated: pnpm install --frozen-lockfile succeeds; full build 27/27.
@TooTallNate
TooTallNate enabled auto-merge (squash) July 13, 2026 17:52
@TooTallNate
TooTallNate merged commit b01ed54 into mainJul 13, 2026
236 of 240 checks passed
@TooTallNate
TooTallNate deleted the fix/declare-typescript-dep branch July 13, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Backport to stable failed for b01ed54 due to a workflow error (backport job run).

This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details.

Once the underlying issue is fixed, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b01ed548d798f96eea9580dd82e2e3f4671105b6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TooTallNate@VaguelySerious@karthikscale3@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

build: declare typescript (catalog:) in every package that runs tsc - #2898

Merged
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep
Jul 13, 2026
Merged

build: declare typescript (catalog:) in every package that runs tsc#2898
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Problem

Twenty packages invoke tsc in their build/typecheck scripts without declaring a typescript dependency — they resolve whatever tsc pnpm happens to leave reachable (usually the hoisted root copy).

After the TypeScript 6 upgrade (#2700), the shared base.json uses the TS6-only "types": ["*"] wildcard. Worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned typescript@5.9.3 bins that pnpm never refreshes for an undeclared dependency) fail with:

error TS2688: Cannot find type definition file for '*'.

Hit locally in @workflow/astro, @workflow/world-postgres, and @workflow/nuxt — invisible in CI because fresh installs never have the stale shims.

Fix

Add "typescript": "catalog:" to the devDependencies of every package whose scripts run tsc (the convention @workflow/nest already follows). pnpm then owns each package's tsc bin shim and refreshes it on catalog upgrades, making this staleness class structurally impossible — and pinning every package to the workspace catalog version (^6.0.3) hermetically.

Packages without tsc in their scripts are left unchanged (nuxt, swc-plugin, tsconfig, plus those already declaring it).

Validation

  • All package-local pnpm exec tsc --version → 6.0.3
  • Full pnpm build: 27/27 tasks green
  • Diff is surgical: one devDependencies line per package (+ lockfile)

Twenty packages invoke tsc in their build/typecheck scripts without
declaring a typescript dependency, resolving whatever tsc pnpm happens
to leave reachable. That broke locally after the TypeScript 6 upgrade
(#2700): base.json now uses the TS6-only 'types': ['*'] wildcard, and
worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned
typescript@5.9.3 bins that pnpm never refreshes for an undeclared
dependency) fail with TS2688 'Cannot find type definition file for *'.
Declaring 'typescript': 'catalog:' (the convention nest already
follows) makes pnpm own each package's tsc bin, so version upgrades
refresh the shims and this staleness class cannot recur. Packages
without tsc in their scripts are left unchanged.
Full pnpm build: 27/27 tasks green.
CopilotAI review requested due to automatic review settings July 13, 2026 17:04
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 13, 2026 17:04
@changeset-bot

changeset-botBot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 85cd8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 85cd8d7 · Mon, 13 Jul 2026 18:05:34 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1276 (+5.4%)1631 🔴1694 🔴2456 🔴30
TTFShook + stream1605 (+6.5%)2020 🔴2056 🔴2322 🔴30
STSO1020 steps (1-20)244 (-10%)263 🔴332 🔴349 🔴19
STSO1020 steps (101-120)401 (-0.7%)448 🔴492 🔴500 🔴19
STSO1020 steps (1001-1020)850 (-6.2%)871 🔴964 🔴1088 🔴19
WOstream1276 (+5.4%)16311694245630
WOhook + stream1605 (+6.5%)20202056232230
SLstream4355 (-6.7%)5156 🔴5534 🔴5757 🔴30
SLhook + stream4837 (-4.5%)5391 🔴5514 🔴5593 🔴30
📜 Previous results (1)

1af2605

Mon, 13 Jul 2026 17:27:04 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1258 (+8.9%)1691 🔴1737 🔴2185 🔴30
TTFShook + stream1669 (+16%)2165 🔴2286 🔴2475 🔴30
STSO1020 steps (1-20)294 (-3.2%)331 🔴465 🔴509 🔴19
STSO1020 steps (101-120)482 (+12%)521 🔴599 🔴825 🔴19
STSO1020 steps (1001-1020)1117 (+31%)1198 🔴1427 🔴1493 🔴19
WOstream1258 (+8.9%)16911737218530
WOhook + stream1669 (+16%)21652286247530
SLstream4477 (-3.0%)5687 🔴5798 🔴5845 🔴30
SLhook + stream4922 (-4.0%)5610 🔴5779 🔴5885 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateTooTallNate changed the title build: declare typescript (catalog:) in every package that runs tscbuild: declare typescript (catalog:) in every package that runs tscJul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit per-package TypeScript toolchain ownership by declaring typescript: "catalog:" in packages that run tsc, preventing stale node_modules/.bin/tsc shims from causing TS6 config incompatibility errors in existing worktrees.

Changes:

  • Add typescript: "catalog:" to devDependencies for multiple packages that invoke tsc in build/typecheck scripts.
  • Update pnpm-lock.yaml to reflect the added per-package TypeScript dependencies.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile updated for newly declared per-package typescript dependencies (currently includes additional resolution churn to verify).
packages/world/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-vercel/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-testing/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-postgres/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-local/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/workflow/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vitest/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vite/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/utils/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/sveltekit/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/serde/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/rollup/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/nitro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/next/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/errors/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/core/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/cli/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/builders/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/astro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/ai/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/world/package.json
Comment threadpnpm-lock.yaml
- packages/world listed zod in both dependencies and devDependencies
(pre-existing on main, surfaced by the devDependencies sort) — keep
the runtime dependency only.
- Regenerate pnpm-lock.yaml from a pristine main baseline with
--lockfile-only (a clean-main run produces zero diff, so main has no
drift). Remaining non-typescript changes are mechanical consequences
of the change itself: typescript is an (optional) peer of several
tooling dependencies, so declaring it in 20 importers creates new
peer-resolution snapshot variants and prunes the now-orphaned old
ones; plus one radix-ui 1.6.1->1.6.2 refresh in docs caused by its
floating 'latest' specifier.
- Validated: pnpm install --frozen-lockfile succeeds; full build 27/27.
@TooTallNate
TooTallNate enabled auto-merge (squash) July 13, 2026 17:52
@TooTallNate
TooTallNate merged commit b01ed54 into mainJul 13, 2026
236 of 240 checks passed
@TooTallNate
TooTallNate deleted the fix/declare-typescript-dep branch July 13, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Backport to stable failed for b01ed54 due to a workflow error (backport job run).

This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details.

Once the underlying issue is fixed, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b01ed548d798f96eea9580dd82e2e3f4671105b6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TooTallNate@VaguelySerious@karthikscale3@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

build: declare typescript (catalog:) in every package that runs tsc - #2898

Merged
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep
Jul 13, 2026
Merged

build: declare typescript (catalog:) in every package that runs tsc#2898
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Problem

Twenty packages invoke tsc in their build/typecheck scripts without declaring a typescript dependency — they resolve whatever tsc pnpm happens to leave reachable (usually the hoisted root copy).

After the TypeScript 6 upgrade (#2700), the shared base.json uses the TS6-only "types": ["*"] wildcard. Worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned typescript@5.9.3 bins that pnpm never refreshes for an undeclared dependency) fail with:

error TS2688: Cannot find type definition file for '*'.

Hit locally in @workflow/astro, @workflow/world-postgres, and @workflow/nuxt — invisible in CI because fresh installs never have the stale shims.

Fix

Add "typescript": "catalog:" to the devDependencies of every package whose scripts run tsc (the convention @workflow/nest already follows). pnpm then owns each package's tsc bin shim and refreshes it on catalog upgrades, making this staleness class structurally impossible — and pinning every package to the workspace catalog version (^6.0.3) hermetically.

Packages without tsc in their scripts are left unchanged (nuxt, swc-plugin, tsconfig, plus those already declaring it).

Validation

  • All package-local pnpm exec tsc --version → 6.0.3
  • Full pnpm build: 27/27 tasks green
  • Diff is surgical: one devDependencies line per package (+ lockfile)

Twenty packages invoke tsc in their build/typecheck scripts without
declaring a typescript dependency, resolving whatever tsc pnpm happens
to leave reachable. That broke locally after the TypeScript 6 upgrade
(#2700): base.json now uses the TS6-only 'types': ['*'] wildcard, and
worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned
typescript@5.9.3 bins that pnpm never refreshes for an undeclared
dependency) fail with TS2688 'Cannot find type definition file for *'.
Declaring 'typescript': 'catalog:' (the convention nest already
follows) makes pnpm own each package's tsc bin, so version upgrades
refresh the shims and this staleness class cannot recur. Packages
without tsc in their scripts are left unchanged.
Full pnpm build: 27/27 tasks green.
CopilotAI review requested due to automatic review settings July 13, 2026 17:04
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 13, 2026 17:04
@changeset-bot

changeset-botBot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 85cd8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 85cd8d7 · Mon, 13 Jul 2026 18:05:34 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1276 (+5.4%)1631 🔴1694 🔴2456 🔴30
TTFShook + stream1605 (+6.5%)2020 🔴2056 🔴2322 🔴30
STSO1020 steps (1-20)244 (-10%)263 🔴332 🔴349 🔴19
STSO1020 steps (101-120)401 (-0.7%)448 🔴492 🔴500 🔴19
STSO1020 steps (1001-1020)850 (-6.2%)871 🔴964 🔴1088 🔴19
WOstream1276 (+5.4%)16311694245630
WOhook + stream1605 (+6.5%)20202056232230
SLstream4355 (-6.7%)5156 🔴5534 🔴5757 🔴30
SLhook + stream4837 (-4.5%)5391 🔴5514 🔴5593 🔴30
📜 Previous results (1)

1af2605

Mon, 13 Jul 2026 17:27:04 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1258 (+8.9%)1691 🔴1737 🔴2185 🔴30
TTFShook + stream1669 (+16%)2165 🔴2286 🔴2475 🔴30
STSO1020 steps (1-20)294 (-3.2%)331 🔴465 🔴509 🔴19
STSO1020 steps (101-120)482 (+12%)521 🔴599 🔴825 🔴19
STSO1020 steps (1001-1020)1117 (+31%)1198 🔴1427 🔴1493 🔴19
WOstream1258 (+8.9%)16911737218530
WOhook + stream1669 (+16%)21652286247530
SLstream4477 (-3.0%)5687 🔴5798 🔴5845 🔴30
SLhook + stream4922 (-4.0%)5610 🔴5779 🔴5885 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateTooTallNate changed the title build: declare typescript (catalog:) in every package that runs tscbuild: declare typescript (catalog:) in every package that runs tscJul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit per-package TypeScript toolchain ownership by declaring typescript: "catalog:" in packages that run tsc, preventing stale node_modules/.bin/tsc shims from causing TS6 config incompatibility errors in existing worktrees.

Changes:

  • Add typescript: "catalog:" to devDependencies for multiple packages that invoke tsc in build/typecheck scripts.
  • Update pnpm-lock.yaml to reflect the added per-package TypeScript dependencies.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile updated for newly declared per-package typescript dependencies (currently includes additional resolution churn to verify).
packages/world/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-vercel/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-testing/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-postgres/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-local/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/workflow/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vitest/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vite/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/utils/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/sveltekit/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/serde/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/rollup/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/nitro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/next/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/errors/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/core/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/cli/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/builders/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/astro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/ai/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/world/package.json
Comment threadpnpm-lock.yaml
- packages/world listed zod in both dependencies and devDependencies
(pre-existing on main, surfaced by the devDependencies sort) — keep
the runtime dependency only.
- Regenerate pnpm-lock.yaml from a pristine main baseline with
--lockfile-only (a clean-main run produces zero diff, so main has no
drift). Remaining non-typescript changes are mechanical consequences
of the change itself: typescript is an (optional) peer of several
tooling dependencies, so declaring it in 20 importers creates new
peer-resolution snapshot variants and prunes the now-orphaned old
ones; plus one radix-ui 1.6.1->1.6.2 refresh in docs caused by its
floating 'latest' specifier.
- Validated: pnpm install --frozen-lockfile succeeds; full build 27/27.
@TooTallNate
TooTallNate enabled auto-merge (squash) July 13, 2026 17:52
@TooTallNate
TooTallNate merged commit b01ed54 into mainJul 13, 2026
236 of 240 checks passed
@TooTallNate
TooTallNate deleted the fix/declare-typescript-dep branch July 13, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Backport to stable failed for b01ed54 due to a workflow error (backport job run).

This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details.

Once the underlying issue is fixed, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b01ed548d798f96eea9580dd82e2e3f4671105b6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TooTallNate@VaguelySerious@karthikscale3@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

build: declare typescript (catalog:) in every package that runs tsc - #2898

Merged
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep
Jul 13, 2026
Merged

build: declare typescript (catalog:) in every package that runs tsc#2898
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Problem

Twenty packages invoke tsc in their build/typecheck scripts without declaring a typescript dependency — they resolve whatever tsc pnpm happens to leave reachable (usually the hoisted root copy).

After the TypeScript 6 upgrade (#2700), the shared base.json uses the TS6-only "types": ["*"] wildcard. Worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned typescript@5.9.3 bins that pnpm never refreshes for an undeclared dependency) fail with:

error TS2688: Cannot find type definition file for '*'.

Hit locally in @workflow/astro, @workflow/world-postgres, and @workflow/nuxt — invisible in CI because fresh installs never have the stale shims.

Fix

Add "typescript": "catalog:" to the devDependencies of every package whose scripts run tsc (the convention @workflow/nest already follows). pnpm then owns each package's tsc bin shim and refreshes it on catalog upgrades, making this staleness class structurally impossible — and pinning every package to the workspace catalog version (^6.0.3) hermetically.

Packages without tsc in their scripts are left unchanged (nuxt, swc-plugin, tsconfig, plus those already declaring it).

Validation

  • All package-local pnpm exec tsc --version → 6.0.3
  • Full pnpm build: 27/27 tasks green
  • Diff is surgical: one devDependencies line per package (+ lockfile)

Twenty packages invoke tsc in their build/typecheck scripts without
declaring a typescript dependency, resolving whatever tsc pnpm happens
to leave reachable. That broke locally after the TypeScript 6 upgrade
(#2700): base.json now uses the TS6-only 'types': ['*'] wildcard, and
worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned
typescript@5.9.3 bins that pnpm never refreshes for an undeclared
dependency) fail with TS2688 'Cannot find type definition file for *'.
Declaring 'typescript': 'catalog:' (the convention nest already
follows) makes pnpm own each package's tsc bin, so version upgrades
refresh the shims and this staleness class cannot recur. Packages
without tsc in their scripts are left unchanged.
Full pnpm build: 27/27 tasks green.
CopilotAI review requested due to automatic review settings July 13, 2026 17:04
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 13, 2026 17:04
@changeset-bot

changeset-botBot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 85cd8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 85cd8d7 · Mon, 13 Jul 2026 18:05:34 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1276 (+5.4%)1631 🔴1694 🔴2456 🔴30
TTFShook + stream1605 (+6.5%)2020 🔴2056 🔴2322 🔴30
STSO1020 steps (1-20)244 (-10%)263 🔴332 🔴349 🔴19
STSO1020 steps (101-120)401 (-0.7%)448 🔴492 🔴500 🔴19
STSO1020 steps (1001-1020)850 (-6.2%)871 🔴964 🔴1088 🔴19
WOstream1276 (+5.4%)16311694245630
WOhook + stream1605 (+6.5%)20202056232230
SLstream4355 (-6.7%)5156 🔴5534 🔴5757 🔴30
SLhook + stream4837 (-4.5%)5391 🔴5514 🔴5593 🔴30
📜 Previous results (1)

1af2605

Mon, 13 Jul 2026 17:27:04 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1258 (+8.9%)1691 🔴1737 🔴2185 🔴30
TTFShook + stream1669 (+16%)2165 🔴2286 🔴2475 🔴30
STSO1020 steps (1-20)294 (-3.2%)331 🔴465 🔴509 🔴19
STSO1020 steps (101-120)482 (+12%)521 🔴599 🔴825 🔴19
STSO1020 steps (1001-1020)1117 (+31%)1198 🔴1427 🔴1493 🔴19
WOstream1258 (+8.9%)16911737218530
WOhook + stream1669 (+16%)21652286247530
SLstream4477 (-3.0%)5687 🔴5798 🔴5845 🔴30
SLhook + stream4922 (-4.0%)5610 🔴5779 🔴5885 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateTooTallNate changed the title build: declare typescript (catalog:) in every package that runs tscbuild: declare typescript (catalog:) in every package that runs tscJul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit per-package TypeScript toolchain ownership by declaring typescript: "catalog:" in packages that run tsc, preventing stale node_modules/.bin/tsc shims from causing TS6 config incompatibility errors in existing worktrees.

Changes:

  • Add typescript: "catalog:" to devDependencies for multiple packages that invoke tsc in build/typecheck scripts.
  • Update pnpm-lock.yaml to reflect the added per-package TypeScript dependencies.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile updated for newly declared per-package typescript dependencies (currently includes additional resolution churn to verify).
packages/world/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-vercel/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-testing/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-postgres/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-local/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/workflow/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vitest/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vite/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/utils/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/sveltekit/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/serde/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/rollup/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/nitro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/next/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/errors/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/core/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/cli/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/builders/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/astro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/ai/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/world/package.json
Comment threadpnpm-lock.yaml
- packages/world listed zod in both dependencies and devDependencies
(pre-existing on main, surfaced by the devDependencies sort) — keep
the runtime dependency only.
- Regenerate pnpm-lock.yaml from a pristine main baseline with
--lockfile-only (a clean-main run produces zero diff, so main has no
drift). Remaining non-typescript changes are mechanical consequences
of the change itself: typescript is an (optional) peer of several
tooling dependencies, so declaring it in 20 importers creates new
peer-resolution snapshot variants and prunes the now-orphaned old
ones; plus one radix-ui 1.6.1->1.6.2 refresh in docs caused by its
floating 'latest' specifier.
- Validated: pnpm install --frozen-lockfile succeeds; full build 27/27.
@TooTallNate
TooTallNate enabled auto-merge (squash) July 13, 2026 17:52
@TooTallNate
TooTallNate merged commit b01ed54 into mainJul 13, 2026
236 of 240 checks passed
@TooTallNate
TooTallNate deleted the fix/declare-typescript-dep branch July 13, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Backport to stable failed for b01ed54 due to a workflow error (backport job run).

This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details.

Once the underlying issue is fixed, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b01ed548d798f96eea9580dd82e2e3f4671105b6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TooTallNate@VaguelySerious@karthikscale3@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

build: declare typescript (catalog:) in every package that runs tsc - #2898

Merged
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep
Jul 13, 2026
Merged

build: declare typescript (catalog:) in every package that runs tsc#2898
TooTallNate merged 2 commits into
mainfrom
fix/declare-typescript-dep

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Problem

Twenty packages invoke tsc in their build/typecheck scripts without declaring a typescript dependency — they resolve whatever tsc pnpm happens to leave reachable (usually the hoisted root copy).

After the TypeScript 6 upgrade (#2700), the shared base.json uses the TS6-only "types": ["*"] wildcard. Worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned typescript@5.9.3 bins that pnpm never refreshes for an undeclared dependency) fail with:

error TS2688: Cannot find type definition file for '*'.

Hit locally in @workflow/astro, @workflow/world-postgres, and @workflow/nuxt — invisible in CI because fresh installs never have the stale shims.

Fix

Add "typescript": "catalog:" to the devDependencies of every package whose scripts run tsc (the convention @workflow/nest already follows). pnpm then owns each package's tsc bin shim and refreshes it on catalog upgrades, making this staleness class structurally impossible — and pinning every package to the workspace catalog version (^6.0.3) hermetically.

Packages without tsc in their scripts are left unchanged (nuxt, swc-plugin, tsconfig, plus those already declaring it).

Validation

  • All package-local pnpm exec tsc --version → 6.0.3
  • Full pnpm build: 27/27 tasks green
  • Diff is surgical: one devDependencies line per package (+ lockfile)

Twenty packages invoke tsc in their build/typecheck scripts without
declaring a typescript dependency, resolving whatever tsc pnpm happens
to leave reachable. That broke locally after the TypeScript 6 upgrade
(#2700): base.json now uses the TS6-only 'types': ['*'] wildcard, and
worktrees carrying pre-upgrade node_modules/.bin/tsc shims (orphaned
typescript@5.9.3 bins that pnpm never refreshes for an undeclared
dependency) fail with TS2688 'Cannot find type definition file for *'.
Declaring 'typescript': 'catalog:' (the convention nest already
follows) makes pnpm own each package's tsc bin, so version upgrades
refresh the shims and this staleness class cannot recur. Packages
without tsc in their scripts are left unchanged.
Full pnpm build: 27/27 tasks green.
CopilotAI review requested due to automatic review settings July 13, 2026 17:04
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 13, 2026 17:04
@changeset-bot

changeset-botBot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 85cd8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 85cd8d7 · Mon, 13 Jul 2026 18:05:34 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1276 (+5.4%)1631 🔴1694 🔴2456 🔴30
TTFShook + stream1605 (+6.5%)2020 🔴2056 🔴2322 🔴30
STSO1020 steps (1-20)244 (-10%)263 🔴332 🔴349 🔴19
STSO1020 steps (101-120)401 (-0.7%)448 🔴492 🔴500 🔴19
STSO1020 steps (1001-1020)850 (-6.2%)871 🔴964 🔴1088 🔴19
WOstream1276 (+5.4%)16311694245630
WOhook + stream1605 (+6.5%)20202056232230
SLstream4355 (-6.7%)5156 🔴5534 🔴5757 🔴30
SLhook + stream4837 (-4.5%)5391 🔴5514 🔴5593 🔴30
📜 Previous results (1)

1af2605

Mon, 13 Jul 2026 17:27:04 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1258 (+8.9%)1691 🔴1737 🔴2185 🔴30
TTFShook + stream1669 (+16%)2165 🔴2286 🔴2475 🔴30
STSO1020 steps (1-20)294 (-3.2%)331 🔴465 🔴509 🔴19
STSO1020 steps (101-120)482 (+12%)521 🔴599 🔴825 🔴19
STSO1020 steps (1001-1020)1117 (+31%)1198 🔴1427 🔴1493 🔴19
WOstream1258 (+8.9%)16911737218530
WOhook + stream1669 (+16%)21652286247530
SLstream4477 (-3.0%)5687 🔴5798 🔴5845 🔴30
SLhook + stream4922 (-4.0%)5610 🔴5779 🔴5885 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@TooTallNateTooTallNate changed the title build: declare typescript (catalog:) in every package that runs tscbuild: declare typescript (catalog:) in every package that runs tscJul 13, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit per-package TypeScript toolchain ownership by declaring typescript: "catalog:" in packages that run tsc, preventing stale node_modules/.bin/tsc shims from causing TS6 config incompatibility errors in existing worktrees.

Changes:

  • Add typescript: "catalog:" to devDependencies for multiple packages that invoke tsc in build/typecheck scripts.
  • Update pnpm-lock.yaml to reflect the added per-package TypeScript dependencies.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
pnpm-lock.yamlLockfile updated for newly declared per-package typescript dependencies (currently includes additional resolution churn to verify).
packages/world/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-vercel/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-testing/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-postgres/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/world-local/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/workflow/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vitest/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/vite/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/utils/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/sveltekit/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/serde/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/rollup/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/nitro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/next/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/errors/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/core/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/cli/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/builders/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/astro/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
packages/ai/package.jsonAdd typescript: "catalog:" to ensure local tsc resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/world/package.json
Comment threadpnpm-lock.yaml
- packages/world listed zod in both dependencies and devDependencies
(pre-existing on main, surfaced by the devDependencies sort) — keep
the runtime dependency only.
- Regenerate pnpm-lock.yaml from a pristine main baseline with
--lockfile-only (a clean-main run produces zero diff, so main has no
drift). Remaining non-typescript changes are mechanical consequences
of the change itself: typescript is an (optional) peer of several
tooling dependencies, so declaring it in 20 importers creates new
peer-resolution snapshot variants and prunes the now-orphaned old
ones; plus one radix-ui 1.6.1->1.6.2 refresh in docs caused by its
floating 'latest' specifier.
- Validated: pnpm install --frozen-lockfile succeeds; full build 27/27.
@TooTallNate
TooTallNate enabled auto-merge (squash) July 13, 2026 17:52
@TooTallNate
TooTallNate merged commit b01ed54 into mainJul 13, 2026
236 of 240 checks passed
@TooTallNate
TooTallNate deleted the fix/declare-typescript-dep branch July 13, 2026 18:33
@github-actions

Copy link
Copy Markdown
Contributor

Backport to stable failed for b01ed54 due to a workflow error (backport job run).

This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details.

Once the underlying issue is fixed, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

b01ed548d798f96eea9580dd82e2e3f4671105b6

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@TooTallNate@VaguelySerious@karthikscale3@NathanColosimo