Fix Nitro cleanup for React Router and add setup guides - #2908

Merged
NathanColosimo merged 4 commits into
mainfrom
nathanc/add-nitro-react-router-docs-and-fix
Jul 14, 2026
Merged

Fix Nitro cleanup for React Router and add setup guides#2908
NathanColosimo merged 4 commits into
mainfrom
nathanc/add-nitro-react-router-docs-and-fix

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 13, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Fix React Router v7 and v8 production builds with Nitro v3, and add setup guides for both versions.

React Router creates a temporary Vite server during vite build. Its Nitro server and Workflow's esbuild contexts remained active, so the build finished but did not exit. This PR cleans up both after their output is written.

Testing

  • React Router 7.18 and 8.1 development and production builds
  • @workflow/nitro build and 32 tests
  • Docs links, code samples, build, and preview smoke tests

Docs Preview

PagePreview
React RouterOpen
React Router v7Open
React Router v8Open

Closes#821

@vercel

vercelBot commented Jul 13, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-astro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-express-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-fastify-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-hono-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nitro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nuxt-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-vite-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 14, 2026 3:50am
workflow-swc-playgroundReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-tarballsBuildingBuildingPreview, CommentJul 14, 2026 3:50am
workflow-webReadyReadyPreview, CommentJul 14, 2026 3:50am

@changeset-bot

changeset-botBot commented Jul 13, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fbb8267

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jul 13, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

✅ All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 13, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit fbb8267 · Tue, 14 Jul 2026 04:07:33 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1401 (+20%)1665 🔴1759 🔴1882 🔴30
TTFShook + stream1666 (+17%)1923 🔴1973 🔴2048 🔴30
STSO1020 steps (1-20)275 (-2.9%)310 🔴360 🔴431 🔴19
STSO1020 steps (101-120)466 (+4.6%)453 🔴569 🔴1311 🔴19
STSO1020 steps (1001-1020)1091 (+25%)1144 🔴1362 🔴1845 🔴19
WOstream1401 (+20%)16651759188230
WOhook + stream1666 (+17%)19231973204830
SLstream4629 (-9.3%)5205 🔴5718 🔴5818 🔴30
SLhook + stream4921 (-3.2%)5149 🔴5742 🔴5815 🔴30
📜 Previous results (3)

b2e31a0

Tue, 14 Jul 2026 00:24:00 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1143 (+10.0%)1624 🔴1741 🔴1943 🔴30
TTFShook + stream1606 (+12%)1972 🔴2105 🔴2172 🔴30
STSO1020 steps (1-20)307 (+2.2%)344 🔴463 🔴497 🔴19
STSO1020 steps (101-120)432 (-2.4%)429 🔴594 🔴717 🔴19
STSO1020 steps (1001-1020)845 (-1.1%)884 🔴932 🔴946 🔴19
WOstream1143 (+10.0%)16241741194330
WOhook + stream1606 (+12%)19722105217230
SLstream4585 (±0%)5436 🔴5587 🔴5796 🔴30
SLhook + stream4630 (-6.6%)5273 🔴5379 🔴5522 🔴30

e506f40

Mon, 13 Jul 2026 23:04:58 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1441 (+1.1%)1668 🔴1706 🔴3011 🔴30
TTFShook + stream1498 (-12%)1879 🔴1934 🔴2104 🔴30
STSO1020 steps (1-20)295 (+12%)316 🔴487 🔴515 🔴19
STSO1020 steps (101-120)465 (+17%)462 🔴740 🔴758 🔴19
STSO1020 steps (1001-1020)1054 (+26%)1001 🔴1298 🔴4108 🔴19
WOstream1441 (+1.1%)16681706301130
WOhook + stream1498 (-12%)18791934210430
SLstream4859 (-4.8%)5293 🔴5784 🔴5871 🔴30
SLhook + stream5056 (+3.5%)5538 🔴5629 🔴5878 🔴30

02e7587

Mon, 13 Jul 2026 22:34:08 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1154 (-19%)1633 🔴1649 🔴1678 🔴30
TTFShook + stream1533 (-9.5%)1963 🔴2022 🔴2254 🔴30
STSO1020 steps (1-20)278 (+5.3%)344 🔴405 🔴416 🔴19
STSO1020 steps (101-120)391 (-1.5%)409 🔴517 🔴558 🔴19
STSO1020 steps (1001-1020)892 (+6.7%)970 🔴1074 🔴1168 🔴19
WOstream1154 (-19%)16331649167830
WOhook + stream1533 (-9.5%)19632022225430
SLstream4193 (-18%)5603 🔴5756 🔴5890 🔴30
SLhook + stream4702 (-3.8%)5582 🔴5704 🔴5759 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimo merged commit 3589958 into mainJul 14, 2026
172 of 174 checks passed
@NathanColosimo
NathanColosimo deleted the nathanc/add-nitro-react-router-docs-and-fix branch July 14, 2026 20:34
@github-actionsgithub-actionsBot mentioned this pull request Jul 14, 2026
Merged
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Backport PR opened against stable: #2923. Merge conflicts were resolved by AI — please review carefully. (backport job run)

@github-actionsgithub-actionsBot mentioned this pull request Jul 14, 2026
Merged
This was referenced Jul 14, 2026
Open
Draft
This was referenced Jul 15, 2026
Open
Open
Closed
Closed
@VaguelySeriousVaguelySerious mentioned this pull request Jul 27, 2026
Merged
@github-actionsgithub-actionsBot mentioned this pull request Aug 24, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doesn't work in a react-router v7 project

2 participants

@NathanColosimo@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix Nitro cleanup for React Router and add setup guides - #2908
Merged
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Jul 14, 2026
Merged
Fix Nitro cleanup for React Router and add setup guides#2908
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Conversation
@NathanColosimo
@NathanColosimoNathanColosimo
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Fix React Router v7 and v8 production builds with Nitro v3, and add setup guides for both versions.
React Router creates a temporary Vite server during vite build. Its Nitro server and Workflow's esbuild contexts remained active, so the build finished but did not exit. This PR cleans up both after their output is written.
Testing
  • React Router 7.18 and 8.1 development and production builds
  • @workflow/nitro build and 32 tests
  • Docs links, code samples, build, and preview smoke tests
Docs Preview
PagePreview
React RouterOpen
React Router v7Open
React Router v8Open
Closes#821
@vercel
vercelBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-astro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-express-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-fastify-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-hono-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nitro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nuxt-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-vite-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 14, 2026 3:50am
workflow-swc-playgroundReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-tarballsBuildingBuildingPreview, CommentJul 14, 2026 3:50am
workflow-webReadyReadyPreview, CommentJul 14, 2026 3:50am
@changeset-bot
changeset-botBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fbb8267
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit fbb8267 · Tue, 14 Jul 2026 04:07:33 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1401 (+20%)1665 🔴1759 🔴1882 🔴30
TTFShook + stream1666 (+17%)1923 🔴1973 🔴2048 🔴30
STSO1020 steps (1-20)275 (-2.9%)310 🔴360 🔴431 🔴19
STSO1020 steps (101-120)466 (+4.6%)453 🔴569 🔴1311 🔴19
STSO1020 steps (1001-1020)1091 (+25%)1144 🔴1362 🔴1845 🔴19
WOstream1401 (+20%)16651759188230
WOhook + stream1666 (+17%)19231973204830
SLstream4629 (-9.3%)5205 🔴5718 🔴5818 🔴30
SLhook + stream4921 (-3.2%)5149 🔴5742 🔴5815 🔴30
📜 Previous results (3)
b2e31a0
Tue, 14 Jul 2026 00:24:00 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1143 (+10.0%)1624 🔴1741 🔴1943 🔴30
TTFShook + stream1606 (+12%)1972 🔴2105 🔴2172 🔴30
STSO1020 steps (1-20)307 (+2.2%)344 🔴463 🔴497 🔴19
STSO1020 steps (101-120)432 (-2.4%)429 🔴594 🔴717 🔴19
STSO1020 steps (1001-1020)845 (-1.1%)884 🔴932 🔴946 🔴19
WOstream1143 (+10.0%)16241741194330
WOhook + stream1606 (+12%)19722105217230
SLstream4585 (±0%)5436 🔴5587 🔴5796 🔴30
SLhook + stream4630 (-6.6%)5273 🔴5379 🔴5522 🔴30
e506f40
Mon, 13 Jul 2026 23:04:58 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1441 (+1.1%)1668 🔴1706 🔴3011 🔴30
TTFShook + stream1498 (-12%)1879 🔴1934 🔴2104 🔴30
STSO1020 steps (1-20)295 (+12%)316 🔴487 🔴515 🔴19
STSO1020 steps (101-120)465 (+17%)462 🔴740 🔴758 🔴19
STSO1020 steps (1001-1020)1054 (+26%)1001 🔴1298 🔴4108 🔴19
WOstream1441 (+1.1%)16681706301130
WOhook + stream1498 (-12%)18791934210430
SLstream4859 (-4.8%)5293 🔴5784 🔴5871 🔴30
SLhook + stream5056 (+3.5%)5538 🔴5629 🔴5878 🔴30
02e7587
Mon, 13 Jul 2026 22:34:08 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1154 (-19%)1633 🔴1649 🔴1678 🔴30
TTFShook + stream1533 (-9.5%)1963 🔴2022 🔴2254 🔴30
STSO1020 steps (1-20)278 (+5.3%)344 🔴405 🔴416 🔴19
STSO1020 steps (101-120)391 (-1.5%)409 🔴517 🔴558 🔴19
STSO1020 steps (1001-1020)892 (+6.7%)970 🔴1074 🔴1168 🔴19
WOstream1154 (-19%)16331649167830
WOhook + stream1533 (-9.5%)19632022225430
SLstream4193 (-18%)5603 🔴5756 🔴5890 🔴30
SLhook + stream4702 (-3.8%)5582 🔴5704 🔴5759 🔴30
Avg deltas compare against the most recent benchmark run on main at the time of this run.
Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)
Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges
🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.
@NathanColosimo
NathanColosimo
merged commit 3589958
into
mainJul 14, 2026

172 of 174 checks passed

@NathanColosimo
NathanColosimo
deleted the

nathanc/add-nitro-react-router-docs-and-fix

branch
July 14, 2026 20:34
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged

@github-actions
github-actionsBot
commented
Jul 14, 2026

Copy link


Copy Markdown

Contributor
Backport PR opened against stable: #2923. Merge conflicts were resolved by AI — please review carefully. (backport job run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged


This was referenced Jul 14, 2026

Open

 Draft


This was referenced Jul 15, 2026
 Open

 Open

 Closed

 Closed

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 27, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 24, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

doesn't work in a react-router v7 project


2 participants

@NathanColosimo@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix Nitro cleanup for React Router and add setup guides - #2908
Merged
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Jul 14, 2026
Merged
Fix Nitro cleanup for React Router and add setup guides#2908
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Conversation
@NathanColosimo
@NathanColosimoNathanColosimo
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Fix React Router v7 and v8 production builds with Nitro v3, and add setup guides for both versions.
React Router creates a temporary Vite server during vite build. Its Nitro server and Workflow's esbuild contexts remained active, so the build finished but did not exit. This PR cleans up both after their output is written.
Testing
  • React Router 7.18 and 8.1 development and production builds
  • @workflow/nitro build and 32 tests
  • Docs links, code samples, build, and preview smoke tests
Docs Preview
PagePreview
React RouterOpen
React Router v7Open
React Router v8Open
Closes#821
@vercel
vercelBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-astro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-express-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-fastify-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-hono-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nitro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nuxt-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-vite-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 14, 2026 3:50am
workflow-swc-playgroundReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-tarballsBuildingBuildingPreview, CommentJul 14, 2026 3:50am
workflow-webReadyReadyPreview, CommentJul 14, 2026 3:50am
@changeset-bot
changeset-botBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fbb8267
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit fbb8267 · Tue, 14 Jul 2026 04:07:33 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1401 (+20%)1665 🔴1759 🔴1882 🔴30
TTFShook + stream1666 (+17%)1923 🔴1973 🔴2048 🔴30
STSO1020 steps (1-20)275 (-2.9%)310 🔴360 🔴431 🔴19
STSO1020 steps (101-120)466 (+4.6%)453 🔴569 🔴1311 🔴19
STSO1020 steps (1001-1020)1091 (+25%)1144 🔴1362 🔴1845 🔴19
WOstream1401 (+20%)16651759188230
WOhook + stream1666 (+17%)19231973204830
SLstream4629 (-9.3%)5205 🔴5718 🔴5818 🔴30
SLhook + stream4921 (-3.2%)5149 🔴5742 🔴5815 🔴30
📜 Previous results (3)
b2e31a0
Tue, 14 Jul 2026 00:24:00 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1143 (+10.0%)1624 🔴1741 🔴1943 🔴30
TTFShook + stream1606 (+12%)1972 🔴2105 🔴2172 🔴30
STSO1020 steps (1-20)307 (+2.2%)344 🔴463 🔴497 🔴19
STSO1020 steps (101-120)432 (-2.4%)429 🔴594 🔴717 🔴19
STSO1020 steps (1001-1020)845 (-1.1%)884 🔴932 🔴946 🔴19
WOstream1143 (+10.0%)16241741194330
WOhook + stream1606 (+12%)19722105217230
SLstream4585 (±0%)5436 🔴5587 🔴5796 🔴30
SLhook + stream4630 (-6.6%)5273 🔴5379 🔴5522 🔴30
e506f40
Mon, 13 Jul 2026 23:04:58 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1441 (+1.1%)1668 🔴1706 🔴3011 🔴30
TTFShook + stream1498 (-12%)1879 🔴1934 🔴2104 🔴30
STSO1020 steps (1-20)295 (+12%)316 🔴487 🔴515 🔴19
STSO1020 steps (101-120)465 (+17%)462 🔴740 🔴758 🔴19
STSO1020 steps (1001-1020)1054 (+26%)1001 🔴1298 🔴4108 🔴19
WOstream1441 (+1.1%)16681706301130
WOhook + stream1498 (-12%)18791934210430
SLstream4859 (-4.8%)5293 🔴5784 🔴5871 🔴30
SLhook + stream5056 (+3.5%)5538 🔴5629 🔴5878 🔴30
02e7587
Mon, 13 Jul 2026 22:34:08 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1154 (-19%)1633 🔴1649 🔴1678 🔴30
TTFShook + stream1533 (-9.5%)1963 🔴2022 🔴2254 🔴30
STSO1020 steps (1-20)278 (+5.3%)344 🔴405 🔴416 🔴19
STSO1020 steps (101-120)391 (-1.5%)409 🔴517 🔴558 🔴19
STSO1020 steps (1001-1020)892 (+6.7%)970 🔴1074 🔴1168 🔴19
WOstream1154 (-19%)16331649167830
WOhook + stream1533 (-9.5%)19632022225430
SLstream4193 (-18%)5603 🔴5756 🔴5890 🔴30
SLhook + stream4702 (-3.8%)5582 🔴5704 🔴5759 🔴30
Avg deltas compare against the most recent benchmark run on main at the time of this run.
Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)
Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges
🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.
@NathanColosimo
NathanColosimo
merged commit 3589958
into
mainJul 14, 2026

172 of 174 checks passed

@NathanColosimo
NathanColosimo
deleted the

nathanc/add-nitro-react-router-docs-and-fix

branch
July 14, 2026 20:34
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged

@github-actions
github-actionsBot
commented
Jul 14, 2026

Copy link


Copy Markdown

Contributor
Backport PR opened against stable: #2923. Merge conflicts were resolved by AI — please review carefully. (backport job run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged


This was referenced Jul 14, 2026

Open

 Draft


This was referenced Jul 15, 2026
 Open

 Open

 Closed

 Closed

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 27, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 24, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

doesn't work in a react-router v7 project


2 participants

@NathanColosimo@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix Nitro cleanup for React Router and add setup guides - #2908
Merged
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Jul 14, 2026
Merged
Fix Nitro cleanup for React Router and add setup guides#2908
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Conversation
@NathanColosimo
@NathanColosimoNathanColosimo
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Fix React Router v7 and v8 production builds with Nitro v3, and add setup guides for both versions.
React Router creates a temporary Vite server during vite build. Its Nitro server and Workflow's esbuild contexts remained active, so the build finished but did not exit. This PR cleans up both after their output is written.
Testing
  • React Router 7.18 and 8.1 development and production builds
  • @workflow/nitro build and 32 tests
  • Docs links, code samples, build, and preview smoke tests
Docs Preview
PagePreview
React RouterOpen
React Router v7Open
React Router v8Open
Closes#821
@vercel
vercelBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-astro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-express-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-fastify-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-hono-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nitro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nuxt-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-vite-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 14, 2026 3:50am
workflow-swc-playgroundReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-tarballsBuildingBuildingPreview, CommentJul 14, 2026 3:50am
workflow-webReadyReadyPreview, CommentJul 14, 2026 3:50am
@changeset-bot
changeset-botBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fbb8267
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit fbb8267 · Tue, 14 Jul 2026 04:07:33 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1401 (+20%)1665 🔴1759 🔴1882 🔴30
TTFShook + stream1666 (+17%)1923 🔴1973 🔴2048 🔴30
STSO1020 steps (1-20)275 (-2.9%)310 🔴360 🔴431 🔴19
STSO1020 steps (101-120)466 (+4.6%)453 🔴569 🔴1311 🔴19
STSO1020 steps (1001-1020)1091 (+25%)1144 🔴1362 🔴1845 🔴19
WOstream1401 (+20%)16651759188230
WOhook + stream1666 (+17%)19231973204830
SLstream4629 (-9.3%)5205 🔴5718 🔴5818 🔴30
SLhook + stream4921 (-3.2%)5149 🔴5742 🔴5815 🔴30
📜 Previous results (3)
b2e31a0
Tue, 14 Jul 2026 00:24:00 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1143 (+10.0%)1624 🔴1741 🔴1943 🔴30
TTFShook + stream1606 (+12%)1972 🔴2105 🔴2172 🔴30
STSO1020 steps (1-20)307 (+2.2%)344 🔴463 🔴497 🔴19
STSO1020 steps (101-120)432 (-2.4%)429 🔴594 🔴717 🔴19
STSO1020 steps (1001-1020)845 (-1.1%)884 🔴932 🔴946 🔴19
WOstream1143 (+10.0%)16241741194330
WOhook + stream1606 (+12%)19722105217230
SLstream4585 (±0%)5436 🔴5587 🔴5796 🔴30
SLhook + stream4630 (-6.6%)5273 🔴5379 🔴5522 🔴30
e506f40
Mon, 13 Jul 2026 23:04:58 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1441 (+1.1%)1668 🔴1706 🔴3011 🔴30
TTFShook + stream1498 (-12%)1879 🔴1934 🔴2104 🔴30
STSO1020 steps (1-20)295 (+12%)316 🔴487 🔴515 🔴19
STSO1020 steps (101-120)465 (+17%)462 🔴740 🔴758 🔴19
STSO1020 steps (1001-1020)1054 (+26%)1001 🔴1298 🔴4108 🔴19
WOstream1441 (+1.1%)16681706301130
WOhook + stream1498 (-12%)18791934210430
SLstream4859 (-4.8%)5293 🔴5784 🔴5871 🔴30
SLhook + stream5056 (+3.5%)5538 🔴5629 🔴5878 🔴30
02e7587
Mon, 13 Jul 2026 22:34:08 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1154 (-19%)1633 🔴1649 🔴1678 🔴30
TTFShook + stream1533 (-9.5%)1963 🔴2022 🔴2254 🔴30
STSO1020 steps (1-20)278 (+5.3%)344 🔴405 🔴416 🔴19
STSO1020 steps (101-120)391 (-1.5%)409 🔴517 🔴558 🔴19
STSO1020 steps (1001-1020)892 (+6.7%)970 🔴1074 🔴1168 🔴19
WOstream1154 (-19%)16331649167830
WOhook + stream1533 (-9.5%)19632022225430
SLstream4193 (-18%)5603 🔴5756 🔴5890 🔴30
SLhook + stream4702 (-3.8%)5582 🔴5704 🔴5759 🔴30
Avg deltas compare against the most recent benchmark run on main at the time of this run.
Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)
Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges
🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.
@NathanColosimo
NathanColosimo
merged commit 3589958
into
mainJul 14, 2026

172 of 174 checks passed

@NathanColosimo
NathanColosimo
deleted the

nathanc/add-nitro-react-router-docs-and-fix

branch
July 14, 2026 20:34
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged

@github-actions
github-actionsBot
commented
Jul 14, 2026

Copy link


Copy Markdown

Contributor
Backport PR opened against stable: #2923. Merge conflicts were resolved by AI — please review carefully. (backport job run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged


This was referenced Jul 14, 2026

Open

 Draft


This was referenced Jul 15, 2026
 Open

 Open

 Closed

 Closed

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 27, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 24, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

doesn't work in a react-router v7 project


2 participants

@NathanColosimo@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix Nitro cleanup for React Router and add setup guides - #2908
Merged
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Jul 14, 2026
Merged
Fix Nitro cleanup for React Router and add setup guides#2908
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Conversation
@NathanColosimo
@NathanColosimoNathanColosimo
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Fix React Router v7 and v8 production builds with Nitro v3, and add setup guides for both versions.
React Router creates a temporary Vite server during vite build. Its Nitro server and Workflow's esbuild contexts remained active, so the build finished but did not exit. This PR cleans up both after their output is written.
Testing
  • React Router 7.18 and 8.1 development and production builds
  • @workflow/nitro build and 32 tests
  • Docs links, code samples, build, and preview smoke tests
Docs Preview
PagePreview
React RouterOpen
React Router v7Open
React Router v8Open
Closes#821
@vercel
vercelBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-astro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-express-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-fastify-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-hono-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nitro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nuxt-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-vite-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 14, 2026 3:50am
workflow-swc-playgroundReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-tarballsBuildingBuildingPreview, CommentJul 14, 2026 3:50am
workflow-webReadyReadyPreview, CommentJul 14, 2026 3:50am
@changeset-bot
changeset-botBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fbb8267
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit fbb8267 · Tue, 14 Jul 2026 04:07:33 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1401 (+20%)1665 🔴1759 🔴1882 🔴30
TTFShook + stream1666 (+17%)1923 🔴1973 🔴2048 🔴30
STSO1020 steps (1-20)275 (-2.9%)310 🔴360 🔴431 🔴19
STSO1020 steps (101-120)466 (+4.6%)453 🔴569 🔴1311 🔴19
STSO1020 steps (1001-1020)1091 (+25%)1144 🔴1362 🔴1845 🔴19
WOstream1401 (+20%)16651759188230
WOhook + stream1666 (+17%)19231973204830
SLstream4629 (-9.3%)5205 🔴5718 🔴5818 🔴30
SLhook + stream4921 (-3.2%)5149 🔴5742 🔴5815 🔴30
📜 Previous results (3)
b2e31a0
Tue, 14 Jul 2026 00:24:00 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1143 (+10.0%)1624 🔴1741 🔴1943 🔴30
TTFShook + stream1606 (+12%)1972 🔴2105 🔴2172 🔴30
STSO1020 steps (1-20)307 (+2.2%)344 🔴463 🔴497 🔴19
STSO1020 steps (101-120)432 (-2.4%)429 🔴594 🔴717 🔴19
STSO1020 steps (1001-1020)845 (-1.1%)884 🔴932 🔴946 🔴19
WOstream1143 (+10.0%)16241741194330
WOhook + stream1606 (+12%)19722105217230
SLstream4585 (±0%)5436 🔴5587 🔴5796 🔴30
SLhook + stream4630 (-6.6%)5273 🔴5379 🔴5522 🔴30
e506f40
Mon, 13 Jul 2026 23:04:58 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1441 (+1.1%)1668 🔴1706 🔴3011 🔴30
TTFShook + stream1498 (-12%)1879 🔴1934 🔴2104 🔴30
STSO1020 steps (1-20)295 (+12%)316 🔴487 🔴515 🔴19
STSO1020 steps (101-120)465 (+17%)462 🔴740 🔴758 🔴19
STSO1020 steps (1001-1020)1054 (+26%)1001 🔴1298 🔴4108 🔴19
WOstream1441 (+1.1%)16681706301130
WOhook + stream1498 (-12%)18791934210430
SLstream4859 (-4.8%)5293 🔴5784 🔴5871 🔴30
SLhook + stream5056 (+3.5%)5538 🔴5629 🔴5878 🔴30
02e7587
Mon, 13 Jul 2026 22:34:08 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1154 (-19%)1633 🔴1649 🔴1678 🔴30
TTFShook + stream1533 (-9.5%)1963 🔴2022 🔴2254 🔴30
STSO1020 steps (1-20)278 (+5.3%)344 🔴405 🔴416 🔴19
STSO1020 steps (101-120)391 (-1.5%)409 🔴517 🔴558 🔴19
STSO1020 steps (1001-1020)892 (+6.7%)970 🔴1074 🔴1168 🔴19
WOstream1154 (-19%)16331649167830
WOhook + stream1533 (-9.5%)19632022225430
SLstream4193 (-18%)5603 🔴5756 🔴5890 🔴30
SLhook + stream4702 (-3.8%)5582 🔴5704 🔴5759 🔴30
Avg deltas compare against the most recent benchmark run on main at the time of this run.
Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)
Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges
🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.
@NathanColosimo
NathanColosimo
merged commit 3589958
into
mainJul 14, 2026

172 of 174 checks passed

@NathanColosimo
NathanColosimo
deleted the

nathanc/add-nitro-react-router-docs-and-fix

branch
July 14, 2026 20:34
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged

@github-actions
github-actionsBot
commented
Jul 14, 2026

Copy link


Copy Markdown

Contributor
Backport PR opened against stable: #2923. Merge conflicts were resolved by AI — please review carefully. (backport job run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged


This was referenced Jul 14, 2026

Open

 Draft


This was referenced Jul 15, 2026
 Open

 Open

 Closed

 Closed

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 27, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 24, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

doesn't work in a react-router v7 project


2 participants

@NathanColosimo@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix Nitro cleanup for React Router and add setup guides - #2908
Merged
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Jul 14, 2026
Merged
Fix Nitro cleanup for React Router and add setup guides#2908
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Conversation
@NathanColosimo
@NathanColosimoNathanColosimo
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Fix React Router v7 and v8 production builds with Nitro v3, and add setup guides for both versions.
React Router creates a temporary Vite server during vite build. Its Nitro server and Workflow's esbuild contexts remained active, so the build finished but did not exit. This PR cleans up both after their output is written.
Testing
  • React Router 7.18 and 8.1 development and production builds
  • @workflow/nitro build and 32 tests
  • Docs links, code samples, build, and preview smoke tests
Docs Preview
PagePreview
React RouterOpen
React Router v7Open
React Router v8Open
Closes#821
@vercel
vercelBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-astro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-express-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-fastify-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-hono-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nitro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nuxt-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-vite-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 14, 2026 3:50am
workflow-swc-playgroundReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-tarballsBuildingBuildingPreview, CommentJul 14, 2026 3:50am
workflow-webReadyReadyPreview, CommentJul 14, 2026 3:50am
@changeset-bot
changeset-botBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fbb8267
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit fbb8267 · Tue, 14 Jul 2026 04:07:33 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1401 (+20%)1665 🔴1759 🔴1882 🔴30
TTFShook + stream1666 (+17%)1923 🔴1973 🔴2048 🔴30
STSO1020 steps (1-20)275 (-2.9%)310 🔴360 🔴431 🔴19
STSO1020 steps (101-120)466 (+4.6%)453 🔴569 🔴1311 🔴19
STSO1020 steps (1001-1020)1091 (+25%)1144 🔴1362 🔴1845 🔴19
WOstream1401 (+20%)16651759188230
WOhook + stream1666 (+17%)19231973204830
SLstream4629 (-9.3%)5205 🔴5718 🔴5818 🔴30
SLhook + stream4921 (-3.2%)5149 🔴5742 🔴5815 🔴30
📜 Previous results (3)
b2e31a0
Tue, 14 Jul 2026 00:24:00 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1143 (+10.0%)1624 🔴1741 🔴1943 🔴30
TTFShook + stream1606 (+12%)1972 🔴2105 🔴2172 🔴30
STSO1020 steps (1-20)307 (+2.2%)344 🔴463 🔴497 🔴19
STSO1020 steps (101-120)432 (-2.4%)429 🔴594 🔴717 🔴19
STSO1020 steps (1001-1020)845 (-1.1%)884 🔴932 🔴946 🔴19
WOstream1143 (+10.0%)16241741194330
WOhook + stream1606 (+12%)19722105217230
SLstream4585 (±0%)5436 🔴5587 🔴5796 🔴30
SLhook + stream4630 (-6.6%)5273 🔴5379 🔴5522 🔴30
e506f40
Mon, 13 Jul 2026 23:04:58 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1441 (+1.1%)1668 🔴1706 🔴3011 🔴30
TTFShook + stream1498 (-12%)1879 🔴1934 🔴2104 🔴30
STSO1020 steps (1-20)295 (+12%)316 🔴487 🔴515 🔴19
STSO1020 steps (101-120)465 (+17%)462 🔴740 🔴758 🔴19
STSO1020 steps (1001-1020)1054 (+26%)1001 🔴1298 🔴4108 🔴19
WOstream1441 (+1.1%)16681706301130
WOhook + stream1498 (-12%)18791934210430
SLstream4859 (-4.8%)5293 🔴5784 🔴5871 🔴30
SLhook + stream5056 (+3.5%)5538 🔴5629 🔴5878 🔴30
02e7587
Mon, 13 Jul 2026 22:34:08 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1154 (-19%)1633 🔴1649 🔴1678 🔴30
TTFShook + stream1533 (-9.5%)1963 🔴2022 🔴2254 🔴30
STSO1020 steps (1-20)278 (+5.3%)344 🔴405 🔴416 🔴19
STSO1020 steps (101-120)391 (-1.5%)409 🔴517 🔴558 🔴19
STSO1020 steps (1001-1020)892 (+6.7%)970 🔴1074 🔴1168 🔴19
WOstream1154 (-19%)16331649167830
WOhook + stream1533 (-9.5%)19632022225430
SLstream4193 (-18%)5603 🔴5756 🔴5890 🔴30
SLhook + stream4702 (-3.8%)5582 🔴5704 🔴5759 🔴30
Avg deltas compare against the most recent benchmark run on main at the time of this run.
Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)
Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges
🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.
@NathanColosimo
NathanColosimo
merged commit 3589958
into
mainJul 14, 2026

172 of 174 checks passed

@NathanColosimo
NathanColosimo
deleted the

nathanc/add-nitro-react-router-docs-and-fix

branch
July 14, 2026 20:34
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged

@github-actions
github-actionsBot
commented
Jul 14, 2026

Copy link


Copy Markdown

Contributor
Backport PR opened against stable: #2923. Merge conflicts were resolved by AI — please review carefully. (backport job run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged


This was referenced Jul 14, 2026

Open

 Draft


This was referenced Jul 15, 2026
 Open

 Open

 Closed

 Closed

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 27, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 24, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

doesn't work in a react-router v7 project


2 participants

@NathanColosimo@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix Nitro cleanup for React Router and add setup guides - #2908
Merged
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Jul 14, 2026
Merged
Fix Nitro cleanup for React Router and add setup guides#2908
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Conversation
@NathanColosimo
@NathanColosimoNathanColosimo
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Fix React Router v7 and v8 production builds with Nitro v3, and add setup guides for both versions.
React Router creates a temporary Vite server during vite build. Its Nitro server and Workflow's esbuild contexts remained active, so the build finished but did not exit. This PR cleans up both after their output is written.
Testing
  • React Router 7.18 and 8.1 development and production builds
  • @workflow/nitro build and 32 tests
  • Docs links, code samples, build, and preview smoke tests
Docs Preview
PagePreview
React RouterOpen
React Router v7Open
React Router v8Open
Closes#821
@vercel
vercelBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-astro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-express-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-fastify-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-hono-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nitro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nuxt-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-vite-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 14, 2026 3:50am
workflow-swc-playgroundReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-tarballsBuildingBuildingPreview, CommentJul 14, 2026 3:50am
workflow-webReadyReadyPreview, CommentJul 14, 2026 3:50am
@changeset-bot
changeset-botBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fbb8267
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit fbb8267 · Tue, 14 Jul 2026 04:07:33 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1401 (+20%)1665 🔴1759 🔴1882 🔴30
TTFShook + stream1666 (+17%)1923 🔴1973 🔴2048 🔴30
STSO1020 steps (1-20)275 (-2.9%)310 🔴360 🔴431 🔴19
STSO1020 steps (101-120)466 (+4.6%)453 🔴569 🔴1311 🔴19
STSO1020 steps (1001-1020)1091 (+25%)1144 🔴1362 🔴1845 🔴19
WOstream1401 (+20%)16651759188230
WOhook + stream1666 (+17%)19231973204830
SLstream4629 (-9.3%)5205 🔴5718 🔴5818 🔴30
SLhook + stream4921 (-3.2%)5149 🔴5742 🔴5815 🔴30
📜 Previous results (3)
b2e31a0
Tue, 14 Jul 2026 00:24:00 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1143 (+10.0%)1624 🔴1741 🔴1943 🔴30
TTFShook + stream1606 (+12%)1972 🔴2105 🔴2172 🔴30
STSO1020 steps (1-20)307 (+2.2%)344 🔴463 🔴497 🔴19
STSO1020 steps (101-120)432 (-2.4%)429 🔴594 🔴717 🔴19
STSO1020 steps (1001-1020)845 (-1.1%)884 🔴932 🔴946 🔴19
WOstream1143 (+10.0%)16241741194330
WOhook + stream1606 (+12%)19722105217230
SLstream4585 (±0%)5436 🔴5587 🔴5796 🔴30
SLhook + stream4630 (-6.6%)5273 🔴5379 🔴5522 🔴30
e506f40
Mon, 13 Jul 2026 23:04:58 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1441 (+1.1%)1668 🔴1706 🔴3011 🔴30
TTFShook + stream1498 (-12%)1879 🔴1934 🔴2104 🔴30
STSO1020 steps (1-20)295 (+12%)316 🔴487 🔴515 🔴19
STSO1020 steps (101-120)465 (+17%)462 🔴740 🔴758 🔴19
STSO1020 steps (1001-1020)1054 (+26%)1001 🔴1298 🔴4108 🔴19
WOstream1441 (+1.1%)16681706301130
WOhook + stream1498 (-12%)18791934210430
SLstream4859 (-4.8%)5293 🔴5784 🔴5871 🔴30
SLhook + stream5056 (+3.5%)5538 🔴5629 🔴5878 🔴30
02e7587
Mon, 13 Jul 2026 22:34:08 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1154 (-19%)1633 🔴1649 🔴1678 🔴30
TTFShook + stream1533 (-9.5%)1963 🔴2022 🔴2254 🔴30
STSO1020 steps (1-20)278 (+5.3%)344 🔴405 🔴416 🔴19
STSO1020 steps (101-120)391 (-1.5%)409 🔴517 🔴558 🔴19
STSO1020 steps (1001-1020)892 (+6.7%)970 🔴1074 🔴1168 🔴19
WOstream1154 (-19%)16331649167830
WOhook + stream1533 (-9.5%)19632022225430
SLstream4193 (-18%)5603 🔴5756 🔴5890 🔴30
SLhook + stream4702 (-3.8%)5582 🔴5704 🔴5759 🔴30
Avg deltas compare against the most recent benchmark run on main at the time of this run.
Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)
Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges
🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.
@NathanColosimo
NathanColosimo
merged commit 3589958
into
mainJul 14, 2026

172 of 174 checks passed

@NathanColosimo
NathanColosimo
deleted the

nathanc/add-nitro-react-router-docs-and-fix

branch
July 14, 2026 20:34
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged

@github-actions
github-actionsBot
commented
Jul 14, 2026

Copy link


Copy Markdown

Contributor
Backport PR opened against stable: #2923. Merge conflicts were resolved by AI — please review carefully. (backport job run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged


This was referenced Jul 14, 2026

Open

 Draft


This was referenced Jul 15, 2026
 Open

 Open

 Closed

 Closed

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 27, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 24, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

doesn't work in a react-router v7 project


2 participants

@NathanColosimo@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix Nitro cleanup for React Router and add setup guides - #2908
Merged
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Jul 14, 2026
Merged
Fix Nitro cleanup for React Router and add setup guides#2908
NathanColosimo merged 4 commits into
mainfrom 
nathanc/add-nitro-react-router-docs-and-fix
Conversation
@NathanColosimo
@NathanColosimoNathanColosimo
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Fix React Router v7 and v8 production builds with Nitro v3, and add setup guides for both versions.
React Router creates a temporary Vite server during vite build. Its Nitro server and Workflow's esbuild contexts remained active, so the build finished but did not exit. This PR cleans up both after their output is written.
Testing
  • React Router 7.18 and 8.1 development and production builds
  • @workflow/nitro build and 32 tests
  • Docs links, code samples, build, and preview smoke tests
Docs Preview
PagePreview
React RouterOpen
React Router v7Open
React Router v8Open
Closes#821
@vercel
vercelBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 14, 2026 3:50am
example-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-astro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-express-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-fastify-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-hono-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nitro-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-nuxt-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workbench-vite-workflowReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 14, 2026 3:50am
workflow-swc-playgroundReadyReadyPreview, CommentJul 14, 2026 3:50am
workflow-tarballsBuildingBuildingPreview, CommentJul 14, 2026 3:50am
workflow-webReadyReadyPreview, CommentJul 14, 2026 3:50am
@changeset-bot
changeset-botBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fbb8267
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit fbb8267 · Tue, 14 Jul 2026 04:07:33 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1401 (+20%)1665 🔴1759 🔴1882 🔴30
TTFShook + stream1666 (+17%)1923 🔴1973 🔴2048 🔴30
STSO1020 steps (1-20)275 (-2.9%)310 🔴360 🔴431 🔴19
STSO1020 steps (101-120)466 (+4.6%)453 🔴569 🔴1311 🔴19
STSO1020 steps (1001-1020)1091 (+25%)1144 🔴1362 🔴1845 🔴19
WOstream1401 (+20%)16651759188230
WOhook + stream1666 (+17%)19231973204830
SLstream4629 (-9.3%)5205 🔴5718 🔴5818 🔴30
SLhook + stream4921 (-3.2%)5149 🔴5742 🔴5815 🔴30
📜 Previous results (3)
b2e31a0
Tue, 14 Jul 2026 00:24:00 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1143 (+10.0%)1624 🔴1741 🔴1943 🔴30
TTFShook + stream1606 (+12%)1972 🔴2105 🔴2172 🔴30
STSO1020 steps (1-20)307 (+2.2%)344 🔴463 🔴497 🔴19
STSO1020 steps (101-120)432 (-2.4%)429 🔴594 🔴717 🔴19
STSO1020 steps (1001-1020)845 (-1.1%)884 🔴932 🔴946 🔴19
WOstream1143 (+10.0%)16241741194330
WOhook + stream1606 (+12%)19722105217230
SLstream4585 (±0%)5436 🔴5587 🔴5796 🔴30
SLhook + stream4630 (-6.6%)5273 🔴5379 🔴5522 🔴30
e506f40
Mon, 13 Jul 2026 23:04:58 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1441 (+1.1%)1668 🔴1706 🔴3011 🔴30
TTFShook + stream1498 (-12%)1879 🔴1934 🔴2104 🔴30
STSO1020 steps (1-20)295 (+12%)316 🔴487 🔴515 🔴19
STSO1020 steps (101-120)465 (+17%)462 🔴740 🔴758 🔴19
STSO1020 steps (1001-1020)1054 (+26%)1001 🔴1298 🔴4108 🔴19
WOstream1441 (+1.1%)16681706301130
WOhook + stream1498 (-12%)18791934210430
SLstream4859 (-4.8%)5293 🔴5784 🔴5871 🔴30
SLhook + stream5056 (+3.5%)5538 🔴5629 🔴5878 🔴30
02e7587
Mon, 13 Jul 2026 22:34:08 GMT · run logs
vercel / nextjs-turbopack
MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1154 (-19%)1633 🔴1649 🔴1678 🔴30
TTFShook + stream1533 (-9.5%)1963 🔴2022 🔴2254 🔴30
STSO1020 steps (1-20)278 (+5.3%)344 🔴405 🔴416 🔴19
STSO1020 steps (101-120)391 (-1.5%)409 🔴517 🔴558 🔴19
STSO1020 steps (1001-1020)892 (+6.7%)970 🔴1074 🔴1168 🔴19
WOstream1154 (-19%)16331649167830
WOhook + stream1533 (-9.5%)19632022225430
SLstream4193 (-18%)5603 🔴5756 🔴5890 🔴30
SLhook + stream4702 (-3.8%)5582 🔴5704 🔴5759 🔴30
Avg deltas compare against the most recent benchmark run on main at the time of this run.
Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)
Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges
🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.
@NathanColosimo
NathanColosimo
merged commit 3589958
into
mainJul 14, 2026

172 of 174 checks passed

@NathanColosimo
NathanColosimo
deleted the

nathanc/add-nitro-react-router-docs-and-fix

branch
July 14, 2026 20:34
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged

@github-actions
github-actionsBot
commented
Jul 14, 2026

Copy link


Copy Markdown

Contributor
Backport PR opened against stable: #2923. Merge conflicts were resolved by AI — please review carefully. (backport job run)
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 14, 2026
 Merged


This was referenced Jul 14, 2026

Open

 Draft


This was referenced Jul 15, 2026
 Open

 Open

 Closed

 Closed

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 27, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 24, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

doesn't work in a react-router v7 project


2 participants

@NathanColosimo@VaguelySerious