Skip to content

Revert "Statically inject workflow world target" (#2752) - #3142

Merged
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target
Jul 29, 2026
Merged

Revert "Statically inject workflow world target" (#2752)#3142
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Reverts #2752 ("Statically inject workflow world target"). The world package is once again resolved at runtime from WORKFLOW_TARGET_WORLD instead of being aliased into host bundles at build time.

Why this is a surgical revert

141 commits have landed on top of #2752, several of which build on it, so git revert alone leaves the tree unbuildable. This branch removes the static-injection mechanism and restores the pre-#2752 runtime resolution while keeping everything that landed after it.

Removed

  • world-target modules in @workflow/core, @workflow/builders, and the Statically inject workflow world target #2752 additions to @workflow/utils
  • the bundler aliases / defines wired through next, nitro, nuxt, astro, sveltekit, rollup, and both nest builders
  • the @workflow/core/runtime/world-target export, its tsconfig/vitest path aliases
  • the pg-native stub alias and the extracted node-compat banner constants, which only existed because the world package was forced into the SSR bundle (the sveltekit typescript stub alias from fix(sveltekit): production server crash from bundled TypeScript compiler #2799 goes with them for the same reason)

Kept

Note on the o2flow incident that motivated #2752

The o2flow failure (Cannot find module as expression is too dynamic on sandboxDoneHook.resume()) was caused by the world registration being tree-shaken out of an isolated route bundle, which made getWorldLazy() fall through to an obfuscated import() that Turbopack stubs. That path is fixed by the world-init side-effect import on every host entrypoint plus the loud "world runtime was not initialized" error — both of which this revert keeps, along with #3001's regression test. o2flow runs on the Vercel world, which core imports statically, so it never reaches the dynamic resolution path this revert restores.

A follow-up PR stacked on this one proposes hardening the remaining dynamic path (custom world packages under Turbopack/webpack) without reintroducing build-time injection.

Verification

  • pnpm build, pnpm typecheck green
  • unit tests for the affected packages green

@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 27, 2026 22:19
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 164e7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 21 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/astroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/utilsPatch
@workflow/cliPatch
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-vercelPatch
workflowPatch
@workflow/vitePatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/errorsPatch
@workflow/world-postgresPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 164e7d3 · Wed, 29 Jul 2026 06:36:12 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep424 (-39%) 💚1299 🔴 (+26%) 🔻1315 🔴 (+24%) 🔻1415 🔴 (-15%)30
TTFSstream1251 (+30%) 🔻1316 🔴 (+29%) 🔻1330 🔴 (+28%) 🔻1428 🔴 (+23%) 🔻30
TTFShook + stream1482 (+26%) 🔻1532 🔴 (+18%) 🔻1597 🔴 (+17%) 🔻1953 🔴 (+27%) 🔻30
STSO1020 steps (1-20)166 (-8.8%)254 🔴 (-3.4%)290 🔴 (-11%)313 🔴 (-17%) 💚19
STSO1020 steps (101-120)186 (-2.6%)241 🔴 (-8.0%)270 🔴 (-18%) 💚378 🔴 (-64%) 💚19
STSO1020 steps (1001-1020)477 (+1.5%)583 🔴 (+4.1%)676 🔴 (-3.3%)717 🔴 (-6.6%)19
WO1020 steps380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)1
SLstream latency96 (+22%) 🔻142 🔴 (+12%)162 🔴 (+3.8%)181 🔴 (-18%) 💚30
SOstream overhead (text)95 (-13%)210 (±0%)350 (+10%)3151 🔴 (+399%) 🔻30
SOstream overhead (structured)98 (-2.0%)144 (-17%) 💚160 (-18%) 💚240 (-43%) 💚30
📜 Previous results (1)

003f800

Mon, 27 Jul 2026 22:42:23 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep238 (-68%) 💚1374 🔴 (+21%) 🔻1408 🔴 (+16%) 🔻1708 🔴 (+25%) 🔻30
TTFSstream242 (-23%) 💚1347 🔴 (+23%) 🔻1384 🔴 (+21%) 🔻1396 🔴 (+19%) 🔻30
TTFShook + stream400 (-68%) 💚1555 🔴 (+11%)1601 🔴 (+9.6%)1624 🔴 (-0.7%)30
STSO1020 steps (1-20)167 (-1.8%)273 🔴 (-9.6%)283 🔴 (-20%) 💚347 🔴 (-8.4%)19
STSO1020 steps (101-120)206 (+4.6%)302 🔴 (-11%)477 🔴 (+17%) 🔻2242 🔴 (+348%) 🔻19
STSO1020 steps (1001-1020)472 (-2.3%)551 🔴 (-4.0%)591 🔴 (-8.5%)1103 🔴 (+68%) 🔻19
WO1020 steps411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)1
SLstream latency101 (+8.6%)148 🔴 (-12%)179 🔴 (-24%) 💚250 🔴 (-1.2%)30
SOstream overhead (text)115 (-12%)185 (-36%) 💚209 (-41%) 💚401 (-4.8%)30
SOstream overhead (structured)124 (-8.1%)209 (-20%) 💚256 (-7.9%)430 (+4.1%)30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

VaguelySeriousand others added 2 commits July 28, 2026 23:01
This reverts the static world-target injection and restores runtime
resolution of the world package from `WORKFLOW_TARGET_WORLD`.
Because 141 commits have landed on top of #2752, this is a surgical
revert rather than a mechanical one. Removed: the `world-target` modules
in core/builders/utils, the bundler aliases and `define`s wired through
next/nitro/nuxt/astro/sveltekit/rollup/nest, the
`@workflow/core/runtime/world-target` export, and the
pg-native/node-compat-banner helpers that only existed to support the
statically bundled world.
Kept (later work that builds on #2752):
- `createWorldFromModule` / `WorldFactoryModule` in core (used by
world-testing and the nitro dev handler)
- `world-init` / `world-init-stub` / `getWorldLazy` and their
registration of `getWorld` on globalThis, plus the #3001 isolated
route bundle regression test
- #2804 (web), #2806 (cli dynamic community backends), #3112 (world
factory alias removal), #2988 (nest vercel builder), #2925/#2908
(nitro), #2799 (sveltekit typescript stub is dropped with the
injection it existed for), next basePath support, and the windows /
canary test timeout tuning
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#3144 landed after this branch was cut and adapted world selection to
#2752's build-time model: `isVercelDeploymentEnv` treats `VERCEL=1`
without a deployment ID as Vercel, because a `vercel build` on external
CI had to decide which world to bake into the bundles.
With selection back at runtime, `VERCEL_DEPLOYMENT_ID` is authoritative
and always present inside a deployment, so the broader signal only
changes the cases that are not deployments: a production server started
locally or in CI with an env file from `vercel env pull` would resolve to
the Vercel world and then fail for want of a deployment ID, where before
#2752 it used the local world. The same applies to the local world's
read-only-filesystem warning, which would fire in a writable one.
The user-facing text from #3144 explains all of this in terms of build
output and prescribes a rebuild, which no longer applies now that
`WORKFLOW_TARGET_WORLD` takes effect on the next start.
The rest of #3144 is independent of the injection mechanism and stays:
`UnwritableDataDirError`, the warning itself, and the Vercel world's
missing-deployment-ID message.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@VaguelySerious
VaguelySerious merged commit a09d001 into mainJul 29, 2026
175 of 177 checks passed
@VaguelySerious
VaguelySerious deleted the peter/revert-static-world-target branch July 29, 2026 15:55
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a09d001 (AI decision).

This commit reverts #2752 (static world-target injection), which only ever landed on mainorigin/stable has no packages/core/src/runtime/world-target.ts, no packages/builders/src/world-target.ts, no packages/core/vitest.config.ts world-target alias, and its packages/core/src/runtime/world.ts / packages/utils/src/world-target.ts already resolve the world at runtime from WORKFLOW_TARGET_WORLD, i.e. exactly the behavior this revert restores. Backporting a revert of something absent from stable would only churn unrelated files (nitro/next/sveltekit builder changes, workbench configs, v5 docs) with no corresponding defect fix.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a09d00135bd96f22bd1ae1dee6b5a6f797b7d804

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Revert "Statically inject workflow world target" (#2752) by VaguelySerious · Pull Request #3142 · vercel/workflow · GitHub
Skip to content

Revert "Statically inject workflow world target" (#2752) - #3142

Merged
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target
Jul 29, 2026
Merged

Revert "Statically inject workflow world target" (#2752)#3142
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Reverts #2752 ("Statically inject workflow world target"). The world package is once again resolved at runtime from WORKFLOW_TARGET_WORLD instead of being aliased into host bundles at build time.

Why this is a surgical revert

141 commits have landed on top of #2752, several of which build on it, so git revert alone leaves the tree unbuildable. This branch removes the static-injection mechanism and restores the pre-#2752 runtime resolution while keeping everything that landed after it.

Removed

  • world-target modules in @workflow/core, @workflow/builders, and the Statically inject workflow world target #2752 additions to @workflow/utils
  • the bundler aliases / defines wired through next, nitro, nuxt, astro, sveltekit, rollup, and both nest builders
  • the @workflow/core/runtime/world-target export, its tsconfig/vitest path aliases
  • the pg-native stub alias and the extracted node-compat banner constants, which only existed because the world package was forced into the SSR bundle (the sveltekit typescript stub alias from fix(sveltekit): production server crash from bundled TypeScript compiler #2799 goes with them for the same reason)

Kept

Note on the o2flow incident that motivated #2752

The o2flow failure (Cannot find module as expression is too dynamic on sandboxDoneHook.resume()) was caused by the world registration being tree-shaken out of an isolated route bundle, which made getWorldLazy() fall through to an obfuscated import() that Turbopack stubs. That path is fixed by the world-init side-effect import on every host entrypoint plus the loud "world runtime was not initialized" error — both of which this revert keeps, along with #3001's regression test. o2flow runs on the Vercel world, which core imports statically, so it never reaches the dynamic resolution path this revert restores.

A follow-up PR stacked on this one proposes hardening the remaining dynamic path (custom world packages under Turbopack/webpack) without reintroducing build-time injection.

Verification

  • pnpm build, pnpm typecheck green
  • unit tests for the affected packages green

@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 27, 2026 22:19
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 164e7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 21 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/astroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/utilsPatch
@workflow/cliPatch
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-vercelPatch
workflowPatch
@workflow/vitePatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/errorsPatch
@workflow/world-postgresPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 164e7d3 · Wed, 29 Jul 2026 06:36:12 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep424 (-39%) 💚1299 🔴 (+26%) 🔻1315 🔴 (+24%) 🔻1415 🔴 (-15%)30
TTFSstream1251 (+30%) 🔻1316 🔴 (+29%) 🔻1330 🔴 (+28%) 🔻1428 🔴 (+23%) 🔻30
TTFShook + stream1482 (+26%) 🔻1532 🔴 (+18%) 🔻1597 🔴 (+17%) 🔻1953 🔴 (+27%) 🔻30
STSO1020 steps (1-20)166 (-8.8%)254 🔴 (-3.4%)290 🔴 (-11%)313 🔴 (-17%) 💚19
STSO1020 steps (101-120)186 (-2.6%)241 🔴 (-8.0%)270 🔴 (-18%) 💚378 🔴 (-64%) 💚19
STSO1020 steps (1001-1020)477 (+1.5%)583 🔴 (+4.1%)676 🔴 (-3.3%)717 🔴 (-6.6%)19
WO1020 steps380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)1
SLstream latency96 (+22%) 🔻142 🔴 (+12%)162 🔴 (+3.8%)181 🔴 (-18%) 💚30
SOstream overhead (text)95 (-13%)210 (±0%)350 (+10%)3151 🔴 (+399%) 🔻30
SOstream overhead (structured)98 (-2.0%)144 (-17%) 💚160 (-18%) 💚240 (-43%) 💚30
📜 Previous results (1)

003f800

Mon, 27 Jul 2026 22:42:23 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep238 (-68%) 💚1374 🔴 (+21%) 🔻1408 🔴 (+16%) 🔻1708 🔴 (+25%) 🔻30
TTFSstream242 (-23%) 💚1347 🔴 (+23%) 🔻1384 🔴 (+21%) 🔻1396 🔴 (+19%) 🔻30
TTFShook + stream400 (-68%) 💚1555 🔴 (+11%)1601 🔴 (+9.6%)1624 🔴 (-0.7%)30
STSO1020 steps (1-20)167 (-1.8%)273 🔴 (-9.6%)283 🔴 (-20%) 💚347 🔴 (-8.4%)19
STSO1020 steps (101-120)206 (+4.6%)302 🔴 (-11%)477 🔴 (+17%) 🔻2242 🔴 (+348%) 🔻19
STSO1020 steps (1001-1020)472 (-2.3%)551 🔴 (-4.0%)591 🔴 (-8.5%)1103 🔴 (+68%) 🔻19
WO1020 steps411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)1
SLstream latency101 (+8.6%)148 🔴 (-12%)179 🔴 (-24%) 💚250 🔴 (-1.2%)30
SOstream overhead (text)115 (-12%)185 (-36%) 💚209 (-41%) 💚401 (-4.8%)30
SOstream overhead (structured)124 (-8.1%)209 (-20%) 💚256 (-7.9%)430 (+4.1%)30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

VaguelySeriousand others added 2 commits July 28, 2026 23:01
This reverts the static world-target injection and restores runtime
resolution of the world package from `WORKFLOW_TARGET_WORLD`.
Because 141 commits have landed on top of #2752, this is a surgical
revert rather than a mechanical one. Removed: the `world-target` modules
in core/builders/utils, the bundler aliases and `define`s wired through
next/nitro/nuxt/astro/sveltekit/rollup/nest, the
`@workflow/core/runtime/world-target` export, and the
pg-native/node-compat-banner helpers that only existed to support the
statically bundled world.
Kept (later work that builds on #2752):
- `createWorldFromModule` / `WorldFactoryModule` in core (used by
world-testing and the nitro dev handler)
- `world-init` / `world-init-stub` / `getWorldLazy` and their
registration of `getWorld` on globalThis, plus the #3001 isolated
route bundle regression test
- #2804 (web), #2806 (cli dynamic community backends), #3112 (world
factory alias removal), #2988 (nest vercel builder), #2925/#2908
(nitro), #2799 (sveltekit typescript stub is dropped with the
injection it existed for), next basePath support, and the windows /
canary test timeout tuning
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#3144 landed after this branch was cut and adapted world selection to
#2752's build-time model: `isVercelDeploymentEnv` treats `VERCEL=1`
without a deployment ID as Vercel, because a `vercel build` on external
CI had to decide which world to bake into the bundles.
With selection back at runtime, `VERCEL_DEPLOYMENT_ID` is authoritative
and always present inside a deployment, so the broader signal only
changes the cases that are not deployments: a production server started
locally or in CI with an env file from `vercel env pull` would resolve to
the Vercel world and then fail for want of a deployment ID, where before
#2752 it used the local world. The same applies to the local world's
read-only-filesystem warning, which would fire in a writable one.
The user-facing text from #3144 explains all of this in terms of build
output and prescribes a rebuild, which no longer applies now that
`WORKFLOW_TARGET_WORLD` takes effect on the next start.
The rest of #3144 is independent of the injection mechanism and stays:
`UnwritableDataDirError`, the warning itself, and the Vercel world's
missing-deployment-ID message.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@VaguelySerious
VaguelySerious merged commit a09d001 into mainJul 29, 2026
175 of 177 checks passed
@VaguelySerious
VaguelySerious deleted the peter/revert-static-world-target branch July 29, 2026 15:55
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a09d001 (AI decision).

This commit reverts #2752 (static world-target injection), which only ever landed on mainorigin/stable has no packages/core/src/runtime/world-target.ts, no packages/builders/src/world-target.ts, no packages/core/vitest.config.ts world-target alias, and its packages/core/src/runtime/world.ts / packages/utils/src/world-target.ts already resolve the world at runtime from WORKFLOW_TARGET_WORLD, i.e. exactly the behavior this revert restores. Backporting a revert of something absent from stable would only churn unrelated files (nitro/next/sveltekit builder changes, workbench configs, v5 docs) with no corresponding defect fix.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a09d00135bd96f22bd1ae1dee6b5a6f797b7d804

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Revert "Statically inject workflow world target" (#2752) by VaguelySerious · Pull Request #3142 · vercel/workflow · GitHub
Skip to content

Revert "Statically inject workflow world target" (#2752) - #3142

Merged
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target
Jul 29, 2026
Merged

Revert "Statically inject workflow world target" (#2752)#3142
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Reverts #2752 ("Statically inject workflow world target"). The world package is once again resolved at runtime from WORKFLOW_TARGET_WORLD instead of being aliased into host bundles at build time.

Why this is a surgical revert

141 commits have landed on top of #2752, several of which build on it, so git revert alone leaves the tree unbuildable. This branch removes the static-injection mechanism and restores the pre-#2752 runtime resolution while keeping everything that landed after it.

Removed

  • world-target modules in @workflow/core, @workflow/builders, and the Statically inject workflow world target #2752 additions to @workflow/utils
  • the bundler aliases / defines wired through next, nitro, nuxt, astro, sveltekit, rollup, and both nest builders
  • the @workflow/core/runtime/world-target export, its tsconfig/vitest path aliases
  • the pg-native stub alias and the extracted node-compat banner constants, which only existed because the world package was forced into the SSR bundle (the sveltekit typescript stub alias from fix(sveltekit): production server crash from bundled TypeScript compiler #2799 goes with them for the same reason)

Kept

Note on the o2flow incident that motivated #2752

The o2flow failure (Cannot find module as expression is too dynamic on sandboxDoneHook.resume()) was caused by the world registration being tree-shaken out of an isolated route bundle, which made getWorldLazy() fall through to an obfuscated import() that Turbopack stubs. That path is fixed by the world-init side-effect import on every host entrypoint plus the loud "world runtime was not initialized" error — both of which this revert keeps, along with #3001's regression test. o2flow runs on the Vercel world, which core imports statically, so it never reaches the dynamic resolution path this revert restores.

A follow-up PR stacked on this one proposes hardening the remaining dynamic path (custom world packages under Turbopack/webpack) without reintroducing build-time injection.

Verification

  • pnpm build, pnpm typecheck green
  • unit tests for the affected packages green

@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 27, 2026 22:19
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 164e7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 21 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/astroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/utilsPatch
@workflow/cliPatch
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-vercelPatch
workflowPatch
@workflow/vitePatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/errorsPatch
@workflow/world-postgresPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 164e7d3 · Wed, 29 Jul 2026 06:36:12 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep424 (-39%) 💚1299 🔴 (+26%) 🔻1315 🔴 (+24%) 🔻1415 🔴 (-15%)30
TTFSstream1251 (+30%) 🔻1316 🔴 (+29%) 🔻1330 🔴 (+28%) 🔻1428 🔴 (+23%) 🔻30
TTFShook + stream1482 (+26%) 🔻1532 🔴 (+18%) 🔻1597 🔴 (+17%) 🔻1953 🔴 (+27%) 🔻30
STSO1020 steps (1-20)166 (-8.8%)254 🔴 (-3.4%)290 🔴 (-11%)313 🔴 (-17%) 💚19
STSO1020 steps (101-120)186 (-2.6%)241 🔴 (-8.0%)270 🔴 (-18%) 💚378 🔴 (-64%) 💚19
STSO1020 steps (1001-1020)477 (+1.5%)583 🔴 (+4.1%)676 🔴 (-3.3%)717 🔴 (-6.6%)19
WO1020 steps380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)1
SLstream latency96 (+22%) 🔻142 🔴 (+12%)162 🔴 (+3.8%)181 🔴 (-18%) 💚30
SOstream overhead (text)95 (-13%)210 (±0%)350 (+10%)3151 🔴 (+399%) 🔻30
SOstream overhead (structured)98 (-2.0%)144 (-17%) 💚160 (-18%) 💚240 (-43%) 💚30
📜 Previous results (1)

003f800

Mon, 27 Jul 2026 22:42:23 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep238 (-68%) 💚1374 🔴 (+21%) 🔻1408 🔴 (+16%) 🔻1708 🔴 (+25%) 🔻30
TTFSstream242 (-23%) 💚1347 🔴 (+23%) 🔻1384 🔴 (+21%) 🔻1396 🔴 (+19%) 🔻30
TTFShook + stream400 (-68%) 💚1555 🔴 (+11%)1601 🔴 (+9.6%)1624 🔴 (-0.7%)30
STSO1020 steps (1-20)167 (-1.8%)273 🔴 (-9.6%)283 🔴 (-20%) 💚347 🔴 (-8.4%)19
STSO1020 steps (101-120)206 (+4.6%)302 🔴 (-11%)477 🔴 (+17%) 🔻2242 🔴 (+348%) 🔻19
STSO1020 steps (1001-1020)472 (-2.3%)551 🔴 (-4.0%)591 🔴 (-8.5%)1103 🔴 (+68%) 🔻19
WO1020 steps411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)1
SLstream latency101 (+8.6%)148 🔴 (-12%)179 🔴 (-24%) 💚250 🔴 (-1.2%)30
SOstream overhead (text)115 (-12%)185 (-36%) 💚209 (-41%) 💚401 (-4.8%)30
SOstream overhead (structured)124 (-8.1%)209 (-20%) 💚256 (-7.9%)430 (+4.1%)30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

VaguelySeriousand others added 2 commits July 28, 2026 23:01
This reverts the static world-target injection and restores runtime
resolution of the world package from `WORKFLOW_TARGET_WORLD`.
Because 141 commits have landed on top of #2752, this is a surgical
revert rather than a mechanical one. Removed: the `world-target` modules
in core/builders/utils, the bundler aliases and `define`s wired through
next/nitro/nuxt/astro/sveltekit/rollup/nest, the
`@workflow/core/runtime/world-target` export, and the
pg-native/node-compat-banner helpers that only existed to support the
statically bundled world.
Kept (later work that builds on #2752):
- `createWorldFromModule` / `WorldFactoryModule` in core (used by
world-testing and the nitro dev handler)
- `world-init` / `world-init-stub` / `getWorldLazy` and their
registration of `getWorld` on globalThis, plus the #3001 isolated
route bundle regression test
- #2804 (web), #2806 (cli dynamic community backends), #3112 (world
factory alias removal), #2988 (nest vercel builder), #2925/#2908
(nitro), #2799 (sveltekit typescript stub is dropped with the
injection it existed for), next basePath support, and the windows /
canary test timeout tuning
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#3144 landed after this branch was cut and adapted world selection to
#2752's build-time model: `isVercelDeploymentEnv` treats `VERCEL=1`
without a deployment ID as Vercel, because a `vercel build` on external
CI had to decide which world to bake into the bundles.
With selection back at runtime, `VERCEL_DEPLOYMENT_ID` is authoritative
and always present inside a deployment, so the broader signal only
changes the cases that are not deployments: a production server started
locally or in CI with an env file from `vercel env pull` would resolve to
the Vercel world and then fail for want of a deployment ID, where before
#2752 it used the local world. The same applies to the local world's
read-only-filesystem warning, which would fire in a writable one.
The user-facing text from #3144 explains all of this in terms of build
output and prescribes a rebuild, which no longer applies now that
`WORKFLOW_TARGET_WORLD` takes effect on the next start.
The rest of #3144 is independent of the injection mechanism and stays:
`UnwritableDataDirError`, the warning itself, and the Vercel world's
missing-deployment-ID message.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@VaguelySerious
VaguelySerious merged commit a09d001 into mainJul 29, 2026
175 of 177 checks passed
@VaguelySerious
VaguelySerious deleted the peter/revert-static-world-target branch July 29, 2026 15:55
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a09d001 (AI decision).

This commit reverts #2752 (static world-target injection), which only ever landed on mainorigin/stable has no packages/core/src/runtime/world-target.ts, no packages/builders/src/world-target.ts, no packages/core/vitest.config.ts world-target alias, and its packages/core/src/runtime/world.ts / packages/utils/src/world-target.ts already resolve the world at runtime from WORKFLOW_TARGET_WORLD, i.e. exactly the behavior this revert restores. Backporting a revert of something absent from stable would only churn unrelated files (nitro/next/sveltekit builder changes, workbench configs, v5 docs) with no corresponding defect fix.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a09d00135bd96f22bd1ae1dee6b5a6f797b7d804

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Revert "Statically inject workflow world target" (#2752) by VaguelySerious · Pull Request #3142 · vercel/workflow · GitHub
Skip to content

Revert "Statically inject workflow world target" (#2752) - #3142

Merged
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target
Jul 29, 2026
Merged

Revert "Statically inject workflow world target" (#2752)#3142
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Reverts #2752 ("Statically inject workflow world target"). The world package is once again resolved at runtime from WORKFLOW_TARGET_WORLD instead of being aliased into host bundles at build time.

Why this is a surgical revert

141 commits have landed on top of #2752, several of which build on it, so git revert alone leaves the tree unbuildable. This branch removes the static-injection mechanism and restores the pre-#2752 runtime resolution while keeping everything that landed after it.

Removed

  • world-target modules in @workflow/core, @workflow/builders, and the Statically inject workflow world target #2752 additions to @workflow/utils
  • the bundler aliases / defines wired through next, nitro, nuxt, astro, sveltekit, rollup, and both nest builders
  • the @workflow/core/runtime/world-target export, its tsconfig/vitest path aliases
  • the pg-native stub alias and the extracted node-compat banner constants, which only existed because the world package was forced into the SSR bundle (the sveltekit typescript stub alias from fix(sveltekit): production server crash from bundled TypeScript compiler #2799 goes with them for the same reason)

Kept

Note on the o2flow incident that motivated #2752

The o2flow failure (Cannot find module as expression is too dynamic on sandboxDoneHook.resume()) was caused by the world registration being tree-shaken out of an isolated route bundle, which made getWorldLazy() fall through to an obfuscated import() that Turbopack stubs. That path is fixed by the world-init side-effect import on every host entrypoint plus the loud "world runtime was not initialized" error — both of which this revert keeps, along with #3001's regression test. o2flow runs on the Vercel world, which core imports statically, so it never reaches the dynamic resolution path this revert restores.

A follow-up PR stacked on this one proposes hardening the remaining dynamic path (custom world packages under Turbopack/webpack) without reintroducing build-time injection.

Verification

  • pnpm build, pnpm typecheck green
  • unit tests for the affected packages green

@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 27, 2026 22:19
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 164e7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 21 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/astroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/utilsPatch
@workflow/cliPatch
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-vercelPatch
workflowPatch
@workflow/vitePatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/errorsPatch
@workflow/world-postgresPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 164e7d3 · Wed, 29 Jul 2026 06:36:12 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep424 (-39%) 💚1299 🔴 (+26%) 🔻1315 🔴 (+24%) 🔻1415 🔴 (-15%)30
TTFSstream1251 (+30%) 🔻1316 🔴 (+29%) 🔻1330 🔴 (+28%) 🔻1428 🔴 (+23%) 🔻30
TTFShook + stream1482 (+26%) 🔻1532 🔴 (+18%) 🔻1597 🔴 (+17%) 🔻1953 🔴 (+27%) 🔻30
STSO1020 steps (1-20)166 (-8.8%)254 🔴 (-3.4%)290 🔴 (-11%)313 🔴 (-17%) 💚19
STSO1020 steps (101-120)186 (-2.6%)241 🔴 (-8.0%)270 🔴 (-18%) 💚378 🔴 (-64%) 💚19
STSO1020 steps (1001-1020)477 (+1.5%)583 🔴 (+4.1%)676 🔴 (-3.3%)717 🔴 (-6.6%)19
WO1020 steps380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)1
SLstream latency96 (+22%) 🔻142 🔴 (+12%)162 🔴 (+3.8%)181 🔴 (-18%) 💚30
SOstream overhead (text)95 (-13%)210 (±0%)350 (+10%)3151 🔴 (+399%) 🔻30
SOstream overhead (structured)98 (-2.0%)144 (-17%) 💚160 (-18%) 💚240 (-43%) 💚30
📜 Previous results (1)

003f800

Mon, 27 Jul 2026 22:42:23 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep238 (-68%) 💚1374 🔴 (+21%) 🔻1408 🔴 (+16%) 🔻1708 🔴 (+25%) 🔻30
TTFSstream242 (-23%) 💚1347 🔴 (+23%) 🔻1384 🔴 (+21%) 🔻1396 🔴 (+19%) 🔻30
TTFShook + stream400 (-68%) 💚1555 🔴 (+11%)1601 🔴 (+9.6%)1624 🔴 (-0.7%)30
STSO1020 steps (1-20)167 (-1.8%)273 🔴 (-9.6%)283 🔴 (-20%) 💚347 🔴 (-8.4%)19
STSO1020 steps (101-120)206 (+4.6%)302 🔴 (-11%)477 🔴 (+17%) 🔻2242 🔴 (+348%) 🔻19
STSO1020 steps (1001-1020)472 (-2.3%)551 🔴 (-4.0%)591 🔴 (-8.5%)1103 🔴 (+68%) 🔻19
WO1020 steps411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)1
SLstream latency101 (+8.6%)148 🔴 (-12%)179 🔴 (-24%) 💚250 🔴 (-1.2%)30
SOstream overhead (text)115 (-12%)185 (-36%) 💚209 (-41%) 💚401 (-4.8%)30
SOstream overhead (structured)124 (-8.1%)209 (-20%) 💚256 (-7.9%)430 (+4.1%)30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

VaguelySeriousand others added 2 commits July 28, 2026 23:01
This reverts the static world-target injection and restores runtime
resolution of the world package from `WORKFLOW_TARGET_WORLD`.
Because 141 commits have landed on top of #2752, this is a surgical
revert rather than a mechanical one. Removed: the `world-target` modules
in core/builders/utils, the bundler aliases and `define`s wired through
next/nitro/nuxt/astro/sveltekit/rollup/nest, the
`@workflow/core/runtime/world-target` export, and the
pg-native/node-compat-banner helpers that only existed to support the
statically bundled world.
Kept (later work that builds on #2752):
- `createWorldFromModule` / `WorldFactoryModule` in core (used by
world-testing and the nitro dev handler)
- `world-init` / `world-init-stub` / `getWorldLazy` and their
registration of `getWorld` on globalThis, plus the #3001 isolated
route bundle regression test
- #2804 (web), #2806 (cli dynamic community backends), #3112 (world
factory alias removal), #2988 (nest vercel builder), #2925/#2908
(nitro), #2799 (sveltekit typescript stub is dropped with the
injection it existed for), next basePath support, and the windows /
canary test timeout tuning
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#3144 landed after this branch was cut and adapted world selection to
#2752's build-time model: `isVercelDeploymentEnv` treats `VERCEL=1`
without a deployment ID as Vercel, because a `vercel build` on external
CI had to decide which world to bake into the bundles.
With selection back at runtime, `VERCEL_DEPLOYMENT_ID` is authoritative
and always present inside a deployment, so the broader signal only
changes the cases that are not deployments: a production server started
locally or in CI with an env file from `vercel env pull` would resolve to
the Vercel world and then fail for want of a deployment ID, where before
#2752 it used the local world. The same applies to the local world's
read-only-filesystem warning, which would fire in a writable one.
The user-facing text from #3144 explains all of this in terms of build
output and prescribes a rebuild, which no longer applies now that
`WORKFLOW_TARGET_WORLD` takes effect on the next start.
The rest of #3144 is independent of the injection mechanism and stays:
`UnwritableDataDirError`, the warning itself, and the Vercel world's
missing-deployment-ID message.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@VaguelySerious
VaguelySerious merged commit a09d001 into mainJul 29, 2026
175 of 177 checks passed
@VaguelySerious
VaguelySerious deleted the peter/revert-static-world-target branch July 29, 2026 15:55
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a09d001 (AI decision).

This commit reverts #2752 (static world-target injection), which only ever landed on mainorigin/stable has no packages/core/src/runtime/world-target.ts, no packages/builders/src/world-target.ts, no packages/core/vitest.config.ts world-target alias, and its packages/core/src/runtime/world.ts / packages/utils/src/world-target.ts already resolve the world at runtime from WORKFLOW_TARGET_WORLD, i.e. exactly the behavior this revert restores. Backporting a revert of something absent from stable would only churn unrelated files (nitro/next/sveltekit builder changes, workbench configs, v5 docs) with no corresponding defect fix.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a09d00135bd96f22bd1ae1dee6b5a6f797b7d804

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Revert "Statically inject workflow world target" (#2752) by VaguelySerious · Pull Request #3142 · vercel/workflow · GitHub
Skip to content

Revert "Statically inject workflow world target" (#2752) - #3142

Merged
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target
Jul 29, 2026
Merged

Revert "Statically inject workflow world target" (#2752)#3142
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Reverts #2752 ("Statically inject workflow world target"). The world package is once again resolved at runtime from WORKFLOW_TARGET_WORLD instead of being aliased into host bundles at build time.

Why this is a surgical revert

141 commits have landed on top of #2752, several of which build on it, so git revert alone leaves the tree unbuildable. This branch removes the static-injection mechanism and restores the pre-#2752 runtime resolution while keeping everything that landed after it.

Removed

  • world-target modules in @workflow/core, @workflow/builders, and the Statically inject workflow world target #2752 additions to @workflow/utils
  • the bundler aliases / defines wired through next, nitro, nuxt, astro, sveltekit, rollup, and both nest builders
  • the @workflow/core/runtime/world-target export, its tsconfig/vitest path aliases
  • the pg-native stub alias and the extracted node-compat banner constants, which only existed because the world package was forced into the SSR bundle (the sveltekit typescript stub alias from fix(sveltekit): production server crash from bundled TypeScript compiler #2799 goes with them for the same reason)

Kept

Note on the o2flow incident that motivated #2752

The o2flow failure (Cannot find module as expression is too dynamic on sandboxDoneHook.resume()) was caused by the world registration being tree-shaken out of an isolated route bundle, which made getWorldLazy() fall through to an obfuscated import() that Turbopack stubs. That path is fixed by the world-init side-effect import on every host entrypoint plus the loud "world runtime was not initialized" error — both of which this revert keeps, along with #3001's regression test. o2flow runs on the Vercel world, which core imports statically, so it never reaches the dynamic resolution path this revert restores.

A follow-up PR stacked on this one proposes hardening the remaining dynamic path (custom world packages under Turbopack/webpack) without reintroducing build-time injection.

Verification

  • pnpm build, pnpm typecheck green
  • unit tests for the affected packages green

@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 27, 2026 22:19
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 164e7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 21 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/astroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/utilsPatch
@workflow/cliPatch
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-vercelPatch
workflowPatch
@workflow/vitePatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/errorsPatch
@workflow/world-postgresPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 164e7d3 · Wed, 29 Jul 2026 06:36:12 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep424 (-39%) 💚1299 🔴 (+26%) 🔻1315 🔴 (+24%) 🔻1415 🔴 (-15%)30
TTFSstream1251 (+30%) 🔻1316 🔴 (+29%) 🔻1330 🔴 (+28%) 🔻1428 🔴 (+23%) 🔻30
TTFShook + stream1482 (+26%) 🔻1532 🔴 (+18%) 🔻1597 🔴 (+17%) 🔻1953 🔴 (+27%) 🔻30
STSO1020 steps (1-20)166 (-8.8%)254 🔴 (-3.4%)290 🔴 (-11%)313 🔴 (-17%) 💚19
STSO1020 steps (101-120)186 (-2.6%)241 🔴 (-8.0%)270 🔴 (-18%) 💚378 🔴 (-64%) 💚19
STSO1020 steps (1001-1020)477 (+1.5%)583 🔴 (+4.1%)676 🔴 (-3.3%)717 🔴 (-6.6%)19
WO1020 steps380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)1
SLstream latency96 (+22%) 🔻142 🔴 (+12%)162 🔴 (+3.8%)181 🔴 (-18%) 💚30
SOstream overhead (text)95 (-13%)210 (±0%)350 (+10%)3151 🔴 (+399%) 🔻30
SOstream overhead (structured)98 (-2.0%)144 (-17%) 💚160 (-18%) 💚240 (-43%) 💚30
📜 Previous results (1)

003f800

Mon, 27 Jul 2026 22:42:23 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep238 (-68%) 💚1374 🔴 (+21%) 🔻1408 🔴 (+16%) 🔻1708 🔴 (+25%) 🔻30
TTFSstream242 (-23%) 💚1347 🔴 (+23%) 🔻1384 🔴 (+21%) 🔻1396 🔴 (+19%) 🔻30
TTFShook + stream400 (-68%) 💚1555 🔴 (+11%)1601 🔴 (+9.6%)1624 🔴 (-0.7%)30
STSO1020 steps (1-20)167 (-1.8%)273 🔴 (-9.6%)283 🔴 (-20%) 💚347 🔴 (-8.4%)19
STSO1020 steps (101-120)206 (+4.6%)302 🔴 (-11%)477 🔴 (+17%) 🔻2242 🔴 (+348%) 🔻19
STSO1020 steps (1001-1020)472 (-2.3%)551 🔴 (-4.0%)591 🔴 (-8.5%)1103 🔴 (+68%) 🔻19
WO1020 steps411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)1
SLstream latency101 (+8.6%)148 🔴 (-12%)179 🔴 (-24%) 💚250 🔴 (-1.2%)30
SOstream overhead (text)115 (-12%)185 (-36%) 💚209 (-41%) 💚401 (-4.8%)30
SOstream overhead (structured)124 (-8.1%)209 (-20%) 💚256 (-7.9%)430 (+4.1%)30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

VaguelySeriousand others added 2 commits July 28, 2026 23:01
This reverts the static world-target injection and restores runtime
resolution of the world package from `WORKFLOW_TARGET_WORLD`.
Because 141 commits have landed on top of #2752, this is a surgical
revert rather than a mechanical one. Removed: the `world-target` modules
in core/builders/utils, the bundler aliases and `define`s wired through
next/nitro/nuxt/astro/sveltekit/rollup/nest, the
`@workflow/core/runtime/world-target` export, and the
pg-native/node-compat-banner helpers that only existed to support the
statically bundled world.
Kept (later work that builds on #2752):
- `createWorldFromModule` / `WorldFactoryModule` in core (used by
world-testing and the nitro dev handler)
- `world-init` / `world-init-stub` / `getWorldLazy` and their
registration of `getWorld` on globalThis, plus the #3001 isolated
route bundle regression test
- #2804 (web), #2806 (cli dynamic community backends), #3112 (world
factory alias removal), #2988 (nest vercel builder), #2925/#2908
(nitro), #2799 (sveltekit typescript stub is dropped with the
injection it existed for), next basePath support, and the windows /
canary test timeout tuning
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#3144 landed after this branch was cut and adapted world selection to
#2752's build-time model: `isVercelDeploymentEnv` treats `VERCEL=1`
without a deployment ID as Vercel, because a `vercel build` on external
CI had to decide which world to bake into the bundles.
With selection back at runtime, `VERCEL_DEPLOYMENT_ID` is authoritative
and always present inside a deployment, so the broader signal only
changes the cases that are not deployments: a production server started
locally or in CI with an env file from `vercel env pull` would resolve to
the Vercel world and then fail for want of a deployment ID, where before
#2752 it used the local world. The same applies to the local world's
read-only-filesystem warning, which would fire in a writable one.
The user-facing text from #3144 explains all of this in terms of build
output and prescribes a rebuild, which no longer applies now that
`WORKFLOW_TARGET_WORLD` takes effect on the next start.
The rest of #3144 is independent of the injection mechanism and stays:
`UnwritableDataDirError`, the warning itself, and the Vercel world's
missing-deployment-ID message.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@VaguelySerious
VaguelySerious merged commit a09d001 into mainJul 29, 2026
175 of 177 checks passed
@VaguelySerious
VaguelySerious deleted the peter/revert-static-world-target branch July 29, 2026 15:55
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a09d001 (AI decision).

This commit reverts #2752 (static world-target injection), which only ever landed on mainorigin/stable has no packages/core/src/runtime/world-target.ts, no packages/builders/src/world-target.ts, no packages/core/vitest.config.ts world-target alias, and its packages/core/src/runtime/world.ts / packages/utils/src/world-target.ts already resolve the world at runtime from WORKFLOW_TARGET_WORLD, i.e. exactly the behavior this revert restores. Backporting a revert of something absent from stable would only churn unrelated files (nitro/next/sveltekit builder changes, workbench configs, v5 docs) with no corresponding defect fix.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a09d00135bd96f22bd1ae1dee6b5a6f797b7d804

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Revert "Statically inject workflow world target" (#2752) by VaguelySerious · Pull Request #3142 · vercel/workflow · GitHub
Skip to content

Revert "Statically inject workflow world target" (#2752) - #3142

Merged
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target
Jul 29, 2026
Merged

Revert "Statically inject workflow world target" (#2752)#3142
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Reverts #2752 ("Statically inject workflow world target"). The world package is once again resolved at runtime from WORKFLOW_TARGET_WORLD instead of being aliased into host bundles at build time.

Why this is a surgical revert

141 commits have landed on top of #2752, several of which build on it, so git revert alone leaves the tree unbuildable. This branch removes the static-injection mechanism and restores the pre-#2752 runtime resolution while keeping everything that landed after it.

Removed

  • world-target modules in @workflow/core, @workflow/builders, and the Statically inject workflow world target #2752 additions to @workflow/utils
  • the bundler aliases / defines wired through next, nitro, nuxt, astro, sveltekit, rollup, and both nest builders
  • the @workflow/core/runtime/world-target export, its tsconfig/vitest path aliases
  • the pg-native stub alias and the extracted node-compat banner constants, which only existed because the world package was forced into the SSR bundle (the sveltekit typescript stub alias from fix(sveltekit): production server crash from bundled TypeScript compiler #2799 goes with them for the same reason)

Kept

Note on the o2flow incident that motivated #2752

The o2flow failure (Cannot find module as expression is too dynamic on sandboxDoneHook.resume()) was caused by the world registration being tree-shaken out of an isolated route bundle, which made getWorldLazy() fall through to an obfuscated import() that Turbopack stubs. That path is fixed by the world-init side-effect import on every host entrypoint plus the loud "world runtime was not initialized" error — both of which this revert keeps, along with #3001's regression test. o2flow runs on the Vercel world, which core imports statically, so it never reaches the dynamic resolution path this revert restores.

A follow-up PR stacked on this one proposes hardening the remaining dynamic path (custom world packages under Turbopack/webpack) without reintroducing build-time injection.

Verification

  • pnpm build, pnpm typecheck green
  • unit tests for the affected packages green

@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 27, 2026 22:19
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 164e7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 21 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/astroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/utilsPatch
@workflow/cliPatch
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-vercelPatch
workflowPatch
@workflow/vitePatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/errorsPatch
@workflow/world-postgresPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 164e7d3 · Wed, 29 Jul 2026 06:36:12 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep424 (-39%) 💚1299 🔴 (+26%) 🔻1315 🔴 (+24%) 🔻1415 🔴 (-15%)30
TTFSstream1251 (+30%) 🔻1316 🔴 (+29%) 🔻1330 🔴 (+28%) 🔻1428 🔴 (+23%) 🔻30
TTFShook + stream1482 (+26%) 🔻1532 🔴 (+18%) 🔻1597 🔴 (+17%) 🔻1953 🔴 (+27%) 🔻30
STSO1020 steps (1-20)166 (-8.8%)254 🔴 (-3.4%)290 🔴 (-11%)313 🔴 (-17%) 💚19
STSO1020 steps (101-120)186 (-2.6%)241 🔴 (-8.0%)270 🔴 (-18%) 💚378 🔴 (-64%) 💚19
STSO1020 steps (1001-1020)477 (+1.5%)583 🔴 (+4.1%)676 🔴 (-3.3%)717 🔴 (-6.6%)19
WO1020 steps380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)1
SLstream latency96 (+22%) 🔻142 🔴 (+12%)162 🔴 (+3.8%)181 🔴 (-18%) 💚30
SOstream overhead (text)95 (-13%)210 (±0%)350 (+10%)3151 🔴 (+399%) 🔻30
SOstream overhead (structured)98 (-2.0%)144 (-17%) 💚160 (-18%) 💚240 (-43%) 💚30
📜 Previous results (1)

003f800

Mon, 27 Jul 2026 22:42:23 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep238 (-68%) 💚1374 🔴 (+21%) 🔻1408 🔴 (+16%) 🔻1708 🔴 (+25%) 🔻30
TTFSstream242 (-23%) 💚1347 🔴 (+23%) 🔻1384 🔴 (+21%) 🔻1396 🔴 (+19%) 🔻30
TTFShook + stream400 (-68%) 💚1555 🔴 (+11%)1601 🔴 (+9.6%)1624 🔴 (-0.7%)30
STSO1020 steps (1-20)167 (-1.8%)273 🔴 (-9.6%)283 🔴 (-20%) 💚347 🔴 (-8.4%)19
STSO1020 steps (101-120)206 (+4.6%)302 🔴 (-11%)477 🔴 (+17%) 🔻2242 🔴 (+348%) 🔻19
STSO1020 steps (1001-1020)472 (-2.3%)551 🔴 (-4.0%)591 🔴 (-8.5%)1103 🔴 (+68%) 🔻19
WO1020 steps411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)1
SLstream latency101 (+8.6%)148 🔴 (-12%)179 🔴 (-24%) 💚250 🔴 (-1.2%)30
SOstream overhead (text)115 (-12%)185 (-36%) 💚209 (-41%) 💚401 (-4.8%)30
SOstream overhead (structured)124 (-8.1%)209 (-20%) 💚256 (-7.9%)430 (+4.1%)30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

VaguelySeriousand others added 2 commits July 28, 2026 23:01
This reverts the static world-target injection and restores runtime
resolution of the world package from `WORKFLOW_TARGET_WORLD`.
Because 141 commits have landed on top of #2752, this is a surgical
revert rather than a mechanical one. Removed: the `world-target` modules
in core/builders/utils, the bundler aliases and `define`s wired through
next/nitro/nuxt/astro/sveltekit/rollup/nest, the
`@workflow/core/runtime/world-target` export, and the
pg-native/node-compat-banner helpers that only existed to support the
statically bundled world.
Kept (later work that builds on #2752):
- `createWorldFromModule` / `WorldFactoryModule` in core (used by
world-testing and the nitro dev handler)
- `world-init` / `world-init-stub` / `getWorldLazy` and their
registration of `getWorld` on globalThis, plus the #3001 isolated
route bundle regression test
- #2804 (web), #2806 (cli dynamic community backends), #3112 (world
factory alias removal), #2988 (nest vercel builder), #2925/#2908
(nitro), #2799 (sveltekit typescript stub is dropped with the
injection it existed for), next basePath support, and the windows /
canary test timeout tuning
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#3144 landed after this branch was cut and adapted world selection to
#2752's build-time model: `isVercelDeploymentEnv` treats `VERCEL=1`
without a deployment ID as Vercel, because a `vercel build` on external
CI had to decide which world to bake into the bundles.
With selection back at runtime, `VERCEL_DEPLOYMENT_ID` is authoritative
and always present inside a deployment, so the broader signal only
changes the cases that are not deployments: a production server started
locally or in CI with an env file from `vercel env pull` would resolve to
the Vercel world and then fail for want of a deployment ID, where before
#2752 it used the local world. The same applies to the local world's
read-only-filesystem warning, which would fire in a writable one.
The user-facing text from #3144 explains all of this in terms of build
output and prescribes a rebuild, which no longer applies now that
`WORKFLOW_TARGET_WORLD` takes effect on the next start.
The rest of #3144 is independent of the injection mechanism and stays:
`UnwritableDataDirError`, the warning itself, and the Vercel world's
missing-deployment-ID message.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@VaguelySerious
VaguelySerious merged commit a09d001 into mainJul 29, 2026
175 of 177 checks passed
@VaguelySerious
VaguelySerious deleted the peter/revert-static-world-target branch July 29, 2026 15:55
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a09d001 (AI decision).

This commit reverts #2752 (static world-target injection), which only ever landed on mainorigin/stable has no packages/core/src/runtime/world-target.ts, no packages/builders/src/world-target.ts, no packages/core/vitest.config.ts world-target alias, and its packages/core/src/runtime/world.ts / packages/utils/src/world-target.ts already resolve the world at runtime from WORKFLOW_TARGET_WORLD, i.e. exactly the behavior this revert restores. Backporting a revert of something absent from stable would only churn unrelated files (nitro/next/sveltekit builder changes, workbench configs, v5 docs) with no corresponding defect fix.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a09d00135bd96f22bd1ae1dee6b5a6f797b7d804

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Revert "Statically inject workflow world target" (#2752) by VaguelySerious · Pull Request #3142 · vercel/workflow · GitHub
Skip to content

Revert "Statically inject workflow world target" (#2752) - #3142

Merged
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target
Jul 29, 2026
Merged

Revert "Statically inject workflow world target" (#2752)#3142
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Reverts #2752 ("Statically inject workflow world target"). The world package is once again resolved at runtime from WORKFLOW_TARGET_WORLD instead of being aliased into host bundles at build time.

Why this is a surgical revert

141 commits have landed on top of #2752, several of which build on it, so git revert alone leaves the tree unbuildable. This branch removes the static-injection mechanism and restores the pre-#2752 runtime resolution while keeping everything that landed after it.

Removed

  • world-target modules in @workflow/core, @workflow/builders, and the Statically inject workflow world target #2752 additions to @workflow/utils
  • the bundler aliases / defines wired through next, nitro, nuxt, astro, sveltekit, rollup, and both nest builders
  • the @workflow/core/runtime/world-target export, its tsconfig/vitest path aliases
  • the pg-native stub alias and the extracted node-compat banner constants, which only existed because the world package was forced into the SSR bundle (the sveltekit typescript stub alias from fix(sveltekit): production server crash from bundled TypeScript compiler #2799 goes with them for the same reason)

Kept

Note on the o2flow incident that motivated #2752

The o2flow failure (Cannot find module as expression is too dynamic on sandboxDoneHook.resume()) was caused by the world registration being tree-shaken out of an isolated route bundle, which made getWorldLazy() fall through to an obfuscated import() that Turbopack stubs. That path is fixed by the world-init side-effect import on every host entrypoint plus the loud "world runtime was not initialized" error — both of which this revert keeps, along with #3001's regression test. o2flow runs on the Vercel world, which core imports statically, so it never reaches the dynamic resolution path this revert restores.

A follow-up PR stacked on this one proposes hardening the remaining dynamic path (custom world packages under Turbopack/webpack) without reintroducing build-time injection.

Verification

  • pnpm build, pnpm typecheck green
  • unit tests for the affected packages green

@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 27, 2026 22:19
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 164e7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 21 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/astroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/utilsPatch
@workflow/cliPatch
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-vercelPatch
workflowPatch
@workflow/vitePatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/errorsPatch
@workflow/world-postgresPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 164e7d3 · Wed, 29 Jul 2026 06:36:12 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep424 (-39%) 💚1299 🔴 (+26%) 🔻1315 🔴 (+24%) 🔻1415 🔴 (-15%)30
TTFSstream1251 (+30%) 🔻1316 🔴 (+29%) 🔻1330 🔴 (+28%) 🔻1428 🔴 (+23%) 🔻30
TTFShook + stream1482 (+26%) 🔻1532 🔴 (+18%) 🔻1597 🔴 (+17%) 🔻1953 🔴 (+27%) 🔻30
STSO1020 steps (1-20)166 (-8.8%)254 🔴 (-3.4%)290 🔴 (-11%)313 🔴 (-17%) 💚19
STSO1020 steps (101-120)186 (-2.6%)241 🔴 (-8.0%)270 🔴 (-18%) 💚378 🔴 (-64%) 💚19
STSO1020 steps (1001-1020)477 (+1.5%)583 🔴 (+4.1%)676 🔴 (-3.3%)717 🔴 (-6.6%)19
WO1020 steps380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)1
SLstream latency96 (+22%) 🔻142 🔴 (+12%)162 🔴 (+3.8%)181 🔴 (-18%) 💚30
SOstream overhead (text)95 (-13%)210 (±0%)350 (+10%)3151 🔴 (+399%) 🔻30
SOstream overhead (structured)98 (-2.0%)144 (-17%) 💚160 (-18%) 💚240 (-43%) 💚30
📜 Previous results (1)

003f800

Mon, 27 Jul 2026 22:42:23 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep238 (-68%) 💚1374 🔴 (+21%) 🔻1408 🔴 (+16%) 🔻1708 🔴 (+25%) 🔻30
TTFSstream242 (-23%) 💚1347 🔴 (+23%) 🔻1384 🔴 (+21%) 🔻1396 🔴 (+19%) 🔻30
TTFShook + stream400 (-68%) 💚1555 🔴 (+11%)1601 🔴 (+9.6%)1624 🔴 (-0.7%)30
STSO1020 steps (1-20)167 (-1.8%)273 🔴 (-9.6%)283 🔴 (-20%) 💚347 🔴 (-8.4%)19
STSO1020 steps (101-120)206 (+4.6%)302 🔴 (-11%)477 🔴 (+17%) 🔻2242 🔴 (+348%) 🔻19
STSO1020 steps (1001-1020)472 (-2.3%)551 🔴 (-4.0%)591 🔴 (-8.5%)1103 🔴 (+68%) 🔻19
WO1020 steps411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)1
SLstream latency101 (+8.6%)148 🔴 (-12%)179 🔴 (-24%) 💚250 🔴 (-1.2%)30
SOstream overhead (text)115 (-12%)185 (-36%) 💚209 (-41%) 💚401 (-4.8%)30
SOstream overhead (structured)124 (-8.1%)209 (-20%) 💚256 (-7.9%)430 (+4.1%)30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

VaguelySeriousand others added 2 commits July 28, 2026 23:01
This reverts the static world-target injection and restores runtime
resolution of the world package from `WORKFLOW_TARGET_WORLD`.
Because 141 commits have landed on top of #2752, this is a surgical
revert rather than a mechanical one. Removed: the `world-target` modules
in core/builders/utils, the bundler aliases and `define`s wired through
next/nitro/nuxt/astro/sveltekit/rollup/nest, the
`@workflow/core/runtime/world-target` export, and the
pg-native/node-compat-banner helpers that only existed to support the
statically bundled world.
Kept (later work that builds on #2752):
- `createWorldFromModule` / `WorldFactoryModule` in core (used by
world-testing and the nitro dev handler)
- `world-init` / `world-init-stub` / `getWorldLazy` and their
registration of `getWorld` on globalThis, plus the #3001 isolated
route bundle regression test
- #2804 (web), #2806 (cli dynamic community backends), #3112 (world
factory alias removal), #2988 (nest vercel builder), #2925/#2908
(nitro), #2799 (sveltekit typescript stub is dropped with the
injection it existed for), next basePath support, and the windows /
canary test timeout tuning
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#3144 landed after this branch was cut and adapted world selection to
#2752's build-time model: `isVercelDeploymentEnv` treats `VERCEL=1`
without a deployment ID as Vercel, because a `vercel build` on external
CI had to decide which world to bake into the bundles.
With selection back at runtime, `VERCEL_DEPLOYMENT_ID` is authoritative
and always present inside a deployment, so the broader signal only
changes the cases that are not deployments: a production server started
locally or in CI with an env file from `vercel env pull` would resolve to
the Vercel world and then fail for want of a deployment ID, where before
#2752 it used the local world. The same applies to the local world's
read-only-filesystem warning, which would fire in a writable one.
The user-facing text from #3144 explains all of this in terms of build
output and prescribes a rebuild, which no longer applies now that
`WORKFLOW_TARGET_WORLD` takes effect on the next start.
The rest of #3144 is independent of the injection mechanism and stays:
`UnwritableDataDirError`, the warning itself, and the Vercel world's
missing-deployment-ID message.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@VaguelySerious
VaguelySerious merged commit a09d001 into mainJul 29, 2026
175 of 177 checks passed
@VaguelySerious
VaguelySerious deleted the peter/revert-static-world-target branch July 29, 2026 15:55
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a09d001 (AI decision).

This commit reverts #2752 (static world-target injection), which only ever landed on mainorigin/stable has no packages/core/src/runtime/world-target.ts, no packages/builders/src/world-target.ts, no packages/core/vitest.config.ts world-target alias, and its packages/core/src/runtime/world.ts / packages/utils/src/world-target.ts already resolve the world at runtime from WORKFLOW_TARGET_WORLD, i.e. exactly the behavior this revert restores. Backporting a revert of something absent from stable would only churn unrelated files (nitro/next/sveltekit builder changes, workbench configs, v5 docs) with no corresponding defect fix.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a09d00135bd96f22bd1ae1dee6b5a6f797b7d804

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Revert "Statically inject workflow world target" (#2752) by VaguelySerious · Pull Request #3142 · vercel/workflow · GitHub
Skip to content

Revert "Statically inject workflow world target" (#2752) - #3142

Merged
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target
Jul 29, 2026
Merged

Revert "Statically inject workflow world target" (#2752)#3142
VaguelySerious merged 2 commits into
mainfrom
peter/revert-static-world-target

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Reverts #2752 ("Statically inject workflow world target"). The world package is once again resolved at runtime from WORKFLOW_TARGET_WORLD instead of being aliased into host bundles at build time.

Why this is a surgical revert

141 commits have landed on top of #2752, several of which build on it, so git revert alone leaves the tree unbuildable. This branch removes the static-injection mechanism and restores the pre-#2752 runtime resolution while keeping everything that landed after it.

Removed

  • world-target modules in @workflow/core, @workflow/builders, and the Statically inject workflow world target #2752 additions to @workflow/utils
  • the bundler aliases / defines wired through next, nitro, nuxt, astro, sveltekit, rollup, and both nest builders
  • the @workflow/core/runtime/world-target export, its tsconfig/vitest path aliases
  • the pg-native stub alias and the extracted node-compat banner constants, which only existed because the world package was forced into the SSR bundle (the sveltekit typescript stub alias from fix(sveltekit): production server crash from bundled TypeScript compiler #2799 goes with them for the same reason)

Kept

Note on the o2flow incident that motivated #2752

The o2flow failure (Cannot find module as expression is too dynamic on sandboxDoneHook.resume()) was caused by the world registration being tree-shaken out of an isolated route bundle, which made getWorldLazy() fall through to an obfuscated import() that Turbopack stubs. That path is fixed by the world-init side-effect import on every host entrypoint plus the loud "world runtime was not initialized" error — both of which this revert keeps, along with #3001's regression test. o2flow runs on the Vercel world, which core imports statically, so it never reaches the dynamic resolution path this revert restores.

A follow-up PR stacked on this one proposes hardening the remaining dynamic path (custom world packages under Turbopack/webpack) without reintroducing build-time injection.

Verification

  • pnpm build, pnpm typecheck green
  • unit tests for the affected packages green

@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 27, 2026 22:19
@vercel

vercelBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 164e7d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 21 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/astroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/utilsPatch
@workflow/cliPatch
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-vercelPatch
workflowPatch
@workflow/vitePatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/errorsPatch
@workflow/world-postgresPatch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 164e7d3 · Wed, 29 Jul 2026 06:36:12 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep424 (-39%) 💚1299 🔴 (+26%) 🔻1315 🔴 (+24%) 🔻1415 🔴 (-15%)30
TTFSstream1251 (+30%) 🔻1316 🔴 (+29%) 🔻1330 🔴 (+28%) 🔻1428 🔴 (+23%) 🔻30
TTFShook + stream1482 (+26%) 🔻1532 🔴 (+18%) 🔻1597 🔴 (+17%) 🔻1953 🔴 (+27%) 🔻30
STSO1020 steps (1-20)166 (-8.8%)254 🔴 (-3.4%)290 🔴 (-11%)313 🔴 (-17%) 💚19
STSO1020 steps (101-120)186 (-2.6%)241 🔴 (-8.0%)270 🔴 (-18%) 💚378 🔴 (-64%) 💚19
STSO1020 steps (1001-1020)477 (+1.5%)583 🔴 (+4.1%)676 🔴 (-3.3%)717 🔴 (-6.6%)19
WO1020 steps380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)380460 (-6.0%)1
SLstream latency96 (+22%) 🔻142 🔴 (+12%)162 🔴 (+3.8%)181 🔴 (-18%) 💚30
SOstream overhead (text)95 (-13%)210 (±0%)350 (+10%)3151 🔴 (+399%) 🔻30
SOstream overhead (structured)98 (-2.0%)144 (-17%) 💚160 (-18%) 💚240 (-43%) 💚30
📜 Previous results (1)

003f800

Mon, 27 Jul 2026 22:42:23 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep238 (-68%) 💚1374 🔴 (+21%) 🔻1408 🔴 (+16%) 🔻1708 🔴 (+25%) 🔻30
TTFSstream242 (-23%) 💚1347 🔴 (+23%) 🔻1384 🔴 (+21%) 🔻1396 🔴 (+19%) 🔻30
TTFShook + stream400 (-68%) 💚1555 🔴 (+11%)1601 🔴 (+9.6%)1624 🔴 (-0.7%)30
STSO1020 steps (1-20)167 (-1.8%)273 🔴 (-9.6%)283 🔴 (-20%) 💚347 🔴 (-8.4%)19
STSO1020 steps (101-120)206 (+4.6%)302 🔴 (-11%)477 🔴 (+17%) 🔻2242 🔴 (+348%) 🔻19
STSO1020 steps (1001-1020)472 (-2.3%)551 🔴 (-4.0%)591 🔴 (-8.5%)1103 🔴 (+68%) 🔻19
WO1020 steps411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)411119 (-6.4%)1
SLstream latency101 (+8.6%)148 🔴 (-12%)179 🔴 (-24%) 💚250 🔴 (-1.2%)30
SOstream overhead (text)115 (-12%)185 (-36%) 💚209 (-41%) 💚401 (-4.8%)30
SOstream overhead (structured)124 (-8.1%)209 (-20%) 💚256 (-7.9%)430 (+4.1%)30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

VaguelySeriousand others added 2 commits July 28, 2026 23:01
This reverts the static world-target injection and restores runtime
resolution of the world package from `WORKFLOW_TARGET_WORLD`.
Because 141 commits have landed on top of #2752, this is a surgical
revert rather than a mechanical one. Removed: the `world-target` modules
in core/builders/utils, the bundler aliases and `define`s wired through
next/nitro/nuxt/astro/sveltekit/rollup/nest, the
`@workflow/core/runtime/world-target` export, and the
pg-native/node-compat-banner helpers that only existed to support the
statically bundled world.
Kept (later work that builds on #2752):
- `createWorldFromModule` / `WorldFactoryModule` in core (used by
world-testing and the nitro dev handler)
- `world-init` / `world-init-stub` / `getWorldLazy` and their
registration of `getWorld` on globalThis, plus the #3001 isolated
route bundle regression test
- #2804 (web), #2806 (cli dynamic community backends), #3112 (world
factory alias removal), #2988 (nest vercel builder), #2925/#2908
(nitro), #2799 (sveltekit typescript stub is dropped with the
injection it existed for), next basePath support, and the windows /
canary test timeout tuning
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#3144 landed after this branch was cut and adapted world selection to
#2752's build-time model: `isVercelDeploymentEnv` treats `VERCEL=1`
without a deployment ID as Vercel, because a `vercel build` on external
CI had to decide which world to bake into the bundles.
With selection back at runtime, `VERCEL_DEPLOYMENT_ID` is authoritative
and always present inside a deployment, so the broader signal only
changes the cases that are not deployments: a production server started
locally or in CI with an env file from `vercel env pull` would resolve to
the Vercel world and then fail for want of a deployment ID, where before
#2752 it used the local world. The same applies to the local world's
read-only-filesystem warning, which would fire in a writable one.
The user-facing text from #3144 explains all of this in terms of build
output and prescribes a rebuild, which no longer applies now that
`WORKFLOW_TARGET_WORLD` takes effect on the next start.
The rest of #3144 is independent of the injection mechanism and stays:
`UnwritableDataDirError`, the warning itself, and the Vercel world's
missing-deployment-ID message.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@VaguelySerious
VaguelySerious merged commit a09d001 into mainJul 29, 2026
175 of 177 checks passed
@VaguelySerious
VaguelySerious deleted the peter/revert-static-world-target branch July 29, 2026 15:55
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a09d001 (AI decision).

This commit reverts #2752 (static world-target injection), which only ever landed on mainorigin/stable has no packages/core/src/runtime/world-target.ts, no packages/builders/src/world-target.ts, no packages/core/vitest.config.ts world-target alias, and its packages/core/src/runtime/world.ts / packages/utils/src/world-target.ts already resolve the world at runtime from WORKFLOW_TARGET_WORLD, i.e. exactly the behavior this revert restores. Backporting a revert of something absent from stable would only churn unrelated files (nitro/next/sveltekit builder changes, workbench configs, v5 docs) with no corresponding defect fix.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a09d00135bd96f22bd1ae1dee6b5a6f797b7d804

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@pranaygp