') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(world-postgres): throw EntityConflictError on duplicate run_created by joeyhotz · Pull Request #2983 · vercel/workflow · GitHub
Skip to content

fix(world-postgres): throw EntityConflictError on duplicate run_created - #2983

Merged
VaguelySerious merged 1 commit into
vercel:mainfrom
joeyhotz:fix/postgres-run-created-conflict
Jul 17, 2026
Merged

fix(world-postgres): throw EntityConflictError on duplicate run_created#2983
VaguelySerious merged 1 commit into
vercel:mainfrom
joeyhotz:fix/postgres-run-created-conflict

Conversation

@joeyhotz

@joeyhotzjoeyhotz commented Jul 17, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

events.create with a run_created event inserts the run with onConflictDoNothing(), so when the run already exists the insert returns no row and create resolves with { run: undefined } instead of signalling the conflict. start() asserts on that field and throws Missing 'run' in server response for 'run_created' event — even though the run is healthy and already running.

This is the race start() documents: it fires events.create(run_created) and world.queue() in parallel, and when the worker dequeues first, run_started on the not-yet-existent run takes the resilient start path and creates the run itself. start() already treats EntityConflictError here as benign ("we can safely return", expected in <=1% of cases) — but the Postgres world never gives it one. world-local throws it for this same race and world-vercel surfaces a 409 that maps to it; world-postgres is the only world that resolves silently.

Throwing before the event insert also stops a duplicate run_created landing in the event log.

Observed on a self-hosted Postgres deployment on 3 of 261 runs (~1%, matching the estimate above) of our highest-frequency workflow over 7 days: each affected run has two run_created events and completed normally, while the trigger that started it returned a 500.

How did you test your changes?

Two cases added to packages/world-postgres/test/storage.test.ts (runs › create):

  • rejects a duplicate run_created with EntityConflictError — the direct conflict.
  • rejects run_created when resilient start already created the run — reproduces the production race (run_started on a non-existent run → resilient start → late run_created), asserting exactly one run_created remains in the event log.

Both resolve instead of rejecting against the current insert, and pass with the fix.

  • pnpm --filter @workflow/world-postgres exec vitest run test/storage.test.ts (119 tests)
  • pnpm --filter @workflow/world-postgres typecheck
  • biome check packages/world-postgres/src/storage.ts packages/world-postgres/test/storage.test.ts

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
  • 🔒 DCO sign-off passes (run git commit --signoff on your commits)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete

@joeyhotz
fix(world-postgres): throw EntityConflictError on duplicate run_created
9e0319e
`events.create` with a `run_created` event inserts the run with
`onConflictDoNothing()`, so a run that already exists resolves with
`{ run: undefined }` rather than signalling the conflict. `start()`
asserts on that field and throws "Missing 'run' in server response for
'run_created' event", even though the run is healthy and already
running.
This is the race `start()` documents: it fires `events.create` and
`world.queue()` in parallel, and when the worker dequeues first,
`run_started` on the not-yet-existent run takes the resilient start
path and creates the run itself. `start()` already treats
`EntityConflictError` as benign, but the Postgres world never gives it
one — world-local throws it, and world-vercel surfaces a 409 that maps
to it.
Throwing before the event insert also stops a duplicate `run_created`
landing in the event log.
Signed-off-by: Joey Hotz <joeyhotz1@gmail.com>
@joeyhotz
joeyhotz requested review from a team and ijjk as code ownersJuly 17, 2026 09:12
@changeset-bot

changeset-botBot commented Jul 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9e0319e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@workflow/world-postgresPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@joeyhotz is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@joeyhotz

joeyhotz commented Jul 17, 2026

Copy link
Copy Markdown
ContributorAuthor

Pinging @vercel/workflow

@VaguelySerious
VaguelySerious merged commit 3ddf42e into vercel:mainJul 17, 2026
66 of 102 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Jul 17, 2026
Closed
github-actionsBot added a commit that referenced this pull request Jul 17, 2026
@github-actions
fix(world-postgres): throw EntityConflictError on duplicate run_creat…
bef7a72
…ed (#2983)
Signed-off-by: Joey Hotz <joeyhotz1@gmail.com>
@github-actions

github-actionsBot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Backport PR opened against stable: #2992. Merge conflicts were resolved by AI — please review carefully. (backport job run)

This was referenced Jul 17, 2026
Merged
Closed
Open
Open
Closed
pranaygp added a commit that referenced this pull request Jul 21, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into docs/competition
f7a526c
* origin/main: (21 commits)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
fix(core): batch stream writes via writeMulti (#2995)
perf(core): cache port discovery in step invocations for self-hosted worlds (#2996)
feat(web-shared): Alt+hover span measurement in the new trace viewer (#2985)
fix(world-postgres): throw EntityConflictError on duplicate run_created (#2983)
[ci] Run benchmarks in-deployment to avoid proxy overhead (#2967)
Enable additional perf optimizations when correctness guarantees are met (#2970)
perf(core): prepare replay payloads concurrently (#2980)
Fix dotted tsconfig alias workflow discovery (#2963)
Adjust helper position on trace viewer (#2968)
...
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
pranaygp pushed a commit that referenced this pull request Aug 24, 2026
@github-actions
fix(world-postgres): throw EntityConflictError on duplicate run_creat…
2ced7cc
…ed (#2983) (#2992)
Signed-off-by: Joey Hotz <joeyhotz1@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 24, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joeyhotz@VaguelySerious