') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat(web-shared): Alt+hover span measurement in the new trace viewer by mitul-s · Pull Request #2985 · vercel/workflow · GitHub
Skip to content

feat(web-shared): Alt+hover span measurement in the new trace viewer - #2985

Merged
mitul-s merged 2 commits into
mainfrom
ms/alt-delta-2
Jul 17, 2026
Merged

feat(web-shared): Alt+hover span measurement in the new trace viewer#2985
mitul-s merged 2 commits into
mainfrom
ms/alt-delta-2

Conversation

@mitul-s

@mitul-smitul-s commented Jul 17, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Figma-style measurement in the new trace viewer: with a span selected, hold Alt and hover any other row to see the time delta between the two spans, drawn as a single measurement line.

CleanShot.2026-07-17.at.11.26.19.mp4

How it works

  • Selection + Alt + hover → one measurement between the selected (anchor) span and the hovered row's span: a stub + vertical guide off the anchor bar's measured edge, elbowing into a 1px line that ends at the hovered span's start, with a duration chip.
  • Delta rule: disjoint spans → gap (anchor end → later start, same semantic as the existing sibling gaps); overlapping/contained spans → start-to-start offset ("how far into the run did this step start").
  • No selection → the existing all-consecutive-gaps overlay, restyled to the same measurement-line design (the old I-beam + pill DeltaIndicator is deleted; both modes render through one DeltaMeasureLine component).
  • Edges clamped by the viewport keep the true duration in the label; if the hovered span is fully off-screen, the line stops short of the row's edge arrow.

Implementation

  • New pure computeSpanDelta() in utils.ts next to computeSpanGaps, unit-tested (disjoint both directions, overlap, containment, identical starts, zero-duration, clamping, off-screen).
  • Hovered row derived from clientY in the existing timeline mousemove handler (now a single TimelineHover {fraction, rowIndex} state) — no per-row listeners, TimelineBar memoization untouched.
  • Overlay renders in the existing absolute, pointer-events-none layer, so it works across virtualized rows.

Replaces #2976 (was opened from the wrong branch and included stale commits).

🤖 Generated with Claude Code

@mitul-s
mitul-s requested review from a team and ijjk as code ownersJuly 17, 2026 15:37
@changeset-bot

changeset-botBot commented Jul 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5e8c292

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 17, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJul 17, 2026 3:41pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJul 17, 2026 3:41pm
example-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-astro-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-express-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-fastify-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-hono-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-nitro-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-nuxt-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workbench-vite-workflowReadyReadyPreview, CommentJul 17, 2026 3:41pm
workflow-docsReadyReadyPreview, Comment, Open in v0Jul 17, 2026 3:41pm
workflow-swc-playgroundReadyReadyPreview, CommentJul 17, 2026 3:41pm
workflow-tarballsReadyReadyPreview, CommentJul 17, 2026 3:41pm
workflow-webReadyReadyPreview, CommentJul 17, 2026 3:41pm

@mitul-smitul-s mentioned this pull request Jul 17, 2026
Closed
@mitul-s
mitul-s merged commit 621b04e into mainJul 17, 2026
54 checks passed
@mitul-s
mitul-s deleted the ms/alt-delta-2 branch July 17, 2026 22:54
@github-actions

github-actionsBot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No backport to stable for 621b04e (AI decision).

All non-changeset changes are confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — stable only has the older trace-viewer directory). This is a feature for the main-only new trace viewer and has nothing to apply against on stable.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

621b04ed52b2ed9dcbff15d5ae46e530a249fe8c

This was referenced Jul 17, 2026
Closed
Closed
Open
This was referenced Jul 18, 2026
Open
Closed
pranaygp added a commit that referenced this pull request Jul 21, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into docs/competition
f7a526c
* origin/main: (21 commits)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
fix(core): batch stream writes via writeMulti (#2995)
perf(core): cache port discovery in step invocations for self-hosted worlds (#2996)
feat(web-shared): Alt+hover span measurement in the new trace viewer (#2985)
fix(world-postgres): throw EntityConflictError on duplicate run_created (#2983)
[ci] Run benchmarks in-deployment to avoid proxy overhead (#2967)
Enable additional perf optimizations when correctness guarantees are met (#2970)
perf(core): prepare replay payloads concurrently (#2980)
Fix dotted tsconfig alias workflow discovery (#2963)
Adjust helper position on trace viewer (#2968)
...
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3