Uh oh!
There was an error while loading. Please reload this page.
Remove step function identifier transform out of swc-plugin and into useStep() runtime function - #337
Merged
Conversation
🦋 Changeset detectedLatest commit: e8fe109 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MemberAuthor
Contributor
There was a problem hiding this comment.
🔧 Build Fix:
The useStep function calls are missing the second required argument after a recent API change. The function now requires both stepName and stepFunctionName parameters, but the builtin response handlers only provided the step name.
View Details
📝 Patch Details
diff --git a/packages/core/src/workflow.ts b/packages/core/src/workflow.ts
index f27f445..195b56e 100644
--- a/packages/core/src/workflow.ts+++ b/packages/core/src/workflow.ts@@ -339,9 +339,10 @@ export async function runWorkflow(
}
vmGlobalThis.Request = Request;
- const resJson = useStep<[any], any>('__builtin_response_json');- const resText = useStep<[any], string>('__builtin_response_text');+ const resJson = useStep<[any], any>('__builtin_response_json', '__builtin_response_json');+ const resText = useStep<[any], string>('__builtin_response_text', '__builtin_response_text');
const resArrayBuffer = useStep<[any], ArrayBuffer>(
+ '__builtin_response_array_buffer',
'__builtin_response_array_buffer'
);
class Response implements globalThis.Response {
Analysis
TypeScript compilation failure due to missing arguments in useStep calls
What fails: TypeScript compiler fails on packages/core/src/workflow.ts lines 342-344 due to missing second argument in useStep function calls
How to reproduce:
pnpm turbo run build --filter=@workflow/coreResult:
src/workflow.ts(342,21): error TS2554: Expected 2 arguments, but got 1.
src/workflow.ts(343,21): error TS2554: Expected 2 arguments, but got 1.
src/workflow.ts(344,28): error TS2554: Expected 2 arguments, but got 1.
TooTallNateforce-pushed
the
swc-plugin-remove-outer-step-fn-wrapper
branch
from
November 13, 2025 23:35
66efe7e to
a132ba4CompareTooTallNateforce-pushed
the
11-13-remove_step_function_identifier_transform_out_of_swc-plugin_and_into_usestep_runtime_function
branch
from
November 13, 2025 23:35
85998cc to
fcfc799CompareTooTallNate
requested review from
Schniz, VaguelySerious, adriandlam and ijjkNovember 14, 2025 00:21
ijjk
approved these changes
Nov 14, 2025
This was referenced Nov 14, 2025
VaguelySerious
approved these changes
Nov 14, 2025
Base automatically changed from
swc-plugin-remove-outer-step-fn-wrapper to
mainNovember 14, 2025 23:42
TooTallNateforce-pushed
the
11-13-remove_step_function_identifier_transform_out_of_swc-plugin_and_into_usestep_runtime_function
branch
from
November 15, 2025 06:12
6786aac to
e8fe109Compare
This was referenced Nov 15, 2025
Merged
Uh oh!
There was an error while loading. Please reload this page.
TooTallNate
deleted the
11-13-remove_step_function_identifier_transform_out_of_swc-plugin_and_into_usestep_runtime_function
branch
November 15, 2025 07:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved step function serialization by moving the function name symbol definition from the SWC plugin to the runtime.
What changed?
createUseStepinpackages/core/src/step.tsto accept astepFunctionNameparameter and apply both the name property and theWORKFLOW_STEP_FUNCTION_NAMEsymbol directly to the step function at creation timeWORKFLOW_STEP_FUNCTION_NAMEsymbol to step functionsHow to test?
WORKFLOW_STEP_FUNCTION_NAMEsymbol properly attachedWhy make this change?
This change improves the architecture by: