Skip to content

Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable
Closed

Backport #3879: fix(core): re-arm late-claimed hook deliveries#3905
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #3879 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in packages/core/src/private.ts, which exists verbatim on stable — including the unarmed buffered-hook barrier, the idle safety net, and the no-op arm() on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The added async-deserialization-ordering regression exercises the defect through the ordinary hook API with no retained-VM machinery, so stable is exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note that packages/core/src/retained-vm-loop.test.ts does not exist on stable (retained VM is main-only), so that test file should be dropped from the cherry-pick.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

* fix(core): re-arm late-claimed hook deliveries
* refactor(core): clarify delivery barrier lifecycle
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9145e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-astro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-express-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-hono-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-python-workflowErrorErrorv0Aug 31, 2026 7:17pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-vite-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-docsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-tarballsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-webReadyReadyPreview, v0Aug 31, 2026 7:17pm

@github-actions

github-actionsBot commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10990781177
✅ 💻 Local Development11980861284
✅ 📦 Local Production11980861284
✅ 🐘 Local Postgres11980861284
✅ 🪟 Windows10700107
❌ 🌍 Community Worlds821069197
✅ 📋 Other606036642
Total54881063815975

❌ Failed Tests

🌍 Community Worlds (106 failed)

redis (21 failed):

  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

turso (85 failed):

  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01M1CTTGZPYD8D1M1SGBYKYW4G
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01M1CTTHD8X5EW9HS4S9GEQ2MJ
  • promiseRaceWorkflow | wrun_01M1CTTPDYJRZ97TSZQRAZZ0VV
  • promiseAnyWorkflow | wrun_01M1CTTRYZ3ET8MCMNE56S5KQH
  • importedStepOnlyWorkflow | wrun_01M1CTTVSFNVD0333BX5GD6SHF
  • readableStreamWorkflow | wrun_01M1CTTVAHX0Q1VWPAAK0MHRPS
  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • webhookWorkflow | wrun_01M1CTVM3H0P6NBCF4RJ96CVRA
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • parallelSleepWorkflow | wrun_01M1CTX84ZAV42GM449B1FYT2R
  • sleepWinsRaceWorkflow | wrun_01M1CTXBRN6KR3AFASTKEJ67Q4
  • stepWinsRaceWorkflow | wrun_01M1CTXFEGKH62EB6F3BKTWJT2
  • nullByteWorkflow | wrun_01M1CTXJZQBKSTQE2AH6E22YSR
  • workflowAndStepMetadataWorkflow | wrun_01M1CTXNCK1NJG649SQSGWWK73
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M1CTZY2AFJCCJ6BV61WTHTQ9
  • writableForwardedFromWorkflowWorkflow | wrun_01M1CV0AW9T5022NVPTEYZXZ4F
  • writableForwardedFromStepWorkflow | wrun_01M1CV0E0AH938BDRG6XYM46B2
  • fetchWorkflow | wrun_01M1CV0GXS83RD8JVDW34WHPMH
  • promiseRaceStressTestWorkflow | wrun_01M1CV0MDJXNKHY0YWKJ0RH1VR
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M1CV4N8WHK9A39B0QXR4828N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M1CV5M2JQ5JP1V95Y0XF1C60
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M1CV5PP8TGMTASZN1FTDRPMP
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M1CV83N1CJ54BQ83R1EX6AFY
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M1CV8M08DXY5819TG7RMJAT2
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M1CV8Y7JMBH3MX1XT7HGDPVC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01M1CV94J8GXC2XNAK6NZAGM1T
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M1CV96WXD5N02VNRNVSE7PF4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M1CV9QSR19RPC42E3P96RBXN
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01M1CV9YQEY72NTQJGAR813AC5
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M1CVA4VJ1NV5S3Q4RGD1G161
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M1CVAAWENCXZDM9GEFEJQKD4
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M1CVAJ6E397ZJZQSXKNEAEYW
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M1CVASJ48AXFCJZGV5Z10EHS
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M1CVB141FVW96K1HKNAC1PDN
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M1CVBDFE0EFX5MS0K99WC42X
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M1CVBNZR5XDCFMVK00JZZ5MK
  • cancelRun - cancelling a running workflow | wrun_01M1CVBXAM3Q7CWZQYM7P5MM3V
  • cancelRun via CLI - cancelling a running workflow | wrun_01M1CVC2FGT0X78QG1WPA922DH
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M1CVCARYF6RMDW9ZB2AHWFPB
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M1CVCQ3510E0FBQQQXZB7QJ3
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M1CVD0N32V3V0AJTA45VJ4KW
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M1CVDBM40MXAM6SDPZBCW8V0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M1CVDJVYDQ2BKNNQQ48DNFKD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M1CVDNA6CJH9YV3V18A902Y8
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9908
✅ example9908
✅ express9908
✅ fastify9908
✅ hono9908
✅ nextjs-turbopack10403
✅ nextjs-webpack10403
✅ nitro9908
✅ nuxt9908
✅ sveltekit9908
✅ vite9908
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10700
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67210
✅ turso-dev403
❌ turso3850
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable10106
✅ e2e-local-dev-tanstack-start-stable10106
✅ e2e-local-postgres-nest-stable10106
✅ e2e-local-postgres-tanstack-start-stable10106
✅ e2e-local-prod-nest-stable10106
✅ e2e-local-prod-tanstack-start-stable10106

📋 View full workflow run

@pranaygp

Copy link
Copy Markdown
Contributor

closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Backport #3879: fix(core): re-arm late-claimed hook deliveries by github-actions[bot] · Pull Request #3905 · vercel/workflow · GitHub
Skip to content

Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable
Closed

Backport #3879: fix(core): re-arm late-claimed hook deliveries#3905
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #3879 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in packages/core/src/private.ts, which exists verbatim on stable — including the unarmed buffered-hook barrier, the idle safety net, and the no-op arm() on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The added async-deserialization-ordering regression exercises the defect through the ordinary hook API with no retained-VM machinery, so stable is exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note that packages/core/src/retained-vm-loop.test.ts does not exist on stable (retained VM is main-only), so that test file should be dropped from the cherry-pick.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

* fix(core): re-arm late-claimed hook deliveries
* refactor(core): clarify delivery barrier lifecycle
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9145e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-astro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-express-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-hono-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-python-workflowErrorErrorv0Aug 31, 2026 7:17pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-vite-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-docsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-tarballsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-webReadyReadyPreview, v0Aug 31, 2026 7:17pm

@github-actions

github-actionsBot commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10990781177
✅ 💻 Local Development11980861284
✅ 📦 Local Production11980861284
✅ 🐘 Local Postgres11980861284
✅ 🪟 Windows10700107
❌ 🌍 Community Worlds821069197
✅ 📋 Other606036642
Total54881063815975

❌ Failed Tests

🌍 Community Worlds (106 failed)

redis (21 failed):

  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

turso (85 failed):

  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01M1CTTGZPYD8D1M1SGBYKYW4G
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01M1CTTHD8X5EW9HS4S9GEQ2MJ
  • promiseRaceWorkflow | wrun_01M1CTTPDYJRZ97TSZQRAZZ0VV
  • promiseAnyWorkflow | wrun_01M1CTTRYZ3ET8MCMNE56S5KQH
  • importedStepOnlyWorkflow | wrun_01M1CTTVSFNVD0333BX5GD6SHF
  • readableStreamWorkflow | wrun_01M1CTTVAHX0Q1VWPAAK0MHRPS
  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • webhookWorkflow | wrun_01M1CTVM3H0P6NBCF4RJ96CVRA
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • parallelSleepWorkflow | wrun_01M1CTX84ZAV42GM449B1FYT2R
  • sleepWinsRaceWorkflow | wrun_01M1CTXBRN6KR3AFASTKEJ67Q4
  • stepWinsRaceWorkflow | wrun_01M1CTXFEGKH62EB6F3BKTWJT2
  • nullByteWorkflow | wrun_01M1CTXJZQBKSTQE2AH6E22YSR
  • workflowAndStepMetadataWorkflow | wrun_01M1CTXNCK1NJG649SQSGWWK73
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M1CTZY2AFJCCJ6BV61WTHTQ9
  • writableForwardedFromWorkflowWorkflow | wrun_01M1CV0AW9T5022NVPTEYZXZ4F
  • writableForwardedFromStepWorkflow | wrun_01M1CV0E0AH938BDRG6XYM46B2
  • fetchWorkflow | wrun_01M1CV0GXS83RD8JVDW34WHPMH
  • promiseRaceStressTestWorkflow | wrun_01M1CV0MDJXNKHY0YWKJ0RH1VR
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M1CV4N8WHK9A39B0QXR4828N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M1CV5M2JQ5JP1V95Y0XF1C60
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M1CV5PP8TGMTASZN1FTDRPMP
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M1CV83N1CJ54BQ83R1EX6AFY
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M1CV8M08DXY5819TG7RMJAT2
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M1CV8Y7JMBH3MX1XT7HGDPVC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01M1CV94J8GXC2XNAK6NZAGM1T
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M1CV96WXD5N02VNRNVSE7PF4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M1CV9QSR19RPC42E3P96RBXN
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01M1CV9YQEY72NTQJGAR813AC5
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M1CVA4VJ1NV5S3Q4RGD1G161
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M1CVAAWENCXZDM9GEFEJQKD4
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M1CVAJ6E397ZJZQSXKNEAEYW
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M1CVASJ48AXFCJZGV5Z10EHS
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M1CVB141FVW96K1HKNAC1PDN
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M1CVBDFE0EFX5MS0K99WC42X
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M1CVBNZR5XDCFMVK00JZZ5MK
  • cancelRun - cancelling a running workflow | wrun_01M1CVBXAM3Q7CWZQYM7P5MM3V
  • cancelRun via CLI - cancelling a running workflow | wrun_01M1CVC2FGT0X78QG1WPA922DH
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M1CVCARYF6RMDW9ZB2AHWFPB
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M1CVCQ3510E0FBQQQXZB7QJ3
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M1CVD0N32V3V0AJTA45VJ4KW
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M1CVDBM40MXAM6SDPZBCW8V0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M1CVDJVYDQ2BKNNQQ48DNFKD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M1CVDNA6CJH9YV3V18A902Y8
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9908
✅ example9908
✅ express9908
✅ fastify9908
✅ hono9908
✅ nextjs-turbopack10403
✅ nextjs-webpack10403
✅ nitro9908
✅ nuxt9908
✅ sveltekit9908
✅ vite9908
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10700
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67210
✅ turso-dev403
❌ turso3850
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable10106
✅ e2e-local-dev-tanstack-start-stable10106
✅ e2e-local-postgres-nest-stable10106
✅ e2e-local-postgres-tanstack-start-stable10106
✅ e2e-local-prod-nest-stable10106
✅ e2e-local-prod-tanstack-start-stable10106

📋 View full workflow run

@pranaygp

Copy link
Copy Markdown
Contributor

closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #3879: fix(core): re-arm late-claimed hook deliveries by github-actions[bot] · Pull Request #3905 · vercel/workflow · GitHub
Skip to content

Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable
Closed

Backport #3879: fix(core): re-arm late-claimed hook deliveries#3905
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #3879 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in packages/core/src/private.ts, which exists verbatim on stable — including the unarmed buffered-hook barrier, the idle safety net, and the no-op arm() on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The added async-deserialization-ordering regression exercises the defect through the ordinary hook API with no retained-VM machinery, so stable is exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note that packages/core/src/retained-vm-loop.test.ts does not exist on stable (retained VM is main-only), so that test file should be dropped from the cherry-pick.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

* fix(core): re-arm late-claimed hook deliveries
* refactor(core): clarify delivery barrier lifecycle
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9145e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-astro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-express-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-hono-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-python-workflowErrorErrorv0Aug 31, 2026 7:17pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-vite-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-docsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-tarballsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-webReadyReadyPreview, v0Aug 31, 2026 7:17pm

@github-actions

github-actionsBot commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10990781177
✅ 💻 Local Development11980861284
✅ 📦 Local Production11980861284
✅ 🐘 Local Postgres11980861284
✅ 🪟 Windows10700107
❌ 🌍 Community Worlds821069197
✅ 📋 Other606036642
Total54881063815975

❌ Failed Tests

🌍 Community Worlds (106 failed)

redis (21 failed):

  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

turso (85 failed):

  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01M1CTTGZPYD8D1M1SGBYKYW4G
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01M1CTTHD8X5EW9HS4S9GEQ2MJ
  • promiseRaceWorkflow | wrun_01M1CTTPDYJRZ97TSZQRAZZ0VV
  • promiseAnyWorkflow | wrun_01M1CTTRYZ3ET8MCMNE56S5KQH
  • importedStepOnlyWorkflow | wrun_01M1CTTVSFNVD0333BX5GD6SHF
  • readableStreamWorkflow | wrun_01M1CTTVAHX0Q1VWPAAK0MHRPS
  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • webhookWorkflow | wrun_01M1CTVM3H0P6NBCF4RJ96CVRA
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • parallelSleepWorkflow | wrun_01M1CTX84ZAV42GM449B1FYT2R
  • sleepWinsRaceWorkflow | wrun_01M1CTXBRN6KR3AFASTKEJ67Q4
  • stepWinsRaceWorkflow | wrun_01M1CTXFEGKH62EB6F3BKTWJT2
  • nullByteWorkflow | wrun_01M1CTXJZQBKSTQE2AH6E22YSR
  • workflowAndStepMetadataWorkflow | wrun_01M1CTXNCK1NJG649SQSGWWK73
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M1CTZY2AFJCCJ6BV61WTHTQ9
  • writableForwardedFromWorkflowWorkflow | wrun_01M1CV0AW9T5022NVPTEYZXZ4F
  • writableForwardedFromStepWorkflow | wrun_01M1CV0E0AH938BDRG6XYM46B2
  • fetchWorkflow | wrun_01M1CV0GXS83RD8JVDW34WHPMH
  • promiseRaceStressTestWorkflow | wrun_01M1CV0MDJXNKHY0YWKJ0RH1VR
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M1CV4N8WHK9A39B0QXR4828N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M1CV5M2JQ5JP1V95Y0XF1C60
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M1CV5PP8TGMTASZN1FTDRPMP
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M1CV83N1CJ54BQ83R1EX6AFY
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M1CV8M08DXY5819TG7RMJAT2
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M1CV8Y7JMBH3MX1XT7HGDPVC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01M1CV94J8GXC2XNAK6NZAGM1T
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M1CV96WXD5N02VNRNVSE7PF4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M1CV9QSR19RPC42E3P96RBXN
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01M1CV9YQEY72NTQJGAR813AC5
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M1CVA4VJ1NV5S3Q4RGD1G161
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M1CVAAWENCXZDM9GEFEJQKD4
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M1CVAJ6E397ZJZQSXKNEAEYW
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M1CVASJ48AXFCJZGV5Z10EHS
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M1CVB141FVW96K1HKNAC1PDN
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M1CVBDFE0EFX5MS0K99WC42X
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M1CVBNZR5XDCFMVK00JZZ5MK
  • cancelRun - cancelling a running workflow | wrun_01M1CVBXAM3Q7CWZQYM7P5MM3V
  • cancelRun via CLI - cancelling a running workflow | wrun_01M1CVC2FGT0X78QG1WPA922DH
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M1CVCARYF6RMDW9ZB2AHWFPB
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M1CVCQ3510E0FBQQQXZB7QJ3
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M1CVD0N32V3V0AJTA45VJ4KW
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M1CVDBM40MXAM6SDPZBCW8V0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M1CVDJVYDQ2BKNNQQ48DNFKD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M1CVDNA6CJH9YV3V18A902Y8
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9908
✅ example9908
✅ express9908
✅ fastify9908
✅ hono9908
✅ nextjs-turbopack10403
✅ nextjs-webpack10403
✅ nitro9908
✅ nuxt9908
✅ sveltekit9908
✅ vite9908
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10700
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67210
✅ turso-dev403
❌ turso3850
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable10106
✅ e2e-local-dev-tanstack-start-stable10106
✅ e2e-local-postgres-nest-stable10106
✅ e2e-local-postgres-tanstack-start-stable10106
✅ e2e-local-prod-nest-stable10106
✅ e2e-local-prod-tanstack-start-stable10106

📋 View full workflow run

@pranaygp

Copy link
Copy Markdown
Contributor

closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #3879: fix(core): re-arm late-claimed hook deliveries by github-actions[bot] · Pull Request #3905 · vercel/workflow · GitHub
Skip to content

Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable
Closed

Backport #3879: fix(core): re-arm late-claimed hook deliveries#3905
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #3879 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in packages/core/src/private.ts, which exists verbatim on stable — including the unarmed buffered-hook barrier, the idle safety net, and the no-op arm() on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The added async-deserialization-ordering regression exercises the defect through the ordinary hook API with no retained-VM machinery, so stable is exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note that packages/core/src/retained-vm-loop.test.ts does not exist on stable (retained VM is main-only), so that test file should be dropped from the cherry-pick.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

* fix(core): re-arm late-claimed hook deliveries
* refactor(core): clarify delivery barrier lifecycle
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9145e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-astro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-express-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-hono-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-python-workflowErrorErrorv0Aug 31, 2026 7:17pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-vite-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-docsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-tarballsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-webReadyReadyPreview, v0Aug 31, 2026 7:17pm

@github-actions

github-actionsBot commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10990781177
✅ 💻 Local Development11980861284
✅ 📦 Local Production11980861284
✅ 🐘 Local Postgres11980861284
✅ 🪟 Windows10700107
❌ 🌍 Community Worlds821069197
✅ 📋 Other606036642
Total54881063815975

❌ Failed Tests

🌍 Community Worlds (106 failed)

redis (21 failed):

  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

turso (85 failed):

  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01M1CTTGZPYD8D1M1SGBYKYW4G
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01M1CTTHD8X5EW9HS4S9GEQ2MJ
  • promiseRaceWorkflow | wrun_01M1CTTPDYJRZ97TSZQRAZZ0VV
  • promiseAnyWorkflow | wrun_01M1CTTRYZ3ET8MCMNE56S5KQH
  • importedStepOnlyWorkflow | wrun_01M1CTTVSFNVD0333BX5GD6SHF
  • readableStreamWorkflow | wrun_01M1CTTVAHX0Q1VWPAAK0MHRPS
  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • webhookWorkflow | wrun_01M1CTVM3H0P6NBCF4RJ96CVRA
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • parallelSleepWorkflow | wrun_01M1CTX84ZAV42GM449B1FYT2R
  • sleepWinsRaceWorkflow | wrun_01M1CTXBRN6KR3AFASTKEJ67Q4
  • stepWinsRaceWorkflow | wrun_01M1CTXFEGKH62EB6F3BKTWJT2
  • nullByteWorkflow | wrun_01M1CTXJZQBKSTQE2AH6E22YSR
  • workflowAndStepMetadataWorkflow | wrun_01M1CTXNCK1NJG649SQSGWWK73
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M1CTZY2AFJCCJ6BV61WTHTQ9
  • writableForwardedFromWorkflowWorkflow | wrun_01M1CV0AW9T5022NVPTEYZXZ4F
  • writableForwardedFromStepWorkflow | wrun_01M1CV0E0AH938BDRG6XYM46B2
  • fetchWorkflow | wrun_01M1CV0GXS83RD8JVDW34WHPMH
  • promiseRaceStressTestWorkflow | wrun_01M1CV0MDJXNKHY0YWKJ0RH1VR
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M1CV4N8WHK9A39B0QXR4828N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M1CV5M2JQ5JP1V95Y0XF1C60
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M1CV5PP8TGMTASZN1FTDRPMP
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M1CV83N1CJ54BQ83R1EX6AFY
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M1CV8M08DXY5819TG7RMJAT2
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M1CV8Y7JMBH3MX1XT7HGDPVC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01M1CV94J8GXC2XNAK6NZAGM1T
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M1CV96WXD5N02VNRNVSE7PF4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M1CV9QSR19RPC42E3P96RBXN
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01M1CV9YQEY72NTQJGAR813AC5
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M1CVA4VJ1NV5S3Q4RGD1G161
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M1CVAAWENCXZDM9GEFEJQKD4
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M1CVAJ6E397ZJZQSXKNEAEYW
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M1CVASJ48AXFCJZGV5Z10EHS
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M1CVB141FVW96K1HKNAC1PDN
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M1CVBDFE0EFX5MS0K99WC42X
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M1CVBNZR5XDCFMVK00JZZ5MK
  • cancelRun - cancelling a running workflow | wrun_01M1CVBXAM3Q7CWZQYM7P5MM3V
  • cancelRun via CLI - cancelling a running workflow | wrun_01M1CVC2FGT0X78QG1WPA922DH
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M1CVCARYF6RMDW9ZB2AHWFPB
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M1CVCQ3510E0FBQQQXZB7QJ3
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M1CVD0N32V3V0AJTA45VJ4KW
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M1CVDBM40MXAM6SDPZBCW8V0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M1CVDJVYDQ2BKNNQQ48DNFKD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M1CVDNA6CJH9YV3V18A902Y8
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9908
✅ example9908
✅ express9908
✅ fastify9908
✅ hono9908
✅ nextjs-turbopack10403
✅ nextjs-webpack10403
✅ nitro9908
✅ nuxt9908
✅ sveltekit9908
✅ vite9908
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10700
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67210
✅ turso-dev403
❌ turso3850
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable10106
✅ e2e-local-dev-tanstack-start-stable10106
✅ e2e-local-postgres-nest-stable10106
✅ e2e-local-postgres-tanstack-start-stable10106
✅ e2e-local-prod-nest-stable10106
✅ e2e-local-prod-tanstack-start-stable10106

📋 View full workflow run

@pranaygp

Copy link
Copy Markdown
Contributor

closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Backport #3879: fix(core): re-arm late-claimed hook deliveries by github-actions[bot] · Pull Request #3905 · vercel/workflow · GitHub
Skip to content

Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable
Closed

Backport #3879: fix(core): re-arm late-claimed hook deliveries#3905
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #3879 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in packages/core/src/private.ts, which exists verbatim on stable — including the unarmed buffered-hook barrier, the idle safety net, and the no-op arm() on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The added async-deserialization-ordering regression exercises the defect through the ordinary hook API with no retained-VM machinery, so stable is exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note that packages/core/src/retained-vm-loop.test.ts does not exist on stable (retained VM is main-only), so that test file should be dropped from the cherry-pick.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

* fix(core): re-arm late-claimed hook deliveries
* refactor(core): clarify delivery barrier lifecycle
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9145e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-astro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-express-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-hono-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-python-workflowErrorErrorv0Aug 31, 2026 7:17pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-vite-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-docsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-tarballsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-webReadyReadyPreview, v0Aug 31, 2026 7:17pm

@github-actions

github-actionsBot commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10990781177
✅ 💻 Local Development11980861284
✅ 📦 Local Production11980861284
✅ 🐘 Local Postgres11980861284
✅ 🪟 Windows10700107
❌ 🌍 Community Worlds821069197
✅ 📋 Other606036642
Total54881063815975

❌ Failed Tests

🌍 Community Worlds (106 failed)

redis (21 failed):

  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

turso (85 failed):

  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01M1CTTGZPYD8D1M1SGBYKYW4G
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01M1CTTHD8X5EW9HS4S9GEQ2MJ
  • promiseRaceWorkflow | wrun_01M1CTTPDYJRZ97TSZQRAZZ0VV
  • promiseAnyWorkflow | wrun_01M1CTTRYZ3ET8MCMNE56S5KQH
  • importedStepOnlyWorkflow | wrun_01M1CTTVSFNVD0333BX5GD6SHF
  • readableStreamWorkflow | wrun_01M1CTTVAHX0Q1VWPAAK0MHRPS
  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • webhookWorkflow | wrun_01M1CTVM3H0P6NBCF4RJ96CVRA
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • parallelSleepWorkflow | wrun_01M1CTX84ZAV42GM449B1FYT2R
  • sleepWinsRaceWorkflow | wrun_01M1CTXBRN6KR3AFASTKEJ67Q4
  • stepWinsRaceWorkflow | wrun_01M1CTXFEGKH62EB6F3BKTWJT2
  • nullByteWorkflow | wrun_01M1CTXJZQBKSTQE2AH6E22YSR
  • workflowAndStepMetadataWorkflow | wrun_01M1CTXNCK1NJG649SQSGWWK73
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M1CTZY2AFJCCJ6BV61WTHTQ9
  • writableForwardedFromWorkflowWorkflow | wrun_01M1CV0AW9T5022NVPTEYZXZ4F
  • writableForwardedFromStepWorkflow | wrun_01M1CV0E0AH938BDRG6XYM46B2
  • fetchWorkflow | wrun_01M1CV0GXS83RD8JVDW34WHPMH
  • promiseRaceStressTestWorkflow | wrun_01M1CV0MDJXNKHY0YWKJ0RH1VR
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M1CV4N8WHK9A39B0QXR4828N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M1CV5M2JQ5JP1V95Y0XF1C60
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M1CV5PP8TGMTASZN1FTDRPMP
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M1CV83N1CJ54BQ83R1EX6AFY
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M1CV8M08DXY5819TG7RMJAT2
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M1CV8Y7JMBH3MX1XT7HGDPVC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01M1CV94J8GXC2XNAK6NZAGM1T
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M1CV96WXD5N02VNRNVSE7PF4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M1CV9QSR19RPC42E3P96RBXN
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01M1CV9YQEY72NTQJGAR813AC5
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M1CVA4VJ1NV5S3Q4RGD1G161
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M1CVAAWENCXZDM9GEFEJQKD4
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M1CVAJ6E397ZJZQSXKNEAEYW
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M1CVASJ48AXFCJZGV5Z10EHS
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M1CVB141FVW96K1HKNAC1PDN
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M1CVBDFE0EFX5MS0K99WC42X
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M1CVBNZR5XDCFMVK00JZZ5MK
  • cancelRun - cancelling a running workflow | wrun_01M1CVBXAM3Q7CWZQYM7P5MM3V
  • cancelRun via CLI - cancelling a running workflow | wrun_01M1CVC2FGT0X78QG1WPA922DH
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M1CVCARYF6RMDW9ZB2AHWFPB
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M1CVCQ3510E0FBQQQXZB7QJ3
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M1CVD0N32V3V0AJTA45VJ4KW
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M1CVDBM40MXAM6SDPZBCW8V0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M1CVDJVYDQ2BKNNQQ48DNFKD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M1CVDNA6CJH9YV3V18A902Y8
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9908
✅ example9908
✅ express9908
✅ fastify9908
✅ hono9908
✅ nextjs-turbopack10403
✅ nextjs-webpack10403
✅ nitro9908
✅ nuxt9908
✅ sveltekit9908
✅ vite9908
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10700
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67210
✅ turso-dev403
❌ turso3850
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable10106
✅ e2e-local-dev-tanstack-start-stable10106
✅ e2e-local-postgres-nest-stable10106
✅ e2e-local-postgres-tanstack-start-stable10106
✅ e2e-local-prod-nest-stable10106
✅ e2e-local-prod-tanstack-start-stable10106

📋 View full workflow run

@pranaygp

Copy link
Copy Markdown
Contributor

closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #3879: fix(core): re-arm late-claimed hook deliveries by github-actions[bot] · Pull Request #3905 · vercel/workflow · GitHub
Skip to content

Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable
Closed

Backport #3879: fix(core): re-arm late-claimed hook deliveries#3905
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #3879 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in packages/core/src/private.ts, which exists verbatim on stable — including the unarmed buffered-hook barrier, the idle safety net, and the no-op arm() on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The added async-deserialization-ordering regression exercises the defect through the ordinary hook API with no retained-VM machinery, so stable is exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note that packages/core/src/retained-vm-loop.test.ts does not exist on stable (retained VM is main-only), so that test file should be dropped from the cherry-pick.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

* fix(core): re-arm late-claimed hook deliveries
* refactor(core): clarify delivery barrier lifecycle
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9145e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-astro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-express-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-hono-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-python-workflowErrorErrorv0Aug 31, 2026 7:17pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-vite-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-docsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-tarballsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-webReadyReadyPreview, v0Aug 31, 2026 7:17pm

@github-actions

github-actionsBot commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10990781177
✅ 💻 Local Development11980861284
✅ 📦 Local Production11980861284
✅ 🐘 Local Postgres11980861284
✅ 🪟 Windows10700107
❌ 🌍 Community Worlds821069197
✅ 📋 Other606036642
Total54881063815975

❌ Failed Tests

🌍 Community Worlds (106 failed)

redis (21 failed):

  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

turso (85 failed):

  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01M1CTTGZPYD8D1M1SGBYKYW4G
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01M1CTTHD8X5EW9HS4S9GEQ2MJ
  • promiseRaceWorkflow | wrun_01M1CTTPDYJRZ97TSZQRAZZ0VV
  • promiseAnyWorkflow | wrun_01M1CTTRYZ3ET8MCMNE56S5KQH
  • importedStepOnlyWorkflow | wrun_01M1CTTVSFNVD0333BX5GD6SHF
  • readableStreamWorkflow | wrun_01M1CTTVAHX0Q1VWPAAK0MHRPS
  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • webhookWorkflow | wrun_01M1CTVM3H0P6NBCF4RJ96CVRA
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • parallelSleepWorkflow | wrun_01M1CTX84ZAV42GM449B1FYT2R
  • sleepWinsRaceWorkflow | wrun_01M1CTXBRN6KR3AFASTKEJ67Q4
  • stepWinsRaceWorkflow | wrun_01M1CTXFEGKH62EB6F3BKTWJT2
  • nullByteWorkflow | wrun_01M1CTXJZQBKSTQE2AH6E22YSR
  • workflowAndStepMetadataWorkflow | wrun_01M1CTXNCK1NJG649SQSGWWK73
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M1CTZY2AFJCCJ6BV61WTHTQ9
  • writableForwardedFromWorkflowWorkflow | wrun_01M1CV0AW9T5022NVPTEYZXZ4F
  • writableForwardedFromStepWorkflow | wrun_01M1CV0E0AH938BDRG6XYM46B2
  • fetchWorkflow | wrun_01M1CV0GXS83RD8JVDW34WHPMH
  • promiseRaceStressTestWorkflow | wrun_01M1CV0MDJXNKHY0YWKJ0RH1VR
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M1CV4N8WHK9A39B0QXR4828N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M1CV5M2JQ5JP1V95Y0XF1C60
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M1CV5PP8TGMTASZN1FTDRPMP
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M1CV83N1CJ54BQ83R1EX6AFY
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M1CV8M08DXY5819TG7RMJAT2
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M1CV8Y7JMBH3MX1XT7HGDPVC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01M1CV94J8GXC2XNAK6NZAGM1T
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M1CV96WXD5N02VNRNVSE7PF4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M1CV9QSR19RPC42E3P96RBXN
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01M1CV9YQEY72NTQJGAR813AC5
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M1CVA4VJ1NV5S3Q4RGD1G161
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M1CVAAWENCXZDM9GEFEJQKD4
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M1CVAJ6E397ZJZQSXKNEAEYW
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M1CVASJ48AXFCJZGV5Z10EHS
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M1CVB141FVW96K1HKNAC1PDN
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M1CVBDFE0EFX5MS0K99WC42X
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M1CVBNZR5XDCFMVK00JZZ5MK
  • cancelRun - cancelling a running workflow | wrun_01M1CVBXAM3Q7CWZQYM7P5MM3V
  • cancelRun via CLI - cancelling a running workflow | wrun_01M1CVC2FGT0X78QG1WPA922DH
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M1CVCARYF6RMDW9ZB2AHWFPB
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M1CVCQ3510E0FBQQQXZB7QJ3
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M1CVD0N32V3V0AJTA45VJ4KW
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M1CVDBM40MXAM6SDPZBCW8V0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M1CVDJVYDQ2BKNNQQ48DNFKD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M1CVDNA6CJH9YV3V18A902Y8
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9908
✅ example9908
✅ express9908
✅ fastify9908
✅ hono9908
✅ nextjs-turbopack10403
✅ nextjs-webpack10403
✅ nitro9908
✅ nuxt9908
✅ sveltekit9908
✅ vite9908
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10700
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67210
✅ turso-dev403
❌ turso3850
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable10106
✅ e2e-local-dev-tanstack-start-stable10106
✅ e2e-local-postgres-nest-stable10106
✅ e2e-local-postgres-tanstack-start-stable10106
✅ e2e-local-prod-nest-stable10106
✅ e2e-local-prod-tanstack-start-stable10106

📋 View full workflow run

@pranaygp

Copy link
Copy Markdown
Contributor

closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #3879: fix(core): re-arm late-claimed hook deliveries by github-actions[bot] · Pull Request #3905 · vercel/workflow · GitHub
Skip to content

Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable
Closed

Backport #3879: fix(core): re-arm late-claimed hook deliveries#3905
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #3879 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in packages/core/src/private.ts, which exists verbatim on stable — including the unarmed buffered-hook barrier, the idle safety net, and the no-op arm() on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The added async-deserialization-ordering regression exercises the defect through the ordinary hook API with no retained-VM machinery, so stable is exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note that packages/core/src/retained-vm-loop.test.ts does not exist on stable (retained VM is main-only), so that test file should be dropped from the cherry-pick.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

* fix(core): re-arm late-claimed hook deliveries
* refactor(core): clarify delivery barrier lifecycle
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9145e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-astro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-express-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-hono-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-python-workflowErrorErrorv0Aug 31, 2026 7:17pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-vite-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-docsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-tarballsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-webReadyReadyPreview, v0Aug 31, 2026 7:17pm

@github-actions

github-actionsBot commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10990781177
✅ 💻 Local Development11980861284
✅ 📦 Local Production11980861284
✅ 🐘 Local Postgres11980861284
✅ 🪟 Windows10700107
❌ 🌍 Community Worlds821069197
✅ 📋 Other606036642
Total54881063815975

❌ Failed Tests

🌍 Community Worlds (106 failed)

redis (21 failed):

  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

turso (85 failed):

  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01M1CTTGZPYD8D1M1SGBYKYW4G
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01M1CTTHD8X5EW9HS4S9GEQ2MJ
  • promiseRaceWorkflow | wrun_01M1CTTPDYJRZ97TSZQRAZZ0VV
  • promiseAnyWorkflow | wrun_01M1CTTRYZ3ET8MCMNE56S5KQH
  • importedStepOnlyWorkflow | wrun_01M1CTTVSFNVD0333BX5GD6SHF
  • readableStreamWorkflow | wrun_01M1CTTVAHX0Q1VWPAAK0MHRPS
  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • webhookWorkflow | wrun_01M1CTVM3H0P6NBCF4RJ96CVRA
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • parallelSleepWorkflow | wrun_01M1CTX84ZAV42GM449B1FYT2R
  • sleepWinsRaceWorkflow | wrun_01M1CTXBRN6KR3AFASTKEJ67Q4
  • stepWinsRaceWorkflow | wrun_01M1CTXFEGKH62EB6F3BKTWJT2
  • nullByteWorkflow | wrun_01M1CTXJZQBKSTQE2AH6E22YSR
  • workflowAndStepMetadataWorkflow | wrun_01M1CTXNCK1NJG649SQSGWWK73
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M1CTZY2AFJCCJ6BV61WTHTQ9
  • writableForwardedFromWorkflowWorkflow | wrun_01M1CV0AW9T5022NVPTEYZXZ4F
  • writableForwardedFromStepWorkflow | wrun_01M1CV0E0AH938BDRG6XYM46B2
  • fetchWorkflow | wrun_01M1CV0GXS83RD8JVDW34WHPMH
  • promiseRaceStressTestWorkflow | wrun_01M1CV0MDJXNKHY0YWKJ0RH1VR
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M1CV4N8WHK9A39B0QXR4828N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M1CV5M2JQ5JP1V95Y0XF1C60
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M1CV5PP8TGMTASZN1FTDRPMP
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M1CV83N1CJ54BQ83R1EX6AFY
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M1CV8M08DXY5819TG7RMJAT2
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M1CV8Y7JMBH3MX1XT7HGDPVC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01M1CV94J8GXC2XNAK6NZAGM1T
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M1CV96WXD5N02VNRNVSE7PF4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M1CV9QSR19RPC42E3P96RBXN
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01M1CV9YQEY72NTQJGAR813AC5
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M1CVA4VJ1NV5S3Q4RGD1G161
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M1CVAAWENCXZDM9GEFEJQKD4
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M1CVAJ6E397ZJZQSXKNEAEYW
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M1CVASJ48AXFCJZGV5Z10EHS
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M1CVB141FVW96K1HKNAC1PDN
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M1CVBDFE0EFX5MS0K99WC42X
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M1CVBNZR5XDCFMVK00JZZ5MK
  • cancelRun - cancelling a running workflow | wrun_01M1CVBXAM3Q7CWZQYM7P5MM3V
  • cancelRun via CLI - cancelling a running workflow | wrun_01M1CVC2FGT0X78QG1WPA922DH
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M1CVCARYF6RMDW9ZB2AHWFPB
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M1CVCQ3510E0FBQQQXZB7QJ3
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M1CVD0N32V3V0AJTA45VJ4KW
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M1CVDBM40MXAM6SDPZBCW8V0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M1CVDJVYDQ2BKNNQQ48DNFKD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M1CVDNA6CJH9YV3V18A902Y8
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9908
✅ example9908
✅ express9908
✅ fastify9908
✅ hono9908
✅ nextjs-turbopack10403
✅ nextjs-webpack10403
✅ nitro9908
✅ nuxt9908
✅ sveltekit9908
✅ vite9908
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10700
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67210
✅ turso-dev403
❌ turso3850
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable10106
✅ e2e-local-dev-tanstack-start-stable10106
✅ e2e-local-postgres-nest-stable10106
✅ e2e-local-postgres-tanstack-start-stable10106
✅ e2e-local-prod-nest-stable10106
✅ e2e-local-prod-tanstack-start-stable10106

📋 View full workflow run

@pranaygp

Copy link
Copy Markdown
Contributor

closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Backport #3879: fix(core): re-arm late-claimed hook deliveries by github-actions[bot] · Pull Request #3905 · vercel/workflow · GitHub
Skip to content

Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905

Closed
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable
Closed

Backport #3879: fix(core): re-arm late-claimed hook deliveries#3905
github-actions[bot] wants to merge 1 commit into
stablefrom
backport/pr-3879-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #3879 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in packages/core/src/private.ts, which exists verbatim on stable — including the unarmed buffered-hook barrier, the idle safety net, and the no-op arm() on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The added async-deserialization-ordering regression exercises the defect through the ordinary hook API with no retained-VM machinery, so stable is exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note that packages/core/src/retained-vm-loop.test.ts does not exist on stable (retained VM is main-only), so that test file should be dropped from the cherry-pick.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

* fix(core): re-arm late-claimed hook deliveries
* refactor(core): clarify delivery barrier lifecycle
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9145e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 31, 2026 7:17pm
example-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-astro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-express-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-hono-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-python-workflowErrorErrorv0Aug 31, 2026 7:17pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workbench-vite-workflowReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-docsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-tarballsReadyReadyPreview, v0Aug 31, 2026 7:17pm
workflow-webReadyReadyPreview, v0Aug 31, 2026 7:17pm

@github-actions

github-actionsBot commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10990781177
✅ 💻 Local Development11980861284
✅ 📦 Local Production11980861284
✅ 🐘 Local Postgres11980861284
✅ 🪟 Windows10700107
❌ 🌍 Community Worlds821069197
✅ 📋 Other606036642
Total54881063815975

❌ Failed Tests

🌍 Community Worlds (106 failed)

redis (21 failed):

  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

turso (85 failed):

  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • addTenWorkflow | wrun_01M1CTTA4X1RHBEBFJFP0XW290
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01M1CTTGZPYD8D1M1SGBYKYW4G
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01M1CTTHD8X5EW9HS4S9GEQ2MJ
  • promiseRaceWorkflow | wrun_01M1CTTPDYJRZ97TSZQRAZZ0VV
  • promiseAnyWorkflow | wrun_01M1CTTRYZ3ET8MCMNE56S5KQH
  • importedStepOnlyWorkflow | wrun_01M1CTTVSFNVD0333BX5GD6SHF
  • readableStreamWorkflow | wrun_01M1CTTVAHX0Q1VWPAAK0MHRPS
  • hookWorkflow | wrun_01M1CTV89F40HCCQ711TYTKD1X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01M1CTVF3G418CEBDDP6675VZ6
  • webhookWorkflow | wrun_01M1CTVM3H0P6NBCF4RJ96CVRA
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M1CTVRZWBEG68NQFHJC8S06D
  • sleepingWorkflow | wrun_01M1CTWR4HTMJDTCW0ZVVXPSJH
  • parallelSleepWorkflow | wrun_01M1CTX84ZAV42GM449B1FYT2R
  • sleepWinsRaceWorkflow | wrun_01M1CTXBRN6KR3AFASTKEJ67Q4
  • stepWinsRaceWorkflow | wrun_01M1CTXFEGKH62EB6F3BKTWJT2
  • nullByteWorkflow | wrun_01M1CTXJZQBKSTQE2AH6E22YSR
  • workflowAndStepMetadataWorkflow | wrun_01M1CTXNCK1NJG649SQSGWWK73
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M1CTZY2AFJCCJ6BV61WTHTQ9
  • writableForwardedFromWorkflowWorkflow | wrun_01M1CV0AW9T5022NVPTEYZXZ4F
  • writableForwardedFromStepWorkflow | wrun_01M1CV0E0AH938BDRG6XYM46B2
  • fetchWorkflow | wrun_01M1CV0GXS83RD8JVDW34WHPMH
  • promiseRaceStressTestWorkflow | wrun_01M1CV0MDJXNKHY0YWKJ0RH1VR
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling serialization failures step-argument serialization failure is catchable in workflow code
  • error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M1CV4N8WHK9A39B0QXR4828N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M1CV53B15HQJBNWJMAB46EAD
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M1CV5HBGQJCQZ6B9H2MSSJM7
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M1CV5M2JQ5JP1V95Y0XF1C60
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M1CV5PP8TGMTASZN1FTDRPMP
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M1CV5SFB9K6Q7VDWJKC707JD
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M1CV674ZN48849G6CG8J278M
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M1CV73TRW50GY0TT9WPFY1HT
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M1CV7840A1M2Z10HPTKJPB7Z
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M1CV7EZV8GZXC34CEVV71C2V
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M1CV7KADCB0E96HR9KNWTQT1
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M1CV7WF63Z20FV095ZTRKGZR
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M1CV83N1CJ54BQ83R1EX6AFY
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M1CV8M08DXY5819TG7RMJAT2
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M1CV8Y7JMBH3MX1XT7HGDPVC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01M1CV94J8GXC2XNAK6NZAGM1T
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M1CV96WXD5N02VNRNVSE7PF4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M1CV9QSR19RPC42E3P96RBXN
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01M1CV9YQEY72NTQJGAR813AC5
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M1CVA4VJ1NV5S3Q4RGD1G161
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M1CVAAWENCXZDM9GEFEJQKD4
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M1CVAJ6E397ZJZQSXKNEAEYW
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M1CVASJ48AXFCJZGV5Z10EHS
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M1CVB141FVW96K1HKNAC1PDN
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M1CVBDFE0EFX5MS0K99WC42X
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M1CVBNZR5XDCFMVK00JZZ5MK
  • cancelRun - cancelling a running workflow | wrun_01M1CVBXAM3Q7CWZQYM7P5MM3V
  • cancelRun via CLI - cancelling a running workflow | wrun_01M1CVC2FGT0X78QG1WPA922DH
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M1CVCARYF6RMDW9ZB2AHWFPB
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M1CVCQ3510E0FBQQQXZB7QJ3
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M1CVD0N32V3V0AJTA45VJ4KW
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M1CVDBM40MXAM6SDPZBCW8V0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M1CVDJVYDQ2BKNNQQ48DNFKD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M1CVDNA6CJH9YV3V18A902Y8
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M1CVDQQMQAJGFJE7FBPT63TT

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9908
✅ example9908
✅ express9908
✅ fastify9908
✅ hono9908
✅ nextjs-turbopack10403
✅ nextjs-webpack10403
✅ nitro9908
✅ nuxt9908
✅ sveltekit9908
✅ vite9908
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable10106
✅ express-stable10106
✅ fastify-stable10106
✅ hono-stable10106
✅ nextjs-turbopack-canary88019
✅ nextjs-turbopack-stable10700
✅ nextjs-webpack-canary88019
✅ nextjs-webpack-stable10700
✅ nitro-stable10106
✅ nuxt-stable10106
✅ sveltekit-stable10106
✅ vite-stable10106
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10700
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67210
✅ turso-dev403
❌ turso3850
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable10106
✅ e2e-local-dev-tanstack-start-stable10106
✅ e2e-local-postgres-nest-stable10106
✅ e2e-local-postgres-tanstack-start-stable10106
✅ e2e-local-prod-nest-stable10106
✅ e2e-local-prod-tanstack-start-stable10106

📋 View full workflow run

@pranaygp

Copy link
Copy Markdown
Contributor

closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@pranaygp