Uh oh!
There was an error while loading. Please reload this page.
refactor: add vite package for hmr - #501
Merged
Merged
Conversation
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: bb88ade The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ContributorAuthor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 10 parallel steps💻 Local Development
▲ Production (Vercel)
stress test: Promise.all with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
stress test: Promise.race with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
Stream BenchmarksStream benchmarks include Time to First Byte (TTFB) metrics. workflow with stream💻 Local Development
▲ Production (Vercel)
Summary: Fastest Framework by WorldWinner determined by most benchmark wins
Summary: Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+31
to
+36
| "devDependencies": { | ||
| "@types/node": "catalog:", | ||
| "@workflow/builders": "workspace:*", | ||
| "@workflow/tsconfig": "workspace:*", | ||
| "vite": "7.1.12" | ||
| } |
Contributor
There was a problem hiding this comment.
The @workflow/builders package should be in dependencies instead of devDependencies because the exported WorkflowHotUpdatePluginOptions interface references BaseBuilder from it. External consumers will fail to resolve the types without this dependency.
View Details
📝 Patch Details
diff --git a/packages/vite/package.json b/packages/vite/package.json
index fc42483..2c86c5c 100644
--- a/packages/vite/package.json+++ b/packages/vite/package.json@@ -28,9 +28,11 @@
"clean": "tsc --build --clean && rm -rf dist",
"typecheck": "tsc --noEmit"
},
+ "dependencies": {+ "@workflow/builders": "workspace:*"+ },
"devDependencies": {
"@types/node": "catalog:",
- "@workflow/builders": "workspace:*",
"@workflow/tsconfig": "workspace:*",
"vite": "7.1.12"
}
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index d21b10a..285fb0c 100644
--- a/pnpm-lock.yaml+++ b/pnpm-lock.yaml@@ -811,13 +811,14 @@ importers:
version: 3.2.4(@types/debug@4.1.12)(@types/node@22.19.0)(jiti@2.6.1)(lightningcss@1.30.1)(terser@5.44.0)(tsx@4.20.6)(yaml@2.8.1)
packages/vite:
+ dependencies:+ '@workflow/builders':+ specifier: workspace:*+ version: link:../builders
devDependencies:
'@types/node':
specifier: 'catalog:'
version: 22.19.0
- '@workflow/builders':- specifier: workspace:*- version: link:../builders
'@workflow/tsconfig':
specifier: workspace:*
version: link:../tsconfig
Analysis
@workflow/builders should be in dependencies, not devDependencies
What fails: The @workflow/vite package exports WorkflowHotUpdatePluginOptions interface which references BaseBuilder type from @workflow/builders. When external consumers import this exported type, TypeScript cannot resolve the @workflow/builders module because it's only listed in devDependencies.
How to reproduce:
cd packages/vite
# Verify @workflow/builders is in devDependencies (lines 33-36 of package.json)
cat package.json | grep -A 5 devDependencies
# Try to build or typecheck
pnpm buildResult: Compilation fails with:
src/hot-update.ts(2,34): error TS2307: Cannot find module '@workflow/builders' or its corresponding type declarations.
Root cause: The exported interface in packages/vite/src/index.ts includes WorkflowHotUpdatePluginOptions which has a type signature that depends on BaseBuilder from @workflow/builders. This type dependency must be available at runtime through the node_modules resolution for TypeScript to resolve type declarations when consuming the published package. External users installing @workflow/vite from npm will receive the built .d.ts files with these type references, but will fail to resolve them without @workflow/builders as a runtime dependency.
Fix: Moved @workflow/builders from devDependencies to dependencies in packages/vite/package.json to ensure external consumers can resolve the type declarations.
ijjk
approved these changes
Dec 5, 2025
adriandlamforce-pushed
the
12-02-refactor-vite-plugin
branch
from
December 5, 2025 23:52
0ad9ad4 to
bb88adeCompareContributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Testsmongodb (🌍 Community Worlds): e2e webhookWorkflowFile: redis (🌍 Community Worlds): e2e webhookWorkflowFile: starter (🌍 Community Worlds): e2e addTenWorkflowFile: starter (🌍 Community Worlds): e2e addTenWorkflowFile: starter (🌍 Community Worlds): e2e retryAttemptCounterWorkflowFile: starter (🌍 Community Worlds): e2e crossFileErrorWorkflow - stack traces work across imported modulesFile: starter (🌍 Community Worlds): e2e hookCleanupTestWorkflow - hook token reuse after workflow completionFile: starter (🌍 Community Worlds): e2e stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)File: starter (🌍 Community Worlds): e2e stepFunctionWithClosureWorkflow - step function with closure variables passed as argumentFile: starter (🌍 Community Worlds): e2e spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a stepFile: turso (🌍 Community Worlds): e2e addTenWorkflowFile: turso (🌍 Community Worlds): e2e addTenWorkflowFile: turso (🌍 Community Worlds): e2e should work with react rendering in stepFile: turso (🌍 Community Worlds): e2e promiseAllWorkflowFile: turso (🌍 Community Worlds): e2e promiseRaceWorkflowFile: turso (🌍 Community Worlds): e2e promiseAnyWorkflowFile: turso (🌍 Community Worlds): e2e readableStreamWorkflowFile: turso (🌍 Community Worlds): e2e hookWorkflowFile: turso (🌍 Community Worlds): e2e webhookWorkflowFile: turso (🌍 Community Worlds): e2e sleepingWorkflowFile: turso (🌍 Community Worlds): e2e nullByteWorkflowFile: turso (🌍 Community Worlds): e2e workflowAndStepMetadataWorkflowFile: turso (🌍 Community Worlds): e2e outputStreamWorkflowFile: turso (🌍 Community Worlds): e2e outputStreamInsideStepWorkflow - getWritable() called inside step functionsFile: turso (🌍 Community Worlds): e2e fetchWorkflowFile: turso (🌍 Community Worlds): e2e promiseRaceStressTestWorkflowFile: turso (🌍 Community Worlds): e2e retryAttemptCounterWorkflowFile: turso (🌍 Community Worlds): e2e retryableAndFatalErrorWorkflowFile: turso (🌍 Community Worlds): e2e crossFileErrorWorkflow - stack traces work across imported modulesFile: turso (🌍 Community Worlds): e2e hookCleanupTestWorkflow - hook token reuse after workflow completionFile: turso (🌍 Community Worlds): e2e stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)File: turso (🌍 Community Worlds): e2e stepFunctionWithClosureWorkflow - step function with closure variables passed as argumentFile: turso (🌍 Community Worlds): e2e closureVariableWorkflow - nested step functions with closure variablesFile: turso (🌍 Community Worlds): e2e spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a stepFile: nuxt (▲ Vercel Production): e2e hookCleanupTestWorkflow - hook token reuse after workflow completionFile: Details by Category❌ ▲ Vercel Production
✅ 🪟 Windows
❌ 🌍 Community Worlds
|
| App | Passed | Failed | Skipped |
|---|---|---|---|
| 25 | 0 | 1 |
- Vercel Prod: failure
- Local Dev: success
- Local Prod: success
- Local Postgres: success
- Windows: success
- Community Worlds: success
Check the workflow run for details.
ContributorAuthor
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nitro, sveltekit and astro and additional vite integrations will use
hotUpdatefor hmr in the future. this adds a@workflow/vitepackage to standardize hmr in workflows