Uh oh!
There was an error while loading. Please reload this page.
[next] Allow implicit react imports - #504
Closed
VaguelySerious wants to merge 2 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 3c4c6d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Benchmark Results
workflow with no steps
workflow with 1 step
workflow with 10 sequential steps
workflow with 10 parallel steps
Stream BenchmarksStream benchmarks include Time to First Byte (TTFB) metrics. workflow with stream
Summary: Fastest Framework by WorldWinner determined by most benchmark wins
Summary: Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
ijjk
reviewed
Dec 2, 2025
| target: 'es2022', | ||
| transform: { | ||
| react: { | ||
| runtime: 'automatic', |
Member
There was a problem hiding this comment.
Ideally we don't actually transform JSX at all so that the upstream tool can consume how it needs to e.g. Next.js might process one way but then vite expects to process a different way. Let me see if I can get that to work
VaguelySerious
commented
Dec 3, 2025
MemberAuthor
Closing in favor of #507 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #212, where workflow/step bundling throws
ReferenceError: React is not definedif react imports aren't explicitly defined, even though the TSConfig handles the implicit import fine.Not sure if this makes sense or not.