Uh oh!
There was an error while loading. Please reload this page.
Update to latest swc/core and preserve JSX - #507
Merged
Conversation
🦋 Changeset detectedLatest commit: 2d0ae6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 10 parallel steps💻 Local Development
▲ Production (Vercel)
Stream BenchmarksStream benchmarks include Time to First Byte (TTFB) metrics. workflow with stream💻 Local Development
▲ Production (Vercel)
Summary: Fastest Framework by WorldWinner determined by most benchmark wins
Summary: Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Testsmongodb (🌍 Community Worlds): e2e webhookWorkflowFile: starter (🌍 Community Worlds): e2e addTenWorkflowFile: starter (🌍 Community Worlds): e2e addTenWorkflowFile: starter (🌍 Community Worlds): e2e retryAttemptCounterWorkflowFile: starter (🌍 Community Worlds): e2e crossFileErrorWorkflow - stack traces work across imported modulesFile: starter (🌍 Community Worlds): e2e hookCleanupTestWorkflow - hook token reuse after workflow completionFile: starter (🌍 Community Worlds): e2e stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)File: starter (🌍 Community Worlds): e2e stepFunctionWithClosureWorkflow - step function with closure variables passed as argumentFile: starter (🌍 Community Worlds): e2e spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a stepFile: turso (🌍 Community Worlds): e2e addTenWorkflowFile: turso (🌍 Community Worlds): e2e addTenWorkflowFile: turso (🌍 Community Worlds): e2e should work with react rendering in stepFile: turso (🌍 Community Worlds): e2e promiseAllWorkflowFile: turso (🌍 Community Worlds): e2e promiseRaceWorkflowFile: turso (🌍 Community Worlds): e2e promiseAnyWorkflowFile: turso (🌍 Community Worlds): e2e readableStreamWorkflowFile: turso (🌍 Community Worlds): e2e hookWorkflowFile: turso (🌍 Community Worlds): e2e webhookWorkflowFile: turso (🌍 Community Worlds): e2e sleepingWorkflowFile: turso (🌍 Community Worlds): e2e nullByteWorkflowFile: turso (🌍 Community Worlds): e2e workflowAndStepMetadataWorkflowFile: turso (🌍 Community Worlds): e2e outputStreamWorkflowFile: turso (🌍 Community Worlds): e2e outputStreamInsideStepWorkflow - getWritable() called inside step functionsFile: turso (🌍 Community Worlds): e2e fetchWorkflowFile: turso (🌍 Community Worlds): e2e promiseRaceStressTestWorkflowFile: turso (🌍 Community Worlds): e2e retryAttemptCounterWorkflowFile: turso (🌍 Community Worlds): e2e retryableAndFatalErrorWorkflowFile: turso (🌍 Community Worlds): e2e crossFileErrorWorkflow - stack traces work across imported modulesFile: turso (🌍 Community Worlds): e2e hookCleanupTestWorkflow - hook token reuse after workflow completionFile: turso (🌍 Community Worlds): e2e stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)File: turso (🌍 Community Worlds): e2e stepFunctionWithClosureWorkflow - step function with closure variables passed as argumentFile: turso (🌍 Community Worlds): e2e closureVariableWorkflow - nested step functions with closure variablesFile: turso (🌍 Community Worlds): e2e spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a stepFile: Details by Category
|
| App | Passed | Failed | Skipped |
|---|---|---|---|
| 25 | 0 | 1 | |
| 25 | 0 | 1 | |
| 25 | 0 | 1 | |
| 25 | 0 | 1 | |
| 25 | 0 | 1 | |
| 25 | 0 | 1 | |
| 25 | 0 | 1 | |
| 25 | 0 | 1 | |
| 25 | 0 | 1 | |
| 25 | 0 | 1 |
✅ 🪟 Windows
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ✅ nextjs-turbopack | 26 | 0 | 0 |
❌ 🌍 Community Worlds
| App | Passed | Failed | Skipped |
|---|---|---|---|
| ✅ mongodb-dev | 3 | 0 | 0 |
| ❌ mongodb | 25 | 1 | 0 |
| ✅ redis-dev | 3 | 0 | 0 |
| ✅ redis | 26 | 0 | 0 |
| ✅ starter-dev | 3 | 0 | 0 |
| ❌ starter | 18 | 8 | 0 |
| ✅ turso-dev | 3 | 0 | 0 |
| ❌ turso | 2 | 24 | 0 |
- Vercel Prod: failure
- Local Dev: success
- Local Prod: success
- Local Postgres: success
- Windows: success
- Community Worlds: success
Check the workflow run for details.
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
VaguelySerious
approved these changes
Dec 3, 2025
Comment on lines
+116
to
+121
| if (!(isNext && isLocal)) { | ||
| // only works with framework that transpiles react and | ||
| // doesn't work on Vercel due to eval hack so react isn't | ||
| // bundled in function | ||
| return; | ||
| } |
There was a problem hiding this comment.
Should this be a test.skipIf() instead?
MemberAuthor
There was a problem hiding this comment.
Oh TIL about skipIf can use that yea
| run: pnpm turbo run build --filter='!./workbench/*' | ||
| - name: Resolve symlinks | ||
| run: ./scripts/resolve-symlinks.sh workbench/${{ matrix.app.name }} |
There was a problem hiding this comment.
Seems fine, but why is it necessary?
MemberAuthor
There was a problem hiding this comment.
Was matching dev tests for consistency and to eliminate causes for failure
TooTallNate
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to preserve JSX when transforming with our custom workflow SWC pass as JSX is meant to be consumed by the framework as each can handle it differently and we can't guess what the correct setup exactly is for each framework/app.
fixes: #212
x-ref: #504 (comment)