Uh oh!
There was an error while loading. Please reload this page.
fix: disable dce in client mode - #632
Closed
adriandlam wants to merge 1 commit into
Closed
Conversation
|
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 10 parallel steps💻 Local Development
▲ Production (Vercel)
stress test: Promise.all with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
stress test: Promise.race with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details.
Check the workflow run for details. |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (2 failed)nitro (1 failed):
sveltekit (1 failed):
🌍 Community Worlds (11 failed)mongodb (1 failed):
redis (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
There was a problem hiding this comment.
Additional Suggestion:
The comment describing the dead code elimination behavior is outdated and contradicts the actual code behavior. It claims DCE happens in both workflow and client mode, but the modified remove_dead_code function now only runs in workflow mode.
View Details
📝 Patch Details
diff --git a/packages/swc-plugin-workflow/transform/src/lib.rs b/packages/swc-plugin-workflow/transform/src/lib.rs
index c523b2d..481eb5f 100644
--- a/packages/swc-plugin-workflow/transform/src/lib.rs+++ b/packages/swc-plugin-workflow/transform/src/lib.rs@@ -4205,7 +4205,7 @@ impl VisitMut for StepTransform {
}
}
- // Perform dead code elimination in workflow and client mode+ // Perform dead code elimination in workflow mode
self.remove_dead_code(items);
}
Analysis
Outdated comment in remove_dead_code call misleads about DCE behavior
What fails: Comment on line 4208 states "Perform dead code elimination in workflow and client mode" but the actual implementation only runs dead code elimination in workflow mode
How to verify:
- View the
remove_dead_code()function definition at lines 2444-2446:
if !matches!(self.mode,TransformMode::Workflow){return;}- This guard causes the function to exit early and skip DCE when NOT in Workflow mode (i.e., when in Client or Step mode)
Result: Comment incorrectly claims DCE runs in both workflow and client modes when it actually only runs in workflow mode
Expected: Comment should accurately describe the actual behavior: "Perform dead code elimination in workflow mode"
Fix applied: Updated line 4208 comment from "workflow and client mode" to "workflow mode" to match the code's actual behavior
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.