Uh oh!
There was an error while loading. Please reload this page.
feat: support nextjs pages router - #650
Closed
adriandlam wants to merge 14 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: d0bdf71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (23 failed)nextjs-pages (23 failed):
🌍 Community Worlds (11 failed)mongodb (1 failed):
redis (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
adriandlamforce-pushed
the
feat/support-next-pages-router
branch
from
December 18, 2025 22:39
a524531 to
d03acf3Compare| return; | ||
| } | ||
| const { token, data } = JSON.parse(req.body); |
Contributor
There was a problem hiding this comment.
The hook.ts endpoint unconditionally calls JSON.parse(req.body), but with Next.js's default body parser enabled, req.body is already an object and cannot be parsed as JSON. This will throw a runtime error.
View Details
📝 Patch Details
diff --git a/workbench/nextjs-pages-router/pages/api/hook.ts b/workbench/nextjs-pages-router/pages/api/hook.ts
index 4092d6f..ef9e1be 100644
--- a/workbench/nextjs-pages-router/pages/api/hook.ts+++ b/workbench/nextjs-pages-router/pages/api/hook.ts@@ -10,7 +10,7 @@ export default async function handler(
return;
}
- const { token, data } = JSON.parse(req.body);+ const { token, data } = req.body as { token: string; data: unknown };
let hook: Awaited<ReturnType<typeof getHookByToken>>;
try {
diff --git a/workbench/nextjs-pages-router/pages/api/test-direct-step-call.ts b/workbench/nextjs-pages-router/pages/api/test-direct-step-call.ts
index ce36778..2d487c4 100644
--- a/workbench/nextjs-pages-router/pages/api/test-direct-step-call.ts+++ b/workbench/nextjs-pages-router/pages/api/test-direct-step-call.ts@@ -14,7 +14,7 @@ export default async function handler(
return;
}
- const { x, y } = JSON.parse(req.body);+ const { x, y } = req.body as { x: number; y: number };
console.log(`Calling step function directly with x=${x}, y=${y}`);
Analysis
Next.js API routes unconditionally calling JSON.parse on already-parsed request bodies
What fails:pages/api/hook.ts and pages/api/test-direct-step-call.ts fail when receiving POST requests with JSON content, because they call JSON.parse(req.body) when req.body is already a parsed object.
How to reproduce:
'Result: Runtime error: TypeError: "[object Object]" is not valid JSON
Expected behavior: The request should be processed successfully. Per Next.js API Routes documentation, the default configuration automatically parses the request body into an object based on content-type. req.body is already a parsed object and does not need JSON.parse().
Root cause: The code assumed req.body was a JSON string, but Next.js automatically parses it into an object by default. Other routes in the same project (workflows/await.ts, workflows/start.ts, workflows/stream.ts) correctly treat req.body as an object directly.
Fix: Changed both endpoints to destructure req.body directly as an object with appropriate type assertions, matching the pattern used by other API routes in the project.
| const pagesRouterWrapper = `// biome-ignore-all lint: generated file | ||
| /* eslint-disable */ | ||
| ${PAGES_ADAPTER_CODE} | ||
| ${stepsBundle.replace(/export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\};?/g, 'const POST = stepEntrypoint;')} |
Contributor
There was a problem hiding this comment.
The regex pattern used to replace the steps bundle export statement is incomplete and will produce invalid JavaScript syntax. The pattern doesn't account for the from 'workflow/runtime' part of the re-export statement.
View Details
📝 Patch Details
diff --git a/packages/astro/src/builder.ts b/packages/astro/src/builder.ts
index 5237247..09dc400 100644
--- a/packages/astro/src/builder.ts+++ b/packages/astro/src/builder.ts@@ -91,7 +91,7 @@ export class LocalBuilder extends BaseBuilder {
// Normalize request, needed for preserving request through astro
stepsRouteContent = stepsRouteContent.replace(
- /export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\}\s*;?$/m,+ /export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\}(?:\s+from\s+['"][^'"]*['"])?\s*;?$/m,
`${NORMALIZE_REQUEST_CODE}
export const POST = async ({request}) => {
const normalRequest = await normalizeRequest(request);
diff --git a/packages/next/src/builder.ts b/packages/next/src/builder.ts
index 85b7a90..174509e 100644
--- a/packages/next/src/builder.ts+++ b/packages/next/src/builder.ts@@ -760,7 +760,7 @@ async function sendPagesResponse(res, webResponse) {
const pagesRouterWrapper = `// biome-ignore-all lint: generated file
/* eslint-disable */
${PAGES_ADAPTER_CODE}
-${stepsBundle.replace(/export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\};?/g, 'const POST = stepEntrypoint;')}+${stepsBundle.replace(/export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\}(?:\s+from\s+['"][^'"]*['"])?\s*;?/g, 'const POST = stepEntrypoint;')}
export default async function handler(req, res) {
const webRequest = await convertPagesRequest(req);
diff --git a/packages/sveltekit/src/builder.ts b/packages/sveltekit/src/builder.ts
index 531c754..681e600 100644
--- a/packages/sveltekit/src/builder.ts+++ b/packages/sveltekit/src/builder.ts@@ -90,7 +90,7 @@ export class SvelteKitBuilder extends BaseBuilder {
// Replace the default export with SvelteKit-compatible handler
stepsRouteContent = stepsRouteContent.replace(
- /export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\}\s*;?$/m,+ /export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\}(?:\s+from\s+['"][^'"]*['"])?\s*;?$/m,
`${NORMALIZE_REQUEST_CODE}
export const POST = async ({request}) => {
const normalRequest = await normalizeRequest(request);
Analysis
Incomplete regex pattern for re-export statement replacement causes invalid JavaScript syntax
What fails: The regex patterns used in pages/astro/sveltekit builders to replace export { stepEntrypoint as POST } statements do not match statements containing the from 'module' clause, resulting in malformed code like const POST = stepEntrypoint; from 'workflow/runtime';
How to reproduce:
- Build a Next.js/Astro/SvelteKit project with a workflow step
- The base builder's
createStepsBundle()method generates an entry with:export { stepEntrypoint as POST } from 'workflow/runtime'; - When this gets bundled and the Pages Router/Astro/SvelteKit handlers attempt to replace the export statement using the incomplete regex pattern, the
from 'workflow/runtime'clause is left behind - Result: Invalid JavaScript syntax that will fail to parse
Example failure:
Input:
export{stepEntrypointasPOST}from'workflow/runtime';Old regex /export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\};?/g produces:
constPOST=stepEntrypoint;from'workflow/runtime';This is invalid JavaScript and will cause a syntax error.
Root cause: The regex patterns in three files do not account for the optional from 'module' clause that esbuild preserves in re-export statements:
packages/next/src/builder.tsline 763packages/astro/src/builder.tsline 94packages/sveltekit/src/builder.tsline 93
Solution: Updated regex patterns to optionally match and remove the from 'module' clause:
- Changed:
/export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\};?/g(Next.js) - Changed:
/export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\}\s*;?$/m(Astro/SvelteKit) - To:
/export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\}(?:\s+from\s+['"][^'"]*['"])?\s*;?/g(Next.js) - To:
/export\s*\{\s*stepEntrypoint\s+as\s+POST\s*\}(?:\s+from\s+['"][^'"]*['"])?\s*;?$/m(Astro/SvelteKit)
The new pattern uses a non-capturing group (?:...) with an optional modifier ? to match the from 'module' clause, handling both single and double quotes.
adriandlam
commented
Dec 19, 2025
ContributorAuthor
update: we just need this PR merged: vercel/vercel which adds support for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add nextjs pages router support
fixes#143