Uh oh!
There was an error while loading. Please reload this page.
Observability config rewrite: remember projects, allow self-hosting, unify env var handling - #775
Closed
VaguelySerious wants to merge 12 commits into
Closed
Observability config rewrite: remember projects, allow self-hosting, unify env var handling#775VaguelySerious wants to merge 12 commits into
VaguelySerious wants to merge 12 commits into
Conversation
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
🦋 Changeset detectedLatest commit: 8a15ced The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (16 failed)mongodb (1 failed):
starter (14 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
| }, | ||
| "devDependencies": { | ||
| "@xyflow/react": "12.9.3", | ||
| "shiki": "3.21.0", |
| @@ -0,0 +1,28 @@ | |||
| #!/usr/bin/env node | |||
MemberAuthor
There was a problem hiding this comment.
This works similar to genversion but copies the world-manifest.json into the local package, instead of the package version
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Comment on lines
+29
to
+30
| // Generate TypeScript file with the manifest data | ||
| const tsContent = `// AUTO-GENERATED FILE - DO NOT EDIT |
MemberAuthor
There was a problem hiding this comment.
Unsure how to get around this. If at all possible, it would be nice to have the world-manifest be a typescript file inside some package, but I didn't want to change the convention here. @pranaygp
| export { parseDurationToDate } from './time.js'; | ||
| // Client-safe project types and utilities (no Node.js dependencies) | ||
| export type { |
MemberAuthor
There was a problem hiding this comment.
I ended up putting quite some cli/web shared code in here. It would be nice to have a o11y-utils package which does all of this, and also does what packages/core/observability.ts does
| serverSourceMaps: false, | ||
| }, | ||
| // Transpile workspace packages | ||
| transpilePackages: ['@workflow/web-shared', '@workflow/utils', '@workflow/core'], |
MemberAuthor
There was a problem hiding this comment.
I'm actually unsure about this - Claude added it 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably replaced with #774
This superseeds #626 and #748, and reverts #747 in order to:
world-manifest.json. Updating the manifest will now directly update the UI support for worlds.The dream for this is that you can open your web app once, and easily switch between local/staging/prod envs, or different project/repos) without having to invoke the o11y separately every time.
Not in this PR, but now unblocked:
vc env pullif vercel credentials expiredTesting
I'm working on e2e tests for this, but in the meantime, I manually validated this PR extensively:
--localUIWORKFLOW_UI_SELF_HOSTING="1")wfis aliased to theworkflowlocal directory (contributor DevEx)What I didn't test:
Screenshots