Update Custom-ADD_GM_ISLAND_VENDORS.sql to be usable

[IamTirion]

🍰 Pullrequest

This pull request updates the Custom-ADD_GM_ISLAND_VENDORS.sql to current structure of the creature_template. This was authored by w5860363. I have tested it and can confirm it works, while the version in the current repository does not.

Issues

Fixes#3280

How2Test

If you don't have the vendors on GM Island installed, run this SQL file.
Teleport to GM Island
See that there are vendors there

If you already have the vendors on GM Island installed, run Custom-REMOVE_GM_ISLAND_VENDORS.sql first, then run this file.
Teleport to GM Island
See that there are vendors there

[mserajnik]

You should probably outline how this differs to #2615.
Edit: Oh, it's identical. So why open a new PR for the same change? 🤔

[IamTirion]

You should probably outline how this differs to #2615.Edit: Oh, it's identical. So why open a new PR for the same change? 🤔

I think that pull request has a very confusing title, and does not follow the template of the pull requests here. And it also didn't mention it is a bug fix.

[mserajnik]

Issues

#3280

If you write Fixes #3280 the linked issue will automatically get closed when this PR gets merged.

[IamTirion]

Sorry I am new to this. Did I do it right?

[mserajnik]

Did I do it right?

Almost; sorry, I didn't mean to literally write Fixes #3280 with the inline code block.
Just write

Fixes #3280

normally and it should work. 😄

Edit:
Yep, like you did it now:

[IamTirion]

I guess I should also mention this. This is a bit of a blocking issue for me. There are changes I would like to make to this file, on top of the changes in this pull request, which are just making it usable. Before this becomes the base, I can't upload new changes using the old file, because that would be lying about it being usable.

[mserajnik]

There are changes I would like to make to this file, on top of the changes in this pull request, which are just making it usable. There are changes I would like to make to this file, on top of the changes in this pull request, which are just making it usable.

You could open a second PR with those changes and add a note like "depends on #3278 being merged first," or similar.

I’m only an occasional collaborator to VMaNGOS myself and don’t have merge permissions. From what I’ve observed, it can take a while until things get reviewed (and eventually merged), which is, of course, totally understandable for a project maintained by volunteers.

[IamTirion]

There are changes I would like to make to this file, on top of the changes in this pull request, which are just making it usable. There are changes I would like to make to this file, on top of the changes in this pull request, which are just making it usable.

You could open a second PR with those changes and add a note like "depends on #3278 being merged first," or similar.

I’m only an occasional collaborator to VMaNGOS myself and don’t have merge permissions. From what I’ve observed, it can take a while until things get reviewed (and eventually merged), which is, of course, understandable for a project maintained by volunteers.

Oh I didn't know I could do that. That's much better.

[mserajnik]

You can also mark the second PR as "Draft" so it's clear it's not ready to be merged. See here for some more information.