refactor(env)!: rename VITE_PLUS_* env vars to VP_* prefix by jong-kyung · Pull Request #1166 · voidzero-dev/vite-plus

jong-kyung · 2026-03-27T08:35:27Z

Summary

Rename all internal VITE_PLUS_* environment variables to VP_* prefix to avoid Vite's default envPrefix: "VITE_" from exposing them in bundled applications via import.meta.env.

Rename 25 env vars across Rust, TypeScript, shell scripts, CI workflows, and snap tests
Rename Rust constant identifiers and get_vite_plus_home() → get_vp_home() to match
Update all code comments and user-facing docs (docs/guide/env.md)
Env vars not renamed: VITE_LOG, VITE_NODE_DIST_MIRROR, VITE_UPDATE_TASK_TYPES, VITE_GLOBAL_CLI_JS_SCRIPTS_DIR — these use the VITE_ prefix (not VITE_PLUS_) and are intentionally kept

Prerequisite (merged)

vite-task: voidzero-dev/vite-task#297 — Add VP_* to DEFAULT_UNTRACKED_ENV so internal vars pass through to child processes without affecting cache keys

Please let me know if I missed anything — I'll fix it.

netlify · 2026-03-27T08:35:32Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`7e5ec7e`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/69c931fb4786c80008a05739

 else
- INSTALL_BASH="curl -fsSL https://vite.plus | VITE_PLUS_VERSION=${{ env.VERSION }} bash"
- INSTALL_PS1="\\\$env:VITE_PLUS_VERSION=\\\"${{ env.VERSION }}\\\"; irm https://vite.plus/ps1 | iex"
+ INSTALL_BASH="curl -fsSL https://vite.plus | VP_VERSION=${{ env.VERSION }} bash"


- INSTALL_BASH="curl -fsSL https://vite.plus | VITE_PLUS_VERSION=${{ env.VERSION }} bash"
- INSTALL_PS1="\\\$env:VITE_PLUS_VERSION=\\\"${{ env.VERSION }}\\\"; irm https://vite.plus/ps1 | iex"
+ INSTALL_BASH="curl -fsSL https://vite.plus | VP_VERSION=${{ env.VERSION }} bash"
+ INSTALL_PS1="\\\$env:VP_VERSION=\\\"${{ env.VERSION }}\\\"; irm https://vite.plus/ps1 | iex"


jong-kyung · 2026-03-27T08:36:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:8adb8192e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jong-kyung · 2026-03-28T05:41:08Z

There's currently a merge conflict with main. If there are no further changes needed, I'll squash the fixup commits and resolve the conflict.

jong-kyung · 2026-03-28T08:46:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:9057048a3f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2

@jong-kyung good job! Please resolve the conflicts, I will manually verifying and then merge on Monday.

…atibility

fengmk2 · 2026-03-29T13:57:29Z

@jong-kyung After I merged the main branch code, CI fails now. Could you help me take a look?

jong-kyung · 2026-03-29T13:59:59Z

@jong-kyung After I merged the main branch code, CI fails now. Could you help me take a look?

Sure, I will check It

…ev#1185

jong-kyung · 2026-03-29T14:07:00Z

@fengmk2 Fixed in 7e5ec7e.

The CI failure was caused by #1185 (fix: get vite_plus_home from node wrapper's path) which was merged into main after our last merge. That PR added a new test (test_get_vite_plus_without_home) in crates/vite_shared/src/home.rs that calls get_vite_plus_home(), but this PR renamed it to get_vp_home(). When GitHub CI auto-merged the latest main with our branch, the old function name no longer existed → compile error.

Updated the test to use the renamed get_vp_home().

Set both VP_VERSION (new) and VITE_PLUS_VERSION (legacy) when invoking the install script, so the action works with vite-plus versions before and after the VP_* env var rename. Ref: voidzero-dev/vite-plus#1166

## Summary - Set both `VP_VERSION` (new) and `VITE_PLUS_VERSION` (legacy) env vars when invoking the vite-plus install script - Ensures the action works with vite-plus versions before and after the `VP_*` env var rename (voidzero-dev/vite-plus#1166) - Includes a TODO comment to remove `VITE_PLUS_VERSION` once old versions are no longer supported ## Test plan - [x] CI passes with current vite-plus release (reads `VITE_PLUS_VERSION`) - [x] After voidzero-dev/vite-plus#1166 merges, verify install still works (reads `VP_VERSION`) 🤖 Generated with [Claude Code](https://claude.ai/claude-code) --------- Signed-off-by: MK (fengmk2) <fengmk2@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

After #1166, all VITE_PLUS_<env_var> env vars are renamed to VP_<env_var>. When I read RFCs, I found some RFCs still include deprecated `VITE_PLUS_` env vars. In this PR, I let Codex find and update all of them.

## Summary This follows up on #1166, which renamed `VITE_PLUS_*` environment variables to use the `VP_*` prefix. It applies the same convention to the remaining Vite+-specific variables: `VITE_LOG`, `VITE_GLOBAL_CLI_JS_SCRIPTS_DIR`, and `VITE_UPDATE_TASK_TYPES`, without retaining compatibility aliases. Resolves#2206

github-advanced-securityAI found potential problems Mar 27, 2026
View reviewed changes

jong-kyung force-pushed the refactor/rename-env-vars-vite-plus-to-vp branch from 8adb819 to 194e940Compare March 27, 2026 08:41

chatgpt-codex-connectorBot reviewed Mar 27, 2026
View reviewed changes

Comment threadcrates/vite_shared/src/env_config.rs
Comment threadcrates/vite_global_cli/src/shim/mod.rs

jong-kyung force-pushed the refactor/rename-env-vars-vite-plus-to-vp branch from 194e940 to ae89367Compare March 27, 2026 08:57

fengmk2 changed the title ~~refactor(env): rename VITE_PLUS_* env vars to VP_* prefix~~refactor(env)!: rename VITE_PLUS_* env vars to VP_* prefixMar 27, 2026

fengmk2 reviewed Mar 27, 2026
View reviewed changes

Comment threadpackages/cli/build.ts

chatgpt-codex-connectorBot reviewed Mar 28, 2026
View reviewed changes

Comment threadcrates/vite_shared/src/env_config.rs

fengmk2 approved these changes Mar 28, 2026
View reviewed changes

fengmk2 self-assigned this Mar 28, 2026

jong-kyung added 2 commits March 29, 2026 01:26

refactor(env): rename VITE_PLUS_* env vars to VP_* prefix
11bbc05

fix(shim): fall back to VITE_PLUS_SHIM_TOOL for older trampoline comp…
e5b2f05
…atibility

jong-kyung force-pushed the refactor/rename-env-vars-vite-plus-to-vp branch from 9057048 to e5b2f05Compare March 28, 2026 16:26

Merge branch 'main' into refactor/rename-env-vars-vite-plus-to-vp
e78b07c

jong-kyung force-pushed the refactor/rename-env-vars-vite-plus-to-vp branch from 7ef75ea to e78b07cCompare March 28, 2026 17:58

Merge branch 'main' into refactor/rename-env-vars-vite-plus-to-vp
399f54e

fix: rename get_vite_plus_home to get_vp_home in test fromvoidzero-d…
7e5ec7e
…ev#1185

fengmk2 mentioned this pull request Mar 29, 2026
feat: add VP_VERSION env var for install script compatibility voidzero-dev/setup-vp#40
Merged
2 tasks

fengmk2 merged commit 97c7571 into voidzero-dev:mainMar 29, 2026
65 checks passed

sapphi-red mentioned this pull request Apr 3, 2026
VITE_PLUS_CLI_BIN env var leaks into Vite env.spec.ts snapshots rolldown/rolldown#8833
Closed

fengmk2 mentioned this pull request Apr 10, 2026
fix(cli,bin): Add env.VP_VERSION for oxlint and oxfmt #946
Merged

fengmk2 mentioned this pull request Apr 20, 2026
feat(cli): embed release version via build.rs instead of CI string replacement #989
Closed

jong-kyung deleted the refactor/rename-env-vars-vite-plus-to-vp branch June 18, 2026 10:41

liangmiQwQ mentioned this pull request Jun 29, 2026
chore: update Vite+ env var prefixes #1984
Merged

liangmiQwQ mentioned this pull request Jul 13, 2026
Rename VITE_GIT_HOOKS to VP_GIT_HOOKS#2161
Closed
3 tasks

liangmiQwQ mentioned this pull request Jul 20, 2026
Rename the remaining env vars that starts with VITE_#2206
Closed

jong-kyung mentioned this pull request Aug 4, 2026
refactor(env): rename remaining Vite+ environment variables #2312
Merged

Uh oh!

Conversation

jong-kyung commented Mar 27, 2026

Summary

Prerequisite (merged)

Uh oh!

netlifyBot commented Mar 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

Check notice

Check notice

jong-kyung commented Mar 27, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jong-kyung commented Mar 28, 2026

Uh oh!

jong-kyung commented Mar 28, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fengmk2 left a comment

Choose a reason for hiding this comment

Uh oh!

fengmk2 commented Mar 29, 2026

Uh oh!

jong-kyung commented Mar 29, 2026

Uh oh!

jong-kyung commented Mar 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlifyBot commented Mar 27, 2026•
edited
Loading