Skip to content

fix: get vite_plus_home from node wrapper's path - #1185

Merged
fengmk2 merged 7 commits into
voidzero-dev:mainfrom
liangmiQwQ:fix/find-node-with-wrappers-path
Mar 29, 2026
Merged

fix: get vite_plus_home from node wrapper's path#1185
fengmk2 merged 7 commits into
voidzero-dev:mainfrom
liangmiQwQ:fix/find-node-with-wrappers-path

Conversation

@liangmiQwQ

@liangmiQwQliangmiQwQ commented Mar 28, 2026

Copy link
Copy Markdown
Collaborator

Close#1184

@netlify

netlifyBot commented Mar 28, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for viteplus-preview canceled.

NameLink
🔨 Latest commit0ba979c
🔍 Latest deploy loghttps://app.netlify.com/projects/viteplus-preview/deploys/69c86f568f65c6000881a1a2

@liangmiQwQ

liangmiQwQ commented Mar 29, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Done!

This PR used which crate to find vp's executable file and it's grandparent directory is expected to be vite_plus_home.

The reason not to use std::env::current_exe() is that node is essentially a symlink, and this function would get vp binary file's path. It makes both tests and debugs harder and less stable than a certain path in $PATH var. ($HOME reading logic is also kept if the node is not controlled by vp)

As which crate is also used in vite_command crate, so there is no cost for new dependencies.

Thanks!

@liangmiQwQ
liangmiQwQ marked this pull request as ready for review March 29, 2026 00:15
@liangmiQwQ

liangmiQwQ commented Mar 29, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@codex

@chatgpt-codex-connector

chatgpt-codex-connectorBot commented Mar 29, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2
fengmk2 approved these changes Mar 29, 2026
View reviewed changes

@fengmk2fengmk2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liangmiQwQ Thanks!

@fengmk2
fengmk2 merged commit 25741aa into voidzero-dev:mainMar 29, 2026
24 checks passed
@liangmiQwQ
liangmiQwQ deleted the fix/find-node-with-wrappers-path branch March 29, 2026 10:24
jong-kyung added a commit to hamsurang/vite-plus that referenced this pull request Mar 29, 2026
@jong-kyung
fix: rename get_vite_plus_home to get_vp_home in test fromvoidzero-d…
7e5ec7e
…ev#1185
@jong-kyungjong-kyung mentioned this pull request Mar 29, 2026
Merged
@liangmiQwQliangmiQwQ mentioned this pull request Jul 3, 2026
Merged
fengmk2 added a commit that referenced this pull request Jul 5, 2026
@liangmiQwQ@fengmk2
fix(global): respect custom VP_HOME (#2029)
638c447
At present, Vite+ allows users to specific `VP_HOME` as an installation
directory. However, for any future `vp` runs without manual `VP_HOME`
environment, we still use default `~/.vite-plus` or `vp`'s grandparent
directory if its name is `.vite-plus` (It's related to #1185 by me).
It will cause mess, like multiple Vite+ instances, vp binary not
finding, packages unusable and a lot of unexpected behavior.
This PR improves all related logic, include:
- Set `VP_HOME` in env files
- Improve prompt and implode check related to `VP_HOME`
- Respect `VP_HOME` in `pnpm boostrap-cli` at devtime.
The new `install.sh` prompt looks like that:
<img width="977" height="270" alt="image"
src="https://github.com/user-attachments/assets/c96435d1-4b49-4e51-bb75-3da06205f23e"
/>
🤖 Generated by Codex
---------
Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengmk2fengmk2fengmk2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

$HOME env overriding makes Vite+ stuck stuck in an infinite loop, especially for Agents use

2 participants

@liangmiQwQ@fengmk2