Skip to content

test(snapshots): migrate vp migrate snap test cases - #2107

Merged
graphite-app[bot] merged 1 commit into
mainfrom
migrate-migrate-snap-tests
Jul 10, 2026
Merged

test(snapshots): migrate vp migrate snap test cases#2107
graphite-app[bot] merged 1 commit into
mainfrom
migrate-migrate-snap-tests

Conversation

@fengmk2

@fengmk2fengmk2 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Migrates all 149 legacy vp migrate snap-test cases (144 from snap-tests-global, 5 from snap-tests) to the PTY snapshot suite under crates/vite_cli_snapshots, and removes the legacy dirs. Part of #2078.

Adds redact.rs rules for the managed-toolchain versions that appear in vp migrate output and bump on release: the completion banner (Migrated . to Vite+ <version>), the version-change table's managed rows (vite-plus, vite, vitest, @vitest/*, keeping the installed-source column), and the bundled vitest pins written into catalogs/overrides.

The not-supported-vite6/vitest3 cases stub node_modules/<pkg>/package.json instead of running a network vp install, so migrate reads the unsupported version offline.

Stacked on #2115 (local-registry teardown signal fix), which the Linux snapshot job needs.

@netlify

netlifyBot commented Jul 9, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

NameLink
🔨 Latest commit3b4829e
🔍 Latest deploy loghttps://app.netlify.com/projects/viteplus-preview/deploys/6a506b03cbb28000086da1ed

@fengmk2Graphite App

fengmk2 commented Jul 9, 2026

Copy link
Copy Markdown
MemberAuthor

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2fengmk2 self-assigned this Jul 9, 2026
@fengmk2fengmk2 changed the title test(snapshots): migrate vp migrate cases to the PTY snapshot suitetest(snapshots): migrate vp migrate cases to the PTY snapshot suiteJul 9, 2026
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch from 32e26d3 to a5f5ca9CompareJuly 9, 2026 07:55
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch 2 times, most recently from 9dd2dc6 to 576fd3bCompareJuly 9, 2026 12:08
@fengmk2
fengmk2 changed the base branch from main to graphite-base/2107July 9, 2026 14:52
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch from 66d9141 to f4cc891CompareJuly 9, 2026 14:53
@fengmk2
fengmk2 changed the base branch from graphite-base/2107 to fix-snap-registry-teardownJuly 9, 2026 14:53
@fengmk2
fengmk2force-pushed the fix-snap-registry-teardown branch from 9b411d2 to cfbc122CompareJuly 9, 2026 14:57
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch from f4cc891 to b9499f0CompareJuly 9, 2026 14:57
@fengmk2
fengmk2 marked this pull request as ready for review July 9, 2026 14:59
@fengmk2
fengmk2 requested a review from wan9chiJuly 9, 2026 14:59
@fengmk2fengmk2 changed the title test(snapshots): migrate vp migrate cases to the PTY snapshot suitetest(snapshots): migrate vp migrate snap test casesJul 9, 2026
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch from b9499f0 to 136ae2fCompareJuly 9, 2026 16:43
@fengmk2
fengmk2force-pushed the fix-snap-registry-teardown branch from 8397ec3 to cfbc122CompareJuly 9, 2026 16:49
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch from 136ae2f to 08df764CompareJuly 9, 2026 16:49
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch from 08df764 to 74811d1CompareJuly 10, 2026 01:50
@fengmk2
fengmk2force-pushed the fix-snap-registry-teardown branch from cfbc122 to 52ce2b9CompareJuly 10, 2026 01:50
Base automatically changed from fix-snap-registry-teardown to mainJuly 10, 2026 02:26
@graphite-app
graphite-appBot changed the base branch from main to graphite-base/2107July 10, 2026 02:26
@fengmk2
fengmk2force-pushed the graphite-base/2107 branch from 52ce2b9 to 9247583CompareJuly 10, 2026 02:52
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch from 74811d1 to 616c94eCompareJuly 10, 2026 02:52
@fengmk2
fengmk2 changed the base branch from graphite-base/2107 to mainJuly 10, 2026 02:52
@fengmk2
fengmk2force-pushed the migrate-migrate-snap-tests branch from 616c94e to e413787CompareJuly 10, 2026 03:19
@graphite-app

graphite-appBot commented Jul 10, 2026

Copy link
Copy Markdown

Merge activity

Migrates all 149 legacy `vp migrate` snap-test cases (144 from `snap-tests-global`, 5 from `snap-tests`) to the PTY snapshot suite under `crates/vite_cli_snapshots`, and removes the legacy dirs. Part of #2078.
Adds `redact.rs` rules for the managed-toolchain versions that appear in `vp migrate` output and bump on release: the completion banner (`Migrated . to Vite+ <version>`), the version-change table's managed rows (vite-plus, vite, vitest, `@vitest/*`, keeping the installed-source column), and the bundled vitest pins written into catalogs/overrides.
The `not-supported-vite6`/`vitest3` cases stub `node_modules/<pkg>/package.json` instead of running a network `vp install`, so migrate reads the unsupported version offline.
Stacked on #2115 (local-registry teardown signal fix), which the Linux snapshot job needs.
@graphite-app
graphite-appBotforce-pushed the migrate-migrate-snap-tests branch from e413787 to 3b4829eCompareJuly 10, 2026 03:46
graphite-appBot pushed a commit that referenced this pull request Jul 10, 2026
Stacked on #2107.
Migrates 7 of the 11 legacy `shim-*` global snap-test cases (node/npm/pnpm shim behavior) to the PTY snapshot suite:
- `shim-inherits-parent-{dev-engines-runtime,engines-node,node-version}`
- `shim-npm-uses-package-manager-version`
- `shim-npm-ignores-mismatched-package-manager`
- `shim-pnpm-uses-project-node-version`
- `shim-recursive-npm-run`
The `test "$(npm --version)" = X` version assertions become direct `npm`/`npx --version` steps whose pinned output is the snapshot. `npx` is added to the runner program allow-list (resolved from the case PATH, so the vp-managed shim wins).
Deferred to a later batch, since they depend on shell features the PTY runner intentionally does not provide (`$VP_HOME` path references, `$(pwd)`/PATH overrides, fake runtimes, arbitrary installed binaries): `shim-corepack-bundled`, `shim-corepack-enable-install-directory`, `shim-npm-downloads-uncached-package-manager-version`, `shim-recursive-package-binary`.
@graphite-app
graphite-appBot merged commit 3b4829e into mainJul 10, 2026
52 checks passed
@graphite-app
graphite-appBot deleted the migrate-migrate-snap-tests branch July 10, 2026 03:52
wan9chi added a commit that referenced this pull request Jul 16, 2026
)
Release vite-plus v0.2.5: Cleaner environments and more reliable
workflows.
This release adds cleanup and package version commands, supports
TypeScript 7 declaration generation, reduces the standalone binary size,
and hardens task tracking, CLI output, package-manager routing, Docker
workflows, and project scaffolding.
### Highlights
- Add `vp env clean` to remove unused managed Node.js runtimes and
package-manager caches
([#2003](#2003)), by
@liangmiQwQ
- Add `vp pm version`, forwarding native version commands to npm, pnpm,
Yarn, and Bun
([#2127](#2127)), by
@jong-kyung
- Add TypeScript 7 support to declaration generation and generated
library projects with tsdown `0.22.7`
([#2104](#2104),
[#2168](#2168)), by
@wan9chi
- Improve automatic task input tracking for Bun on macOS, Linux
containers with constrained `/dev/shm`, and Windows process images,
reduce Windows backing-file allocation, and clarify task wait failures
([vite-task#515](voidzero-dev/vite-task#515),
[vite-task#518](voidzero-dev/vite-task#518),
[vite-task#523](voidzero-dev/vite-task#523),
[vite-task#524](voidzero-dev/vite-task#524),
[vite-task#542](voidzero-dev/vite-task#542),
[#2126](#2126),
[#2167](#2167)), by
@wan9chi
- Prevent CLI diagnostics from truncating or panicking when inherited
standard output or error is nonblocking
([#2172](#2172),
[#2173](#2173)), by
@wan9chi
### Fixes & Enhancements
- Reduce standalone `vp` binary sizes by about 5% on Linux and macOS and
19% on Windows
([#2043](#2043)), by
@fengmk2
- Keep the Docker image non-root by default while allowing passwordless
`sudo` for Playwright browser dependencies and system packages
([#2088](#2088)), by
@fengmk2
- Ignore `.env` and `.env.*` in generated projects while keeping
`.env.example` trackable
([#2095](#2095)), by
@forehalo
- Create `vp-use.cmd` after the Windows environment bin directory is
ready and document its Command Prompt-only usage
([#2128](#2128)), by
@liangmiQwQ
- Render user-facing process statuses and paths without Rust debug
wrappers ([#2130](#2130)),
by @liangmiQwQ
- Make `vp dedupe` fall back to `yarn install` with a warning on Yarn
Classic ([#2139](#2139)),
by @jong-kyung
- Ensure package-manager child processes, including Bun, can always find
the managed Node.js runtime
([#2158](#2158)), by
@BlankParticle
### Docs
- Update the release-manager post-release guidance
([#2096](#2096)), by
@wan9chi
- Add Windows to the Namespace sponsor credit
([#2108](#2108)), by
@fengmk2
- Document installer and runtime environment variables, registry
settings, TLS options, and precedence rules
([#2114](#2114)), by
@yukinoshi
- Mark shell examples in `CONTRIBUTING.md` as Bash code blocks
([#2159](#2159)), by
@BlankParticle
### Chore
- Assign prepared release PRs to the workflow actor
([#2094](#2094)), by
@wan9chi
- Complete the PTY snapshot migration and harden the runner, fixtures,
release-version redaction, registry teardown, timeouts, and Linux
parallelism
([#2071](#2071),
[#2080](#2080),
[#2084](#2084),
[#2099](#2099),
[#2102](#2102),
[#2103](#2103),
[#2107](#2107),
[#2109](#2109),
[#2115](#2115),
[#2117](#2117),
[#2118](#2118),
[#2119](#2119),
[#2120](#2120),
[#2121](#2121),
[#2131](#2131),
[#2132](#2132),
[#2134](#2134),
[#2137](#2137),
[#2138](#2138),
[#2141](#2141),
[#2143](#2143),
[#2145](#2145),
[#2182](#2182)), by
@fengmk2 and @wan9chi
- Expose Vite+ managed binaries consistently inside snapshot fixtures
([#2110](#2110)), by
@liangmiQwQ
- Exclude PTY snapshot configuration from Vitest discovery and remove
the legacy snapshot infrastructure
([#2135](#2135),
[#2146](#2146)), by
@jong-kyung
- Modernize Windows runners, registry bridge publishing, native size
reporting, merge-base comparisons, and package-manager installation CI
([#2083](#2083),
[#2100](#2100),
[#2105](#2105),
[#2106](#2106),
[#2112](#2112),
[#2133](#2133)), by
@fengmk2
- Verify that created monorepo libraries emit declarations in CI
([#2171](#2171)), by
@wan9chi
### Bundled Versions
| Tool | Version | Source |
| --------------- | ------- |
-----------------------------------------------------------------------
|
| vite | `8.1.4` |
[`a477454`](vitejs/vite@a477454)
|
| rolldown | `1.1.5` |
[`f09947a`](rolldown/rolldown@f09947a)
|
| tsdown | `0.22.7` | [npm](https://npmx.dev/package/tsdown/v/0.22.7) |
| vitest | `4.1.10` | [npm](https://npmx.dev/package/vitest/v/4.1.10) |
| oxlint | `1.73.0` | [npm](https://npmx.dev/package/oxlint/v/1.73.0) |
| oxlint-tsgolint | `0.24.0` |
[npm](https://npmx.dev/package/oxlint-tsgolint/v/0.24.0) |
| oxfmt | `0.58.0` | [npm](https://npmx.dev/package/oxfmt/v/0.58.0) |
### Upgrade
```bash
vp upgrade
```
### New Contributors
Welcome @yukinoshi and @BlankParticle.
**Full Changelog**:
v0.2.4...v0.2.5
---
Merging this PR will trigger the release workflow.
---------
Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com>
Co-authored-by: wan9chi <dk4rest@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fengmk2@wan9chi