Skip to content

refactor(path): normalize AbsolutePath strip_prefix - #464

Merged
wan9chi merged 1 commit into
mainfrom
infra-strip-path-prefix-helper
Jun 14, 2026
Merged

refactor(path): normalize AbsolutePath strip_prefix#464
wan9chi merged 1 commit into
mainfrom
infra-strip-path-prefix-helper

Conversation

@wan9chi

@wan9chiwan9chi commented Jun 14, 2026

Copy link
Copy Markdown
Member

Motivation

The auto-output stack needs to compare runner-reported absolute paths with fspy paths even when Windows namespace prefixes differ. Keeping that OsStr-based prefix handling in fspy made the cache update fix duplicate platform-specific code.

This PR moves the shared prefix stripping into vite_path and folds that normalization into AbsolutePath::strip_prefix, so existing absolute-path prefix stripping handles Windows namespace prefixes consistently without adding a parallel AbsolutePath API.

@wan9chiwan9chi changed the title refactor(path): add shared strip_path_prefix helperrefactor(path): share path-prefix strippingJun 14, 2026
@wan9chi
wan9chiforce-pushed the infra-strip-path-prefix-helper branch 2 times, most recently from 0a4c11e to 3e8296cCompareJune 14, 2026 22:17
@wan9chiwan9chi changed the title refactor(path): share path-prefix strippingrefactor(path): normalize AbsolutePath strip_prefixJun 14, 2026
@wan9chi
wan9chiforce-pushed the infra-strip-path-prefix-helper branch from 3e8296c to ae8408cCompareJune 14, 2026 22:35
Co-authored-by: GPT-5 Codex <codex@openai.com>
@wan9chi
wan9chiforce-pushed the infra-strip-path-prefix-helper branch from ae8408c to d02ecb7CompareJune 14, 2026 22:41
@wan9chiGraphite App

wan9chi commented Jun 14, 2026

Copy link
Copy Markdown
MemberAuthor

Merge activity

  • Jun 14, 10:48 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 14, 10:48 PM UTC: @wan9chi merged this pull request with Graphite.

@wan9chi
wan9chi merged commit 949ca0c into mainJun 14, 2026
20 checks passed
@wan9chi
wan9chi deleted the infra-strip-path-prefix-helper branch June 14, 2026 22:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@wan9chi