Uh oh!
There was an error while loading. Please reload this page.
feat(cache): add explicit auto output tracking - #460
Conversation
a1c7046 to
729380cCompareThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:a1c7046148
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| &mut negative_globs, | ||
| )?; | ||
| } | ||
| UserOutputEntry::Auto(AutoInput { auto: true }) => includes_auto = true, |
There was a problem hiding this comment.
When an inherited SyntheticPlanRequest supplies output: [{ auto: true }], this new includes_auto value is resolved here but resolve_synthetic_cache_config still merges only positive_globs and negative_globs from synthetic_output (crates/vite_task_plan/src/plan.rs:521-535). In that nested-synthetic context the flag is dropped back to the parent output config (usually false), so fspy is not attached and the synthetic command's written outputs are never archived or restored despite opting into auto output tracking.
Useful? React with 👍 / 👎.
729380c to
cc9e8c7Compareed8d3c6 to
f83d812Comparecc9e8c7 to
64ed82bCompared843881 to
e1a8b45Compare64ed82b to
8a334a7Comparee1a8b45 to
e713ae3Compare8a334a7 to
6d2908cComparee713ae3 to
dcee0e6Compare6d2908c to
5eb76f5Comparedcee0e6 to
5d84636Compare5eb76f5 to
c34daebComparec47df41 to
02224e8Compare18d1416 to
4bb199dCompare4bb199d to
3e75f37Compare02224e8 to
521bb20Compare3e75f37 to
12e1a52CompareCo-authored-by: GPT-5 Codex <codex@openai.com>
12e1a52 to
a077de0CompareUh oh!
There was an error while loading. Please reload this page.
Motivation
Users should be able to ask the runner to archive files written by a task without manually maintaining output globs, while still keeping the default behavior unchanged for a small reviewable step.
Scope
Support
output: [{ auto: true }], attach fspy when explicit auto output tracking is requested, keep read and write filtering separate, and archive fspy-tracked writes after applying output negatives and runnerignoreOutputreports. Add an e2e withinput: []to prove explicit auto output tracking works on its own.