Uh oh!
There was an error while loading. Please reload this page.
Datafusion 52 upgrade - #5863
Merged
Merged
Conversation
AdamGSforce-pushed
the
adamg/df-52-wip
branch
2 times, most recently
from
January 5, 2026 19:40
72a86ec to
605888eCompareMerging this PR will improve performance by 13.48%
Performance Changes
Comparing  |
41 tasks
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
AdamGSforce-pushed
the
adamg/df-52-wip
branch
4 times, most recently
from
January 6, 2026 17:06
94a43db to
3384dcaCompareContributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
AdamGSforce-pushed
the
adamg/df-52-wip
branch
5 times, most recently
from
January 7, 2026 16:32
ca2adc8 to
d877c4eCompareAdamGS
commented
Jan 8, 2026
| )) | ||
| } | ||
| fn split_projection( |
ContributorAuthor
There was a problem hiding this comment.
I'm really unsure if this function should be part of the trait or just some internal implementation detail. I'm tempted to keep it out of the public API for now and see if anyone ever runs into needed to customize it.
AdamGSforce-pushed
the
adamg/df-52-wip
branch
3 times, most recently
from
January 13, 2026 11:18
ba02a0d to
670dc71CompareAdamGS
marked this pull request as ready for review
January 13, 2026 11:19
Closed
AdamGS added a commit
that referenced
this pull request
Jan 13, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
robert3005
approved these changes
Jan 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
danking pushed a commit
that referenced
this pull request
Feb 6, 2026
danking pushed a commit
that referenced
this pull request
Feb 6, 2026
This PR uses the current tip of DataFusion to test the upcoming upgrade. It drops the use of the `SchemaAdapter` API, removes the vendored code we pulled to fix some bugs and currently passes all of our tests! This PR requires at least one more round of polish, I'm sure I left some convoluted things in `opener.rs`. ~Waiting for the upstream release apache/datafusion#18566 --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the current tip of DataFusion to test the upcoming upgrade. It drops the use of the
SchemaAdapterAPI, removes the vendored code we pulled to fix some bugs and currently passes all of our tests!This PR requires at least one more round of polish, I'm sure I left some convoluted things in
opener.rs.Waiting for the upstream release apache/datafusion#18566