Skip to content

Support precision casting for DScalar - #5937

Merged
AdamGS merged 2 commits into
developfrom
adamg/support-dscalar-precision-casting
Jan 13, 2026
Merged

Support precision casting for DScalar#5937
AdamGS merged 2 commits into
developfrom
adamg/support-dscalar-precision-casting

Conversation

@AdamGS

@AdamGSAdamGS commented Jan 13, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This is a missing piece to support #5863

@AdamGS
Support precision casting for DScalar
c26db0d
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
AdamGSforce-pushed the adamg/support-dscalar-precision-casting branch from 1df34b8 to c26db0dCompareJanuary 13, 2026 15:25
@AdamGSAdamGS added the changelog/feature A new feature label Jan 13, 2026
@AdamGS
AdamGS marked this pull request as ready for review January 13, 2026 15:26
robert3005
robert3005 reviewed Jan 13, 2026
View reviewed changes
Comment threadvortex-compute/src/cast/dvector.rs
@AdamGS
Add i256
4f689ea
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
AdamGS enabled auto-merge (squash) January 13, 2026 15:35
@codecov

codecovBot commented Jan 13, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.38710% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.39%. Comparing base (5cd8b29) to head (4f689ea).
⚠️ Report is 1 commits behind head on develop.

Files with missing linesPatch %Lines
vortex-compute/src/cast/dvector.rs98.38%2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdamGS
AdamGS merged commit 65e7263 into developJan 13, 2026
47 of 48 checks passed
@AdamGS
AdamGS deleted the adamg/support-dscalar-precision-casting branch January 13, 2026 15:43
danking pushed a commit that referenced this pull request Feb 6, 2026
@AdamGS@danking
Support precision casting forDScalar(#5937)
47a18d1
This is a missing piece to support
#5863
---------
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005robert3005robert3005 approved these changes
@joseph-isaacsjoseph-isaacsjoseph-isaacs approved these changes
@connortsui20connortsui20Awaiting requested review from connortsui20

Assignees

No one assigned

Labels

changelog/featureA new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdamGS@robert3005@joseph-isaacs