chore: pin Node v24.20.0 in .nvmrc - #204
Merged
Merged
Conversation
v24.18.0 is no longer the version `nvm install 24` resolves to, so a fresh setup lands on 24.20.0 and the shim refuses to run against the pin. 24.20.0 bundles npm 11.19.0, so every "npm 11" claim in the docs still holds, and all four workflows read the version via `node-version-file: .nvmrc` and follow it automatically. Updates the two places that named the old version explicitly (AGENTS.md and the inlined Copilot instructions) so they cannot drift from the pin, and refreshes the release workflow's comment about npm lagging Node: the pinned 24.20.0 already clears the npm >= 11.5.1 floor Trusted Publishers needs, so `npm install -g npm@latest` is now a safeguard against the pin moving rather than a requirement. The step stays. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
.nvmrcpinned v24.18.0, which is no longer whatnvm install 24resolves to — a fresh setup lands on v24.20.0 and the nvm shim then refuses to run anything in this repo (Node.js v24.18.0 is not installed or cannot be found), which makesnode,npm testandnpm run build-tsall fail until the developer hunts down the exact old build.Safety
CI.yml,build.yml,bench.yml,release.yml) read the version vianode-version-file: ".nvmrc", so they follow the pin automatically — no workflow edit needed.README.mdsays "Node.js v24" generically anddocs/jsfeat-parity-and-refactor-audit.mdsets a floor of "≥ v20.18.0" — neither conflicts.What else changed, and why it had to change with it
Two files named the old version explicitly and would have silently contradicted the pin:
AGENTS.md— "Node: v24.18.0" → v24.20.0 (also reworded to "bundles npm 11", which is the accurate relationship)..github/copilot-instructions.md— same version string, inlined because Copilot injects that file directly.And one comment became misleading rather than wrong:
.github/workflows/release.yml— the note justifyingnpm install -g npm@latestcited "Node 24.18.0 ships npm 10.9.4" as its reason. The newly pinned 24.20.0 bundles npm 11.19.0, which already clears the npm ≥ 11.5.1 floor Trusted Publishers requires. The step stays — it is now a safeguard against the pin moving rather than a requirement — but the comment now says that instead of implying the bundled npm is too old.Note
Exact pinning is deliberate and worth keeping: it is what makes CI reproducible. The cost is exactly this maintenance —
nvm install 24tracks the latest 24.x, so the pin needs a bump whenever that moves and someone sets up fresh. Loosening.nvmrcto24would remove the chore at the price of CI silently changing Node under us.🤖 Generated with Claude Code