chore(release): bump version to 0.17.0 and rebuild dist - #207
Merged
Conversation
Phase A of the release runbook: version bump, lockfile regenerated with npm 11, dist/ + types/ rebuilt from source, and CHANGELOG.md's 0.17.0 section generated with git-cliff. Cut as a minor rather than a patch: fast_corners.detect now returns a different (larger) corner set for every image, so a patch number would understate it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase A of the release runbook in
MAINTAINERS.md. Phase B (promotedev→main, tag, publish) is left to the maintainer.Why 0.17.0 and not 0.16.1
fast_corners.detectnow returns a different, larger corner set for every image (#202). It is a bug fix, but any pipeline tuned against 0.16.0's output will see it shift. A patch number reads as "safe to bump blindly", which is not true here; in a 0.x line the minor is the honest signal.What's in it
fast_corners.detectper-row candidate buffer off-by-one — detect is now a pure function of its inputs and recovers the corners it was droppingbench/smoke check is not run bynpm test)Steps performed
package.json→0.17.0npx npm@11 install) — lockfile root andpackages[""]both confirmed at 0.17.0npm run build-ts→dist/jsfeatNext.js,dist/jsfeatNext.mjs,types/rebuilt and committednpx git-cliff --unreleased --tag 0.17.0 --prepend CHANGELOG.mdVerification
npm test— 356 passed, 28 filesnpm run bench:smoke— exit 0npm pack --dry-run— 43 files, 88.7 kB packed / 295.1 kB unpacked, version0.17.0prettier --check— cleandist/jsfeatNext.mjsand runningdetectagainst a pool poisoned with three different values returns an identical 33-corner set each time, confirming the fast_corners.detect reads uninitialised memory and drops each row's last corner #202 fix is present in the shipped bundle and thatdetectis pool-independent there.Note on the changelog entry
CHANGELOG.mdhad a hand-written## Unreleasedsection describing #202 in full prose. It was removed before running git-cliff so the entry would not be duplicated, and the generated section now follows the repo's usual git-cliff format (commit subject + hash) like every other release. The long-form explanation of the defect lives indocs/implementation-notes.mdand in #202.🤖 Generated with Claude Code