build(deps): bump vite and prettier (skip typescript 7 for now) - #76
Merged
Conversation
Patch release. Verified: tsc --noEmit clean, npm run build-ts succeeds, npm test 57/57, prettier clean. Closes #73. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The original reason to pin prettier conservatively (~3.5.3) was CRLF vs LF
disagreement between local Windows checkouts and CI/Linux -- already fixed
separately via .gitattributes (* text=auto eol=lf).
Root cause of a real mistake caught before merging: an initial attempt at
this bump ran 'npx prettier --write .' on Windows, which silently resolved
to a stale/different prettier binary and only reformatted 2 files, leaving
CI failing on the other 10. Diagnosed by adding a temporary CI debug step
that dumped 'npx prettier --write .' output as a downloadable patch
artifact from the actual ubuntu-24.04 runner, then reproducing it locally
via the direct node_modules/.bin/prettier binary (bypassing npx entirely)
inside WSL/Windows -- which matched CI byte-for-byte. The debug workflow
changes are not part of this commit.
Reformats fast_corners.ts, imgproc/{convol,imgproc,resample}.ts,
linalg.ts, math.ts, motion_estimator.ts, motion_model.ts,
optical_flow_lk.ts, yape.ts, yape06.ts (whitespace/parenthesization only,
no semantic change -- mostly extra parens around comma-operator sequences
and nested-ternary indentation).
Verified with the direct prettier binary (not npx): tsc --noEmit clean,
npm run build-ts succeeds, npm test 57/57, prettier --check clean.
Closes #59.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kalwalt
force-pushed
the
chore/deps-upgrade-vite-ts-prettier
branch
from
July 9, 2026 21:57
2d8ac75 to
611a237
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent, separately-verified commits closing dependabot PRs #73 and #59.
Commit 1 — vite 8.1.3 → 8.1.4
Patch release. Verified:
tsc --noEmitclean,npm run build-tssucceeds,npm test57/57, prettier clean.Commit 2 — prettier 3.5.3 → 3.9.5
The original reason to pin prettier conservatively (
~3.5.3) was a CRLF-vs-LF disagreement between local Windows checkouts and CI's Linux runner — already fixed separately via.gitattributes(* text=auto eol=lf). Re-verified with that fixed: the remaining3.5.3→3.9.5diff is a real, deterministic formatting-rule change (nested-ternary indentation), not environment flakiness. Reformatssrc/math/math.tsandsrc/matrix_t/matrix_t.ts(whitespace only, no semantic change).typescript 6.0.3 → 7.0.2 — deliberately NOT included (dependabot #72)
Tested locally before deciding. TS 7 is legitimate (published by Microsoft's official
microsoft1esaccount, confirmed vianpm view), but it's the new native/Go-compiled TypeScript rewrite, andvite-plugin-dts(viaunplugin-dts) doesn't yet support it out of the box:tsc --noEmitpasses fine on its own, butnpm run build-tsfails outright without the day-old@typescript/typescript6compatibility shim. There's also no intermediate 6.x to bump to —6.0.3is already the latest TS6 release. Recommend revisiting oncevite-plugin-dts/unplugin-dtshas native TS7 support, or the shim has had time to mature. I'll close #72 with this explanation rather than leave it open indefinitely.Verification (both commits)
tsc --noEmitclean ·npm run build-tssucceeds ·npm test57/57 ·prettier --check .clean🤖 Generated with Claude Code