Skip to content

build(deps): bump vite and prettier (skip typescript 7 for now) - #76

Merged
kalwalt merged 2 commits into
devfrom
chore/deps-upgrade-vite-ts-prettier
Jul 10, 2026
Merged

build(deps): bump vite and prettier (skip typescript 7 for now)#76
kalwalt merged 2 commits into
devfrom
chore/deps-upgrade-vite-ts-prettier

Conversation

@kalwalt

@kalwalt kalwalt commented Jul 9, 2026

Copy link
Copy Markdown
Member

Two independent, separately-verified commits closing dependabot PRs #73 and #59.

Commit 1 — vite 8.1.3 → 8.1.4

Patch release. Verified: tsc --noEmit clean, npm run build-ts succeeds, npm test 57/57, prettier clean.

Commit 2 — prettier 3.5.3 → 3.9.5

The original reason to pin prettier conservatively (~3.5.3) was a CRLF-vs-LF disagreement between local Windows checkouts and CI's Linux runner — already fixed separately via .gitattributes (* text=auto eol=lf). Re-verified with that fixed: the remaining 3.5.33.9.5 diff is a real, deterministic formatting-rule change (nested-ternary indentation), not environment flakiness. Reformats src/math/math.ts and src/matrix_t/matrix_t.ts (whitespace only, no semantic change).

typescript 6.0.3 → 7.0.2 — deliberately NOT included (dependabot #72)

Tested locally before deciding. TS 7 is legitimate (published by Microsoft's official microsoft1es account, confirmed via npm view), but it's the new native/Go-compiled TypeScript rewrite, and vite-plugin-dts (via unplugin-dts) doesn't yet support it out of the box:

Error: [unplugin-dts] The installed "typescript" package does not provide the
JavaScript Compiler API (this happens with TypeScript 7+)...
Please install it alongside TypeScript 7:
  npm install -D @typescript/typescript6

tsc --noEmit passes fine on its own, but npm run build-ts fails outright without the day-old @typescript/typescript6 compatibility shim. There's also no intermediate 6.x to bump to — 6.0.3 is already the latest TS6 release. Recommend revisiting once vite-plugin-dts/unplugin-dts has native TS7 support, or the shim has had time to mature. I'll close #72 with this explanation rather than leave it open indefinitely.

Verification (both commits)

tsc --noEmit clean · npm run build-ts succeeds · npm test 57/57 · prettier --check . clean

🤖 Generated with Claude Code

Patch release. Verified: tsc --noEmit clean, npm run build-ts succeeds,
npm test 57/57, prettier clean.

Closes #73.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@kalwalt kalwalt added this to the Parity & Modernization milestone Jul 9, 2026
@kalwalt kalwalt self-assigned this Jul 9, 2026
@kalwalt kalwalt added enhancement New feature or request dependencies Pull requests that update a dependency file npm Vite bundler labels Jul 9, 2026
The original reason to pin prettier conservatively (~3.5.3) was CRLF vs LF
disagreement between local Windows checkouts and CI/Linux -- already fixed
separately via .gitattributes (* text=auto eol=lf).

Root cause of a real mistake caught before merging: an initial attempt at
this bump ran 'npx prettier --write .' on Windows, which silently resolved
to a stale/different prettier binary and only reformatted 2 files, leaving
CI failing on the other 10. Diagnosed by adding a temporary CI debug step
that dumped 'npx prettier --write .' output as a downloadable patch
artifact from the actual ubuntu-24.04 runner, then reproducing it locally
via the direct node_modules/.bin/prettier binary (bypassing npx entirely)
inside WSL/Windows -- which matched CI byte-for-byte. The debug workflow
changes are not part of this commit.

Reformats fast_corners.ts, imgproc/{convol,imgproc,resample}.ts,
linalg.ts, math.ts, motion_estimator.ts, motion_model.ts,
optical_flow_lk.ts, yape.ts, yape06.ts (whitespace/parenthesization only,
no semantic change -- mostly extra parens around comma-operator sequences
and nested-ternary indentation).

Verified with the direct prettier binary (not npx): tsc --noEmit clean,
npm run build-ts succeeds, npm test 57/57, prettier --check clean.

Closes #59.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@kalwalt
kalwalt force-pushed the chore/deps-upgrade-vite-ts-prettier branch from 2d8ac75 to 611a237 Compare July 9, 2026 21:57
@kalwalt
kalwalt merged commit 36732a1 into dev Jul 10, 2026
4 checks passed
@kalwalt
kalwalt deleted the chore/deps-upgrade-vite-ts-prettier branch July 10, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request npm Vite bundler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant