Uh oh!
There was an error while loading. Please reload this page.
feat(client): introduce core-js - #1950
Conversation
| 'use strict'; | ||
| require('core-js/features/string/includes'); | ||
| require('core-js/features/array/includes'); |
There was a problem hiding this comment.
We pollute global namespace 😞 We should use named import like in docs https://github.com/zloirock/core-js
There was a problem hiding this comment.
Maybe we need setup support import/export in our babel config for client too
There was a problem hiding this comment.
Using require('core-js/features/array/includes'); modify Array.prototype, so if developer already have modified Array.prototype we break can break their app. Using import arrayIncludes from 'core-js/features/array/includes' doesn't modify Array.prototype so it is safe to use
There was a problem hiding this comment.
Makes sense. ok, I'll change
Because opn was renamed to open.
ddfff11 to
3ea39adCompare@evilebottnawi updated, PTAL |
Codecov Report
@@ Coverage Diff @@## next #1950 +/- ##
==========================================
+ Coverage 92.61% 92.62% +0.01%
==========================================
Files 29 30 +1 Lines 1124 1126 +2 Branches 325 325 ==========================================
+ Hits 1041 1043 +2
Misses 79 79 Partials 4 4
Continue to review full report at Codecov.
|
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good! Before merge please manually check what we don't modify global built-in (just looks in client and this file should not have any String.prototype or Array.prototype)
589bbdf to
eeb3fd2Comparef469dc3 to
534dedeCompare148dfd5 to
d0893f1Comparehiroppy
commented
Dec 5, 2019
I'll create other new pr. |
For Bugs and Features; did you add new tests?
modify only
Motivation / Use-Case
#1948 (comment)
Breaking Changes
no
Additional Info