Uh oh!
There was an error while loading. Please reload this page.
feat: pair Testbench with Laravel version - #29
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the reusable GitHub Actions workflow to derive the orchestra/testbench version from the selected Laravel version in the matrix, preventing invalid Laravel/Testbench cross-product combinations when testing multiple Laravel majors.
Changes:
- Removes
testbenchfrom the strategy matrix (no longer sourced frominputs.testbench-versions). - Adds a shell
casemapping frommatrix.laravelto an appropriate Testbench constraint and uses it duringcomposer require.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
1b84422 to
374fafeCompare09c9b45 to
bde1760Compareictbeheer
commented
Sep 1, 2026
@SimonvanWijhe en @rivanuff ik zou dit juist minder complex willen maken. Is dit alleen nodig om Acorn 4 compatibiliteit te behouden? Kunnen we het anders niet afkijken van spatie: https://github.com/spatie/laravel-data/actions/runs/33497179425/workflow |
292d241 to
e50e179Comparee50e179 to
57b69dfCompare
Derives orchestra/testbench from the Laravel matrix value (L10->8, L11->9, L12->10) so consumers can test multiple Laravel majors without invalid cross-product combos. Backward compatible: existing single-value callers resolve to the same pair. The testbench-versions input remains declared but unused.
Update: both
run-laravel-testbench-tests.ymlandrun-pest-tests.ymlnow derive the PHP matrix fromcomposer.jsonviatypisttech/php-matrix-action, and cover the dependency range viacomposer update(highest) vscomposer update --prefer-lowest(lowest) instead of pinning explicit Laravel/testbench combinations. Thephp-versions,laravel-versions, andtestbench-versionsinputs are now deprecated/ignored (kept for backward compatibility). The two workflows have converged on the same job structure.