Uh oh!
There was an error while loading. Please reload this page.
feat: Acorn 5 / Laravel 12 support (retains Acorn 4 / Laravel 10 & 11) - #98
Open
rivanuff wants to merge 4 commits into
Open
feat: Acorn 5 / Laravel 12 support (retains Acorn 4 / Laravel 10 & 11)#98rivanuff wants to merge 4 commits into
rivanuff wants to merge 4 commits into
Conversation
BREAKING CHANGE: drops Laravel 10 support; requires roots/acorn ^5.0 and PHP >=8.2.
Coverage report for commit: 5656853 Summary - Lines:9.89% | Methods:7.27%
🤖 comment via lucassabreu/comment-coverage-clover | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
rivanuff
marked this pull request as ready for review
September 1, 2026 14:43
rivanuff
requested review from
Rovasch, ShunLuk, SimonvanWijhe, dtakken, ictbeheer and mvdhoek1
and
a lite review from Copilot
and removed request for
Rovasch, ShunLuk, SimonvanWijhe, dtakken, ictbeheer and mvdhoek1September 1, 2026 14:43
There was a problem hiding this comment.
Pull request overview
Adds backward-compatible dependency and CI updates so this package can be installed and tested against Acorn 5 / Laravel 12 while retaining compatibility with Acorn 4 / Laravel 10–11.
Changes:
- Widened Composer runtime and dev dependency version constraints to cover newer supported versions (including Laravel 12 tooling).
- Expanded GitHub Actions test matrix inputs to include Laravel 12 and PHP 8.2/8.3.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| composer.json | Broadens dependency constraints (runtime + dev) to support newer Laravel/Acorn toolchains. |
| .github/workflows/run-tests.yml | Updates CI reusable-workflow inputs to test Laravel 10/11/12 across PHP 8.2/8.3. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+16
to
+18
| with: | ||
| php-versions: '["8.2","8.3"]' | ||
| laravel-versions: '["10.*","11.*","12.*"]' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acorn 5 / Laravel 12 support — backward compatible
Adds support for Acorn 5 / Laravel 12 while retaining Acorn 4 / Laravel 10 & 11. This is a backward-compatible change.
Target release:
v1.6.0(minor).composer.jsonconstraints so the package installs on Laravel 10, 11 and 12 (Acorn 4 or 5 where applicable), and widened the dev toolchain (orchestra/testbench,pestphp/pest,larastan/larastan,szepeviktor/phpstan-wordpress) to span those versions.