Skip to content

refactor(example): enhance example for public inputs validation - #1195

Closed
IAvecilla wants to merge 23 commits into
testnetfrom
1132-add-public-input-example
Closed

refactor(example): enhance example for public inputs validation#1195
IAvecilla wants to merge 23 commits into
testnetfrom
1132-add-public-input-example

Conversation

@IAvecilla

@IAvecillaIAvecilla commented Oct 7, 2024•
edited by uri-99
Loading

Copy link
Copy Markdown
Contributor

Caution

Content of thi PR is OK but we had to make another branch.
the new PR is this one

Update the public input validation example to support both SP1 and Risc0 implementations. Additionally, improve the steps and documentation to make it easier to follow and execute.

How to test

You can test it locally following the commands in examples/validating-public-input/README.md or use holesky following the official documentation in docs/guides/3_validating_public_input.md.

@IAvecillaIAvecilla linked an issue Oct 7, 2024 that may be closed by this pull request
Add examples #1132
Closed
@IAvecillaIAvecilla self-assigned this Oct 7, 2024
@uri-99
uri-99 changed the base branch from testnet to stagingOctober 9, 2024 00:06
@uri-99
uri-99force-pushed the 1132-add-public-input-example branch from d8c1b3b to 334468fCompareOctober 9, 2024 00:35
@uri-99
uri-99 changed the base branch from staging to testnetOctober 9, 2024 00:36
uri-99
uri-99 suggested changes Oct 9, 2024
View reviewed changes

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should this PR be pointed at testnet?

Comment threaddocs/3_guides/3_validating_public_input.md Outdated
Comment threaddocs/3_guides/3_validating_public_input.md Outdated
Comment threaddocs/3_guides/3_validating_public_input.md Outdated
Comment threadexamples/validating-public-input/Makefile Outdated
Comment threadexamples/validating-public-input/Makefile Outdated
Comment threadexamples/validating-public-input/README.md Outdated
Comment threadexamples/validating-public-input/README.md Outdated
Comment threadexamples/validating-public-input/contracts/validate_batch_inclusion.sh Outdated
Comment threadexamples/validating-public-input/README.md
@uri-99uri-99 changed the title docs: enhance example for public inputs validationrefactor(example): enhance example for public inputs validationOct 9, 2024
uri-99
uri-99 suggested changes Oct 9, 2024
View reviewed changes

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single proofs emitted will not get included in a batch, so in devnet it is necesarry to send more proofs in parallel. We should add this detail in the docs since this PR is going to testnet.
After this it is an approve

@IAvecilla
IAvecilla requested a review from uri-99October 9, 2024 19:04
MauroToscanoand others added 3 commits October 13, 2024 10:55
@MauroToscano
Pull fixes from testnet (#1231)
4478256
@uri-99@IAvecilla@MauroToscano
Add observability batcher (#1226)
ba04f04
Co-authored-by: IAvecilla <ignacio.avecilla@lambdaclass.com>
Co-authored-by: MauroFab <maurotoscano2@gmail.com>
@JuArce
docs: update version to v0.9.1 (#1233)
73e0481
@uri-99
uri-99 marked this pull request as draft October 14, 2024 20:20
@uri-99uri-99 mentioned this pull request Oct 14, 2024
Merged
@uri-99

uri-99 commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Closing this PR because it is being solved in this other rebased PR

@uri-99uri-99 closed this Oct 14, 2024
@JuArce
JuArce deleted the 1132-add-public-input-example branch January 2, 2025 15:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uri-99uri-99Awaiting requested review from uri-99
1 more reviewer
@PatStilesPatStilesPatStiles approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@IAvecillaIAvecilla

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add examples

5 participants

@IAvecilla@uri-99@PatStiles@MauroToscano@JuArce