Skip to content

refactor(example): enhance example for public inputs validation 2 - #1245

Merged
MauroToscano merged 28 commits into
testnetfrom
removing-staging-from-validating-pub-inputs
Nov 5, 2024
Merged

refactor(example): enhance example for public inputs validation 2#1245
MauroToscano merged 28 commits into
testnetfrom
removing-staging-from-validating-pub-inputs

Conversation

@uri-99

@uri-99uri-99 commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Note

This PR comes from a rebase of the original branch solving this issue
Original PR is this one
This branch will be merged and not the other one, to avoid git history conflicts

Update the public input validation example to support both SP1 and Risc0 implementations. Additionally, improve the steps and documentation to make it easier to follow and execute.

How to test

You can test it locally following the commands in examples/validating-public-input/README.md or use holesky following the official documentation in docs/guides/3_validating_public_input.md.

@uri-99uri-99 changed the title fix: Removing staging from validating pub inputsrefactor(example): enhance example for public inputs validation 2Oct 14, 2024
@uri-99
uri-99 marked this pull request as ready for review October 14, 2024 20:22
@JulianVentura

Copy link
Copy Markdown
Contributor

After deleting the file sp1_fibonacci.elf if I run the command make generate_sp1_fibonacci_proof the execution fails because it's missing that file. Same happens if I execute cargo build on sp1/fibonacci/script directory. Seems the build.rs is not being executed for some reason.

@IAvecilla

Copy link
Copy Markdown
Contributor

@JulianVentura It should be already fixed, the build.rs should run everytime now without the need of cleaning or building all the dependencies again.

Comment threadexamples/validating-public-input/sp1/fibonacci/program/Cargo.toml Outdated
Comment threadexamples/validating-public-input/sp1/fibonacci/lib/src/lib.rs Outdated
Comment threadexamples/validating-public-input/sp1/fibonacci/lib/Cargo.toml Outdated
Comment threadexamples/validating-public-input/sp1/fibonacci/Cargo.toml Outdated
Comment threadexamples/validating-public-input/README.md Outdated

@OppenOppen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Haven't tested it tho.

@JuArceJuArce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to finish the review later

Comment threadbatcher/aligned-sdk/src/core/types.rs Outdated
Comment threaddocs/3_guides/3_validating_public_input.md Outdated
Comment threaddocs/3_guides/3_validating_public_input.md Outdated
@uri-99
uri-99 requested a review from JuArceOctober 22, 2024 17:37
@MarcosNicolau
MarcosNicolauforce-pushed the removing-staging-from-validating-pub-inputs branch from c79adde to 6bb9fb5CompareOctober 24, 2024 16:45
@yetanothercoyetanotherco deleted a comment from github-actionsBotOct 24, 2024

@MarcosNicolauMarcosNicolau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comments, everything worked fine.

Comment threadexamples/validating-public-input/README.md Outdated
Comment threadexamples/validating-public-input/Makefile
Comment threadexamples/validating-public-input/README.md Outdated
@MauroToscano
MauroToscano merged commit 8f3c68d into testnetNov 5, 2024
@MauroToscano
MauroToscano deleted the removing-staging-from-validating-pub-inputs branch November 5, 2024 17:53
PatStiles pushed a commit that referenced this pull request Nov 6, 2024
)
Co-authored-by: IAvecilla <ignacio.avecilla@lambdaclass.com>
Co-authored-by: Mario Rugiero <mrugiero@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@uri-99@JulianVentura@IAvecilla@Oppen@PatStiles@JuArce@MarcosNicolau@MauroToscano