feat(aggregation): have constant costs proof sending

[maximopalopoli]

Description

Description of the pull request changes and motivation.

How to test

Unit test

You can run the unit test cases with:

make proof_aggregator_test_without_compiling_agg_programs

This target avoids recompiling for the tests when the aggregation programs are already compiled (to be used when the programs are not being tested).

Ethereum package

Another way to test this is to test the proof aggregation service, which can be done in the following way:

1. Start Ethereum package:

make ethereum_package_start

2. Start batcher:

make batcher_start_ethereum_package

3. Send SP1 and Risc0 proofs:

make batcher_send_sp1_burst BURST_SIZE=1
make batcher_send_risc0_burst BURST_SIZE=1

4. Run proof aggregator for SP1 and RISC0:

make proof_aggregator_start AGGREGATOR=sp1
make proof_aggregator_start AGGREGATOR=risc0

5. Verify the proofs have been aggregated:

make verify_aggregated_proof_sp1 FROM_BLOCK=0
make verify_aggregated_proof_risc0 FROM_BLOCK=0

Submission skipping with anvil

To test that the proof is skipped when the gas cost is too high, you should use Anvil to test, following these steps:

1. Start the anvil node:

make anvil_start

2. Start the batcher:

make batcher_start_local ENVIRONMENT=devnet

3. Send a proof to the batcher:

make batcher_send_sp1_burst BURST_SIZE=1

4. Start the proof aggregator:

make proof_aggregator_start AGGREGATOR=sp1

5. Before the proof is sent, increase the base gas cost by making a post to the anvil node:

curl -s http://localhost:8545/ -H "Content-Type: application/json" -d '{ "jsonrpc":"2.0","id":1, "method":"anvil_setNextBlockBaseFeePerGas", "params":["0xffffffff000"] }'

You should see the log Skipping sending proof to ProofAggregationService contract due to budget/time constraints..
The proof submission to the contract will fail because the anvil node does not work for the Fusaka fork, but with these steps, we were testing that the skipping works.

Type of change

Please delete options that are not relevant.

• New feature
• Bug fix
• Optimization
• Refactor

Checklist

• “Hotfix” to testnet, everything else to staging
• Linked to Github Issue
• This change depends on code or research by an external entity
  • Acknowledgements were updated to give credit
• Unit tests added
• This change requires new documentation.
  • Documentation has been added/updated.
• This change is an Optimization
  • Benchmarks added/run
• Has a known issue
  • Link to the open issue addressing it
• If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
  • This PR adds compatibility for operator for both versions and do not change crates/docs/examples
  • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

[MarcosNicolau]

Suggested change

	pubfn new_for_testing(config:&Config) -> Self{
	let rpc_url = config.eth_rpc_url.parse().expect("RPC URL should be valid");
	let rpc_provider = ProviderBuilder::new().connect_http(rpc_url);
	let aligned_service_manager = AlignedLayerServiceManager::new(
	Address::from_str(&config.aligned_service_manager_address)
	.expect("AlignedProofAggregationService address should be valid"),
	rpc_provider.clone(),
	);
	let last_aggregated_block = 0;
	Self{
	rpc_provider,
	aligned_service_manager,
	last_aggregated_block,
	}
	}
	pubfn new_for_testing(config:&Config) -> Self{
	letmut proof_fetcher = self.new();
	proof_fetcher.last_aggregated_block = 0;
	proof_fetcher
	}

[maximopalopoli]

This is done this way to avoid having to read from the files, which was causing conflicts in the CI. Instead of reading from the file we just set it to zero (since it isn’t important for what we’re testing). If we call the other constructor, then we’ll get the error that led us to create this new_for_testing in the first place.

[MarcosNicolau]

I would move this to a function: should_skip_build() -> bool

[maximopalopoli]

Done in 675540b