Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 401
feat(aggregation): have constant costs proof sending#2179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
c20832e839283a77fbb7c560c1307316cb7b65538ab7dba3d6c60fd1b8d32eed9595c0073eee7eb9d4817260821007d2c58b058114edca4824244d04450ac1d0bf1e14986c423364963bdacfc6d51ca2f79a817d7a391f87a5a5a3c1cd90a569d0062da166b8ae4e77329c65dcf219bd893209d616fe62d94b40524be68aacf3b44c26601543b94eeef7ab6bee4cc13e9ae7e5ab46aa1a2aa18d6e67363a211e3f675540bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -33,6 +33,25 @@ pub struct ProofsFetcher { | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
| impl ProofsFetcher { | ||||||||||||||||||||||||||||||||||||||||||||||
| #[cfg(test)] | ||||||||||||||||||||||||||||||||||||||||||||||
| pub fn new_for_testing(config: &Config) -> Self { | ||||||||||||||||||||||||||||||||||||||||||||||
| let rpc_url = config.eth_rpc_url.parse().expect("RPC URL should be valid"); | ||||||||||||||||||||||||||||||||||||||||||||||
| let rpc_provider = ProviderBuilder::new().connect_http(rpc_url); | ||||||||||||||||||||||||||||||||||||||||||||||
| let aligned_service_manager = AlignedLayerServiceManager::new( | ||||||||||||||||||||||||||||||||||||||||||||||
| Address::from_str(&config.aligned_service_manager_address) | ||||||||||||||||||||||||||||||||||||||||||||||
| .expect("AlignedProofAggregationService address should be valid"), | ||||||||||||||||||||||||||||||||||||||||||||||
| rpc_provider.clone(), | ||||||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||||||
| let last_aggregated_block = 0; | ||||||||||||||||||||||||||||||||||||||||||||||
| Self { | ||||||||||||||||||||||||||||||||||||||||||||||
| rpc_provider, | ||||||||||||||||||||||||||||||||||||||||||||||
| aligned_service_manager, | ||||||||||||||||||||||||||||||||||||||||||||||
| last_aggregated_block, | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+37
to
+53
Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is done this way to avoid having to read from the files, which was causing conflicts in the CI. Instead of reading from the file we just set it to zero (since it isn’t important for what we’re testing). If we call the other constructor, then we’ll get the error that led us to create this new_for_testing in the first place. | ||||||||||||||||||||||||||||||||||||||||||||||
| pub fn new(config: &Config) -> Self { | ||||||||||||||||||||||||||||||||||||||||||||||
| let rpc_url = config.eth_rpc_url.parse().expect("RPC URL should be valid"); | ||||||||||||||||||||||||||||||||||||||||||||||
| let rpc_provider = ProviderBuilder::new().connect_http(rpc_url); | ||||||||||||||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this to a function:
should_skip_build() -> boolThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 675540b