You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Users can now specify a max fee for a certain task. They sign this max fee, the contract then verifies that what the fee the batcher set * tx gas price is less than that max fee.
The batcher builds the batch putting the highest max fees first, but making it as big as possible without making it invalid (adding a fee that was too low).
The batcher also checks that a single user has not specified a bigger max fee for a bigger nonce, since this would cause the greater nonce to be sent first.
The batcher allows a user to replace a pending task by specifying the same nonce and a bigger fee. To prevent issues with this, the batcher checks that there is not a smaller nonce with a smaller fee (same as when adding a new task).
To send a task with a specific max_fee and nonce run in the batcher/aligned dir:
Note that if you don't specify a nonce it will fetch from disk cache / rpc and if you don't specify a max fee, it has a default.
Also note that you will need a funded account for this, since if not the batcher will just replace max fee and nonce. To fund that private key you can run:
The reason will be displayed to describe this comment to others. Learn more.
Should the Batcher close the first connection with a client if a proof is sent again with same nonce and bigger fee?
Its odd if a user has many open connections with the same nonce.
The reason will be displayed to describe this comment to others. Learn more.
Considering this PR adds informing different errors to the client (invalid fee, invalid nonce, etc), reverted txs should also be informed to the client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can now specify a max fee for a certain task. They sign this max fee, the contract then verifies that what the fee the batcher set * tx gas price is less than that max fee.
The batcher builds the batch putting the highest max fees first, but making it as big as possible without making it invalid (adding a fee that was too low).
The batcher also checks that a single user has not specified a bigger max fee for a bigger nonce, since this would cause the greater nonce to be sent first.
The batcher allows a user to replace a pending task by specifying the same nonce and a bigger fee. To prevent issues with this, the batcher checks that there is not a smaller nonce with a smaller fee (same as when adding a new task).
To send a task with a specific max_fee and nonce run in the
batcher/aligneddir:Note that if you don't specify a nonce it will fetch from disk cache / rpc and if you don't specify a max fee, it has a default.
Also note that you will need a funded account for this, since if not the batcher will just replace max fee and nonce. To fund that private key you can run: