Skip to content

feat(DEN-2725): route root gitops commands safely on current main - #242

Merged
ORESoftware merged 1 commit into
mainfrom
feat/den-2725-root-gitops-current-main-v2
Aug 8, 2026
Merged

feat(DEN-2725): route root gitops commands safely on current main#242
ORESoftware merged 1 commit into
mainfrom
feat/den-2725-root-gitops-current-main-v2

Conversation

@ORESoftware

@ORESoftwareORESoftware commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Scope

Current-main root zed gitops dispatcher, replayed without changing its behavior after the independently certified offline tool-profile slice merged.

Exact parent:

de774cc9fc5b786d85e9b5ff19251675f0e9391b

Exact candidate head:

8eb8e31fe719ca598961a98bd139ef99ac905e8e

Behavior

  • zed gitops ... delegates only to the trusted sibling executable zed-gitops next to the running zed binary.
  • No ambient PATH search is used for the delegated command.
  • Recursion into the same executable is rejected.
  • Missing or non-executable sibling commands fail visibly.
  • The child receives the caller's arguments and exit status without shell interpretation.
  • Root help and shell completions advertise the command.
  • The package graph validator and package manifest include the reviewed GitOps binary contract.

Changed files

  • .zpkg.toml
  • docs/gitops-validator.md
  • scripts/validate-zed-package-graph.sh
  • src/completion.rs
  • src/external_subcommands.rs
  • src/lib.rs
  • src/main.rs
  • tests/external_gitops_dispatch.rs

The only overlapping integration with the newly merged offline tool-profile slice is src/lib.rs. The current candidate preserves pub mod tool_profile; and adds only pub mod external_subcommands;. No task-runtime, inspect-JSON, SOPS ciphertext/configuration, native-registry, release, dependency, lockfile, tool-profile implementation, or workflow files are changed.

Validation

cargo fmt --all -- --check
cargo clippy --all-targets --all-features --locked -- -D warnings
cargo test --all-targets --all-features --locked
cargo test --locked --test external_gitops_dispatch
bash scripts/validate-zed-package-graph.sh

The focused integration test covers sibling selection, argument forwarding, exit-code propagation, missing executable behavior, recursion rejection, and root help/completion visibility.

Coordination and evidence

This PR remains draft until the new exact-head product and test-org matrices are terminal and review threads are clear.

@linear-code

Copy link
Copy Markdown

DEN-2725

@ORESoftware
ORESoftwareforce-pushed the feat/den-2725-root-gitops-current-main-v2 branch from 173bab4 to 17fe649CompareAugust 8, 2026 15:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ORESoftware