Uh oh!
There was an error while loading. Please reload this page.
fix(windows): flush binary host views with writable handles - #275
Merged
Conversation
Windows FlushFileBuffers rejects read-only file handles. Reopen staged host-view files with write access only on Windows before sync_all, preserving the existing Unix durability path and atomic publication semantics.
ORESoftware
marked this pull request as ready for review
August 14, 2026 19:52
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows portability job on current
mainpasses compilation and reaches the binary host-layout tests, then fails all three materialization tests withAccess is denied (os error 5).The failure occurs before atomic publication in
sync_tree_files: WindowsFlushFileBuffersrejects the read-only handle returned byFile::open.Fix
Use a write-capable handle only on Windows when calling
sync_all. Retain the existing read-only flush path on non-Windows targets.This does not write or mutate file contents. It only gives the Windows handle the access required to flush the already-written staged file before the existing no-clobber rename.
Validation
cargo fmt --all -- --checkgit diff --checkcargo check --locked --all-targetscargo clippy --locked --all-targets -- -D warningsFollow-up to #266 and Linear DEN-3495.