Uh oh!
There was an error while loading. Please reload this page.
fix: keep secure auth file mode warning-free on Windows - #92
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The static mise certification matrix uncovered a Windows-only Clippy failure in current
main:secure_file_modeuses its path only inside#[cfg(unix)], so Windows builds see an unused parameter and fail undercargo clippy -- -D warnings.Fix
Rename the parameter to
_pathand use that name in the Unix-only permission branch. Runtime behavior is unchanged on every platform:0600to the same path.Validation
This is intentionally a one-file, two-token semantic change. Existing repository workflows plus the Ubuntu/macOS/Windows static mise matrix remain the merge gates. Static mise PR #91 will stack this fix before its final immutable E2E pin.
Found by: zed-pkg-test/zed-pkg-e2e#7
Related static CLI: #91
Linear: DEN-1439, DEN-1449