Skip to content

fix: keep secure auth file mode warning-free on Windows - #92

Merged
ORESoftware merged 1 commit into
mainfrom
fix/windows-auth-secure-file-mode
Aug 4, 2026
Merged

fix: keep secure auth file mode warning-free on Windows#92
ORESoftware merged 1 commit into
mainfrom
fix/windows-auth-secure-file-mode

Conversation

@ORESoftware

Copy link
Copy Markdown
Contributor

Problem

The static mise certification matrix uncovered a Windows-only Clippy failure in current main:

src/auth.rs:899:21: unused variable: `path`

secure_file_mode uses its path only inside #[cfg(unix)], so Windows builds see an unused parameter and fail under cargo clippy -- -D warnings.

Fix

Rename the parameter to _path and use that name in the Unix-only permission branch. Runtime behavior is unchanged on every platform:

  • Unix still applies mode 0600 to the same path.
  • Non-Unix still performs no permission mutation and returns success.
  • Windows Clippy no longer reports an unused variable.

Validation

This is intentionally a one-file, two-token semantic change. Existing repository workflows plus the Ubuntu/macOS/Windows static mise matrix remain the merge gates. Static mise PR #91 will stack this fix before its final immutable E2E pin.

Found by: zed-pkg-test/zed-pkg-e2e#7
Related static CLI: #91
Linear: DEN-1439, DEN-1449

@ORESoftware
ORESoftware merged commit 2203538 into mainAug 4, 2026
27 checks passed
@linear-code

Copy link
Copy Markdown

DEN-1605

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ORESoftware