Skip to content

Added ONNXRuntime as dependency - #13

Merged
jgrosseo merged 1 commit into
AliceO2Group:masterfrom
saganatt:onnxruntime
Aug 19, 2021
Merged

Added ONNXRuntime as dependency#13
jgrosseo merged 1 commit into
AliceO2Group:masterfrom
saganatt:onnxruntime

Conversation

@saganatt

@saganattsaganatt commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

Requires alidist from alisw/alidist#3197

@saganatt
saganatt requested review from a team and jgrosseo as code ownersJuly 29, 2021 06:38
@saganattsaganatt mentioned this pull request Jul 29, 2021
Closed
@jgrosseo

jgrosseo commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

@saganatt Are you sure you wanted to merge this into O2Physics and not O2?

@saganatt

saganatt commented Jul 29, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Well, @ktf told me to merge in O2Physics and not O2, I had previously a PR for O2...

For now we use ONNXRuntime only in analysis tasks, so it might actually make sense...?

@jgrosseo

jgrosseo commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

OK, then it is fine. It is just that we will not use O2Physics until end August for tasks. So you cannot yet use it.

@jgrosseo

jgrosseo commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

Is the change in alidist already in? Can you link the PR here?

@saganatt

saganatt commented Jul 29, 2021

Copy link
Copy Markdown
CollaboratorAuthor

OK, but the users can still run O2Physics locally?

alidist PR is here: alisw/alidist#3197

@jgrosseo

jgrosseo commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

OK, but the users can still run O2Physics locally?

Not really. Mid August we will move all tasks from O2 to O2Physics. Until then nothing should be added here (except for testing)

@saganatt

saganatt commented Jul 29, 2021

Copy link
Copy Markdown
CollaboratorAuthor

OK, anyways, merging to O2 just for a month neither wouldn't make sense.
So till that time we will manage on my forks, and let's come back to these PRs at the end of August.

@jgrosseo

jgrosseo commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

Sounds good.

As soon as the alidist is merged, we can merge this PR as well. We should just not add the tasks yet.
Can you ping me when alidist is done?

@saganatt

saganatt commented Jul 29, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Yes, thanks, cool! That'd already make the task running easier for the others.

@saganatt

saganatt commented Aug 15, 2021

Copy link
Copy Markdown
CollaboratorAuthor

As soon as the alidist is merged, we can merge this PR as well. We should just not add the tasks yet.
Can you ping me when alidist is done?

Hi @jgrosseo ,
the alidist PR has just been merged.

@ktf
ktf self-requested a review August 17, 2021 13:38
ktf
ktf approved these changes Aug 17, 2021
View reviewed changes

@ktfktf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for tests. (First time contributors are not automatically tested).

@TimoWilkenTimoWilken mentioned this pull request Aug 18, 2021
Merged
@jgrosseo
jgrosseo merged commit 5cb7cc8 into AliceO2Group:masterAug 19, 2021
@saganatt
saganatt deleted the onnxruntime branch August 24, 2021 14:28
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 4, 2022
@ddobrigk
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-1581
ec7b4cb
Please consider the following formatting changes to AliceO2Group#1581
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Apr 4, 2023
@ZFederica
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-2310
9a4809f
Please consider the following formatting changes to AliceO2Group#2310
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request May 25, 2023
@atavirag
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-2479
740b15f
Please consider the following formatting changes to AliceO2Group#2479
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Jul 13, 2023
@RafRaf11
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-3005
4a8478c
Please consider the following formatting changes to AliceO2Group#3005
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 24, 2023
@nepeivodaRS
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-3256
98e2d8d
Please consider the following formatting changes to AliceO2Group#3256
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Sep 27, 2023
@yashpatley
Merge pull requestAliceO2Group#13from yashpatley/yashpatley-patch-4
3d74b1f
Update collisionCuts.h
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Jan 5, 2024
@fkrizek
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-4240
fb666cf
Please consider the following formatting changes to AliceO2Group#4240
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Feb 14, 2024
@maciacco
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-4716
7b30c76
Please consider the following formatting changes to AliceO2Group#4716
jezwilkinson pushed a commit to jezwilkinson/O2Physics that referenced this pull request Feb 23, 2024
@ChSonnabend
Merge pull requestAliceO2Group#13from jezwilkinson/TuneOnData
818b534
Restructuring for TPC TuneOnData
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Feb 26, 2024
@rolavick
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-4778
1a65eed
Please consider the following formatting changes to AliceO2Group#4778
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Apr 16, 2024
@Simple-Shyam
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-4510
9a939ce
Please consider the following formatting changes to AliceO2Group#4510
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request May 29, 2024
@mapalhares
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-6329
b78a3fa
Please consider the following formatting changes to AliceO2Group#6329
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Sep 27, 2024
@Yunfan-Liu
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-7808
298577a
Please consider the following formatting changes to AliceO2Group#7808
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Oct 24, 2024
@cnkoster
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-8136
182a589
Please consider the following formatting changes to AliceO2Group#8136
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Nov 14, 2024
@ljoergen
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-8435
7ed6268
Please consider the following formatting changes to AliceO2Group#8435
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 4, 2024
@alibuild
Please consider the following formatting changes (AliceO2Group#13)
45dff7f
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 14, 2024
@scattaru
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-8997
56f5255
Please consider the following formatting changes to AliceO2Group#8997
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Jan 13, 2025
@gbencedi
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-8913
359766b
[PWGLF] Please consider the following formatting changes to AliceO2Group#8913
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Feb 11, 2025
@nepeivodaRS
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-9896
0ec3d31
Please consider the following formatting changes to AliceO2Group#9896
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request May 9, 2025
@blacwovie
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-11151
78bd939
Please consider the following formatting changes to AliceO2Group#11151
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Jun 30, 2025
@FDUEnrich
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-11764
67861d5
Please consider the following formatting changes to AliceO2Group#11764
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 12, 2025
@SuJeong-Ji
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-12401
857bc7d
Please consider the following formatting changes to AliceO2Group#12401
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Oct 3, 2025
@GiorgioAlbertoLucia
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-13212
ecb88fa
Please consider the following formatting changes to AliceO2Group#13212
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Oct 6, 2025
@Tao-Fang
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-12758
f76f0e3
Please consider the following formatting changes to AliceO2Group#12758
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Oct 31, 2025
@torkjellsdatter
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-13619
6df7c59
[PWGDQ] Please consider the following formatting changes to AliceO2Group#13619
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Apr 6, 2026
@mjkim525
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-15668
50e3f3d
Please consider the following formatting changes to AliceO2Group#15668
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Apr 9, 2026
@tutripat
Merge pull requestAliceO2Group#13from alibuild/alibot-cleanup-15707
d443551
Please consider the following formatting changes to AliceO2Group#15707
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktfktfktf approved these changes
@jgrosseojgrosseojgrosseo approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saganatt@jgrosseo@ktf