Uh oh!
There was an error while loading. Please reload this page.
PWGHF: Cache lookups in Array2D - #47
Merged
Merged
Conversation
ktf
commented
Aug 29, 2021
MemberAuthor
@ginnocen this should speed up quite significantly the 3 prong business... |
ktf
commented
Aug 29, 2021
MemberAuthor
(not yet tested) |
ktf
commented
Aug 29, 2021
MemberAuthor
Do not merge. This crashes. I think i missed something trivial. Looking into it. |
vkucera
marked this pull request as draft
August 29, 2021 11:54
String lookups are done per candidate, making it extremely slow for no reason. Caching the position of the indices should give a rather significant boost to loosely cut setups.
ktf
marked this pull request as ready for review
August 29, 2021 14:50
ktf
commented
Aug 29, 2021
MemberAuthor
Verified with https://alimonitor.cern.ch/train-workdir/tests/0001/00010515/stdout.log by Sourav. 3x times in that particular case. |
ginnocen
approved these changes
Aug 29, 2021
ginnocen
enabled auto-merge (squash)
August 29, 2021 15:17
alibuild pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 11, 2023
Please consider the following formatting changes to AliceO2Group#4131
alibuild added a commit
to alibuild/O2Physics
that referenced
this pull request
Mar 27, 2024
alibuild pushed a commit
to alibuild/O2Physics
that referenced
this pull request
May 2, 2024
Please consider the following formatting changes to AliceO2Group#5932
alibuild pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Jun 3, 2025
Please consider the following formatting changes to AliceO2Group#11447
alibuild pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Jul 15, 2025
Please consider the following formatting changes to AliceO2Group#12056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String lookups are done per candidate, making it extremely slow for
no reason. Caching the position of the indices should give a rather
significant boost to loosely cut setups.