Skip to content

[QA-1840] Fix Offline Mode errors - #10460

Merged
amendelsohn merged 5 commits into
mainfrom
am-fix-offline-mode
Nov 19, 2024
Merged

[QA-1840] Fix Offline Mode errors#10460
amendelsohn merged 5 commits into
mainfrom
am-fix-offline-mode

Conversation

@amendelsohn

@amendelsohnamendelsohn commented Nov 18, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes two issues with offline mode:

  • Tracks were not downloading in offline mode unless marked available for download by the artist. Fix is to use the /stream endpoint instead for fetching the offline audio.
  • Offline lineups were showing an error toast on track play near end of playlist because we were failing to fetch recommended autoplay tracks. Disabled this behavior while offline.

According to the charts, these errors spiked starting Nov 5th, around the time we shipped changes to the stream endpoint mirroring. Unsure the full root cause, but could be related?

How Has This Been Tested?

tested on ios sim and android device

@amendelsohn
amendelsohn requested review from a team and dylanjeffers and removed request for a teamNovember 18, 2024 21:15
@changeset-bot

changeset-botBot commented Nov 18, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4bca0c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@amendelsohn
amendelsohn requested review from a team and sliptype and removed request for dylanjeffersNovember 18, 2024 21:15
Kyle-Shanks
Kyle-Shanks approved these changes Nov 18, 2024
View reviewed changes

@Kyle-ShanksKyle-Shanks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea stream endpoint makes sense. good stuff

@audius-infra

audius-infra commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/am-fix-offline-mode

@audius-infra

audius-infra commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/am-fix-offline-mode

@amendelsohn
amendelsohn merged commit d51cc3c into mainNov 19, 2024
@amendelsohn
amendelsohn deleted the am-fix-offline-mode branch November 19, 2024 00:06
raymondjacobson pushed a commit that referenced this pull request Nov 22, 2024
@amendelsohn@raymondjacobson
[QA-1840] Fix Offline Mode errors (#10460)
aa7ce27
audius-infra pushed a commit that referenced this pull request Nov 23, 2024
audius-infra
Audius Client (Web and Mobile) v1.5.110
218d5a3
[34d450f] QA ticket grab bag (#10514) Raymond Jacobson
[ccb7082] [PAY-3607] Migrate explore tracks to sdk (#10509) Reed
[bb6828e] [PAY-3503] Update no longer can message user UI (#10505) Reed
[80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn
[bb06fba] Fix sidebar playlists account sync (#10495) Isaac Solo
[047598a] [C-5405] Update upload flow with file replace (#10494) Kyle Shanks
[e1bc4ca] [QA-1842] Fix web date picker time default (#10491) Isaac Solo
[2fdfd7b] Remove PREFER_HIGHER_PATCH_FOR_PRIMARY/SECONDARIES feature flags (#10480) Reed
[2736806] [C-5410] Add ReplaceTrackConfirmation modal (#10489) Kyle Shanks
[8c52795] [C-5408] Move delete track action to overflow menu (#10487) Kyle Shanks
[4cfea48] [C-5395 & C-5396] Upgrade to amplitude v2 and enable session replay (#10463) JD Francis
[d6f43a6] Fix watchQueueAutoplay test (#10488) Andrew Mendelsohn
[4d15579] [C-5430] Add feature flag for track audio replace (#10482) Kyle Shanks
[7820db8] Remove AI_ATTRIBUTION feature flag (#10476) Reed
[09ec89b] [C-5404] Add FileReplaceContainer component to web (#10462) Kyle Shanks
[14756ed] Remove DISCOVERY_TIP_REACTIONS feature flag (#10479) Reed
[92eed35] Remove DEVELOPER_APPS_PAGE feature flag (#10477) Reed
[f242d87] Remove SDK_DISCOVERY_NODE_SELECTOR feature flag (#10474) Reed
[ec135ba] Remove LAZY_USERBANK_CREATION_ENABLED feature flag (#10473) Reed
[bc4452e] Remove misc feature flags (#10478) Reed
[980e2b0] Remove RELATED_ARTISTS_ON_PROFILE_ENABLED feature flag (#10475) Reed
[4d76fbe] Remove PODCAST_CONTROL_UPDATES_ENABLED feature flag (#10471) Reed
[914b46b] Remove EARLY_ACCESS feature flag (#10469) Reed
[5d0a9ed] Remove RATE_CTA_ENABLED feature flag (#10467) Reed
[61e9ddf] Remove OFFLINE_MODE_RELEASE feature flag (#10466) Reed
[85fb740] [C-5403, C-5411] Add Upload icon to harmony (#10459) Kyle Shanks
[d51cc3c] [QA-1840] Fix Offline Mode errors (#10460) Andrew Mendelsohn
[9a0603f] [C-5416] Basic guest checkout behind feature flag (#10447) Isaac Solo
[38e007c] [C-5417] Update track audio replace for sdk change (#10458) Kyle Shanks
[8455921] Remove TIPPING_ENABLED feature flag (#10457) Reed
[0403468] Remove SOLANA_LISTEN_ENABLED feature flag (#10456) Reed
[a93a826] Fix track edit sdk issues (#10450) Sebastian Klingler
[5484dac] [QA-1827] Fix queuing short profile lineups issue (#10451) Randy Schott
[c4ef1e0] Fix bad useEffects calls in PremiumContentPurchaseDrawer (#10454) Randy Schott
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sliptypesliptypeAwaiting requested review from sliptype
1 more reviewer
@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amendelsohn@audius-infra@Kyle-Shanks