Skip to content

[PAY-3607] Migrate explore tracks to sdk - #10509

Merged
dharit-tan merged 4 commits into
mainfrom
rt-explore-tracks
Nov 23, 2024
Merged

[PAY-3607] Migrate explore tracks to sdk#10509
dharit-tan merged 4 commits into
mainfrom
rt-explore-tracks

Conversation

@dharit-tan

@dharit-tandharit-tan commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

Description

Migrate all tracks-related explore requests to use sdk.

ok to delete unused fns in DiscoveryProvider.ts and requests.ts?

How Has This Been Tested?

Tested all tracks explore tiles on web prod

@changeset-bot

changeset-botBot commented Nov 22, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 07ce2b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dharit-tandharit-tan changed the title Rt explore tracks[PAY-3607] Migrate explore tracks to sdkNov 22, 2024
@audius-infra

audius-infra commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rt-explore-tracks

schottra
schottra approved these changes Nov 22, 2024
View reviewed changes

@schottraschottra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you for this.

Comment threadpackages/libs/src/services/discoveryProvider/DiscoveryProvider.ts
Comment threadpackages/common/src/services/explore/Explore.ts Outdated
Comment threadpackages/common/src/services/explore/Explore.ts
Comment threadpackages/discovery-provider/src/api/v1/tracks.py
id="Best New Releases",
description='Gets the tracks found on the "Best New Releases" smart playlist',
)
@full_ns.expect(best_new_releases_parser)

@schottraschottraNov 22, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the calls already work against staging/prod without this parser decorator? Just wondering if we have to do a DN release before client goes out to keep from breaking things.

@dharit-tandharit-tanNov 22, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good call, no they don't. i think we're good tho cuz the protocol release will go out on monday, and client won't go out until tues earliest?

@audius-infra

audius-infra commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rt-explore-tracks

@dharit-tan
dharit-tan merged commit ccb7082 into mainNov 23, 2024
@dharit-tan
dharit-tan deleted the rt-explore-tracks branch November 23, 2024 01:57
audius-infra pushed a commit that referenced this pull request Nov 23, 2024
audius-infra
Audius Client (Web and Mobile) v1.5.110
218d5a3
[34d450f] QA ticket grab bag (#10514) Raymond Jacobson
[ccb7082] [PAY-3607] Migrate explore tracks to sdk (#10509) Reed
[bb6828e] [PAY-3503] Update no longer can message user UI (#10505) Reed
[80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn
[bb06fba] Fix sidebar playlists account sync (#10495) Isaac Solo
[047598a] [C-5405] Update upload flow with file replace (#10494) Kyle Shanks
[e1bc4ca] [QA-1842] Fix web date picker time default (#10491) Isaac Solo
[2fdfd7b] Remove PREFER_HIGHER_PATCH_FOR_PRIMARY/SECONDARIES feature flags (#10480) Reed
[2736806] [C-5410] Add ReplaceTrackConfirmation modal (#10489) Kyle Shanks
[8c52795] [C-5408] Move delete track action to overflow menu (#10487) Kyle Shanks
[4cfea48] [C-5395 & C-5396] Upgrade to amplitude v2 and enable session replay (#10463) JD Francis
[d6f43a6] Fix watchQueueAutoplay test (#10488) Andrew Mendelsohn
[4d15579] [C-5430] Add feature flag for track audio replace (#10482) Kyle Shanks
[7820db8] Remove AI_ATTRIBUTION feature flag (#10476) Reed
[09ec89b] [C-5404] Add FileReplaceContainer component to web (#10462) Kyle Shanks
[14756ed] Remove DISCOVERY_TIP_REACTIONS feature flag (#10479) Reed
[92eed35] Remove DEVELOPER_APPS_PAGE feature flag (#10477) Reed
[f242d87] Remove SDK_DISCOVERY_NODE_SELECTOR feature flag (#10474) Reed
[ec135ba] Remove LAZY_USERBANK_CREATION_ENABLED feature flag (#10473) Reed
[bc4452e] Remove misc feature flags (#10478) Reed
[980e2b0] Remove RELATED_ARTISTS_ON_PROFILE_ENABLED feature flag (#10475) Reed
[4d76fbe] Remove PODCAST_CONTROL_UPDATES_ENABLED feature flag (#10471) Reed
[914b46b] Remove EARLY_ACCESS feature flag (#10469) Reed
[5d0a9ed] Remove RATE_CTA_ENABLED feature flag (#10467) Reed
[61e9ddf] Remove OFFLINE_MODE_RELEASE feature flag (#10466) Reed
[85fb740] [C-5403, C-5411] Add Upload icon to harmony (#10459) Kyle Shanks
[d51cc3c] [QA-1840] Fix Offline Mode errors (#10460) Andrew Mendelsohn
[9a0603f] [C-5416] Basic guest checkout behind feature flag (#10447) Isaac Solo
[38e007c] [C-5417] Update track audio replace for sdk change (#10458) Kyle Shanks
[8455921] Remove TIPPING_ENABLED feature flag (#10457) Reed
[0403468] Remove SOLANA_LISTEN_ENABLED feature flag (#10456) Reed
[a93a826] Fix track edit sdk issues (#10450) Sebastian Klingler
[5484dac] [QA-1827] Fix queuing short profile lineups issue (#10451) Randy Schott
[c4ef1e0] Fix bad useEffects calls in PremiumContentPurchaseDrawer (#10454) Randy Schott
audius-infra pushed a commit that referenced this pull request Nov 25, 2024
audius-infra
Audius Protocol v0.7.41
43006f6
[ccb7082] [PAY-3607] Migrate explore tracks to sdk (#10509) Reed
[b444ad6] [PAY-3612] Add discovery endpoint for retrieving email data (#10501) Farid Salau
dharit-tan added a commit that referenced this pull request Nov 25, 2024
@dharit-tan
[PAY-3607] Migrate explore tracks to sdk (#10509)
e554bdc
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonAwaiting requested review from raymondjacobson
@rickyromborickyromboAwaiting requested review from rickyrombo
@sliptypesliptypeAwaiting requested review from sliptype
1 more reviewer
@schottraschottraschottra approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@faridsalaufaridsalau

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dharit-tan@audius-infra@schottra@faridsalau