Skip to content

Fix $AUDIO send - #12438

Merged
dharit-tan merged 7 commits into
mainfrom
rt-amount
Jul 1, 2025
Merged

Fix $AUDIO send#12438
dharit-tan merged 7 commits into
mainfrom
rt-amount

Conversation

@dharit-tan

@dharit-tandharit-tan commented Jun 30, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This was broken after the BN.js migration.

  • Pass AudioWei around the UI components, but use StringWei between redux actions as BigInts aren't serializable.
  • Added new tan-query optimistic update functions for the user's $AUDIO balance. Tried invalidating the query cache but that always happened after the balance re-fetch so the UI didn't reflect the latest balance.

How Has This Been Tested?

Screen.Recording.2025-07-01.at.3.20.35.PM.mov

@changeset-bot

changeset-botBot commented Jun 30, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 58f200c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rickyrombo
rickyrombo approved these changes Jul 1, 2025
View reviewed changes
Comment threadpackages/web/src/components/token-value-slider/TokenValueSlider.tsx
Comment threadpackages/web/src/pages/audio-page/components/DashboardTokenValueSlider.tsx Outdated
Comment threadpackages/web/src/pages/audio-page/components/SendInputBody.tsx Outdated
Comment threadpackages/web/src/pages/audio-page/components/SendInputBody.tsx Outdated
@dharit-tandharit-tan changed the title Fix send amount formattingFix $AUDIO sendJul 1, 2025
rickyrombo
rickyrombo approved these changes Jul 1, 2025
View reviewed changes
Comment threadpackages/web/src/common/store/wallet/sagas.ts
}

try {
yield* call(optimisticallyDecreaseUserSolBalance, audioWeiAmount)

@rickyromborickyromboJul 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as confident on the optimistic changes, maybe @DejayJD can weigh in

Also wonder if we still need optimism or if this was a remnant of eth sends

@dharit-tandharit-tanJul 1, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried just invalidating the query cache, but there was a race condition - the refetch happens before the cache gets invalidated, so this still felt necessary

@rickyromborickyromboJul 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing it's because we need to wait to see the balance change on RPC before invalidating the cache

@dharit-tan
dharit-tan merged commit 9dfdbd1 into mainJul 1, 2025
@dharit-tan
dharit-tan deleted the rt-amount branch July 1, 2025 20:00
dharit-tan added a commit that referenced this pull request Jul 1, 2025
@dharit-tan
Fix $AUDIO send (#12438)
dc7fdc4
audius-infra pushed a commit that referenced this pull request Jul 5, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.142
cccabc6
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyromborickyromborickyrombo approved these changes
@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau
@raymondjacobsonraymondjacobsonAwaiting requested review from raymondjacobson
@DejayJDDejayJDAwaiting requested review from DejayJD

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dharit-tan@raymondjacobson@rickyrombo@dylanjeffers