') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Revert "Add rich notifications to enable image urls (#12428)" by dylanjeffers · Pull Request #12447 · AudiusProject/apps · GitHub
Skip to content

Revert "Add rich notifications to enable image urls (#12428)" - #12447

Merged
dylanjeffers merged 1 commit into
mainfrom
revert-rich-notifs
Jul 1, 2025
Merged

Revert "Add rich notifications to enable image urls (#12428)"#12447
dylanjeffers merged 1 commit into
mainfrom
revert-rich-notifs

Conversation

@dylanjeffers

@dylanjeffersdylanjeffers commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

This reverts commit c12b5d7.

@changeset-bot

changeset-botBot commented Jul 1, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b4c66a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers
dylanjeffers merged commit d4ec12c into mainJul 1, 2025
@dylanjeffers
dylanjeffers deleted the revert-rich-notifs branch July 1, 2025 18:50
cursor[bot]
cursorBot reviewed Jul 1, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: iPad Compatibility Lost in Build Configs

The revert of the notification service accidentally removed the TARGETED_DEVICE_FAMILY = "1,2" setting from all main app build configurations (Debug, Release, ReleaseCandidate, Staging.Debug, Staging.Release, Staging.ReleaseCandidate). This setting specifies iPhone (1) and iPad (2) device support. Its removal, which is unrelated to notification functionality, will break iPad compatibility and may cause build or distribution issues.

packages/mobile/ios/AudiusReactNative.xcodeproj/project.pbxproj#L453-L994

https://github.com/AudiusProject/audius-protocol/blob/b4c66a8768e70738ad6356ff499a07b8c60ec953/packages/mobile/ios/AudiusReactNative.xcodeproj/project.pbxproj#L453-L994

Fix in Cursor

BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

audius-infra pushed a commit that referenced this pull request Jul 5, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.142
cccabc6
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
+1 more reviewer
@faridsalaufaridsalaufaridsalau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@faridsalau