Skip to content

[QA-2189] Fix DM blast crash while users are loading - #12439

Merged
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash
Jul 1, 2025
Merged

[QA-2189] Fix DM blast crash while users are loading#12439
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Fix ChatListItem crashing due to track.user.name caused by the user still loading (occurs in DMs that sent a playlist)

How Has This Been Tested?

ios:prod w/Kato's blast

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 345037d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DejayJD
DejayJD merged commit 6f9a8fd into mainJul 1, 2025
@DejayJD
DejayJD deleted the jd/fix-DM-blast-crash branch July 1, 2025 15:51
audius-infra pushed a commit that referenced this pull request Jul 5, 2025
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[QA-2189] Fix DM blast crash while users are loading by DejayJD · Pull Request #12439 · AudiusProject/apps · GitHub
Skip to content

[QA-2189] Fix DM blast crash while users are loading - #12439

Merged
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash
Jul 1, 2025
Merged

[QA-2189] Fix DM blast crash while users are loading#12439
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Fix ChatListItem crashing due to track.user.name caused by the user still loading (occurs in DMs that sent a playlist)

How Has This Been Tested?

ios:prod w/Kato's blast

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 345037d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DejayJD
DejayJD merged commit 6f9a8fd into mainJul 1, 2025
@DejayJD
DejayJD deleted the jd/fix-DM-blast-crash branch July 1, 2025 15:51
audius-infra pushed a commit that referenced this pull request Jul 5, 2025
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [QA-2189] Fix DM blast crash while users are loading by DejayJD · Pull Request #12439 · AudiusProject/apps · GitHub
Skip to content

[QA-2189] Fix DM blast crash while users are loading - #12439

Merged
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash
Jul 1, 2025
Merged

[QA-2189] Fix DM blast crash while users are loading#12439
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Fix ChatListItem crashing due to track.user.name caused by the user still loading (occurs in DMs that sent a playlist)

How Has This Been Tested?

ios:prod w/Kato's blast

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 345037d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DejayJD
DejayJD merged commit 6f9a8fd into mainJul 1, 2025
@DejayJD
DejayJD deleted the jd/fix-DM-blast-crash branch July 1, 2025 15:51
audius-infra pushed a commit that referenced this pull request Jul 5, 2025
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [QA-2189] Fix DM blast crash while users are loading by DejayJD · Pull Request #12439 · AudiusProject/apps · GitHub
Skip to content

[QA-2189] Fix DM blast crash while users are loading - #12439

Merged
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash
Jul 1, 2025
Merged

[QA-2189] Fix DM blast crash while users are loading#12439
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Fix ChatListItem crashing due to track.user.name caused by the user still loading (occurs in DMs that sent a playlist)

How Has This Been Tested?

ios:prod w/Kato's blast

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 345037d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DejayJD
DejayJD merged commit 6f9a8fd into mainJul 1, 2025
@DejayJD
DejayJD deleted the jd/fix-DM-blast-crash branch July 1, 2025 15:51
audius-infra pushed a commit that referenced this pull request Jul 5, 2025
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [QA-2189] Fix DM blast crash while users are loading by DejayJD · Pull Request #12439 · AudiusProject/apps · GitHub
Skip to content

[QA-2189] Fix DM blast crash while users are loading - #12439

Merged
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash
Jul 1, 2025
Merged

[QA-2189] Fix DM blast crash while users are loading#12439
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Fix ChatListItem crashing due to track.user.name caused by the user still loading (occurs in DMs that sent a playlist)

How Has This Been Tested?

ios:prod w/Kato's blast

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 345037d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DejayJD
DejayJD merged commit 6f9a8fd into mainJul 1, 2025
@DejayJD
DejayJD deleted the jd/fix-DM-blast-crash branch July 1, 2025 15:51
audius-infra pushed a commit that referenced this pull request Jul 5, 2025
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [QA-2189] Fix DM blast crash while users are loading by DejayJD · Pull Request #12439 · AudiusProject/apps · GitHub
Skip to content

[QA-2189] Fix DM blast crash while users are loading - #12439

Merged
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash
Jul 1, 2025
Merged

[QA-2189] Fix DM blast crash while users are loading#12439
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Fix ChatListItem crashing due to track.user.name caused by the user still loading (occurs in DMs that sent a playlist)

How Has This Been Tested?

ios:prod w/Kato's blast

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 345037d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DejayJD
DejayJD merged commit 6f9a8fd into mainJul 1, 2025
@DejayJD
DejayJD deleted the jd/fix-DM-blast-crash branch July 1, 2025 15:51
audius-infra pushed a commit that referenced this pull request Jul 5, 2025
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [QA-2189] Fix DM blast crash while users are loading by DejayJD · Pull Request #12439 · AudiusProject/apps · GitHub
Skip to content

[QA-2189] Fix DM blast crash while users are loading - #12439

Merged
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash
Jul 1, 2025
Merged

[QA-2189] Fix DM blast crash while users are loading#12439
DejayJD merged 1 commit into
mainfrom
jd/fix-DM-blast-crash

Conversation

@DejayJD

Copy link
Copy Markdown
Contributor

Description

  • Fix ChatListItem crashing due to track.user.name caused by the user still loading (occurs in DMs that sent a playlist)

How Has This Been Tested?

ios:prod w/Kato's blast

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 345037d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DejayJD
DejayJD merged commit 6f9a8fd into mainJul 1, 2025
@DejayJD
DejayJD deleted the jd/fix-DM-blast-crash branch July 1, 2025 15:51
audius-infra pushed a commit that referenced this pull request Jul 5, 2025
[f340a70] Fix collection tile link (#12461) Dylan Jeffers
[d0062e7] [QA-2197] Update related artists count add follows idx (#12457) Ray Jacobson
[70e3b02] Remove hashtags from twitter copy (#12458) Reed
[652beda] Add user id parser to dev tools (#12455) JD Francis
[901be7b] Update ToS 7.2.25 (#12407) Ray Jacobson
[db27c52] [QA-2198] Fix collection tile play/pause (#12452) Dylan Jeffers
[4746f2b] [QA-2193] Fix android playback stuck on one track (#12460) Reed
[59140ae] [QA-2190] Fix download all button text (#12451) Dylan Jeffers
[9dfdbd1] Fix $AUDIO send (#12438) Reed
[d4ec12c] Revert "Add rich notifications to enable image urls (#12428)" (#12447) Dylan Jeffers
[a26074b] [QA-2194] Fix scroll in chat user list (#12446) Farid Salau
[a059dcc] Update the amout of decimal places we show (#12445) Farid Salau
[4742b9d] [QA-2191] Fix trending lineup scroll issues (#12444) JD Francis
[6f9a8fd] [QA-2189] Fix DM blast crash while users are loading (#12439) JD Francis
[fbc8645] Fix dashboard bugs (#12436) Ray Jacobson
[093656f] Make our eth rpc conform to updated viem (#12440) Ray Jacobson
[43987b8] [PE-6464] Mobile change twitter to x (#12435) Reed
[903114f] [QA-2188] Fix sign out not working (#12437) JD Francis
[27adc83] Fix more double dollar signs (#12434) Reed
[52aa9e1] Remove extra dollar signs (#12433) Reed
[fec336f] [PE-6461] Change Twitter share button to X (#12429) Reed
[cb11fef] [PE-6455] Migrate all wallet balance reads to tan-query (#12427) JD Francis
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers